Commit Graph

1303 Commits

Author SHA1 Message Date
5751291e8c LOK - Calc: changed the way header is updated on row/col insert/remove
This patch introduce a new LOK callback for informing the client that
the row/col header is no more valid and needs to be updated.

Change-Id: I21a3a41d69bd1a3c11c9ffaf1d7d53dbc3b9681d
Reviewed-on: https://gerrit.libreoffice.org/36733
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-04-21 15:35:22 +02:00
1c5cae479b loplugin:unusedmethods
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672
Reviewed-on: https://gerrit.libreoffice.org/36718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20 10:07:10 +02:00
2b83e73fd7 remove freshly unused menu support from src files
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b
Reviewed-on: https://gerrit.libreoffice.org/36646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-19 13:42:07 +02:00
e2d3e936ab tdf#95992 "Edit" > "Compare Document..." opens dialog that is...
misnamed "Insert"

Issue is that the caption of the dialog is handled by generic code,
which was not designed with comparison in mind. This fix extends the
captions that can be used by such generic codes, without modifying
the underlaying architecture.
Letting callers directly provide caption text might be more versatile,
though.

The fix is extended to:
* Writer Merge functionality
* Calc Compare/Merge functionalities
which use the same dialog (and thus were also displaying "Insert").

Change-Id: I452b37bf7d0024924c87316cd47572c09b373b65
Reviewed-on: https://gerrit.libreoffice.org/35285
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-18 16:24:37 +02:00
f3ab7e1403 remove sfx2/sfxcommands.h
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-18 14:19:31 +01:00
9f5a275a42 Fix typos
Change-Id: I0238202c0dc0380b0e33a9c4567a9513c0afbe91
Reviewed-on: https://gerrit.libreoffice.org/36556
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-15 10:13:34 +02:00
d490729a0f sfx2 lok: use auto when initializing with a cast to avoid duplication
Change-Id: I4e462e9355db3ae44deb0762f019f097f8550eb2
Reviewed-on: https://gerrit.libreoffice.org/36548
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-04-14 11:08:32 +02:00
9e4d84daf2 drop document_io_logring.txt and use global logging
Change-Id: Ibda0ce925bc76355e636022c955077ac89e66cce
Reviewed-on: https://gerrit.libreoffice.org/36434
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12 09:57:50 +02:00
91afe55196 loplugin:inlinefields in SfxSaveAsTemplateDialog
Change-Id: I7b32fc64b96e2f89edc810d4a95d3a3f6f885957
Reviewed-on: https://gerrit.libreoffice.org/36352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:40:27 +02:00
289158d59e Revert "Remove button handler and let the button dispatch the uno cmd"
This reverts commit 6584735bba4b96fbde5c7be55dc6c98878ad059a.

Ooops, that doesn't build any more without the previous reverted one.
2017-04-07 14:20:18 +02:00
6584735bba Remove button handler and let the button dispatch the uno cmd
Change-Id: Iac4d0e1bf96505b02102ae94ca703c00d5348466
Reviewed-on: https://gerrit.libreoffice.org/36252
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07 10:58:36 +00:00
359ff94950 Drop remains of the Welcome Screen feature
Which was dropped in e299ef4952a580bdbd416cef3e1a2feba4979e13
(that was in 2001)

Change-Id: I5860bb44ced35b338f667e47d89f6ed1d597dc11
Reviewed-on: https://gerrit.libreoffice.org/36159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07 08:28:52 +00:00
ad16351d9d Resolves: rhbz#1438876 detect preferred help module for csv dialog
For calc import before any toplevel is created the context is otherwise
unknown. If a help id starts with a specific module name, then default to that
module name as default help category context. Cosmetic, same help is shown in
any case because its in the shared section, but title bar would state "Writer"
when context is expected to be "Calc"

Change-Id: I3323bc55ef23ec162dad4349efb5e84ec3e8054c
2017-04-06 13:55:25 +01:00
e3eadc96cc teach constantparam plugin to find always on and always off bitmask values
Change-Id: If56a483494bd3d7feb3fa67c01000dddd0d34421
Reviewed-on: https://gerrit.libreoffice.org/36085
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05 06:49:56 +00:00
ff339c89b5 loplugin:constantparam part2
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05 06:42:40 +00:00
ed6c5a4908 coverity#440972 Dereference before null check
Change-Id: If4a1da1859dbdf19a7084341003fd6c41700971f
Reviewed-on: https://gerrit.libreoffice.org/36040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03 09:39:48 +00:00
7fca8e61ce use actual UNO enums in sfx2
Change-Id: Ide3ce0bc1afc9de46c2d06b161acff8d32fe1193
Reviewed-on: https://gerrit.libreoffice.org/35911
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31 06:59:13 +00:00
a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-31 06:27:11 +00:00
9bfd742d8c loplugin:unusedmethods
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29 11:43:40 +00:00
5a725d1fde loplugin:singlevalfields
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61
Reviewed-on: https://gerrit.libreoffice.org/35804
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29 06:42:30 +00:00
946a049114 remove some more unused SID constants and commands
Change-Id: Ibf2bb58ca687c18798328ed86cd549d64f3621b4
Reviewed-on: https://gerrit.libreoffice.org/35792
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28 12:51:17 +00:00
9aee1f80a5 SFX_SLOT macro is unused
Change-Id: I29ef05eda5a6e552d497e42220f36200401a3ef1
Reviewed-on: https://gerrit.libreoffice.org/35795
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28 10:49:49 +00:00
7097037d5a remove enum slot code from sfx2
since we only used it for the pseudo-slot stuff, which is now gone

Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a
Reviewed-on: https://gerrit.libreoffice.org/35759
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28 08:25:18 +00:00
71403558cb remove PseudoSlot support from idl compiler
Since we have removed the last usage with
commit 12c6caa84a61f23df996a0396432fa4b8d5c4785
"Kill remaining PseudoSlots usage"

And remove corresponding support from the list-dispatch-commands script.

Also remove the now unused SFX_NEW_SLOT_ENUM macro

Change-Id: Id07c431de4404acf61a8bdd3507e390e5249879a
Reviewed-on: https://gerrit.libreoffice.org/35754
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28 08:24:51 +00:00
2fc5ef74c5 remove unhandled SID commands from sfx2
Change-Id: I5473dbb1fdc2c3779892610ab4ea5f6146291921
Reviewed-on: https://gerrit.libreoffice.org/35742
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28 06:41:25 +00:00
d615af618c create SfxInterfaceId o3tl::strong_int
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6
Reviewed-on: https://gerrit.libreoffice.org/35722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27 09:43:58 +00:00
ee045805e6 remove unhandled SID commands in sd
checked to make sure none of the related .uno commands are present
in any .xcu files.

Change-Id: Iec555836a0a926e070b7632dc1205decf49d331f
Reviewed-on: https://gerrit.libreoffice.org/35615
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27 06:10:05 +00:00
86781bcfc8 Fix typos
Change-Id: I998e9b2ad8ebdcc983239192cb61f6689e378ad9
Reviewed-on: https://gerrit.libreoffice.org/35633
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 10:49:09 +00:00
7916487cf4 convert ViewShellId to o3tl::strong_int
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09
Reviewed-on: https://gerrit.libreoffice.org/35421
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24 06:14:17 +00:00
8ab1fe71f5 remove unused helpid in SfxShell
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae
"update unusedmethods plugin to deal with constructors"
where I removed a unused SfxDockingWindow constructor.
And in that case, the helpid was only being used to assign
the window a UniqueId.

Change-Id: I148e424424fcf08449440b83a8600071b39d7a07
Reviewed-on: https://gerrit.libreoffice.org/35554
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23 10:51:13 +00:00
e9c7d259e8 create SfxDisableFlags enum
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f
Reviewed-on: https://gerrit.libreoffice.org/35514
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22 06:46:10 +00:00
b5bef1f7d5 Typos
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c
Reviewed-on: https://gerrit.libreoffice.org/35436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 18:50:33 +00:00
4a268ebc3f Can return const OUString&, here
Thanks to Noel Grandin for his suggestion.

Change-Id: Ia0d9c46c03928e5551e766572c814f4e9ba6f278
2017-03-19 17:12:25 +01:00
2cdca5d32e SfxObjectFactory: directly store factory name as OUString
Change-Id: I0779be1e4b344124514115c6645394d26ac09c36
Reviewed-on: https://gerrit.libreoffice.org/35375
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17 22:12:48 +00:00
b165f0f9cc Remove SfxObjectFactory::GetShortName()
Used in just two places, where GetFactoryName can also work.

Change-Id: I8d498345c41aef520ef776a3deb6744cc64756f5
Reviewed-on: https://gerrit.libreoffice.org/35374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17 20:22:31 +00:00
c68ac77770 cleanup double includes and declarations
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b
Reviewed-on: https://gerrit.libreoffice.org/35312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17 11:01:26 +00:00
6bedab8bc3 remove unused defines from HRC files in sfx2
Change-Id: Iffe6508558795e059048acae2ca955a78d3e9d6d
Reviewed-on: https://gerrit.libreoffice.org/35279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17 10:23:52 +00:00
2a2b9b5cc9 gpg4libre: Also show Infobar when signature is valid
Change-Id: I5eb639d5cc298b595ccee71f00c1f2fc54867186
Reviewed-on: https://gerrit.libreoffice.org/35287
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-17 08:15:27 +00:00
b4156ece74 use forward declaration for SfxItemSet
Change-Id: I81f5d1ca22868d278662a55443e2038581dd3246
Reviewed-on: https://gerrit.libreoffice.org/35280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16 18:36:08 +00:00
c97d78eaa9 tdf#103355 Working menu after closing slideshow
Change-Id: Ic6bfb6f9a86d9c475d2d3368b924b56a89c90551
Reviewed-on: https://gerrit.libreoffice.org/35251
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-16 15:45:27 +00:00
e681749ffa tdf#105040 Notebookbar: added shortcuts toolbox
In the tabbed notebookbar the shortcuts toolbox is introduced.
It is placed before tab labels, after the menu button.
Customization is possible, buttons are loaded from the
newly created toolbar "Notebookbar shortcuts".

NotebookbarTabControl was moved to the sfx module.

Change-Id: Ifa4a1688c6e92c2f03bd386608e3e9d1c28069d4
Reviewed-on: https://gerrit.libreoffice.org/35194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-15 15:54:19 +00:00
f645294d39 remove unused RID constants
found with the attached bin/find-unused-rid.py script

Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf
Reviewed-on: https://gerrit.libreoffice.org/35136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14 08:37:44 +00:00
6e4d3bad80 Clean up integer types representing positions in ToolBox's item vector
(vs. uses of sal_uInt16 representing such items' IDs).  APPEND and ITEM_NOTFOUND
are members of ToolBox now (and have been bumped to the corresponding type's
max).  The payload of VclEventIds

  ToolboxButtonStateChanged
  ToolboxClick
  ToolboxHighlightOff
  ToolboxItemAdded
  ToolboxItemDisabled
  ToolboxItemEnabled
  ToolboxItemRemoved
  ToolboxItemTextChanged
  ToolboxItemUpdated
  ToolboxItemWindowChanged
  ToolboxSelect

has been changed too (note that reading/writing of those payloads isn't very
consistent, though: for some of these, values are written that are never read,
while for some others no values are ever written but the reading code would like
to receive some value if the payload wasn't a nullptr).

Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-13 13:48:23 +01:00
e5b98fd9c2 Fix "specialization in different namespace" error with old GCCs
Change-Id: I8b2c678ec70de3432bb335d7e76487ef44cd72a6
2017-03-09 16:34:43 +01:00
fee2de9cb1 Clean up uses of integer types
Change-Id: If022ca9de8db49b885065c32b4f6f89debae1392
2017-03-09 15:12:48 +01:00
d3816ab9db Use o3tl::typed_flags
Change-Id: I02b88e60a03441c3c4df6ed32616bb618089539c
2017-03-09 14:24:03 +01:00
3d213b3dc5 make SfxGetpApp just get and move GetOrCreate to the periphery
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32
Reviewed-on: https://gerrit.libreoffice.org/34957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-08 09:56:07 +00:00
1f4e0359d3 convert SvxShadowLocation to scoped enum
Change-Id: Ie51995579312328538263172cd3173641df89bca
Reviewed-on: https://gerrit.libreoffice.org/34965
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08 09:07:34 +00:00
a247f6f8fe only one use of GetLastSaveDirectory
which is to get its value and do a const_cast dance to save and
restore its value which is a strange thing to do just for one
obscure dialog when no other use of the save/load dialogs does this

Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07 10:48:56 +00:00
a32e5162bc make SfxApplication ctor private
Change-Id: I85d2a112b1f7e6215480d89e038d6515d641d147
2017-03-07 10:01:14 +00:00