Commit Graph

979 Commits

Author SHA1 Message Date
c48ad62924 convert HTML_OPTION_IDS to scoped enum
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6
Reviewed-on: https://gerrit.libreoffice.org/36748
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21 09:20:50 +02:00
f1489399d5 convert fileview context menu to .ui
Change-Id: I4631b4fa0312c6548a1176872e3a836d377f518c
2017-04-14 11:51:30 +01:00
1b921c2f1b loplugin:inlinefields in OpenFileDropTargetListener
Change-Id: Ib1f7004ce57f144309d396bc71419f3d1036ff74
Reviewed-on: https://gerrit.libreoffice.org/36353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:51:14 +02:00
a7d008a8df Resolves: tdf#106732 the intent was surely to return a const ref
Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2
2017-04-07 18:36:59 +01:00
359ff94950 Drop remains of the Welcome Screen feature
Which was dropped in e299ef4952a580bdbd416cef3e1a2feba4979e13
(that was in 2001)

Change-Id: I5860bb44ced35b338f667e47d89f6ed1d597dc11
Reviewed-on: https://gerrit.libreoffice.org/36159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07 08:28:52 +00:00
7d4b68fa47 Fix typos
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4
Reviewed-on: https://gerrit.libreoffice.org/36100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-06 07:53:19 +00:00
ff339c89b5 loplugin:constantparam part2
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05 06:42:40 +00:00
bb37c73bdc tdf#39468 Translate German comments
Translate German comments in filter/

Change-Id: I2b5856f1d4b894ca64a5b8105ca3f6466b17360b
Reviewed-on: https://gerrit.libreoffice.org/35953
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-31 08:58:48 +00:00
a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-31 06:27:11 +00:00
90305526ee loplugin:unusedenumconstants
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c
Reviewed-on: https://gerrit.libreoffice.org/35854
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30 06:26:26 +00:00
b0a3a48c1d expand vis to visible; fix typos
* translate German source code comments
* remove bogus surce code comments
* remove ascii art
* removed old StarOffice/Sun internal bug tracker references
* remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f


Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad
Reviewed-on: https://gerrit.libreoffice.org/35404
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29 08:12:10 +00:00
1735654408 Fix typos
Change-Id: Ib8bec97be916d5ea70ae9fb9dc83771b6fec1845
Reviewed-on: https://gerrit.libreoffice.org/35634
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 10:20:44 +00:00
47a9523f3f Fix typos + some German translations
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253
Reviewed-on: https://gerrit.libreoffice.org/35406
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 10:05:45 +00:00
a6209ba6a8 vcl: OutputDevice::GetGlyphBoundRects()'s nIndex and nBase is always the same
So keeping just nIndex is enough.

Change-Id: I5d3a0e6b4a6ce1305a56cf50e7ff181a098f6412
Reviewed-on: https://gerrit.libreoffice.org/35336
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-17 20:18:46 +00:00
f5a16eae76 remove unused defines from HRC files in svtools
Change-Id: I5d8a6a4fd232ef10644ae45174a07b30af789205
Reviewed-on: https://gerrit.libreoffice.org/35277
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17 08:21:21 +00:00
f2a873cd13 convert SvxBorderStyle to scoped enum
and rename to SvxBorderLineStyle

Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17 06:04:30 +00:00
bde834ee6b display raw language tags in curly brackets
Place raw language tags in curly brackets {}, so all on-the-fly tags are
grouped together at the top of a listbox (but behind the "[None]"
entry).

Change-Id: I01d388150241a8482a1f39f8eda26cdd5bb1d832
2017-03-14 12:48:22 +01:00
7c0e3d0b37 convert GraphicDrawMode to scoped enum
Change-Id: I18eec89c4e1ebb86d64297e7cef4b36bf12df59f
Reviewed-on: https://gerrit.libreoffice.org/35004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13 08:38:33 +00:00
5b25275002 No need for extra heap allocation
Change-Id: I0844a0a8a3476cdb007ab1d587b15ce26c68783e
2017-03-09 18:26:40 +01:00
b0f13baae8 convert HTMLTableRules to scoped enum
Change-Id: Id8758955565579abd1f4687907d7fe06aaefa749
2017-03-06 09:52:04 +02:00
f36846b145 convert HTMLTableFrame to scoped enum
Change-Id: I1353619ca11f867ca37dec3105e50ba9f3d70d54
2017-03-06 09:52:04 +02:00
5a099fef6e convert HTMLInputType to scoped enum
Change-Id: I3f6f6aadd813898ccff93154138a2fbf911b9c8f
2017-03-06 09:52:04 +02:00
1cbef3eb08 convert HTMLScriptLanguage to scoped enum
Change-Id: If87863b520da704410a6ad261330bbde7ef8008c
2017-03-06 09:52:04 +02:00
59fbef6cf8 templatize HTMLEnumOption::GetEnum methods
And consequently fix bug in htmlfld.cxx in
the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating
the m_bUpdateDocStat fields by comparing the wrong enum variable.

Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0
Reviewed-on: https://gerrit.libreoffice.org/34857
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06 05:59:16 +00:00
6cb9e6dad7 Remove redundant 'inline' keyword
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03 20:55:50 +00:00
60f6127854 don't need this STL hack anymore
Change-Id: Id0883060acf2ca73af5cce56e1cf9021c2fb121a
2017-03-02 08:39:18 +02:00
5ee57cabb4 no need to use smart pointers for DataFlavorExVector
DataFlavorExVector is a std::vector<..> typedef.
remove odd void pointer in BrowseBox.
return const references to keep getter const qualified.

Change-Id: Iafd529a46b7511941c1dffc86d2066fdc4f07e28
Reviewed-on: https://gerrit.libreoffice.org/34767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02 06:33:48 +00:00
ab92c84dfe Revert "Fix typos"
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7.

Caused some problems, need to be broken down.

Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52
Reviewed-on: https://gerrit.libreoffice.org/34534
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
2017-02-22 08:46:44 +00:00
ffd7f8fcfc Fix typos
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447
Reviewed-on: https://gerrit.libreoffice.org/34476
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
2017-02-22 07:21:20 +00:00
917d5b8b26 Resolves: tdf#97731 allow status bar to adapt to its own preferred size
Change-Id: I4390f61a21eef21371ce7399bf746e60234b8db8
2017-02-20 17:20:02 +00:00
c0089c104d Translate German comments
Change-Id: Ia30dc2f96b34e0edecade84a020092b0a24cbb18
Reviewed-on: https://gerrit.libreoffice.org/33895
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-02-15 19:04:58 +00:00
e1c4dbdbe1 convert SvxIconChoiceCtrlTextMode to scoped enum
and drop unused DontKnow enumerator

Change-Id: Ida06ae702e45d489765f970bbbdab6d762293c6c
2017-02-15 08:33:37 +02:00
89c24a380a convert SvxIconChoiceCtrlPositionMode to scoped enum
and drop unused AutoAdjust enumerator

Change-Id: Ie900f89241947cb93a16f0223071846fecfef09c
2017-02-15 08:33:37 +02:00
2074acd6e3 remove unused Border from RulerIndentStyle enum
Change-Id: If8d5acdf48278adeb4974c46c8e777e8792ba743
2017-02-14 14:22:24 +02:00
52305b6620 convert SvParserState to scoped enum
and drop unused WAITFORDATA enumerator

Change-Id: I658802d88a19dcc2d378456375810454e7426447
2017-02-14 14:22:24 +02:00
5a5940858e drop unused LIST from SvTreeAccRoleType enum
Change-Id: I378dea43b0c08675419a5399e5999c34441497fe
2017-02-14 14:22:24 +02:00
ff82f13b68 drop unused error strings
includes ERRCODE_SFXMSG_STYLEREPLACE

which has the knock on effect that the flags argument
can be removed from a bunch of methods

Change-Id: I72b58bc2a19376bb4609e61aa44e71f734efb333
2017-02-08 12:18:41 +00:00
21864fed06 tdf#105814 enable localization of "host" and "port" in sample addresses
Change-Id: I2e58f4757bd86393410cdc6fd77205a8ebb9b917
Reviewed-on: https://gerrit.libreoffice.org/34021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-02-08 11:33:41 +00:00
32cae6a2ea Revert "create ErrorHandlerFlags scoped enum for error handling flags"
This reverts commit 05e78bde26d8b8b257ed22a0ce20c5b386a629d1.

Depends on the other commit that needs reverting
2017-02-07 23:02:28 +01:00
05e78bde26 create ErrorHandlerFlags scoped enum for error handling flags
Change-Id: I30c80979c87bad7bc98f36a158c31c88d80d1caf
Reviewed-on: https://gerrit.libreoffice.org/33991
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 12:04:35 +00:00
11a4507f8a Following up German translation - fix spelling
Following up on the commit a3a878268f903f3a1a4b6bc80c9c5abe42fd691a

Change-Id: I4f525ecb030044fc9a330ad8964dbeca6ef35ee3
Reviewed-on: https://gerrit.libreoffice.org/33908
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-02-04 08:48:34 +00:00
a3a878268f Translate German comments
Change-Id: I36e9a90116627c44c755108cb38cb3fad8037b3f
Reviewed-on: https://gerrit.libreoffice.org/33851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-02-03 09:09:34 +00:00
f4826959c1 new loplugin:unusedenumconstants
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits

Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03 08:59:39 +00:00
4978328534 convert method names in tools::SvRef to be more like our other..
reference classes, uno::Reference and rtl::Reference.

Specifically rename Is()->is() and Clear()->clear().

Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae
Reviewed-on: https://gerrit.libreoffice.org/33576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02 08:02:54 +00:00
2dff5e856a tdf#105566 Show InfoBar when signature is invalid
gpg4libre

Change-Id: I272ac155889e25b9af91ff723a014588a65b045a
Reviewed-on: https://gerrit.libreoffice.org/33737
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31 12:21:48 +00:00
e0e3bcfae0 Translate German comments
Change-Id: Idf54772d7da0da60d00cfd3b0650cfda0bcd9059
Reviewed-on: https://gerrit.libreoffice.org/33736
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31 08:27:46 +00:00
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
58868eb9ed loplugin: unnecessary destructor svl..svtools
Change-Id: Ie96dda7194c83ba88693f8c91899c732d704a4bd
Reviewed-on: https://gerrit.libreoffice.org/33515
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25 11:29:08 +00:00
bf110d40ef Change all Idle* LINKs to be Timer*
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:

  1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
  2. split the inheritance of Idle from Timer again to maintain
     different Link<>s and move all common code into a TimerBase.

While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.

And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.

It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).

Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23 20:49:05 +01:00
6f1123d3dd use rtl::Reference in Ruler
instead of manual acquire/release

Change-Id: I7815a0a3c01fce57b4798ac1dbf501e20444c61d
2017-01-23 07:56:34 +02:00