wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
441,970 Commits 5 Branches 0 Tags
c8eaadb5d70f42723517bb028f363e37726be256
Commit Graph

3237 Commits

Author SHA1 Message Date
Andrea Gelmini
ec2f188f3d Removed duplicated include 
Change-Id: I55fdf178bbd185d8852da13757aca627d93526bb
Reviewed-on: https://gerrit.libreoffice.org/80911
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-10-16 18:36:48 +02:00
Szymon Kłos
4961eccc77 Disable chart doubleclick on mobile 
To not show any dialog.

Change-Id: Ie19df429b927f746d3fc511ab0aa7b489ec1fd18
Reviewed-on: https://gerrit.libreoffice.org/80851
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2019-10-16 10:27:14 +02:00
Caolán McNamara
5c921a617d Resolves: tdf#128134 page creation order affecting travel 
the page is created before the page is moved to, so CanTravel gets
locked. Only lock when the page is the current page

Change-Id: Ic21fe3077a750e1279db8be0dd5c7f9112c999b1
Reviewed-on: https://gerrit.libreoffice.org/80779
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-14 20:30:00 +02:00
Noel Grandin
3277446dc3 rename TakeSdrDragComment to GetSdrDragComment 
and return the value, instead of using an awkward out-parameter

Change-Id: Ie1b2b31d36a2aa352b40b3582e0014e6b1f95390
Reviewed-on: https://gerrit.libreoffice.org/80549
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-10 08:13:33 +02:00
Caolán McNamara
a487021dcf name all Notebooks 'tabcontrol' 
Change-Id: I5159ed77c2b3ba2f06e381a738a49dbe17a6a4dd
Reviewed-on: https://gerrit.libreoffice.org/80542
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-09 17:31:38 +02:00
Noel Grandin
682fdbf131 loplugin:redundantpointerops check other pointer types 
as well as unique_ptr

Change-Id: I54842bca161ee460fb96c46ca31b6f9c0a7dbbdf
Reviewed-on: https://gerrit.libreoffice.org/80455
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-09 07:44:49 +02:00
Stephan Bergmann
8ec3116162 Introduce o3tl::unsafe_downcast for known-good dynamic_cast downcasts 
(This helps rewrite code that silences Coverity unchecked dynamic_cast warnings,
like 57b89ea1c2ff07b53c3cc002e5ec9e52abd0c1bd "coverity#704563 Unchecked dynamic
cast", in a way that is cleaner and potentially executes faster.)

Change-Id: I3319c0eeec2aa822f686feacd499a76c8c9b9499
Reviewed-on: https://gerrit.libreoffice.org/80458
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-08 18:07:57 +02:00
Stephan Bergmann
063702253e Simplify some uses of dynamic_cast 
(SdrCaptionObj is derived from SdrTextObj, and SdrTextObj::SetVerticalWriting
isn't shadowed anywhere along the derivation path to SdrCaptionObj, so dropping
the dynamic_cast to SdrTextObj in the last block is fine.)

Change-Id: I914a13cbdbeb4ba58f642c9696ef4ad456bc3322
Reviewed-on: https://gerrit.libreoffice.org/80451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-08 16:49:06 +02:00
Noel Grandin
231e16d909 loplugin:redundantpointerops simplify *p.get() 
Change-Id: I12517651fb3f777fd08e384992bb3e84b340ad85
Reviewed-on: https://gerrit.libreoffice.org/80382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-08 08:26:23 +02:00
Noel Grandin
191794ab56 use SfxUInt16Item for SID_ATTR_TRANSFORM_SIZE_POINT 
Change-Id: Id7762047a17a1652c91761d3c910eadd3393040b
Reviewed-on: https://gerrit.libreoffice.org/80237
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-05 08:16:34 +02:00
Caolán McNamara
c6f0192114 drop unnecessary includes 
Change-Id: I2d6828734cfdf795499d54e1b1e8ba9fc4b5a4d1
Reviewed-on: https://gerrit.libreoffice.org/80197
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-04 20:39:36 +02:00
Noel Grandin
53df91adab loplugin:singlevalfields 
Change-Id: Ic74b400f0b929b4c57ad70d0b0936983a3d46360
Reviewed-on: https://gerrit.libreoffice.org/80154
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-04 08:53:37 +02:00
Mike Kaganski
981654f6e0 Drop SfxItemIter::FirstItem 
It is always used right after the iterator is created, where simple
GetCurItem gives the same value without reseting the position.

Change-Id: I871dc7989b79e13f06436ef7928692645b5209f6
Reviewed-on: https://gerrit.libreoffice.org/79903
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-10-01 06:35:49 +02:00
Noel Grandin
ef98596d62 loplugin:virtualdead in chart2 
Change-Id: Ia24e5072cf4d16e8a437323fa7fd5ab5207e71d2
Reviewed-on: https://gerrit.libreoffice.org/79645
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-09-28 17:56:49 +02:00
Caolán McNamara
68a568ea88 drop unnecessary includes 
Change-Id: Ie7dcf55a78ec896ba937c521b59c0a1f2bbb6e94
Reviewed-on: https://gerrit.libreoffice.org/79598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 15:25:35 +02:00
Caolán McNamara
aa7e7747f4 weld DataEditor 
Change-Id: I8b59140d2e2b0892f17159282a1aeb1a47008ba0
Reviewed-on: https://gerrit.libreoffice.org/79561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 13:21:22 +02:00
Caolán McNamara
07d6f4cb86 TODO rename to GetFrameWeld 
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180
Reviewed-on: https://gerrit.libreoffice.org/79560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 13:20:59 +02:00
Caolán McNamara
468729d649 drop unnecessary includes and update pch 
Change-Id: Id7fa7d5b95c32fdc738a18208eb95eaec102d937
Reviewed-on: https://gerrit.libreoffice.org/79523
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 09:55:44 +02:00
Caolán McNamara
deb37c44ec now drop TabPageParent intermediate 
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c
Reviewed-on: https://gerrit.libreoffice.org/79469
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 09:54:49 +02:00
Caolán McNamara
a37e559ed1 disinherit OWizardPage and SfxTabPage from vcl TabPage 
Now that there's no need to support weld/unwelded mixes of
pages in dialog any more.

inherit from a BuilderPage which contains a Builder and
Toplevel container

BuilderPage Activate and Deactivate replace TabPage ActivatePage and
DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and
DeactivatePage.

Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812
Reviewed-on: https://gerrit.libreoffice.org/79317
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 09:54:18 +02:00
Noel Grandin
b13421011d better data structures for some static const vars 
use compact, cache-friendly structures for some static const stuff

and add a std::initialiser_list constructor to o3tl::sorted_vector

Change-Id: I6a6049bf19a7f48dae1843a81cd2257944ada9d5
Reviewed-on: https://gerrit.libreoffice.org/79470
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-09-25 09:28:31 +02:00
Arkadiy Illarionov
1d398fb983 tdf#39593 use getUnoTunnelImplementation 
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd
Reviewed-on: https://gerrit.libreoffice.org/79350
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
 2019-09-23 15:47:12 +02:00
Caolán McNamara
024a570173 drop newly unnecessary OGenericUnoDialog::Dialog 
Change-Id: If047d08cea93fdfacff9ee00c69cf57ba08c916c
Reviewed-on: https://gerrit.libreoffice.org/78972
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-20 21:25:12 +02:00
Caolán McNamara
df809481d4 inherit from one class 
Change-Id: Ia3cb14429a42e445c14cecc20728d59d985f4b5d
Reviewed-on: https://gerrit.libreoffice.org/78837
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-14 06:51:30 +02:00
Miklos Vajna
483ed485ee chart2: add some doxygen comments from Marco's talk 
See
<https://conference.libreoffice.org/2019/program/schedule/sept-12th-thursday/>.

Change-Id: I914cfd02934206ab20a5e7af43ec5698dd9d29dc
Reviewed-on: https://gerrit.libreoffice.org/78829
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2019-09-12 15:48:09 +02:00
Noel Grandin
f8f606297d loplugin:constmethod in chart2 
Change-Id: Ib97571b3750bd832d0d69a1530e6c8589134c633
Reviewed-on: https://gerrit.libreoffice.org/78601
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-09-05 08:26:56 +02:00
Noel Grandin
9e0b3423f2 loplugin:referencecasting find more redundant static_cast 
Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae
Reviewed-on: https://gerrit.libreoffice.org/78191
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-08-27 18:42:13 +02:00
Caolán McNamara
693d9ff29e weld SwMailMergeWizard 
Change-Id: I03a7fd1f7676792387155db986d710a001887c8d
Reviewed-on: https://gerrit.libreoffice.org/77977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-08-23 16:28:12 +02:00
Mike Kaganski
63dfd069b3 Mark move ctors/assignments noexcept 
This should enable using move semantics where possible e.g. in standard
containers.
According to https://en.cppreference.com/w/cpp/language/move_constructor:

  To make strong exception guarantee possible, user-defined move
  constructors should not throw exceptions. For example, std::vector
  relies on std::move_if_noexcept to choose between move and copy
  when the elements need to be relocated.

Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb
Reviewed-on: https://gerrit.libreoffice.org/77957
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-08-23 11:48:53 +02:00
Caolán McNamara
d661cb1761 weld chart CreationWizard 
Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8
Reviewed-on: https://gerrit.libreoffice.org/77954
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-08-22 18:26:41 +02:00
Noel Grandin
9c10e29287 loplugin:constvars in chart2..connectivity 
Change-Id: I35d450b022af870df4e57714363892554a4ae917
Reviewed-on: https://gerrit.libreoffice.org/77722
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-08-19 19:28:03 +02:00
Caolán McNamara
07083030e3 move RoadmapWizard to vcl 
Change-Id: Iae2f5e0ac52dcf862035508db3a22cfd86d02d8f
Reviewed-on: https://gerrit.libreoffice.org/76903
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-08-17 16:31:30 +02:00
Caolán McNamara
4d450704d6 move WizardMachine to vcl 
Change-Id: I55cc4a6c1ad111a22a43fd66a3cd01b5b02fb7cb
Reviewed-on: https://gerrit.libreoffice.org/76902
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-08-16 22:32:42 +02:00
Stephan Bergmann
2d447ddc7a Improved loplugin:stringconstant (now that GCC 7 supports it): chart2 
Change-Id: I9fb8e2853b5ddb1f9fe589f4e47828025ea52915
Reviewed-on: https://gerrit.libreoffice.org/76692
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-07-31 13:00:34 +02:00
Noel Grandin
ff41cf1b8d loplugin:oncevar 
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb
Reviewed-on: https://gerrit.libreoffice.org/76495
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-28 16:51:51 +02:00
Caolán McNamara
1dea4f935a cid#1451627 Division or modulo by float zero 
Change-Id: Ifb4b446edb3da3096230e99a898e2fa8c4e9d66c
Reviewed-on: https://gerrit.libreoffice.org/76098
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-07-22 20:48:45 +02:00
Noel Grandin
836c40904f loplugin:referencecasting in canvas..chart2 
Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc
Reviewed-on: https://gerrit.libreoffice.org/75935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-19 11:31:51 +02:00
Caolán McNamara
4b65103510 cid#1448440 silence Dereference null return value 
Change-Id: I1dce0d6a40086539cbcadeaf9a669f4640dbc730
Reviewed-on: https://gerrit.libreoffice.org/75817
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-07-18 11:55:25 +02:00
Caolán McNamara
7fcb5c2031 cid#1448236 Use after free 
Change-Id: Id7a0ad49a8e73a6b12a0f40c4b8f62b1e1d64356
Reviewed-on: https://gerrit.libreoffice.org/75810
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-07-18 09:37:45 +02:00
Katarina Behrens
0e15fb798a tdf#94300: custom gradients apply also from chart sidebar 
Change-Id: Id6ba90b404ad97cdfc4091bcb4028677f1600fa2
Reviewed-on: https://gerrit.libreoffice.org/75693
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2019-07-17 11:03:49 +02:00
Caolán McNamara
de075c0f38 cid#1448478 Dereference befoew null check 
Change-Id: Ia73e6d02d8a8b06012f207820d0d579cfc08c541
Reviewed-on: https://gerrit.libreoffice.org/75718
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-07-16 20:32:50 +02:00
Caolán McNamara
06579261de cid#1448300 Using invalid iterator 
Change-Id: Ibf3c2f90834e40f06ee1ba55480bd1d345642059
Reviewed-on: https://gerrit.libreoffice.org/75663
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-07-16 12:16:58 +02:00
Noel Grandin
4583911575 improve loplugin:simplifyconstruct 
Change-Id: If863d28c6db470faa0d22273020888d4219e069e
Reviewed-on: https://gerrit.libreoffice.org/74559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-25 13:53:21 +02:00
Arkadiy Illarionov
336b9a14f6 tdf#39593 Remove chart::ExplicitValueProvider::getExplicitValueProvider 
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I8a457dc2aa701957f463b31bd6cc112337999aad
Reviewed-on: https://gerrit.libreoffice.org/74377
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-20 07:51:48 +02:00
Gabor Kelemen
e080acf221 tdf#42949 Fix IWYU warnings in include/svx/[t-v]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I345b8c54890b5bc27f51addd2e6e73ba68b6b327
Reviewed-on: https://gerrit.libreoffice.org/73977
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-06-18 09:08:59 +02:00
Arkadiy Illarionov
adc295a1b2 Add comphelper::getUnoTunnelImplementation template 
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_*

Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596
Reviewed-on: https://gerrit.libreoffice.org/74107
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-17 08:56:36 +02:00
Noel Grandin
bba7ca803c loplugin:logexceptionnicely in chart2 
Change-Id: Ib7933723e5506578bbc85cc431d54d1ed8466376
Reviewed-on: https://gerrit.libreoffice.org/74019
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-14 10:49:55 +02:00
Gabor Kelemen
a7ceb3352a tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b
Reviewed-on: https://gerrit.libreoffice.org/73476
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-06-11 08:48:04 +02:00
Andrea Gelmini
ca81bf6c7d Fix typo 
Change-Id: Iae4e5edb4d7df99e48b0198f150b8593ef206a8f
Reviewed-on: https://gerrit.libreoffice.org/73786
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2019-06-11 07:58:06 +02:00
Arkadiy Illarionov
1eb8859813 Use hasElements to check Sequence emptiness in chart2..connectivity 
Similar to clang-tidy readability-container-size-empty

Change-Id: I41824e8a4ef38d6a35a0ac4421cffcbcd17308e1
Reviewed-on: https://gerrit.libreoffice.org/71802
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-10 10:55:57 +02:00