5c921a617d
Resolves: tdf#128134 page creation order affecting travel
...
the page is created before the page is moved to, so CanTravel gets
locked. Only lock when the page is the current page
Change-Id: Ic21fe3077a750e1279db8be0dd5c7f9112c999b1
Reviewed-on: https://gerrit.libreoffice.org/80779
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-10-14 20:30:00 +02:00
a487021dcf
name all Notebooks 'tabcontrol'
...
Change-Id: I5159ed77c2b3ba2f06e381a738a49dbe17a6a4dd
Reviewed-on: https://gerrit.libreoffice.org/80542
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-10-09 17:31:38 +02:00
231e16d909
loplugin:redundantpointerops simplify *p.get()
...
Change-Id: I12517651fb3f777fd08e384992bb3e84b340ad85
Reviewed-on: https://gerrit.libreoffice.org/80382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-10-08 08:26:23 +02:00
c6f0192114
drop unnecessary includes
...
Change-Id: I2d6828734cfdf795499d54e1b1e8ba9fc4b5a4d1
Reviewed-on: https://gerrit.libreoffice.org/80197
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-10-04 20:39:36 +02:00
53df91adab
loplugin:singlevalfields
...
Change-Id: Ic74b400f0b929b4c57ad70d0b0936983a3d46360
Reviewed-on: https://gerrit.libreoffice.org/80154
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-10-04 08:53:37 +02:00
ef98596d62
loplugin:virtualdead in chart2
...
Change-Id: Ia24e5072cf4d16e8a437323fa7fd5ab5207e71d2
Reviewed-on: https://gerrit.libreoffice.org/79645
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-09-28 17:56:49 +02:00
68a568ea88
drop unnecessary includes
...
Change-Id: Ie7dcf55a78ec896ba937c521b59c0a1f2bbb6e94
Reviewed-on: https://gerrit.libreoffice.org/79598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-26 15:25:35 +02:00
aa7e7747f4
weld DataEditor
...
Change-Id: I8b59140d2e2b0892f17159282a1aeb1a47008ba0
Reviewed-on: https://gerrit.libreoffice.org/79561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-26 13:21:22 +02:00
07d6f4cb86
TODO rename to GetFrameWeld
...
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180
Reviewed-on: https://gerrit.libreoffice.org/79560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-26 13:20:59 +02:00
deb37c44ec
now drop TabPageParent intermediate
...
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c
Reviewed-on: https://gerrit.libreoffice.org/79469
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-26 09:54:49 +02:00
a37e559ed1
disinherit OWizardPage and SfxTabPage from vcl TabPage
...
Now that there's no need to support weld/unwelded mixes of
pages in dialog any more.
inherit from a BuilderPage which contains a Builder and
Toplevel container
BuilderPage Activate and Deactivate replace TabPage ActivatePage and
DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and
DeactivatePage.
Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812
Reviewed-on: https://gerrit.libreoffice.org/79317
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-26 09:54:18 +02:00
024a570173
drop newly unnecessary OGenericUnoDialog::Dialog
...
Change-Id: If047d08cea93fdfacff9ee00c69cf57ba08c916c
Reviewed-on: https://gerrit.libreoffice.org/78972
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-20 21:25:12 +02:00
df809481d4
inherit from one class
...
Change-Id: Ia3cb14429a42e445c14cecc20728d59d985f4b5d
Reviewed-on: https://gerrit.libreoffice.org/78837
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-09-14 06:51:30 +02:00
f8f606297d
loplugin:constmethod in chart2
...
Change-Id: Ib97571b3750bd832d0d69a1530e6c8589134c633
Reviewed-on: https://gerrit.libreoffice.org/78601
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-09-05 08:26:56 +02:00
693d9ff29e
weld SwMailMergeWizard
...
Change-Id: I03a7fd1f7676792387155db986d710a001887c8d
Reviewed-on: https://gerrit.libreoffice.org/77977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-08-23 16:28:12 +02:00
d661cb1761
weld chart CreationWizard
...
Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8
Reviewed-on: https://gerrit.libreoffice.org/77954
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-08-22 18:26:41 +02:00
07083030e3
move RoadmapWizard to vcl
...
Change-Id: Iae2f5e0ac52dcf862035508db3a22cfd86d02d8f
Reviewed-on: https://gerrit.libreoffice.org/76903
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-08-17 16:31:30 +02:00
4d450704d6
move WizardMachine to vcl
...
Change-Id: I55cc4a6c1ad111a22a43fd66a3cd01b5b02fb7cb
Reviewed-on: https://gerrit.libreoffice.org/76902
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-08-16 22:32:42 +02:00
2d447ddc7a
Improved loplugin:stringconstant (now that GCC 7 supports it): chart2
...
Change-Id: I9fb8e2853b5ddb1f9fe589f4e47828025ea52915
Reviewed-on: https://gerrit.libreoffice.org/76692
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-07-31 13:00:34 +02:00
ff41cf1b8d
loplugin:oncevar
...
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb
Reviewed-on: https://gerrit.libreoffice.org/76495
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-07-28 16:51:51 +02:00
836c40904f
loplugin:referencecasting in canvas..chart2
...
Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc
Reviewed-on: https://gerrit.libreoffice.org/75935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-07-19 11:31:51 +02:00
4b65103510
cid#1448440 silence Dereference null return value
...
Change-Id: I1dce0d6a40086539cbcadeaf9a669f4640dbc730
Reviewed-on: https://gerrit.libreoffice.org/75817
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-07-18 11:55:25 +02:00
de075c0f38
cid#1448478 Dereference befoew null check
...
Change-Id: Ia73e6d02d8a8b06012f207820d0d579cfc08c541
Reviewed-on: https://gerrit.libreoffice.org/75718
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-07-16 20:32:50 +02:00
4583911575
improve loplugin:simplifyconstruct
...
Change-Id: If863d28c6db470faa0d22273020888d4219e069e
Reviewed-on: https://gerrit.libreoffice.org/74559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-06-25 13:53:21 +02:00
336b9a14f6
tdf#39593 Remove chart::ExplicitValueProvider::getExplicitValueProvider
...
Replace with comphelper::getUnoTunnelImplementation.
Change-Id: I8a457dc2aa701957f463b31bd6cc112337999aad
Reviewed-on: https://gerrit.libreoffice.org/74377
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-06-20 07:51:48 +02:00
adc295a1b2
Add comphelper::getUnoTunnelImplementation template
...
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_*
Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596
Reviewed-on: https://gerrit.libreoffice.org/74107
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-06-17 08:56:36 +02:00
bba7ca803c
loplugin:logexceptionnicely in chart2
...
Change-Id: Ib7933723e5506578bbc85cc431d54d1ed8466376
Reviewed-on: https://gerrit.libreoffice.org/74019
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-06-14 10:49:55 +02:00
1eb8859813
Use hasElements to check Sequence emptiness in chart2..connectivity
...
Similar to clang-tidy readability-container-size-empty
Change-Id: I41824e8a4ef38d6a35a0ac4421cffcbcd17308e1
Reviewed-on: https://gerrit.libreoffice.org/71802
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-06-10 10:55:57 +02:00
d00a8b05c0
weld View3DDialog
...
Change-Id: Ifd689c54574c08f026f6760efb39b5f927cb2625
Reviewed-on: https://gerrit.libreoffice.org/73604
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-06-08 16:17:45 +02:00
32eeb405d7
tdf#39593 remove IMPL_XUNOTUNNEL* macros
...
Replace with UNO3_GETIMPLEMENTATION* macros.
Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body.
Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e
Reviewed-on: https://gerrit.libreoffice.org/73424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-06-04 09:06:43 +02:00
1bf1c56ce0
Remove ContainerHelper.hxx
...
Use comphelper::sequenceToContainer instead of ContainerHelper::SequenceToVector
Change-Id: I4834255a1349ac7a29127a84a54fcfa98d678d00
Reviewed-on: https://gerrit.libreoffice.org/72186
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-05-13 10:02:02 +02:00
a361231b13
fix wrong SET/QUERY flags passed to uno::Reference
...
By creating deleted methods for the wrong calls.
Avoids the compiler needing to construct a temporary
Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a
Reviewed-on: https://gerrit.libreoffice.org/72103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-05-13 08:15:27 +02:00
492b0d5d07
weld conditional formatting
...
Change-Id: Ia9c99a17d5a95d67a412cfde959192c99caa70be
Reviewed-on: https://gerrit.libreoffice.org/71956
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-05-11 18:34:23 +02:00
747a7d2603
Fix typo
...
Change-Id: I2b5827c3f6fd7630655d4658844792462f80767e
Reviewed-on: https://gerrit.libreoffice.org/72016
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2019-05-09 08:50:07 +02:00
38ef4990bf
tdf#42949 Fix IWYU warnings in include/svx/[a-D]*
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98
Reviewed-on: https://gerrit.libreoffice.org/71295
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-04-27 17:45:17 +02:00
6154489314
tdf#120703 PVS: V581 ifs with identical conditions
...
V581 The conditional expressions of the 'if' statements situated
alongside each other are identical.
Change-Id: I18562d60e33c7ecff14807976dde4cbcae3f665b
Reviewed-on: https://gerrit.libreoffice.org/70731
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2019-04-14 15:47:48 +02:00
1e75520265
Fix typo
...
Change-Id: I9861cda038b6ab32aea44bc82dd0d1253a0679d4
Reviewed-on: https://gerrit.libreoffice.org/70579
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2019-04-11 08:55:07 +02:00
4a6dc219fc
tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679
Reviewed-on: https://gerrit.libreoffice.org/70383
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
2019-04-08 11:55:43 +02:00
3feb65096a
tdf#120703 PVS: Silence V522 warnings
...
V522 There might be dereferencing of a potential null pointer.
Change-Id: I680f1628133216de6336ac5ffa846447ffd55a41
Reviewed-on: https://gerrit.libreoffice.org/70352
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2019-04-07 13:52:51 +02:00
4304226d79
tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4
Reviewed-on: https://gerrit.libreoffice.org/69481
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
2019-03-25 13:42:28 +01:00
9f5cf96bd8
weld SwFieldEditDlg
...
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66
Reviewed-on: https://gerrit.libreoffice.org/69463
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-03-20 14:22:32 +01:00
93b562432a
Resolves: tdf#124111 Cannot enter negative number
...
Change-Id: I9b08595f5dc7ca0bd3e86891330dd1caa0446e63
Reviewed-on: https://gerrit.libreoffice.org/69417
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-03-19 16:43:15 +01:00
e3e6f43bc8
clarify that set_visible(true/false) is just show/hide
...
ditch duplicate method
Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b
Reviewed-on: https://gerrit.libreoffice.org/69302
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-03-16 01:01:33 +01:00
d02381a701
Resolves: tdf#123694 we need the controller, not the tabpage parent
...
Change-Id: Ib390abaec648a1e06fcc35f83cb170fc654cf021
Reviewed-on: https://gerrit.libreoffice.org/69203
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-03-13 22:17:19 +01:00
6987f1d398
These items are of type SfxUInt32Item
...
...see include/svx/svxids.hrc for SID_ATTR_NUMBERFORMAT_VALUE and
chart2/source/inc/chartview/ChartSfxItemIds.hxx for
SCHATTR_AXIS_CROSSING_MAIN_AXIS_NUMBERFORMAT, and as reported by
-fsanitize=vptr in sc/qa/uitest/chart/tdf122398.py recently added to
UITest_chart (<https://ci.libreoffice.org/job/lo_ubsan/1188/ >).
Change-Id: Ic1e2f3390bd54b722730e6dd7962d613587774b1
Reviewed-on: https://gerrit.libreoffice.org/67884
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-02-15 20:50:31 +01:00
c7ad7849d5
Resolves: tdf#123231 spin-button focus loss triggers changing active radio
...
Change-Id: I6562631df4225d5aa4fe650c40be7c0424eb5621
Reviewed-on: https://gerrit.libreoffice.org/67689
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2019-02-11 16:53:10 +01:00
21b224211c
loplugin:indentation in canvas..chart2
...
Change-Id: I9ef57a2e9aaf298f4cfd029aa9b8143871b1bc21
Reviewed-on: https://gerrit.libreoffice.org/67526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-02-08 10:01:20 +01:00
d2cf4cb762
loplugin:constparams in basctl..chart2
...
Change-Id: I9ac9a34ba58f411d5aad235407553df63216319c
Reviewed-on: https://gerrit.libreoffice.org/66791
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-01-24 07:46:23 +01:00
8f4e9ea870
convert MoveDirection to scoped enum
...
Change-Id: I077604051af8af05a3a6ea278d7164d39303f09f
Reviewed-on: https://gerrit.libreoffice.org/66568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-01-18 12:40:57 +01:00
ba28af8aa5
o3tl::make_unique -> std::make_unique in chart2...cui
...
Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one
Change-Id: I2ba0b9b44971166bd79527b52745f3c40dc14387
Reviewed-on: https://gerrit.libreoffice.org/66490
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-01-18 09:49:12 +01:00
