Commit Graph

152 Commits

Author SHA1 Message Date
994a359649 Revert "Let's use RADIO_BUTTON and CHECK_BUTTON roles"
This reverts commit 97d4f7e07462cbc33e8ebf0bc2bbf8a17c232d50, which appears to
be incomplete: CHECK_BUTTON is not defined anywhere.
2014-02-26 22:36:49 +01:00
97d4f7e074 Let's use RADIO_BUTTON and CHECK_BUTTON roles
Thank you Caolán and Niklas for your support!

Change-Id: Ied978b36cc309b2668889d878a309d1a1400633a
2014-02-26 22:31:14 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
09a1c9d31f cppcheck: duplicateIf
- replace duplicate TIB_DROPDOWN test with TIB_DROPDOWN + TIB_DROPDOWNONLY
- consider also TIB_RADIOCHECK as AccessibleRole::TOGGLE_BUTTON

Change-Id: Id159349ae1515681f47c373ba3d839ed406284ab
Reviewed-on: https://gerrit.libreoffice.org/8164
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:06:44 -06:00
2e821e4741 Remove visual noise from accessibility
Change-Id: I876e5c4d1991b35c1dc2cea709d8a2ddf781b012
Reviewed-on: https://gerrit.libreoffice.org/8225
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 16:18:25 +00:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
da13dd9a35 Related: fdo#74242 #i104470# we now have a seperate CARET_CHANGED event
so cursoring left and right in normal non-multiline edit widgets should
give a11y cursor-changed events

Change-Id: I91e86e43d049793912b3ffcc2802bb9aa4b3857c
2014-02-19 11:07:12 +00:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
2b04d0a17f Avoid unnecessary heap allocation
Change-Id: I7bc1a0960cc100c51b90c50838a5ef620f3c763f
2014-02-07 18:43:30 +01:00
59238ef422 Related: #i123862# use O*String's isEmpty() method...
to check for emptiness in modules starting with 'a'

Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 40b2ffbb1036c2f2db50965525009213d8fd6343)

Conflicts:
	accessibility/source/extended/accessibleiconchoicectrl.cxx
	accessibility/source/extended/textwindowaccessibility.cxx
	accessibility/source/standard/vclxaccessiblebox.cxx
	accessibility/source/standard/vclxaccessibletoolboxitem.cxx
	automation/source/server/recorder.cxx
	automation/source/server/statemnt.cxx
	avmedia/source/framework/mediacontrol.cxx
	avmedia/source/framework/soundhandler.cxx
	avmedia/source/gstreamer/gstplayer.cxx
	avmedia/source/viewer/mediawindow.cxx

Change-Id: I8e6d6754282634f6931a2e7f73f08f70c23d452e
2014-02-04 12:14:11 +00:00
bfe5448939 bool improvements
Change-Id: I09ac60e907b7c0a78934dce05343e2ba2b6df49f
2014-01-28 20:26:30 +01:00
05534b5523 Resolves: #i124008# listbox entry's are selected automatically...
on mouse over instead of mouse click

(cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3)

Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28 11:37:23 +00:00
2a77e7a310 coverity#1158122 : Explicit null dereferenced
Change-Id: I6ffec6e69ca5ddb01998653d2f7637ed062bdc80
2014-01-19 15:14:55 -06:00
8db51361dc coverity#1132662 Dereference after null check
Change-Id: Iaccf8bb7903702d2bed3c4fc2195172e18ead6c7
2014-01-19 15:11:09 -06:00
9fd10cca8e coverity#1132661 Dereference after null check
Change-Id: Ida147599810b0aff4a7ebd00b90475b1c6cd1366
2014-01-19 15:07:28 -06:00
382421189f Improve exception message
Change-Id: I06ffe3088546d55b29d61ccfae16937d8a7ce9e8
2013-11-27 09:15:14 +01:00
1533129759 Revert sense in VCLXAccessibleBox::getAccessibleActionCount again
...this had been switched from "m_bIsDropDownBox ? 1 : 0" to "m_bIsDropDownBox ?
0 : 1" in efb23f29983f87104a684e7fab00b84fc59d131d "Integrate branch of
IAccessible2" for no apparent reason and broke JunitTest_testtools_unoapi.

Change-Id: I276d2f452648387a5fa693349cf868787b2d48e1
2013-11-27 09:12:38 +01:00
383c7a4b90 statement aligned as second statement in if body but not in a statement block
Change-Id: I237148ec56164994e5c3168ef5b7dfc56588cad9
2013-11-26 14:41:27 +01:00
efb23f2998 Integrate branch of IAccessible2
(cherry picked from commit e2f90c93c97f3cf137c348ed302c6470f398aa70)

Change-Id: I44ce0d69f3e7364038b00b1ba0f0d27e60132a37

WaE: Prevent uninitialized variable warnings.

(cherry picked from commit b989f4074ea70729d527b307bfbe49e01a0d3646)
2013-11-26 10:24:24 +00:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
7cfd340e92 Fix crash & reduce nesting.
Change-Id: Ifbfe401cd69678c278394d190a37cc41a28d5c56
2013-07-17 13:27:46 +02:00
35b45e6915 VCLXAccessibleTabPageWindow: unhandled IndexOutOfBoundsException
... due to GetPagePos returning -1, work around that (can be easily
triggered in template manager).

Change-Id: Ic1334b224730d79e533539a24f115dc9aa2e9570
2013-06-20 17:01:32 +02:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
7f51d6fa0d coverity#707601 Uninitialized pointer field
Change-Id: I1b7c13be91bd2047a4141b6d7d8e4363b0ddcf4f
Reviewed-on: https://gerrit.libreoffice.org/2211
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:34:48 +00:00
2c570973cc coverity#707602 Uninitialized pointer field
Change-Id: I70fa5899f3bb1eeb22eb18d77f2c816ec60aa97c
Reviewed-on: https://gerrit.libreoffice.org/2212
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:33:52 +00:00
de3fc38adf coverity#707600 Uninitialized pointer field
Change-Id: I8894efd7549299903f0ca4c223a3dff60a9db536
Reviewed-on: https://gerrit.libreoffice.org/2210
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:33:12 +00:00
d204c1a47e Remove last RTL_CONSTASCII_* from accessibility
Change-Id: Icb8f66c9f6ad70828aa55580a1f3aae8b2af1593
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1500
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-29 15:29:18 +00:00
70626249cd API CHANGE a11y unpublishing and add/removeListener rename.
The a11y API has never really been picked up by tools vendors, let's
not tie ourselves up here for no good reason.

This unpublishes all css::accessibility, and dependend API.

With that, we can change the rather unfortunately-named add/
removeEventListener to be add/removeAccessibleEventListener, thus
not conflicting with the XComponent methods of the same name.

Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-29 16:58:16 +01:00
7470cc532f fdo#46808, Adapt reflection::ProxyFactory UNO service to new style
The service is deprecated, but we still have a handful of in-tree
users, and converting it lets me thread XComponentContext through
a bunch of classes.

Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-28 13:06:18 +01:00
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
06ec1c0895 Merge branch 'master' into feature/killsdf
Conflicts:
	Repository.mk
	RepositoryFixes.mk
	connectivity/prj/build.lst
	extensions/prj/build.lst
	filter/prj/build.lst
	fpicker/prj/build.lst
	l10ntools/StaticLibrary_transex.mk
	saxon/build.xml
	shell/prj/build.lst
	solenv/gbuild/AllLangResTarget.mk
	solenv/gbuild/Configuration.mk
	solenv/gbuild/UI.mk
	ucb/source/ucp/webdav/webdavcontent.cxx
2012-11-11 18:24:14 +01:00
8eb5db8997 replace sxub_Unicode by sal_Unicode
Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
Reviewed-on: https://gerrit.libreoffice.org/887
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-19 10:55:56 +00:00
e5ce011c3f Merge branch 'master' into feature/killsdf
Conflicts:
	Makefile.top
	Module_tail_build.mk
	RepositoryExternal.mk
	RepositoryFixes.mk
	accessibility/source/standard/vclxaccessibletoolbox.cxx
	basic/source/uno/dlgcont.cxx
	connectivity/Library_ado.mk
	cross_tail_build/prj/build.lst
	desktop/source/offacc/acceptor.cxx
	filter/Library_PptImporter.mk
	filter/source/t602/filterenv.cxx
	i18npool/Library_textconv_dict.mk
	ooo.lst.in
	saxon/ExternalProject_saxon.mk
	saxon/build.xml
	sc/sdi/scalc.sdi
	sc/source/filter/xml/xmlstyli.cxx
	sc/source/ui/condformat/condformatdlg.cxx
	sc/source/ui/condformat/condformatmgr.cxx
	sc/source/ui/view/cellsh1.cxx
	sdext/source/pdfimport/misc/pwdinteract.cxx
	shell/qa/zip/makefile.mk
	shell/qa/zip/testimpl/makefile.mk
	solenv/gbuild/CppunitTest.mk
	solenv/gbuild/gbuild.mk
	solenv/gbuild/platform/android.mk
	solenv/gbuild/platform/com_GCC_defs.mk
	solenv/gbuild/platform/macosx.mk
	soltools/Executable_adjustvisibility.mk
	soltools/Executable_checkdll.mk
	soltools/Executable_cpp.mk
	soltools/Executable_javadep.mk
	soltools/Executable_makedepend.mk
	sw/qa/extras/rtfimport/rtfimport.cxx
	tail_build/prj/build.lst
	tomcat/ExternalProject_tomcat.mk
	ucb/source/ucp/webdav/webdavcontent.cxx
	xml2cmp/Executable_xml2cmp.mk
2012-10-13 17:41:05 +02:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
e09e9bfb89 re-base on ALv2 code. 2012-10-01 13:55:41 +02:00
286a7733ac re-base on ALv2 code. 2012-09-29 15:07:42 +01:00
0d7cbdbeac just return a vector rather than pass one in by ref to be cleared 2012-09-28 08:48:19 +01:00
d3788f3276 UniString::Fill->padToLength(OUStringBuffer
Change-Id: I61a562982af75fd3141b4b5d55840c0ebc94306c
2012-09-27 09:46:30 +01:00
106a1b4eba sal_Bool to bool conversion in accessibility
Change-Id: I79967eea535dc4bd11e725dc854ae8a8f97a2905
Reviewed-on: https://gerrit.libreoffice.org/701
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2012-09-26 19:36:49 +00:00
2171077c0c Introduce cppu::supportsService helper, adapt some call-sites
...more to follow (easy hack?)

Change-Id: Icb02626495701a3905c124c7368b98c3258e91b2
2012-09-14 19:32:30 +02:00
1ebed7b6c9 ::rtl::OUString to OUString correction in accessibility
Change-Id: Ib59e07ef5dcdd2f30bc5abee2e958cbda57e9629
Reviewed-on: https://gerrit.libreoffice.org/589
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2012-09-11 12:38:36 +00:00
e1276e83e0 OUString cleanup in accessibility
Change-Id: Ie4e51632bf81053f0d32428bb7ef5b01ec301ccc
Reviewed-on: https://gerrit.libreoffice.org/579
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-09-07 12:26:19 +00:00
3c1a1aacf5 fdo#39425: Remove DBG_NAME, DBG_CTOR, DBG_DTOR and debug.hxx in accessibility
Change-Id: I194f776c298f6e149f8e30e82c4b591fed594d55
2012-06-29 23:32:03 +02:00
caf0e31e24 fdo#39425: Replace DBG_ASSERT macros with OSL_ equivalents in accessibility
Change-Id: I4f8fb4ffa8bcd5a503374040ada191ccf1f89013
2012-06-29 23:31:48 +02:00
9928fd7fc6 remove some annoying XubStrings
Change-Id: I8c34a344285b6929091788c6b7a5529b48943f94
2012-06-25 14:19:02 +01:00
3dd8f023fa re-base on ALv2 code. 2012-06-11 17:22:31 +01:00
13887f4848 Remove superfluous include comments
Change-Id: Icd57ca7fd89e30c190c1b06dbe67c30bea8d1b59
2012-06-09 04:51:38 +02:00
2a566b1775 Replaced SAL_INFO with SAL_WARN were applicable. 2012-01-17 23:27:44 +01:00