Commit Graph

739 Commits

Author SHA1 Message Date
f2cdf8848c Remove visual noise from chart2
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27 00:44:41 -06:00
4ea1b80c48 Statics with non-trivial initialization must use StaticWithInit
...not StaticAggregate, as StaticAggregate does the initialization with
osl::GetGlobalMutex locked and can thus lead to deadlock.

Change-Id: I0cce0da84b5a277fdda1ebaaeba85b04011f5459
2014-02-26 23:15:25 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
83055835b1 fdo#74112 Preserve Chart displayunits properties during ODF import/export.
Change-Id: I38508b71ee5b3b966e1d36b0d253304fe17c0ec0
Reviewed-on: https://gerrit.libreoffice.org/7721
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-11 23:23:40 +00:00
b37bce11cf Resolves: rhbz#975421 wrong chart direction in Farsi
Where Farsi (and apparenly Moroccon) are RTL but have LTR
math and charts should reportedly follow the math direction

Change-Id: Ib60eaaaa90fe46ef240030a91169fdff3f736329
2014-02-06 15:11:59 +00:00
262fccfccd fix the time based rendering
I managed to screw it up already. I really need some sleep.

Change-Id: Ie1f13496cd36a6f48b2b094ac302f293d5fd5383
2014-01-29 08:09:32 +01:00
750b46025c give up with the nice solutions and enjoy the ugly hack
I was always hitting a corner case so it seems that this need some
drastic measures.

Change-Id: I3fdd278b9c3fed178513d653ef24ad8adf20cbd2
2014-01-29 08:09:30 +01:00
55656ee2e8 some improvements for the time based charting
The updating seems to work. It just does not update the references yet.

Change-Id: I0a971dbe2beb113c1c3e9ef103d77d5d8c7174a0
2014-01-29 08:09:30 +01:00
2d6e556abd first try at implementing time based updates in new chart implementation
Change-Id: I3d03e44a415023ca12548ea99a3732cba49c8074
2014-01-29 08:09:30 +01:00
a07cce8d06 remaining chart work for time based charting
Change-Id: Iac33c81df199a942ddf073f9eb1b34e147a34f3c
2014-01-29 08:09:29 +01:00
91e1d305a1 implement time based charting based on new approach
The old approach does not work with the current implementation of the
OpenGL backend. We now need to repaing every time the whole chart.

Change-Id: I2151a3f016c6ceecaec2d45db0cb967cfee59af6
2014-01-29 08:09:28 +01:00
7f0fe5444f bool improvements
Change-Id: I8e83eb52a8873e6c7372091c697158053da82488
2014-01-22 08:22:35 +01:00
2054af83fe fdo#72520 : Added property to store external data path in chart.
-  added new property entry to store xlsx external data for chart.

Change-Id: I3695865ad7e888359d1048e9bc380cba26108636
Reviewed-on: https://gerrit.libreoffice.org/7212
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-16 01:46:40 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
20bb1e6854 fdo#72304 Preserve Chart data table properties during ODF import/export.
Change-Id: I767bb32fdaddcaf742923055cc86bb19138b42be
2013-12-19 03:55:05 +01:00
12bbe8f130 Remove unnecessary macro
Change-Id: I8af2e887a6ad2b345b5b214eb02095c71cdafbc2
2013-12-12 08:26:43 +01:00
a62c2a5fa5 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-12 08:26:40 +01:00
123e2c3e93 Revert "Don't hold css::uno::Type instances by pointer"
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now:
Ach, old GCC doesn't like plain string literals to initialize members
of OUString type...

Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11 15:38:30 +01:00
90f91088d2 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11 15:16:51 +01:00
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
3c10c9ec66 Remove code that never effectively did anything
... since inception in 44569a657c4282757443ae06efc6441e571a0409 "CWS-TOOLING:
integrate CWS bubblechart."

Change-Id: I1785ef41bf7146ea7f4d8927165c38317d7183e8
2013-11-28 17:58:03 +01:00
1ccab525db fix lifetime problems of ChartView
Change-Id: I99b24b026c50a05f8f3803348c76277e29a45ec7
2013-11-19 13:47:39 +01:00
401f01caf5 use ChartModel instead of XModel in a few places
This allows us easier implementation of some advanced features. Mainly
the 4D chartting will now be able to work without several ugly layers of
UNO.

Change-Id: I74d07229eaef921c508f3bab8fae6d6075ad737a
2013-11-19 13:47:36 +01:00
24cad6a649 Move MediaDescriptor from comphelper to unotools
...so it will be able to use SvtSecurityOptions internally.

Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14 11:13:24 +01:00
54a17dd246 windows: warning 4355 is disabled globally in com_MSC_defs.mk
So there is no need to do this locally, too.

Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-28 01:02:13 +01:00
75b7ce9c66 fixincludeguards.sh: chart2
Change-Id: I166e054926fb975949b3021cbc43b25a222f6198
2013-10-23 23:22:34 +02:00
140e5eabbf replace more auto_ptr with scoped_ptr
Change-Id: Ia96fcc857e028c7c14186b9560153e7580e6b4fb
2013-09-29 20:26:06 +02:00
3aea6c121d Mark as const
Change-Id: I7ad2a1bd29afbf4813b1ad984081935ca84ec98a
2013-08-02 10:34:43 +09:00
dd9c97d587 fdo#62475 removed pointless comments
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 11:34:33 +00:00
ed0646e52f Fixes for new-style com.sun.star.chart2.FormattedString service
...changed from old-style with 5d1ad167294878789e644452f23ef883af93fe87
"fdo#46808 Convert chart2::FormattedString service to new style."  The
CharacterProperties* services dropped there are property-only old-style
services, so only serve documentation purposes anyway.  Ideally, the new-style
service would offer interface attributes for the relevant properties (and likely
not implement XPropertySet at all), but so be it for now...

Change-Id: I0dd0373cfd372f2320204eb953acce9a2b9e86d2
2013-06-05 14:39:45 +02:00
275225ed4d Resolves: #i120828#, restore some ChartModel::dispose() calls..
to break cyclic reference

Found by: zhangjf
Patch by: zhangjf

(cherry picked from commit 1c564cb9a46fc6435750f9f1a70f654b52efd970)

Change-Id: I8aaac18584d55d9f381acdf4deb0e704bc9bcfc1
2013-05-31 14:59:58 +01:00
f30399c540 Revert "fdo#46808, Convert chart2::Title service to new style"
This reverts commit d256dbede60533369d1aac64cca34721183f6a8a:

For one, the new css.chart2.XTitle2 looked unfinished, in that it transfered the
direct properties of the old-style css.chart2.Title service into attributes, but
left out all the properties inherited by the old-style service from
css.style.ParagraphProperties, css.drawing.FillProperties,
css.drawing.LineProperties (and that missing FIXME css.layout.LayoutElement,
whatever that is supposed to be).  This needs more thought, to either make
available all propertiers as attributes, or none.

For another, this broke JunitTest_chart2_unoapi (sch.ChXChartDocument,
sch.ChartTitle), for hard-to-debug reasons.

Conflicts:
	chart2/source/model/main/Title.cxx
	chart2/source/model/main/Title.hxx
	offapi/com/sun/star/chart2/XTitle2.idl
	sc/source/filter/inc/xlchart.hxx

Change-Id: I4747208a13984904d0e409ea49a73b0f667c86c7
2013-05-23 10:39:21 +02:00
03c3cd9093 fix maybevoid attributes
..from commit d256dbede60533369d1aac64cca34721183f6a8a
"Convert chart2::Title service to new style"

Change-Id: Ib4b8a9126f1042c7d0b8cc07505444f25fe9c55a
2013-05-22 14:35:44 +02:00
d256dbede6 fdo#46808, Convert chart2::Title service to new style
API CHANGE: The chart2::XTitled interface now takes and returns
   a XTitle2 instead of an XTitle.

Change-Id: I96c35909d3a13f1abb544296a782a0b6a7a58ec6
2013-05-21 08:24:01 +02:00
5d1ad16729 fdo#46808 Convert chart2::FormattedString service to new style
API CHANGE: dropped the following services from the new unified
interface because the current service does not implement them.
    service ::com::sun::style::CharacterProperties;
    [optional] service ::com::sun::style::CharacterPropertiesAsian;
    [optional] service ::com::sun::style::CharacterPropertiesComplex;

Change-Id: I7cb6a5d4e998975b1272f4f4da03feea30cd30b6
2013-05-13 09:38:03 +02:00
925e27014e turn this nasty SAL_WARN into a SAL_INFO
Change-Id: I740c1ac683500a406539239f9e5bfe093be58e9b
2013-04-22 13:57:32 +02:00
4a4bdc142a fix the remaining issues with the changed handling of ErrorBar props
Change-Id: I75c839cbfccbe84e7aa98aef6959bcd0c5390ab6
2013-04-22 13:57:31 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
ef53a3a12e Some cppcheck cleaning
Change-Id: I993bd95b31f1090c747f01a899650e8873dcaada
2013-04-02 23:01:14 +02:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
aa46348777 remove C2U in chart2
Change-Id: Id7ebf66319f0891d276a3da95a95658aed59cbc7
2013-03-25 16:14:02 +01:00
bab961dd0a Fix chart2 build
Change-Id: Ia3eb1c1576034c1cbc93e9fb4e60d205a325b132
2013-03-11 18:15:05 +01:00
ded39ea57b #119989# Support relative 3D pie chart height when importing charts.
Reported by: Yan Li
Patch by: Yan Li, Tan Li, alg
Review by: alg(cherry picked from commit 2b1cedbe547ea8f7979f91873dd6e602ebb08a7b)

Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

Conflicts:
	chart2/source/view/charttypes/PieChart.cxx
	chart2/source/view/main/ChartView.cxx
	sc/source/filter/inc/xlchart.hxx

Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185
2013-03-11 17:34:44 +01:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00