ac9212feed
Remove visual noise from connectivity
...
Conflicts:
connectivity/source/inc/odbc/OConnection.hxx
Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:54:35 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
d9cd3dc9aa
connectivity: harmonize types relatated to Tell()/Seek()
...
Change-Id: I032f6d32b151203e62b23bffaf25dbc4aeb5ae8a
Reviewed-on: https://gerrit.libreoffice.org/8217
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2014-02-25 04:42:28 +00:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
15535e32dd
convert SvStream::operator>> methods to ReadXXX methods
...
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 15:31:40 +00:00
4bb7e9a1b0
WaE: -Werror=missing-field-initializers
...
Change-Id: I7d1c9c460d41dec416275e1ce8e6328020118682
2014-02-02 00:50:35 +00:00
599b3c91dc
accidentally used a c++11 only construct
...
Change-Id: I3c89cdf3c3ea6214f4313afde70677f0752dc66b
2014-02-01 17:38:17 -06:00
5323a5a587
coverity#707692-93 : Uninitialized scalar field
...
Change-Id: I72f1e29ef4f5e8af1e3bd300bc2604396080912c
2014-02-01 15:29:56 -06:00
9e015c70cd
coverity#707691 : Uninitialized scalar field
...
Change-Id: I7bd74a8cb2b3cd5a57e960605816fc8373f8bae4
2014-02-01 15:29:56 -06:00
c6faf13222
coverity#707690 : Uninitialized scalar field
...
Change-Id: Ie8df6f61610083afd46bccc3a1363e62f54a40db
2014-02-01 15:29:55 -06:00
ead1525417
bool improvements
...
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
2014-01-28 20:24:39 +01:00
61360536d7
coverity#440728 Explicit null dereferenced
...
Change-Id: I76b8d6eb59d2558a7ff8a1b1573f24e41a03b8b6
2014-01-23 20:35:32 +00:00
89f7da7ac1
coverity#1158204 Unintentional integer overflow
...
Change-Id: I8e10fb52803dbd81e5490940a9a7e529beebc803
2014-01-23 20:35:32 +00:00
d803483f6a
convert more SvStream::operator<< calls
...
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.
Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-01-22 22:00:39 +00:00
c648d08720
convert SvStream::operator<< overloads to more explicit methods
...
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
09dc581359
drop unnecessary tools/string.hxx includes
...
Change-Id: I2439ed19b554381f80e882aacbac05167622df92
2014-01-13 13:54:51 +00:00
b69864f3f8
re-write SvStream operator<< to non-overloaded methods
...
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-10 13:26:24 +00:00
e2591cdeeb
drop STRING_MAXLEN uses from connectivity
...
Change-Id: I12a999c2c6bdd119c2e3e544bbbdabb0b0ce2ba2
2013-12-30 00:21:08 +00:00
151887a955
Fix other typos
...
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-22 18:51:41 +01:00
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
4283bc1836
convert STRING_NOTFOUND -> NODE_NOTFOUND in connectivity
...
The code was interchangably using the two anyway.
Change-Id: I4f3fe8f1d699a9725bbcce0138a9d978a1eff28a
2013-11-11 13:41:43 +02:00
1bdb2b6f06
remove unnecessary use of OUString constructor in CONNECTIVITY module
...
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-11-11 11:21:25 +02:00
aeb41c9b9b
remove redundant calls to OUString constructor
...
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
2b91dc3ae6
fdo#54938: Adapt connectivity module to use cppu::supportsService
...
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-10-09 15:03:38 +00:00
8e30689680
drop worthless _VECTOR_/_MAP_ header guards
...
Change-Id: I54be19847b8fb609f0b08a528cc06dbae9f579d5
2013-09-25 19:24:24 +02:00
98de5b40c8
Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii
...
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-25 19:24:23 +02:00
ea4003de2e
Reserve correct size (dbase).
...
19 values are inserted (but misleadingly only 1-18 are used).
Change-Id: Iae76c16494e8a9a1c1057b0993679ef828254b8f
Reviewed-on: https://gerrit.libreoffice.org/5210
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-31 15:42:03 +00:00
d44f14946a
unused variable 'aStrFieldName' [loplugin]
...
Change-Id: I29d73fc3188b197c78cf7c57ca25f8ce57aca25d
2013-07-19 13:51:41 +02:00
b04304dc45
janitorial: remove unused, add const
...
Change-Id: I1c0509d2415130fe654c09424ea1f8ce8e069602
2013-07-19 11:49:40 +02:00
8529e88518
Cleanup String in connectivity
...
Change-Id: Ica1cf0ac9e9da9c943e50ba77b1ce4a9dc7f8300
Reviewed-on: https://gerrit.libreoffice.org/4895
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2013-07-19 09:45:01 +00:00
6a08067902
OUString convertion for unotools
...
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-02 07:31:30 +00:00
dd3f8fbaff
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*
Change-Id: If89af70767c3fdc4b1d0cb5e51033ca98583bc5d
Reviewed-on: https://gerrit.libreoffice.org/4286
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-06-17 15:55:21 +00:00
7298a2b0c7
fdo#46808, Convert XMultiServiceFactory to XComponentContext
...
Change-Id: I3a74d4edaa3ff3c2498c3db2720b0e4e5305c2e4
2013-05-22 15:20:03 +02:00
0f200cc30e
fdo#63154: Change Min/Max/Abs for std::min/max/abs
...
Now all these usages were removed from LO.
Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2013-04-20 11:09:54 +00:00
e8ff469da5
Remove any remaining remnants of unused component_canUnload feature
...
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
9830fd36db
date/time IDL datatypes incompatible change
...
- nanosecond precision
- signed (allowed negative) year
Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.
Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
f9122b3297
coverity#704216 Logically dead code
...
Change-Id: I83af7c87576c185b4884a2a6ceaea5274efa7c37
2013-03-23 14:52:25 +01:00
9c281fda84
String::AppendAscii cleanup
...
Change-Id: I3c1ff291488b7747e143982aa7ea95169175c2c2
Reviewed-on: https://gerrit.libreoffice.org/2914
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-03-22 17:17:18 +00:00
c3d1c45e51
coverity#705135 Missing break in switch
...
Change-Id: Ie610b3b10b5d83b772ad96e455d59360368086a4
Reviewed-on: https://gerrit.libreoffice.org/2779
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-03-18 07:42:44 +00:00
4bf95c4c31
make use of startsWith()
...
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679
Reviewed-on: https://gerrit.libreoffice.org/2599
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-03-08 13:16:49 +00:00
57d169b606
doubled namespace
...
Change-Id: I756f4a98b1eedcbe7674e9afd9b06816141688b9
2013-03-04 13:58:39 +01:00
4f4e4e40f5
loplugin: improve indentation
...
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
616c6924f1
s/the the/the/
...
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
e13a3d566e
fdo#38838 Some removal/replacement of the String/UniString with OUString
...
Also used the new OUString::number(...) methods.
Change-Id: I3174c43d56d1ae359901bb8a13fe0096f2c74808
Reviewed-on: https://gerrit.libreoffice.org/1766
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-01-22 14:25:15 +00:00
63bcb139b9
Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
...
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-01-21 15:04:17 +00:00
