Commit Graph

1558 Commits

Author SHA1 Message Date
2991d2d65b Remove visual noise from desktop
Change-Id: Ib8ca7794ce6f3e96ee3a9b2896b141635665552c
Reviewed-on: https://gerrit.libreoffice.org/8252
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 05:59:38 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
1974b1601c The LO process is called just "soffice" on OS X
Change-Id: I74a6af7f4dc49ccf8ff3ead0d5b3e5e9b78b4f7a
2014-02-25 15:05:01 +02:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
d548b250db Drop unnecessary #include
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-18 13:24:11 +09:00
064c628842 fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c
Reviewed-on: https://gerrit.libreoffice.org/8001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-12 07:23:09 +00:00
d63170c4c0 coverity#704223 Logically dead code
Change-Id: I4d5380f7c60ff10d1e1c2560e1e1288eb79cd056
2014-02-11 20:21:48 +00:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
21e90f901d coverity#707748 : Uninitialized scalar field
Change-Id: I9155c4ab7409d1fa00abbc3c81ff03d0c0d3910b
2014-02-01 16:16:53 -06:00
e1dc859beb bool improvements
Change-Id: Ie4c9d7f01fef2604d80d8e465ce30daab7481eed
2014-01-28 20:26:29 +01:00
ef597d80dc Introduce com.sun.star.task.theJobExecutor singleton.
To replace com.sun.star.task.JobExecutor single-instance service,
incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58

[including changes by Stephan Bergmann <sbergman@redhat.com>]

Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687
Reviewed-on: https://gerrit.libreoffice.org/7609
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-24 14:24:34 +00:00
e3133ae237 Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).

Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23 18:43:53 +01:00
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
0e5c7d0b5b bool improvements
Change-Id: Iddc92e42a100a0fb36c77c21d4c176dded8f3391
2014-01-22 08:22:33 +01:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
d8bbe0ede2 EndDialog takes long nResult, not bool
Change-Id: Ic6283b7a71a5d1c539ae99155f448e34e877080a
2014-01-14 21:28:05 +01:00
382b013275 Some ConfigurationProvider -> theDefaultProvider simplifications
Change-Id: I7c25cd94f8a1ca339f7423c26f21f13c7a68906d
2014-01-08 09:10:29 +01:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
500448212a WaE: unused variable 'url'
Change-Id: I6ae6a95bdf9b0f82384dfdcbdefc6a546f81ef0f
2013-12-26 19:29:50 +02:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
661f7bdefc m_bHasActive must be false after last visible entry is removed
...otherwise, ExtensionBox_Impl::RecalcAll would crash in CalcActiveHeight(-1).

Change-Id: If399825951c79b821ed44ebefa19d1032ab4f850
2013-12-16 13:53:30 +01:00
7e72b9de55 use OUString::endsWith where possible
Change-Id: Ie2b68f79a7f9a54899f1d727f9a1fc7cfb14d90a
2013-12-12 13:15:24 +02:00
fb84710151 simplify - use OUString::startsWith where possible
Convert code like
   if( !aStr.isEmpty() && aStr[0] == 'x' )
to
   if( aStr.startsWith("x") )

Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12 13:15:24 +02:00
83e191e25d Do not use C++-UNO internal static_type functions in client code
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
de6be3dcdf convert accept license dialog to .ui
Change-Id: Ib36f42d65ef73446320823775accc94016afb13a
2013-12-06 10:50:25 +00:00
e661d295c2 convert show extension licence dialog to .ui
Change-Id: I0e34a0ddaee1485184b55788d618288f4e3f69cb
2013-12-06 09:38:14 +00:00
071c3f3e93 remove unnecessary use of OUString constructor in equalsIgnoreAsciiCase
Convert code like:
    sType.equalsIgnoreAsciiCase(OUString("VIEW"));
to:
    sType.equalsIgnoreAsciiCase("VIEW");

Change-Id: I6fb47e6a83b561c7e5a25da76b63606a3174858d
2013-11-22 08:07:18 +02:00
f01580ce9c Windows: Require at least Windows XP SP2
* Windows XP SP2 is 0x0502, see
  http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
  this is done module wide now. So the overall behavior
  is as before. This seems to be the best compromise for
  now.
* We need at least SP2 because of the bluetooth stuff
  used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
  has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
  project specific precompiled header files.
* All local definitions of WINVER are removed, because
  the global WINVER setting makes them obsolete now.

To the relation of the three macros:

Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.

WINVER and NTDDI_VERSION can be set idenpendently each
for itself.

Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20 07:15:16 -06:00
b0c988cf92 -Werror,-Wunused-member-function
Change-Id: I1e91eb89b25aea247bb2d615a14a7d1cdd2b488c
2013-11-14 10:14:58 +01:00
3e70dda335 remove unnecessary use of OUString constructor in DESKTOP module
Change-Id: I467334094a621f4bab0ff251267412fb3a0fb4b7
2013-11-11 11:21:24 +02:00
c69ed33628 Don't unnecessarily wrap RuntimeExceptions
(and IllegalArgumentException is a RuntimeException now)

Change-Id: Ic18f11ff7675878c7f6b5e9ee52453bbb9f1e787
2013-11-08 18:28:11 +01:00
7af7023a42 Unwind confusing namespace alias
Change-Id: I08d3e5f71278c7f96adb2db546da5602df84aad8
2013-11-08 18:08:46 +01:00
8bf2052de8 Improve debug output
Change-Id: Ia09e61a37bc485509c604df9279275003050d916
2013-11-05 09:31:29 +01:00
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
35836f3508 fixincludeguards.sh: desktop
Change-Id: Iaeba85d313af1840f925fd0536d11ac83545a118
2013-10-28 15:16:18 +01:00
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
5040ad523e Remove unnecessary component_getProcessComponentContext C wrapper
Change-Id: I9d9f1a542dbbfc461dd27c32b57e4cad5532fab0
2013-10-22 23:49:06 +02:00
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
0cd21c2bed drop intermediate Strings
Change-Id: I7f730d4f5329525eda9f78514dcaa3788149d077
2013-09-17 10:11:08 +01:00
7865b9762d convert DESKTOP module from String to OUString
Change-Id: I5dc43849ace8edbab9e6308db80a70797f090c69
2013-09-17 09:05:21 +02:00
e658caeda9 Extension Manager: surely we should be able to spawn uno ...
... in finite time; waiting forever may hang the smoktetest in case uno
fails to start.

Change-Id: I42be4cecb8eec82df8f2df63f02e1223e4933626
2013-09-09 22:09:18 +02:00
e13fd39593 getFallbackStrings() with bIncludeFullBcp47 parameter
so the various places that check the full tag first do not have to get
it just to delete it again.

Change-Id: Ib4e3cf1b16988464db875f1b6ac5cf4a0ab60fe5
2013-09-05 16:51:28 +02:00
d695e8d0ea was convertIsoStringToLanguage(), use makeFallback()
Change-Id: I215e418d314cbc8bbc333c2d75cdc1a0c07e9071
2013-09-03 20:35:39 +02:00
0e40013d90 Add macosx_x86_64 extension platform identifier
Change-Id: Ie7b6e8dee54ae240ff1ca7e7cac89b914dcce9ff
2013-08-30 19:18:26 +02:00
8492cd9f9a The "shared" extensions are read-only when HAVE_FEATURE_READONLY_INSTALLSET
Change-Id: Ia7b9a5a297ecc3bf8eedae10ee8918b5db40a5e6
2013-08-25 00:29:18 +03:00
123189c882 No use continuing with empty extensions sequence past the exception here
Change-Id: I889c7d526b0b06b3c77248d1da255ffa8f754da1
2013-08-22 16:26:50 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00