Commit Graph

628 Commits

Author SHA1 Message Date
af63727b9f Resolves: #i15508# Added support for BMP file type
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)

Conflicts:
	filter/source/msfilter/escherex.cxx
	include/vcl/gfxlink.hxx
	svx/source/xml/xmlgrhlp.cxx
	sw/source/ui/docvw/romenu.cxx
	vcl/source/filter/graphicfilter.cxx

Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00
aeaded675c Remove visual noise from filter
Change-Id: Ieab1d12204bcf917b2e1bf74f3145fc96d7b207c
Reviewed-on: https://gerrit.libreoffice.org/8261
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:10:36 -06:00
57779aa019 editeng: sal_Bool->bool
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27 12:30:26 +02:00
ef16d954c2 editeng: sal_Bool->bool
Change-Id: Ic3d9fe45d3242d3da147067d3c388e9d7305ee61
2014-02-27 12:30:25 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
2d3ed7ebb5 cid#736173 - increase default fill chars buffer size.
Change-Id: Ib7ae9b0a0cddd070372a244cf705f71b6e793473
2014-02-25 22:56:35 +00:00
b854cb787e coverity#735747 Dereference after null check
also

coverity#736774 Dereference before null check

Change-Id: Ic2e2a341565af0609ec748b40ac7848a46c9e3af
2014-02-24 12:53:09 +00:00
ad7fdc4e0f filter: Code reduction, prevents crash.
Not all shape types have the full com.sun.star. prefix, for example
FrameShape. The existing code would crash in that case, but the new
code doesn't.

Change-Id: I9aa3d0f20f48ab91a6770e8409a8da2028816504
2014-02-24 13:24:53 +01:00
ad73967e99 Remove unnecessary extractInterface
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
8a5ad76b4e Related: #i119985# date/time is displayed as different language
(cherry picked from commit 2a3c87a5ea5e3308a138e461dffae19483c0184c)

Change-Id: I3ef171481b206f7a9d356110d1b4a1559cd5e837
2014-02-23 21:01:19 +00:00
09c0e5110a coverity#704642 Dereference after null check
Change-Id: Iae9b7caf2076722a01e6882921622b193f2b4349
2014-02-23 14:22:43 +00:00
619b751f90 coverity#704641 Dereference after null check
Change-Id: Ib30bcefedb2685038f22e33b4c7a97b0295b224c
2014-02-23 14:22:43 +00:00
324f33cb44 coverity#704640 Dereference after null check
Change-Id: I05b932002ff8176d76f842dcd57ea39c4112f181
2014-02-23 14:22:43 +00:00
fe56219fcc coverity#704639 Dereference after null check
Change-Id: Ic176da3b05337678dd12fd23a726b958577cbefb
2014-02-23 14:22:42 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
c94f566aa4 coverity#738644 Uninitialized scalar field
Change-Id: Ic1c910cf2187405e966576bdba1ff606b23d993b
2014-02-21 12:40:28 +00:00
2484bf5804 coverity#738645 Uninitialized scalar field
Change-Id: I85496d643cfadbf7b6daa5d0c5e2b6d9382dcb5b
2014-02-21 12:40:28 +00:00
4e89ae1f46 coverity#738646 Uninitialized scalar field
Change-Id: I111f970932451a4557920b6988f6e1d508c462ed
2014-02-21 12:40:28 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
10985869bf coverity#984090 Uninitialized scalar field
Change-Id: I1df4f04b46e1b9c2d82d85aa915e4d04c5959e30
2014-02-19 09:33:01 +00:00
95401d5898 tools: sal_Bool -> bool
Change-Id: I3aad235d92b3972b44199294c0f3de65ad57f450
2014-02-18 08:18:29 +01:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
c7c761455f drawingML export: make WritePolyPolygon robuster
Make sure a:cubicBezTo conatins three a:pt elements.

escherex: It seems a cubic bezier curve last point has
a POLY_NORMAL flag and not POLY_CONTROL.

Change-Id: Id6dc2160c7ae171a720e4a1aa9161cef2b3b9413
2014-02-16 17:45:37 +01:00
3e971c792c sal_Bool->bool
Change-Id: Ibd5178f35d735e94065a3fbb6b61de53e53b1b0c
2014-02-14 14:15:13 +02:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
6f3fd680ea that delete of pWrapPolygon looks dodgy to me
seeing as it is only conditionally replaced later

Change-Id: I6801de8472b88f37a34aea260336750cb3c47015
2014-02-12 13:03:51 +00:00
3337331359 coverity#1169881 Use after free
this method is *way* too long and convoluted

Change-Id: Ib34d400043358a5426bbf5652e0bb12f8c49312a
2014-02-12 13:03:51 +00:00
ed5cf167c6 coverity#708947 Empty virtual destructor
Change-Id: I3f660aff0c53b1cd35c7ae57bde612daf0950349
2014-02-11 20:21:47 +00:00
3ec9bccaab silence coverity#1027865 Out-of-bounds access
and coverity#1027864

Change-Id: Ic3d1b91ef77ab3510c7428b7135dd9f249d56b4b
2014-02-07 09:03:48 +00:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
07eb648d82 Remove some extra break
Change-Id: I55405c748d67101ecef8ef8a52037a26bc52b9f6
2014-02-05 10:48:38 +01:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
5c39b6b997 drawingML export: custom geometry with cubic bezier curves
When the custom shape is not a preset shape then construct a
PolyPolygon and use DrawingML::WritePolyPolygon() to export it.

Change-Id: I6598976a475bfcb92305338af9016e09df4c9456
2014-02-03 02:46:30 +01:00
79a532c1be -Werror=maybe-uninitialized
Change-Id: I696dc966bce7a19d0de898fc107aa29784011bb4
2014-01-29 19:18:08 +01:00
a701b7dead coverity#1157789 Division or modulo by zero
Change-Id: I7c6fc34702acce21759dad00626ff4ffcd0ced95
2014-01-29 15:21:06 +00:00
ca1c17d7e5 coverity#1157791 Division or modulo by zero
Change-Id: I6b46a037b0d5f13681ad4936ddd56fd80c8128fb
2014-01-29 15:21:05 +00:00
fe89615fd2 coverity#1000696 Out-of-bounds access
Change-Id: I4e69c7f5e45882238c4cc27244f38b81c87780e2
2014-01-29 10:57:22 +00:00
19aa235feb nRetValue was a reference, nRetValue->rRetValue
Change-Id: I0516bc22274a3bdba54246613c9925d3f2a67c44
2014-01-29 10:57:22 +00:00
f0dc6cda75 bool improvements
Change-Id: Ib0f16e57ce84a40412fd95bffd4f41a113810a96
2014-01-28 20:24:40 +01:00
4f3012fc05 ooxml: Fix incorrectly named shape type in translation table
Change-Id: Iad49c54e29afb4a5fa0198d5300ca63dcb360874
2014-01-24 18:17:41 +01:00
f1ec5dcfca fdo#69616: Fix for VML part missing for group.
Cause:
 - In altenrate content, Fallback contains only group tag.
Implementation:
 - Added export logic in Vml export.
 - Added unit test case for vml group.

Change-Id: Ia1c9834950528dc892caea1cb675a7f42165d9ba
Reviewed-on: https://gerrit.libreoffice.org/7276
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-24 08:43:08 +00:00
2c31a03f7c coverity#1158490 Uninitialized scalar field
Change-Id: I03fd7aeea00a1998f4e281a7561f5d43672e9ccf
2014-01-23 16:02:12 +00:00
d803483f6a convert more SvStream::operator<< calls
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:39 +00:00
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
40cc36a2e7 fix the build 2014-01-19 18:20:50 +01:00
d8239d0b03 CID#705650: fix memory leak 2014-01-19 18:15:49 +01:00
6e216adedd filter: audit customshape type -> drawingML preset shape table
It turns out that this table contained entries which are not valid
drawingML preset shape names.

Invalid entries are now either have a valid name instead (based on the
oox/source/export/preset-definitions-to-shape-types.pl mapping, which
already tries to map VML shape ID's to drawingML preset strings), or in
case I found no mapping there, the entry is now simply commented out.

It's still better to fall back to export a shape as a rectangle than
corrupting the whole document.

Change-Id: Ic2d8926e5819f3312aaca55d50a1492332e52a9d
2014-01-15 15:04:36 +01:00
058324532e bool improvements
Change-Id: I4733554d3329525516511bbd60b9ad3fabc12be0
2014-01-14 21:28:06 +01:00