Commit Graph

592 Commits

Author SHA1 Message Date
2a09751d51 Remove visual noise from fpicker
Change-Id: I58ae70cc71853e17e638ef64aaded87615e37986
Reviewed-on: https://gerrit.libreoffice.org/8264
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:35:19 -06:00
36774806da (a/A)utomaticaly -> (a/A)utomatically
Change-Id: Ice4327bdb8e5a14ef082f013fa513b2267f0fbf3
2014-02-25 22:00:50 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
94bc29cb71 Typo: I/internaly -> I/internally
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-09 10:12:07 +01:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
6f0e7c36e4 Typo: seam(s) -> seem(s)
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
2014-02-06 21:22:42 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
acc0fcd96c fpicker: cleanup async requests, dung out comments.
Change-Id: I016145d315ae1c4b5376e43583e2546a2b7f7b07
2013-11-20 15:44:14 -05:00
f01580ce9c Windows: Require at least Windows XP SP2
* Windows XP SP2 is 0x0502, see
  http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
  this is done module wide now. So the overall behavior
  is as before. This seems to be the best compromise for
  now.
* We need at least SP2 because of the bluetooth stuff
  used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
  has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
  project specific precompiled header files.
* All local definitions of WINVER are removed, because
  the global WINVER setting makes them obsolete now.

To the relation of the three macros:

Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.

WINVER and NTDDI_VERSION can be set idenpendently each
for itself.

Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20 07:15:16 -06:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
4da020c527 Windows XP is 0x0501
See http://msdn.microsoft.com/en-us/library/aa383745.aspx

And as we support only XP as minimum change this.

Change-Id: Iad51b0dd4bb960ed5a270b0b701ec3e0b28ab4e2
2013-10-30 22:58:19 +01:00
bb13b922b6 fpicker: warning C4018: '<': signed/unsigned mismatch
Change-Id: I51652d573f59e6ca3b00385790bf14d478f03074
2013-10-28 15:21:54 +01:00
4089083f32 Resolves: #i123544# Prevent accessing empty filters' vector
(cherry picked from commit 3b16c98449d120b07ca4f2f312e31127ac655482)

Change-Id: Ieb71209d9c299ef7f050e00ccf010aca87ee2ab7
2013-10-27 12:03:23 +00:00
7235d23267 fdo#54938: Adapt supportsService implementations to cppu::supportsService
Change-Id: I683c0d30c3286ed5d725d4eefe8b3977b82ee316
Reviewed-on: https://gerrit.libreoffice.org/6035
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-07 17:01:33 +00:00
a92be728a5 fdo#42155: Replace the only use of CAutoUnicodeBuffer end part
Change-Id: Id1c00a24cdc1914693d8cadeeee64923af3db786
Reviewed-on: https://gerrit.libreoffice.org/5829
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-09-08 03:19:20 +00:00
346427e22e remove duplicate include
Change-Id: I1809d186b9eabb03c8d388cc9361014d16a3080d
2013-09-05 20:01:07 +02:00
07e23d609e fpicker: try to fix headers to make tinderbox happy
Change-Id: If0de9b31b4d754dfda4f135a8ffa6df21d7b4314
2013-09-05 19:06:25 +02:00
07dee4da76 add missing include
Change-Id: Id28803d431c2f585f46b92888ee5b97293b63a2e
2013-09-05 18:56:19 +02:00
36baf31d2b fdo#42155: Replace the only use of CAutoUnicodeBuffer part1
Change-Id: Id6ea78148b7689199540407518f6bcb25af4450d
Reviewed-on: https://gerrit.libreoffice.org/5713
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-05 16:21:57 +00:00
df58d4a925 Typo: controling => controlling
Change-Id: Ie5bb34d2000be74bad7f18808f49f389ab9373d8
2013-08-12 21:40:22 +02:00
570fe620e9 Keep passing XComponentContext into officecfg:: wrapper fns, where available
Change-Id: I10448edd04c6c7e7f03c539bf85aba4e00c7e311
2013-07-24 09:31:41 +02:00
75ef95ebc4 fdo#46037: no more comphelper/configurationhelper.hxx in fpicker
Change-Id: I571e0271d9432118d886561e140d689b2d1b8713
Reviewed-on: https://gerrit.libreoffice.org/5042
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-24 00:43:46 +02:00
57ebb84c1f Revert "fdo#46037: no more comphelper/configurationhelper.hxx in fpicker"
This reverts commit 7cbf9c9e0a34937783dfa7f78d460dcf70504841.

Revert "Trying to fix the windows build"

This reverts commit d1f58e5ea695e823e931aad1bfb1d7b4bf17634c.

Change-Id: I67d00ec010a834e27b0e79b0afd92c5a2e7d47d6
2013-07-24 00:33:03 +02:00
7cbf9c9e0a fdo#46037: no more comphelper/configurationhelper.hxx in fpicker
Change-Id: I571e0271d9432118d886561e140d689b2d1b8713
Reviewed-on: https://gerrit.libreoffice.org/5042
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-23 21:32:30 +00:00
e9fd9c2526 Cleaning: remove use of old edt1 from dlg.h (Windows)
edt1 was used before cmb13 (used from Win2K version)
So use only cmb13 + tweaks associated comments
See http://nabble.documentfoundation.org/Cppcheck-reassignment-of-edt1Id-because-isWin2000-has-been-removed-fpicker-module-td4061342.html

Change-Id: I9d56726508a9fbf2607c9d18b7b33eca340f1b9f
Reviewed-on: https://gerrit.libreoffice.org/4283
Tested-by: Andras Timar <atimar@suse.com>
Reviewed-by: Andras Timar <atimar@suse.com>
2013-06-17 06:25:19 +00:00
956c775c54 mingw64: Don't cast from MAKELONG to pointer directly
Change-Id: Ia0ff071a5676f27d39175e30d7c5f472e32c99b3
2013-06-10 14:03:35 +02:00
35a65baefe Slowly, but surely going on compiling for mingw64
Change-Id: I590aa6a854a040281bf73d5be768c05d4906a984
2013-06-06 15:52:05 +02:00
95c0d568fd use uno::Reference#clear() method...
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
e347af862c typo fix: s/inavlid/invalid/
Change-Id: If75cad038f35033be6dcad6f051673bd795accf3
2013-05-14 15:52:24 +02:00
11fd73acce SolarMutex does not belong into the URE interface
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx.  It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.

I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.

(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)

Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
4d52f70467 Different fix for bnc#777788
Use the same GUID in the file dialog for the FILESAVE_AUTOEXTENSION
case as for the FILESAVE_AUTOEXTENSION_SELECTION case. The former is
used when exporting to PDF. Exactly why using one GUID for the dialog
causes it to use the default folder as set by SetFolder(), and the
other not, I have no idea. Are the GUIDs we use arbitrary (and unique
to the OOo/LO codebase), or does either of them, or both, have some
magic meaning to Windows?

FILESAVE_AUTOEXTENSION is also used in other cases than exporting to
PDF. It remains to be seen whether this change will cause noticeable
behaviour change interpreted as a harmful regression. Or whether the
change of default folder for PDF export will do that, for that matter.

Change-Id: I135e4b2b2bc4dc70670919fb478196e27b55ac79
2013-05-08 11:34:24 +03:00
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
7b4d85901b those are never defined
Change-Id: If3893026047f9a75a122b64a5f368070721bb6d7
2013-04-27 12:04:20 +02:00
3b032a3ef1 fdo#63622: Revert '"Fix" bnc#777788'
Let's keep that "fix" just in the SUSE-specific branch.

This reverts commit 56d41fef8f96888d5aaf39a9c4d0c7eca5b63d44.

Conflicts:
	fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx

Change-Id: If331c6ec8978923e8e8bc6653bd27b5a9edaf2d7
2013-04-26 08:45:27 +03:00
52b618e196 VistaFilePicker::getDisplayDirectory(): s/NON_BLOCKED/BLOCKED/
All getter methods in this class use BLOCKED, all setter methods use
NON_BLOCKED... except for getDisplayDirectory(), without any hint as
to why it might be different... so make it consistent.

Change-Id: I3c90ea6560944f9e7033a26f4419003f154a520c
2013-04-26 00:11:13 +02:00
435f5e30c9 fdo#60724 correct spelling
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-15 05:10:29 +02:00
60fbefc615 fdo#60724 informations -> information
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
f40b19d4b8 Windows build failed
Change-Id: I5a1ccd2b06526291e0db827d9e7d512c59d76270
2013-04-08 16:31:33 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
e1f6dac689 Replace compareTo(...) == 0 with ==
Proposed patch for the following issue:
https://bugs.freedesktop.org/show_bug.cgi?id=62096

Change-Id: Ib83a9051ea12c53642f781e5427a6ca728049a7f
Reviewed-on: https://gerrit.libreoffice.org/3198
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-04-05 08:57:28 +00:00
049ce78144 remove local css definitions
follow-up of 66a175834c39ccde9475eac3adb72a843110d01f

Change-Id: I1c495041ccc4db4dd9554d49b6324e989fa46c60
2013-03-30 00:56:42 +01:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00