wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
346,699 Commits 5 Branches 0 Tags
c94f12a3893f79c73a12d330dd0e01dde64da170
Commit Graph

6633 Commits

Author SHA1 Message Date
Kohei Yoshida
f32df2d590 fdo#75053: Adjust reference update on shift for formula groups. 
This is similar to my earlier fix for reference update on moving of
cells.

Change-Id: I592599507bfcab12f611eeae7b56c99da6c31919
 2014-02-28 21:28:57 -05:00
Kohei Yoshida
c177e1cbec Simplify ScViewFunc::DoThesaurus() with ScCellValue. 
Change-Id: Ic5d31107aa7653cd8e3fae096888bd633696074f
 2014-02-27 23:23:09 -05:00
Kohei Yoshida
cf70996311 Remove all uses of GetMarkRowRanges() and use GetMarkedRowSpans(). 
And ditto with its column variant.  The former created a heap array of
1 million elements (=MAXROWCOUNT). There is no need for this memory
wastage.

Change-Id: I07845966c51cdcbdc676cd0d249f6420a19b9c5e
 2014-02-27 21:35:02 -05:00
Kohei Yoshida
6ef6dd0122 Store the length of originally requested array size prior to trimming. 
This change adds GetRequestedArrayLength() method to both single and double
vector ref tokens, which returns the length of the requested array size prior
to trimming of the trailing empty cell region.

Change-Id: Iaba96fa2ea4ff3c8bccb0bc86fa4f1525e2f45fb
 2014-02-27 21:19:36 -05:00
Caolán McNamara
cadddf1640 coverity#1187687 Dereference null return value 
Change-Id: Iaaa2f17382d83e864d7f14f3788e7f7476ac3212
 2014-02-27 12:58:47 +00:00
Caolán McNamara
8a21d42426 coverity#1187670 Dereference null return value 
Change-Id: Ib1b2616e48d1fed7ae1557f60af04920025a9ae5
 2014-02-27 12:58:44 +00:00
Caolán McNamara
467a4d5f41 coverity#1187669 Dereference null return value 
Change-Id: Ic77fc2d436bf70ee166e4732f19f2067907f7c53
 2014-02-27 12:58:44 +00:00
Caolán McNamara
6cccfffa08 coverity#1187667 Dereference null return value 
Change-Id: Ibc7f840f984ce12e9dae998085f42168d7819dc8
 2014-02-27 12:58:43 +00:00
Noel Grandin
d0edd3dc7d remove unused code in ScCellIterator 
Specifically:
  ScCellIterator::getValue()
  ScCellIterator::hasNumeric() const

Change-Id: If15c627789576772bb220ece0b9dd143b1374a1b
 2014-02-27 10:27:34 +02:00
Noel Grandin
988a6c418d remove unused cdeo from ScCellValue 
Specifically:
  ScCellValue::ScCellValue(EditTextObject const&)
  ScCellValue::ScCellValue(ScFormulaCell const&)
  ScCellValue::hasNumeric() const
  ScCellValue::hasString() const
  ScCellValue::set(ScFormulaCell const&)

Change-Id: Ief8c07d6e2c7df6c6037fb3e59c00c37e3e0a49a
 2014-02-27 10:27:33 +02:00
Noel Grandin
6374c59217 remove unused code ScColorScaleEntry::UpdateMoveTab(short, short, short) 
Change-Id: I32437bb06dc5fd1522361d9591f470d00bb96d77
 2014-02-27 10:27:32 +02:00
Noel Grandin
2d257fa778 remove unused code in ScColumn 
Specifically:
  ScColumn::DeleteCellNote(int)
  ScColumn::MoveListeners(SvtBroadcaster&, int)
  ScColumn::SetRawString(sc::ColumnBlockPosition&, int,
                         rtl::OUString const&, bool)

Change-Id: I34ec659bce7ae18cc3e9d0e27fcd138bc64201b0
 2014-02-27 10:27:32 +02:00
Noel Grandin
b709688cae remove unused data ScComplexRefData::IsDeleted() 
Change-Id: I06d44a709f18b457c3d3381e2c6f4636fbffd4f0
 2014-02-27 10:27:32 +02:00
Noel Grandin
297c4d4021 remove unused code ScDBQueryDataIterator::DataAccessInternal::setPos 
Change-Id: If59f5b99a792ff5eafc0e027a84ca07b89a86c81
 2014-02-27 10:27:32 +02:00
Noel Grandin
778e685b6d remove unused code ScDPFilteredCache::SingleFilter::getMatchValue() 
Change-Id: If47b1c5e3c04be18315cd9698c18d6e6bf5b7084
 2014-02-27 10:27:31 +02:00
Noel Grandin
368d3aba40 remove unused code ScDocument::GetCellCount(short, short) const 
Change-Id: I63f6bf43dade896858a78414beaafb9792831946
 2014-02-27 10:27:31 +02:00
Noel Grandin
5ecbb39b9b remove unused code ScFlatBoolRowSegments::getValue(int) 
Change-Id: Ifd3fdbd5fc336064cbcd9d085e8fc5062e95aa77
 2014-02-27 10:27:31 +02:00
Noel Grandin
af9d999091 remove unused code ScGlobal::GetStandardFormat 
full signature:
    ScGlobal::GetStandardFormat(double, SvNumberFormatter&,
        unsigned long, short)

Change-Id: Ifa2946cdb1d27f3a7bca1541c8f569456cb45b88
 2014-02-27 10:27:30 +02:00
Noel Grandin
99e5749e80 remove unused code ScRangeStringConverter::GetRangeListFromString 
full signature:
ScRangeStringConverter::GetRangeListFromString(
    css::uno::Sequence<css::table::CellRangeAddress>&,
    rtl::OUString const&, ScDocument const*,
    formula::FormulaGrammar::AddressConvention,
    unsigned short, unsigned short)

Change-Id: I61784cb55fb82caaeed22ddae94017c3ea630990
 2014-02-27 10:27:30 +02:00
Noel Grandin
44af42016e remove unused code ScRefCellValue::commit(ScColumn&, int) const 
Change-Id: I2f91a7b6b471d655f19f1f0ed94c4e1d0273ed80
 2014-02-27 10:27:29 +02:00
Noel Grandin
b28e435105 remove unused code ScTable::GetNote(short, int) 
Change-Id: Iad250b204423b897d903053b3ea4c63c01837e79
 2014-02-27 10:27:29 +02:00
Noel Grandin
4573046663 remove unused code ScTable::SetRawString(short, int, rtl::OUString const&) 
Change-Id: I098143e76c141e4cf6b9d9aec4cb727680ea7457
 2014-02-27 10:27:28 +02:00
Noel Grandin
1c5797b166 remove unused code ScRefreshTimer::StartRefreshTimer() 
Change-Id: If96e0de72338aabfb2c4db04fba8f524d48a1d5c
 2014-02-27 10:27:28 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Caolán McNamara
c5bcfe902d callcatcher: update unused code 
Change-Id: I2d79938465800a6bfe8cc120b85dc449ff04a960
 2014-02-26 11:51:16 +00:00
Noel Grandin
dbe081749d remove unused code ScDocument::IsEmptyData(short, short) 
and the consequently unused code
ScTable::IsEmptyData(short, short)

Change-Id: I622de7c1118d61c0e434f80d1b7c41ace24c5592
 2014-02-26 08:55:07 +02:00
Noel Grandin
0a0290b252 remove unused code ScDocument::CountNotes() 
Change-Id: Ic0f638f1e052b2d9117207f234d879638cbfc19a
 2014-02-26 08:55:06 +02:00
Noel Grandin
10bf297024 remove unused code ScDocument::GetFormulaTokens 
and consequently unused code
ScTable::GetFormulaTokens
ScColumn::GetFormulaTokens

Change-Id: Iad1fd45e67489bb8b0f9ed96a36b647e40e6f774
 2014-02-26 08:55:04 +02:00
Noel Grandin
8a6c9bc82d remove unused code ScDocument::RebuildFormulaGroups() 
and the consequently unused code
ScTable::RebuildFormulaGroups()

Change-Id: Ic7dfb7420c7cc4ca52c4ed4fe580fbb499ab53b6
 2014-02-26 08:54:55 +02:00
Noel Grandin
9bfbaa5864 remove unused code ScFormulaCell::HasColRowName() 
Change-Id: I907492e1385f76d27cc8559d599f518d3b91f75d
 2014-02-26 08:54:54 +02:00
Kohei Yoshida
79d03eb090 fdo#75386: Totally fix reference update during range move. 
It was just not working at all due to multiple reasons.  The
reference update needed to be reworked for formula groups such that
the token array is adjusted only for the top cell but all formula cells
still needed to be processed afterwards.  The bound check also needed
to be done against the old range prior to the move, not the new range
after the move.

During undo, the paint had to be deferred until after the two calls to
DoUndo() else the formula cells would get re-calculated before the
values were placed back to their old positions, causing them to mis-
calculate wrong values.

Change-Id: Iba66f80a413e0539cac5ab619226cd6f7a04f317
 2014-02-25 22:53:39 -05:00
Noel Grandin
265aea232c remove unused code ScEditUtil::GetSpaceDelimitedString(EditTextObject const&) 
Change-Id: Ie18a4c8a75b5cd3b42ecfa3278806a2c8876c8ee
 2014-02-25 15:16:59 +02:00
Noel Grandin
651d52ca04 remove unused code ScFormulaCell::GetErrorOrString 
and then the now unused code in ScFormulaResult::GetErrorOrString

Change-Id: I95de8b5c24c0127cff61399eb6f38359040aace3
 2014-02-25 15:16:59 +02:00
Kohei Yoshida
4917cebdb9 fdo#75304: Set external reference info to ScCompiler. 
And remove this excessive const fetish which was unfortunately necessary to
get this to compile.  Setting the container const is good enough.

Change-Id: I2c6cc55a88643a68e065c4518cdf069c247f4f02
 2014-02-24 16:05:07 -05:00
Kohei Yoshida
e752620bf5 fdo#75259: Let undo document share its string pool with the source doc. 
We already do that for the pool helper.  It would only make sense to do
it for shared strings as well.

Change-Id: I813d262799af6f0c1d3fa12246ad973f852ac199
 2014-02-24 13:13:51 -05:00
Stephan Bergmann
76b114f849 implicitboolconversion: warn about implicit conversion of call args to bool 
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.

Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.

(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)

Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
 2014-02-24 17:25:05 +01:00
Matteo Casalin
83aa6d8180 Remove some temporaries around calls to SvNumberFormatter methods 
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
 2014-02-24 09:08:35 +01:00
Takeshi Abe
a53577e6ff Replace deprecated std::auto_ptr with boost::scoped_ptr 
Change-Id: I55292f5f0049e7c77d5bb0e5ef5fa187b815d159
 2014-02-24 10:20:51 +09:00
Caolán McNamara
7db1dbaa70 coverity#706831 Uncaught exception 
also

coverity#706839 Uncaught exception
coverity#706840 Uncaught exception

and probably a gadzillion more

Change-Id: I3c3ceebb259cccc9c41f5a49bd0c95b151dd7c58
 2014-02-23 15:29:32 +00:00
Caolán McNamara
1cd5a55007 coverity#706826 Uncaught exception 
also

coverity#706827 Uncaught exception

and probably a gadzillion more

Change-Id: Ia924e33b188035e8dcb4f345d6c20d6c7bbcf4ea
 2014-02-23 15:29:21 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Noel Grandin
b7180bd14f editeng: sal_Bool->bool 
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
 2014-02-21 12:19:24 +02:00
Noel Grandin
327dde336e editeng: sal_Bool->bool 
Change-Id: Ib1113ebcfc523c8c97731debb2bf456a8c99d802
 2014-02-21 12:19:21 +02:00
Noel Grandin
4692d28e90 sal_Bool->bool 
Change-Id: I83a9267cc461c2921b5da04a1122539ba0ac7d2d
 2014-02-21 12:19:19 +02:00
Noel Grandin
09fed2bcd3 cid#708014 Uninitialized pointer field 
Change-Id: Icfffb7ce6e34f31ae1bcc2964460e59f5486399d
 2014-02-21 11:59:10 +02:00
Noel Grandin
b6c8a233f2 cid#707998 Uninitialized pointer field 
Change-Id: I7e72f2e3f2d62c0f293f9cdab212fabd74452b4d
 2014-02-21 11:59:09 +02:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx 
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 16:22:17 +00:00
Noel Grandin
64ed1e1c07 cid#983376 Dereference before null check 
Change-Id: Ife25ca2199b9f4c997f2c7ad500b612b4703c07e
 2014-02-20 09:31:10 +02:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool 
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
 2014-02-20 08:17:00 +01:00
Kohei Yoshida
9e183fbfdb fdo#75228: We still need to get the value only to pop value from the stack. 
Change-Id: Iad231aa97ed35f91b96cddf8157ebcd9af0f8ec9
 2014-02-20 00:29:18 -05:00