Commit Graph

3839 Commits

Author SHA1 Message Date
f32df2d590 fdo#75053: Adjust reference update on shift for formula groups.
This is similar to my earlier fix for reference update on moving of
cells.

Change-Id: I592599507bfcab12f611eeae7b56c99da6c31919
2014-02-28 21:28:57 -05:00
c177e1cbec Simplify ScViewFunc::DoThesaurus() with ScCellValue.
Change-Id: Ic5d31107aa7653cd8e3fae096888bd633696074f
2014-02-27 23:23:09 -05:00
cf70996311 Remove all uses of GetMarkRowRanges() and use GetMarkedRowSpans().
And ditto with its column variant.  The former created a heap array of
1 million elements (=MAXROWCOUNT). There is no need for this memory
wastage.

Change-Id: I07845966c51cdcbdc676cd0d249f6420a19b9c5e
2014-02-27 21:35:02 -05:00
6ef6dd0122 Store the length of originally requested array size prior to trimming.
This change adds GetRequestedArrayLength() method to both single and double
vector ref tokens, which returns the length of the requested array size prior
to trimming of the trailing empty cell region.

Change-Id: Iaba96fa2ea4ff3c8bccb0bc86fa4f1525e2f45fb
2014-02-27 21:19:36 -05:00
8a21d42426 coverity#1187670 Dereference null return value
Change-Id: Ib1b2616e48d1fed7ae1557f60af04920025a9ae5
2014-02-27 12:58:44 +00:00
467a4d5f41 coverity#1187669 Dereference null return value
Change-Id: Ic77fc2d436bf70ee166e4732f19f2067907f7c53
2014-02-27 12:58:44 +00:00
d0edd3dc7d remove unused code in ScCellIterator
Specifically:
  ScCellIterator::getValue()
  ScCellIterator::hasNumeric() const

Change-Id: If15c627789576772bb220ece0b9dd143b1374a1b
2014-02-27 10:27:34 +02:00
988a6c418d remove unused cdeo from ScCellValue
Specifically:
  ScCellValue::ScCellValue(EditTextObject const&)
  ScCellValue::ScCellValue(ScFormulaCell const&)
  ScCellValue::hasNumeric() const
  ScCellValue::hasString() const
  ScCellValue::set(ScFormulaCell const&)

Change-Id: Ief8c07d6e2c7df6c6037fb3e59c00c37e3e0a49a
2014-02-27 10:27:33 +02:00
6374c59217 remove unused code ScColorScaleEntry::UpdateMoveTab(short, short, short)
Change-Id: I32437bb06dc5fd1522361d9591f470d00bb96d77
2014-02-27 10:27:32 +02:00
2d257fa778 remove unused code in ScColumn
Specifically:
  ScColumn::DeleteCellNote(int)
  ScColumn::MoveListeners(SvtBroadcaster&, int)
  ScColumn::SetRawString(sc::ColumnBlockPosition&, int,
                         rtl::OUString const&, bool)

Change-Id: I34ec659bce7ae18cc3e9d0e27fcd138bc64201b0
2014-02-27 10:27:32 +02:00
297c4d4021 remove unused code ScDBQueryDataIterator::DataAccessInternal::setPos
Change-Id: If59f5b99a792ff5eafc0e027a84ca07b89a86c81
2014-02-27 10:27:32 +02:00
778e685b6d remove unused code ScDPFilteredCache::SingleFilter::getMatchValue()
Change-Id: If47b1c5e3c04be18315cd9698c18d6e6bf5b7084
2014-02-27 10:27:31 +02:00
368d3aba40 remove unused code ScDocument::GetCellCount(short, short) const
Change-Id: I63f6bf43dade896858a78414beaafb9792831946
2014-02-27 10:27:31 +02:00
5ecbb39b9b remove unused code ScFlatBoolRowSegments::getValue(int)
Change-Id: Ifd3fdbd5fc336064cbcd9d085e8fc5062e95aa77
2014-02-27 10:27:31 +02:00
af9d999091 remove unused code ScGlobal::GetStandardFormat
full signature:
    ScGlobal::GetStandardFormat(double, SvNumberFormatter&,
        unsigned long, short)

Change-Id: Ifa2946cdb1d27f3a7bca1541c8f569456cb45b88
2014-02-27 10:27:30 +02:00
44af42016e remove unused code ScRefCellValue::commit(ScColumn&, int) const
Change-Id: I2f91a7b6b471d655f19f1f0ed94c4e1d0273ed80
2014-02-27 10:27:29 +02:00
b28e435105 remove unused code ScTable::GetNote(short, int)
Change-Id: Iad250b204423b897d903053b3ea4c63c01837e79
2014-02-27 10:27:29 +02:00
4573046663 remove unused code ScTable::SetRawString(short, int, rtl::OUString const&)
Change-Id: I098143e76c141e4cf6b9d9aec4cb727680ea7457
2014-02-27 10:27:28 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
dbe081749d remove unused code ScDocument::IsEmptyData(short, short)
and the consequently unused code
ScTable::IsEmptyData(short, short)

Change-Id: I622de7c1118d61c0e434f80d1b7c41ace24c5592
2014-02-26 08:55:07 +02:00
0a0290b252 remove unused code ScDocument::CountNotes()
Change-Id: Ic0f638f1e052b2d9117207f234d879638cbfc19a
2014-02-26 08:55:06 +02:00
10bf297024 remove unused code ScDocument::GetFormulaTokens
and consequently unused code
ScTable::GetFormulaTokens
ScColumn::GetFormulaTokens

Change-Id: Iad1fd45e67489bb8b0f9ed96a36b647e40e6f774
2014-02-26 08:55:04 +02:00
8a6c9bc82d remove unused code ScDocument::RebuildFormulaGroups()
and the consequently unused code
ScTable::RebuildFormulaGroups()

Change-Id: Ic7dfb7420c7cc4ca52c4ed4fe580fbb499ab53b6
2014-02-26 08:54:55 +02:00
9bfbaa5864 remove unused code ScFormulaCell::HasColRowName()
Change-Id: I907492e1385f76d27cc8559d599f518d3b91f75d
2014-02-26 08:54:54 +02:00
79d03eb090 fdo#75386: Totally fix reference update during range move.
It was just not working at all due to multiple reasons.  The
reference update needed to be reworked for formula groups such that
the token array is adjusted only for the top cell but all formula cells
still needed to be processed afterwards.  The bound check also needed
to be done against the old range prior to the move, not the new range
after the move.

During undo, the paint had to be deferred until after the two calls to
DoUndo() else the formula cells would get re-calculated before the
values were placed back to their old positions, causing them to mis-
calculate wrong values.

Change-Id: Iba66f80a413e0539cac5ab619226cd6f7a04f317
2014-02-25 22:53:39 -05:00
651d52ca04 remove unused code ScFormulaCell::GetErrorOrString
and then the now unused code in ScFormulaResult::GetErrorOrString

Change-Id: I95de8b5c24c0127cff61399eb6f38359040aace3
2014-02-25 15:16:59 +02:00
e752620bf5 fdo#75259: Let undo document share its string pool with the source doc.
We already do that for the pool helper.  It would only make sense to do
it for shared strings as well.

Change-Id: I813d262799af6f0c1d3fa12246ad973f852ac199
2014-02-24 13:13:51 -05:00
83aa6d8180 Remove some temporaries around calls to SvNumberFormatter methods
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-02-24 09:08:35 +01:00
a53577e6ff Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I55292f5f0049e7c77d5bb0e5ef5fa187b815d159
2014-02-24 10:20:51 +09:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
b7180bd14f editeng: sal_Bool->bool
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21 12:19:24 +02:00
327dde336e editeng: sal_Bool->bool
Change-Id: Ib1113ebcfc523c8c97731debb2bf456a8c99d802
2014-02-21 12:19:21 +02:00
4692d28e90 sal_Bool->bool
Change-Id: I83a9267cc461c2921b5da04a1122539ba0ac7d2d
2014-02-21 12:19:19 +02:00
b6c8a233f2 cid#707998 Uninitialized pointer field
Change-Id: I7e72f2e3f2d62c0f293f9cdab212fabd74452b4d
2014-02-21 11:59:09 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
64ed1e1c07 cid#983376 Dereference before null check
Change-Id: Ife25ca2199b9f4c997f2c7ad500b612b4703c07e
2014-02-20 09:31:10 +02:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
ca50752c34 fdo#72491: Always set input as text when that's requested.
Even when the text begins with '='.

Change-Id: I6e0a995f3042240b9f78068b5d0b9b758eb253ed
2014-02-18 22:59:41 -05:00
cdc8ebf964 fdo#74573: Delete ranges that are non-empty before pasting from clipboard.
The conditional formatting part is still not working. But other bits
appear to be working now.

Change-Id: Ia8a2cbe57cd2fa9ca9ad46635a91a1d8b99b0e7d
2014-02-18 16:51:18 -05:00
3920bb664a coverity#984133 Uninitialized scalar field
Change-Id: I933aa0d34d99808ccc359acfd895a7b9ea60217c
2014-02-17 23:15:51 -06:00
575e88da27 fdo#75032: Handle note copying correctly.
Change-Id: I1b8fa5231b23554c856fb63b580cb13ea9223b08
2014-02-17 22:26:40 -05:00
2f55cee393 fdo#74573: Skip removing of cell notes on empty cells if the flag is set.
Change-Id: I0d9cb5b48c5fdf51cf290cd838f5d6d7cb572e8b
2014-02-17 19:47:27 -05:00
4d15e903bf cid#736786 dereference before null check
Change-Id: I9cf201148c7cf90e95c88b7bf53e07f1ada9e229
2014-02-17 14:04:34 +02:00
f38aa72c1d fdo#73800 fix incorrect separator in function description in Calc
Depending on locale, the function description with arguments did
show incorrect separator(s) for functions with PAIRED_VAR_ARGS.

Change-Id: Ie493a77285360a099e5b07e8360ecb5c6c6c1aec
Reviewed-on: https://gerrit.libreoffice.org/8052
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-02-14 21:30:41 +00:00
8610d99b04 Related: #i124065# Low performance opening attached .ods
(cherry picked from commit d89ee4f6306ce8f290e01c80edbcc28a5cd8dcc3)

Conflicts:
	sc/inc/document.hxx
	sc/source/core/data/documen3.cxx
	sc/source/ui/unoobj/nameuno.cxx

Change-Id: Iced475cefe1df62920535db252841fe40339ebb1
2014-02-14 18:29:27 +00:00
11cea9af95 sal_Bool->bool
Change-Id: I42f3e248cc368a8cea47ff8ff124df654d445879
2014-02-14 14:15:01 +02:00
f5c4fd14a8 sal_Bool->bool
Change-Id: Ia411584e133b80eb72676acef6f004bf87898141
2014-02-14 14:15:01 +02:00
15db276813 sal_Bool->bool
Change-Id: I68c8c9f4d2a76ca4ad469a92714db86f1deae4de
2014-02-14 14:15:00 +02:00
e0c9266f5c sal_Bool->bool
Change-Id: I7b48eab9d76d5909080a615f0ad04cdfbda77d26
2014-02-14 14:14:59 +02:00
6124183d7b WaE: private fields 'mnStartRow' and 'mnEndRow' are not used
Change-Id: I067ad401608552df45275d0cbb73e486e93461ba
2014-02-14 08:40:23 +02:00