Commit Graph

1202 Commits

Author SHA1 Message Date
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
6fc2bd0094 Fixup whitespace changes, remove commented code.
This is a light touchup of 2ef9df8aee696993d9eb235fd36caa4cbcfd3624

Change-Id: Icfaf6fb0111c85b5f78010b16bdda0e237419323
2014-02-26 17:50:46 +01:00
2ef9df8aee Remove visual noise from sd
Change-Id: I0957cabd66ddc4e25c7e6ff54ec2a555eda0792c
Reviewed-on: https://gerrit.libreoffice.org/8306
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 06:53:03 -06:00
ad73967e99 Remove unnecessary extractInterface
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
6cccfd6c63 coverity#704736 Dereference after null check
Change-Id: Ib11b59696135f29375ec53332c526f0b5bcd638d
2014-02-23 14:45:55 +00:00
ad346fb791 coverity#704735 Dereference after null check
Change-Id: Ib2804949024dc3967d3eb2bcc7a82844f225be2f
2014-02-23 14:43:37 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
7be107378b coverity#738813 Uninitialized scalar field
Change-Id: Ibd63cdba123a1171b40780bb8a9ab6ef1af6e8a0
2014-02-21 12:40:24 +00:00
11a671ac5b coverity#738815 Uninitialized scalar field
Change-Id: I64379b438718ac1043fe7583a9eba966d8d83853
2014-02-21 12:40:23 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
b7180bd14f editeng: sal_Bool->bool
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21 12:19:24 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
d024fe60dc fdo#63154 Remove unused solar.h reference in sd.
Change-Id: I3dca2ffe3f94bedfea954bd83e84c724fb564ec9
Reviewed-on: https://gerrit.libreoffice.org/8063
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-15 15:27:01 +00:00
a4d059e2b1 cid#704734 reference after null check
Change-Id: I54a51427347bdd363fc980db4c1ef1a1feb99177
2014-02-14 11:38:03 +02:00
b2878af322 more SvStream:operator>> conversion
Convert the template based read_lenPrefixed methods to regular
methods.

Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:32:11 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
6f984c03da coverity#738965 unused pointer value
Change-Id: Ie00a0ec0cbe5e3ec9c8e0e54f93153e799b621af
2014-02-07 12:14:32 +02:00
eba6a6789c fdo#33852 do not remove too much from the path
Change-Id: I1cf89f300530e761df5a287097d05f95d8af2017
2014-02-06 15:17:16 +01:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
326bec33e0 some more continuous corrections 2014-02-03 14:01:40 +01:00
3cbfcee36d xub_StrLen and tools/string.hxx final straw
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases

Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-03 07:44:28 +00:00
64126a2d87 cppcheck: redundantAssignment
Change-Id: I8f29605dd11e39da6b0d9704c4801c5a798c4078
2014-02-01 19:36:35 +01:00
608953c425 bool improvements
Change-Id: Icac34936bdb551ad517170fd497212513719d2aa
2014-01-28 20:26:23 +01:00
61ca90050b coverity#1038498 : Uninitialized scalar field
Change-Id: I11f3056e96436fbb305316ef5c6505629e6418a3
2014-01-27 00:15:51 -06:00
16a2e90335 remove SvStream::operator<< methods
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
8711842d1b bool improvements
Change-Id: I19b429741a2ba972bef8863008657823b9bb7f91
2014-01-17 18:45:16 +01:00
c648d08720 convert SvStream::operator<< overloads to more explicit methods
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
b69864f3f8 re-write SvStream operator<< to non-overloaded methods
This is the actual re-write.

Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
  (*this) << 1;

Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:24 +00:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
3bbf357e58 convert OUString** in HtmlExport to std::vector<OUString>
There is no point in storing pointers to a ref-counted value type like
OUString.
And while we're there, convert arrays to std::vector

Change-Id: I96ceeb13dd3c4fb4f2ebdd017edc92d01dcb47cb
Reviewed-on: https://gerrit.libreoffice.org/7044
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-19 11:47:42 +00:00
83e191e25d Do not use C++-UNO internal static_type functions in client code
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
121be3b60a Remove unnecessary macro
Change-Id: Ibdb27900b70b6ccebfde542b516e71c4c1a6e795
2013-12-12 08:26:46 +01:00
a62c2a5fa5 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-12 08:26:40 +01:00
123e2c3e93 Revert "Don't hold css::uno::Type instances by pointer"
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now:
Ach, old GCC doesn't like plain string literals to initialize members
of OUString type...

Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11 15:38:30 +01:00
90f91088d2 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11 15:16:51 +01:00
eebc75ea63 Typos (mainly "propably")
Change-Id: Ifeecd82f98f9be9f90d293a7b68691f91d7bbc34
2013-12-10 23:06:39 +01:00
3414013984 sd: PPT export: fix assert on 0-length text portions
Not sure if such are legit, but this should fix the crash.

Change-Id: Idf8a3a67ddae464533d431f1a6a2ebea6d6c2213
2013-12-10 15:28:52 +01:00
cccc6c4ebc fdo#54938: Convert sd to use cppu::supportsService
Change-Id: I1aaecbc9f7b5ca0ca2009caf38013054f84cbecc
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-12-09 17:08:33 +01:00
e9c62a2d9c Get rid of unnecessary comphelper::UStringEqual
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
2013-12-06 14:28:36 +01:00
059cc67245 Remove obsolete SEQTYPE workaround
Change-Id: I366b29038be034b03a16fa6d7f6873dc78d8d88f
2013-12-05 12:22:17 +01:00
78ed89cebb Resolves: #i123789# ppt import, if sub address is not document...
internal link, take it as it is

(cherry picked from commit d44e9a9244558f63b3feaf923802ed32b4931283)

Conflicts:
	sd/source/filter/ppt/pptin.cxx

Change-Id: Ic2541bcf7e368a4e9f2cc87353be165fc203dbac
2013-12-05 10:10:04 +00:00
9f3aa81c5d Lenght -> Length
Change-Id: Ic338484627a1b74fba2d4d0794f8865290177464
2013-11-23 23:22:25 +01:00
5668e73beb avmedia: Implement "block untrusted referer links" feature
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block
untrusted referer links' feature" for details.  This adds some further /*TODO?*/
comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not
blocked during a slideshow presentation.

Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-20 14:44:27 +01:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
b211b8b2e1 Related: rhbz#1014990 valgrind reports yet another unint variable
Change-Id: Idf6a0a1e12fffee6c090add41247723f1d9cf576
2013-11-18 14:08:07 +00:00
e0840f7056 Related: rhbz#1014990 valgrind reports yet another uninitialized variable
Change-Id: Idf15ee825a34aa7788c422475aa6cea8ff802581
2013-11-18 14:08:07 +00:00
f3660062ce Related: rhbz#1014990 valgrind reports uninitialized variable
Change-Id: Ibaa2ed0ee2f1f3f00bceec91ccced968e4913e47
2013-11-18 14:08:06 +00:00
0ee16bf9c3 sad little semi-colon dangling in space
Change-Id: I297fb09996c694b920b4ae56e6da2f7a009c9386
2013-11-18 14:08:06 +00:00
90be5b23e6 -Werror,-Wshift-sign-overflow
Change-Id: Ie6843c4d455dd82a8c1ebd8778165b04e7b94d71
2013-11-14 10:15:10 +01:00