Commit Graph

55 Commits

Author SHA1 Message Date
97a185d8b9 cid#983380 Dereference before null check
Change-Id: I9504738a5291b85362a80e630d9e413825fa6572
2014-02-20 09:31:11 +02:00
417c85bf58 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17 11:57:04 +00:00
6eac9deadd remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsL
Convert code like this:
    if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aStr == "rem")
which compiles down to the same code.

Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
2013-11-21 13:29:29 +02:00
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
2013-11-20 16:38:28 +02:00
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20 13:56:08 +02:00
e0cbd673c2 -Werror,-Wunused-exception-parameter
Change-Id: Ibcda8d872ad89a363f71bc4d5aa92b6bae2d2608
2013-11-14 10:14:57 +01:00
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
943a03a4ee Drop unnecessary #include
Change-Id: I20448aebfae86c097413660e9ec836a786507a85
2013-10-29 09:27:39 +09:00
2381e89bd3 fix Windows build, dbglevel=2
Change-Id: I7dba2852a32a1b1c8309b5981e6b535c6dfb1b8c
2013-09-20 07:52:42 -07:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
59eee3c0a4 coverity#1019312 check inflateInit return value
Change-Id: I5ec18176291e128c79d3e51e39b8a42b17a27b30
2013-06-25 09:26:58 +01:00
3c38b7727a zlib: remove ExternalPackage_zlib
Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850
2013-05-08 23:34:26 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
083092e808 OSL_FAIL -> SAL_WARN
Change-Id: I1871e5e3a319b2d5177ae4bd470046c022c14eb7
Reviewed-on: https://gerrit.libreoffice.org/3121
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-03-30 17:37:54 +00:00
dd0db92a17 Kill fprintf in sdext in favour of SAL_LOG
Change-Id: I2253c1a4d90ab348764cd8863b8aaf2036a254de
2013-03-21 00:51:03 +01:00
b9d1006ebb re-base on ALv2 code. Includes:
#i118662# remove berkeleyDB from module l10tools
    Patch contributed by Oliver-Rainer Wittmann
    http://svn.apache.org/viewvc?view=revision&revision=1213189

    reportdesign: remove extra items from Help menu
    Patch contributed by Ariel Constenla-Haile
    http://svn.apache.org/viewvc?view=revision&revision=1201215
2012-10-02 12:15:41 +01:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
d3d720b14c rhbz#826526 Inform user about unsupported PDF encryption formats
...with a crudely reused "Version Incompatibility" message box (TODO: improve),
rather than keeping asking for a password.

Change-Id: I8239232704a4426af7a14a729840d184a502d2df
2012-09-28 18:30:24 +02:00
1f08711bd1 Replace usage of rtl/memory.h in PDF Import with equivalent from string.h
Change-Id: I13f88bdfa6fc7d2b39fb2fd6a686b5364c20d6b5
2012-09-02 13:44:33 +02:00
c53812a1b7 Some cppcheck cleaning
Change-Id: Ic30cdeffabec1eb1a6c153ac450a3d28064ef534
2012-05-20 15:25:37 +02:00
120cd2b578 WaE: MSVC2008 C4309 truncation of constant data
Change-Id: I7cae514cfd3c51bde5e8e0df2c51bed23904569d
2012-05-17 14:03:25 +01:00
3934efe28c sigh, need a 64bit zlib too on windows, reverting 2012-04-13 14:06:55 +01:00
452af5f452 gbuildize internal zlib
and stick headers into the solver in the same hierarchy as is "standard"
so we don't have to patch so much, similiarly rename to libz
2012-04-13 13:15:25 +01:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
9656a15495 WaE: various higher debug level compile time warnings 2012-03-07 11:06:47 +00:00
dba2d32d5b gbuildize sdext 2012-03-06 10:26:33 +01:00
bc99c90e88 This method is still used on WIN32. 2012-02-10 14:51:30 -05:00
99b2adf721 Removed unused code 2012-02-10 14:20:52 +00:00
7c704c78d3 Removed some unused parameters; added SAL_UNUSED_PARAMETER.
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones.  To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.
2012-01-21 15:21:16 +01:00
f19d269ab4 Fix for fdo43460 Part XXXII getLength() to isEmpty()
Part XXXII
Modules
sdext
2012-01-10 23:08:01 -02:00
5451e9c702 catch exception by constant reference 2011-12-26 03:38:50 +09:00
dd896dd28e remove include of pch header from sdext 2011-11-27 13:21:13 -06:00
1cad5e7b13 use OString::equalsL 2011-06-23 00:45:09 +01:00
f46e4f570d hash_map -> unordered_map 2011-03-23 20:02:01 +00:00
761118f831 Merge commit 'ooo/DEV300_m103'
Conflicts:
	jfreereport/java/flute/makefile.mk
	jfreereport/java/libbase/makefile.mk
	jfreereport/java/libfonts/makefile.mk
	jfreereport/java/libformula/makefile.mk
	jfreereport/java/libloader/makefile.mk
	jfreereport/java/librepository/makefile.mk
	jfreereport/java/libserializer/makefile.mk
	jfreereport/java/libxml/makefile.mk
	jfreereport/java/sac/makefile.mk
	mysqlc/source/mysqlc_connection.cxx
	mysqlc/source/mysqlc_connection.hxx
	mysqlc/source/mysqlc_databasemetadata.cxx
	mysqlc/source/mysqlc_databasemetadata.hxx
	mysqlc/source/mysqlc_driver.cxx
	mysqlc/source/mysqlc_driver.hxx
	mysqlc/source/mysqlc_general.hxx
	mysqlc/source/mysqlc_preparedstatement.hxx
	mysqlc/source/mysqlc_resultsetmetadata.hxx
	mysqlc/source/mysqlc_statement.hxx
	sdext/source/minimizer/impoptimizer.cxx
	sdext/source/pdfimport/config/description.xml
	sdext/source/pdfimport/tree/drawtreevisiting.cxx
	sdext/source/presenter/PresenterWindowManager.cxx
	swext/prj/build.lst
2011-03-23 16:58:56 +01:00
490d076d16 Remove "using namespace ::rtl" 2011-02-26 14:36:27 +01:00
1e4cebf61f Remove unused headers 2011-02-07 16:01:08 +01:00
a91b24db4a porting extensions to boost containers 2011-02-06 02:49:07 +01:00
db944ee55f vcl119: #163136# do not pass a clear text password to xpdf 2011-02-03 17:54:31 +01:00
5d1335e1f0 vcl119: #163136# fix warnings 2011-02-03 11:28:51 +01:00
680b4e9038 vcl119: #163136# produce correct output when decrypting 2011-02-03 11:28:03 +01:00
cca4d900ed WaE: unused variable 2011-01-25 10:23:17 +01:00
7e56fec5de Replace suitable equalsAscii calls with equalsAsciiL.
Done with sed -i 's%\(\.equalsAscii\)(\(\s\?"[^"]\+"\)\(\s\?\))%\1L(\3RTL_CONSTASCII_STRINGPARAM(\2\3)\3)%g'.
2011-01-20 11:30:00 +01:00
fa39fbdcce Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:24 +02:00
0877b8e08c silence warning 2010-10-06 08:43:24 +01:00
ef8fba3206 pdfextfix03: #i110871# pdf literal strings may contain nested parantheses 2010-04-27 19:27:46 +02:00
0eebf5add7 CWS-TOOLING: integrate CWS vcl109 2010-03-22 18:17:46 +01:00
4326ef06fe changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
775cc94b67 merge with DEV300_m71 2010-02-03 15:34:13 +01:00
526575b696 improve deflate recognition, fix debug output 2010-01-29 15:49:01 +01:00