Commit Graph

1073 Commits

Author SHA1 Message Date
9ee630ee01 remove unused code RecentDocsView::SetThumbnailSize(long)
Change-Id: I9a898fda8e494693f48d7611c07bd65e86c22bdf
2014-02-28 08:32:00 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
c7c40687f6 Remove visual noise from sfx2
Change-Id: I0f556a386ce64d154b695c2a35f808c94b9f0b7a
Reviewed-on: https://gerrit.libreoffice.org/8310
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 08:12:10 -06:00
b8ebdae034 Yet another one undefined comparison of 'const' and a 'non-const' iterators (hope the last one)
Change-Id: Iefcd1f5561e5a8cac4152f16e72e8f628e9204a5
Reviewed-on: https://gerrit.libreoffice.org/8223
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 16:21:27 +00:00
f6cef562c0 remove unused method SfxBindings::GetDispatchProvider_Impl()
Change-Id: Ie2a04a2b5056bf607911f9705c06b74b9637d211
2014-02-25 15:16:59 +02:00
523fcec55d Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I72b0e8b07bd7309a23d5635b7e0b7dbdc9c2c721
2014-02-25 11:15:06 +09:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
0799a45f0f Use correct log area
Change-Id: Idcbb480be0c6bba1215bf75310cd6fc7bfd101a3
2014-02-18 16:23:39 +02:00
5732b24b59 assert() is too harsh here I think, use SAL_WARN_IF() instead
I run into the assertion now in TiledLibreOffice, but if I drop the
assert(), it still works. So let's just print a warning (that
everybody will cheerfully ignore, ha ha) instead. I have no idea what
this code actually is doing...

(Originally the code had DBG_ASSERT(), which despite its name also
just prints a warning, which I changed to a real assert() in
8293b29304716d6bd117ab233b1238e1385ae592 for some reason.)

Change-Id: I928078aaf3648c8d04c59f271504c7d3b02e1bb5
2014-02-18 16:18:09 +02:00
d13545987a callcatcher: update unused code lists
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-18 10:10:01 +00:00
be0177fe42 Do not crash when no interfaces are registered.
Change-Id: Idee3bb5821e8b46da78243f6396780b35f23e30a
2014-02-17 17:29:27 +01:00
4f430d7a92 cid#705884 dereference before null check
Change-Id: I55258bb30034b95f53134a9747088fc488796564
2014-02-17 14:04:32 +02:00
2842e32490 coverity#441125 Dereference after null check
Change-Id: Ia8046dc20ff46612ad3ffeba098bee079858e8da
2014-02-12 14:26:47 +00:00
cc7b1ee2f3 coverity#440982 Dereference after null check
Change-Id: I5e19801311c2cb038b6e1c5e7e52a6022f62ea86
2014-02-12 13:03:58 +00:00
7141cfa6a3 coverity#440973 Dereference after null check
Change-Id: I24caa53a66da4d724e4f8e5d4b06c7d3e9633f5e
2014-02-12 13:03:58 +00:00
0d3082dbf2 callcatcher: update unused code
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12 13:03:50 +00:00
9e6dfbd244 coverity#441011 Dereference after null check
Change-Id: I8a3430440bdd8cc1561eb60863c2bda3df8eac6d
2014-02-10 20:49:48 +00:00
a90746cb65 coverity#1130368 Unchecked dynamic_cast
Change-Id: Ib4ae0ce1647e15bf1b9d7fe8e2d3bcfcb8ec1466
2014-02-10 11:21:09 +00:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
a6b41b0c14 coverity#1169825 Dereference after null check
Change-Id: I74df9084f46e38901b6682b892fa7d0f71d72572
2014-02-09 15:53:22 +00:00
96e7225260 fdo#65430 add OnItemDblClicked and setOpenTemplateHdl in templateSearchView
Currently only templateAbstractView had such handler, which are
templateLocalView and templateRemoteView are based on.

Change-Id: I6694d0804a8b7e58abc0ddc970e811d053394d6f
Reviewed-on: https://gerrit.libreoffice.org/7918
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07 15:07:38 +00:00
b29c078c7f Convert template manager dialog to .ui + adapt code.
Change-Id: I854abb47c2d22206ed5581373b3e841f221672e3
2014-02-07 12:11:50 +01:00
e2eda70f27 startcenter: fdo#72469: Thumbnails also for other file types than ODF.
Change-Id: If905b2f3e51adf7e64df9385ede74368acd11771
2014-02-04 09:11:29 +01:00
6472e79148 fdo#72338: startcenter: Show busy mouse pointer when starting apps.
Change-Id: I8f254419ea7bb4e3e9835bd9fab8229ed89cd0e9
2014-02-03 19:09:22 +01:00
6141a2fda4 startcenter: Don't cut off the thumbnails.
Change-Id: Ie5ad5f5be48aa873df94a31e980aaabc4ac24868
2014-02-03 19:09:22 +01:00
470b393fd5 Kill one indentation level.
Change-Id: I5a5d98bb2f2d0749fb9113423f5663780ecf3520
2014-01-31 13:10:27 +01:00
5b1e68bd85 fdo#71763: F6 key moves focus on this trip: Menu -> Sidebar -> Thumbnail view
Sidebar and thumbnail View are actually not separate windows
but F6 key traversal should simulate it as they would be.
Define a new getfocus flag called GETFOCUS_F6 which means focus
were grabed as a result of pressing F6 key. Use this and other two
(GETFOCUS_FORWARD, GETFOCUS_BACKWARD) flags to indicate the focus were
grabbed along subwindow relation (define a new ImplGrabFocusToDocument
method with a flag parameter on the analogy of GrabFocus() <-> ImplGrabFocus()).
Handle F6, Shift+F6 inside BackingWindow as it would have
two subwindow (sidebar and thumbnail view).
Plus Ctrl+F6 -> grab focus to the thumbnail view.

Change-Id: Ie43d761e7cb0269afb79481a81947a4b96e1dde0
Reviewed-on: https://gerrit.libreoffice.org/7486
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-31 12:06:46 +00:00
f5115e33e4 fdo#73869 fix highlight RTL Problem at the StartCenter window.
Change-Id: I744d8f85c6e4c555ef8916281ebdc709fe6ddfa9
Reviewed-on: https://gerrit.libreoffice.org/7719
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30 12:02:03 +00:00
c35616dd73 bool improvements
Change-Id: I4a09bffccc0049d81ea3113e79184f64b026a4ba
2014-01-28 20:24:40 +01:00
417a8624c7 coverity#440811 Dereference null return value
Change-Id: Iccf2f6dd757fe8d14a2f68a0492ea898d2f95490
2014-01-28 11:29:19 +00:00
c051007c1b coverity#440882 Logically dead code
Change-Id: Ia54cffe6368d320c717b941b4f3df036f924c343
2014-01-28 11:29:16 +00:00
9808306875 Related fdo#65826: Set StartCenter's min width to display one column of docs
If there is document to display. Otherwise set minimum to the width
of greating background text.

Updating minimum size is needed only when the list is cleared.

Change-Id: Ic089571fd21d5ab9ded0f4cde7e1aa72fd508d32
2014-01-25 06:47:05 +01:00
31f57cb679 Use the "sfx" log area consistently in sfx2
Change-Id: I497d2d93e1a1819ff709c94007ae98f5ef312e77
2014-01-23 08:12:37 +02:00
8293b29304 Use assert() and SAL_WARN() instead of DBG_ASSERT() and OSL_FAIL()
Change-Id: Id3be30bc95325e8f18cf8cb55da2217984a26035
2014-01-23 07:24:23 +02:00
840e7f0043 fdo#65826 and fdo#73605: set a minimum size to start center
This minimum size calculated like this:
width: sidebar optimal width + width of text appearing in
the thumbnail view when no recent document is available.
height: menu width + optimal width of GtkBox containing
buttons.

Change-Id: Ic1fd6e33a1ec93e61318af02c09ee88909a76cf4
Reviewed-on: https://gerrit.libreoffice.org/7505
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 15:42:57 +00:00
01a9f7b2fb fdo#72639: send proper ACTIVE_DESCENDANT_CHANGED events
At ThumbnailView::SelectItem the piece of code in charge of the
accessible events related to selection change was mistakenly using
the accessibility helper class ThumbnailViewAcc instead of
ThumbnailViewItemAcc which is the proper one for managing the events
related to ThumbnailViewItem objects.

The methods FireAccessibleEvent and static getImplementation had to
be added to ThumbnailViewItemAcc to provide the full functionality
required.

Change-Id: Ia5ffb24c920f3c48854021700819be683c979411
Reviewed-on: https://gerrit.libreoffice.org/7551
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 15:14:14 +00:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
20223e2374 bool improvements
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
2014-01-17 18:45:14 +01:00
0a2d80f754 remove sfx2/appuno.hxx
Change-Id: Ibfcd2954b20def05d2a7db36f5ccc0b570305441
2014-01-15 15:11:49 +01:00
d610e8618e longparas: none of the callers check for the error case
so we can safely change the return of 0xFFFF to 0 without
changing any callers. Which makes this safe seeing as before
now every caller would have done something stupid with the
results

Change-Id: I10d9f12525de10661ed82f3405e6c728d38be106
2014-01-14 13:09:44 +00:00
340e70e248 fdo#72947 Startcenter: handle file urls and non-file urls on a different way
Thanks Stephan Bergmann for the idea.

Change-Id: Ifdde1b7eaaefd30a176c47385bc9bfec48d5b86c
2014-01-10 17:18:20 +01:00
d1043892df SfxPoolItem::operator ==, != should return bool
...and SfxEnumItemInterface::HasBoolValue, too.

Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-10 17:11:51 +01:00
1ae9feedf1 Startcenter: ignore repeated clicks inside recent docs view
Change-Id: Ia433adb26e820b89c4d207d018d0daf42654b4a0
2014-01-10 15:54:23 +01:00
60c7ed8064 fdo#72947 Startcenter: display more userfriendly file urls in tooltips
Use INetURLObject to get a readable url (it displayes special characters
too). It is a side effect that 'file:///' prefix disappear
which seems a good thing.
Plus some cleanup: remove second INetURLObject.

Change-Id: I4aab5e2546ae70e5a3d85b12e26e021bfa244999
2014-01-10 14:11:39 +01:00
baf112e6f0 Startcenter: mnSpacing became unused
Change-Id: I01f2911c690da36ed0d5beb306e28ab438890fd9
2014-01-09 19:00:11 +01:00
0c4639fa83 Set PAPER_SCREEN_4_3 values back and use it as it was
It breaks things.

Change-Id: Ia28391aed27051e5f6a7e0996f30b23c46eb8269
2014-01-09 18:47:50 +01:00
0314034d8b fdo#71628 Startcenter: remove thumbnail selection when focus is moved away
mnHighItemId is never assaigned with a valid value and there is
no sense to store one selected element's index anyway,
because there can be more.
The bMove parameter of ImplGetItem is never used and doesn' work
so remove it.

Change-Id: I91d6bc3fd13a2b44e6961fea66d02702a8f31c2b
2014-01-09 15:43:28 +01:00