c94f12a389
nOrigTxtStt is never read
...
Change-Id: I9ace298d66aaaa46cecdeacfc633144715535e50
2014-03-02 20:18:03 +01:00
d0feb9d89d
Rework SwAutoFormat::IsBlanksInString
...
The old code was convoluted and suffered the following issues:
* Relied on OUStrings being zero-terminated, which is not granted
* Systematically missed the end of string, accessing unrelated
memory, in case there was just a single trailing space
Change-Id: I98dd0f94a8f48f40c467a02dfd01c7866266d9d4
2014-03-02 20:18:02 +01:00
e9ac4088d9
Avoid consecutive OUString appends and a temporary
...
Change-Id: Iee8998a4947a253f869fefb7bde316e3d3b4129b
2014-03-02 20:18:02 +01:00
0ea119318a
Use mutable instead of casting this
...
Change-Id: Ifdf6334af72637b1c18a9ea2bd2be317d5ae8b20
2014-03-02 20:17:59 +01:00
778e65cc2a
Bail out early and avoid temporaries
...
Change-Id: Iee0f72995c59c03189c6e187c7e24f9247ff844d
2014-03-02 20:17:59 +01:00
990a6328d1
D'oh! I forgot something in commit 3e43a891e89aa6eb8eeecd9d3528f2a002371646
...
Change-Id: I2bd3c13eccd94dfb06d2245dd68e97f08c50cbdb
2014-03-02 20:17:58 +01:00
387b9122b0
Do not use heap for two temporaries
...
Change-Id: I49750170fbe68159fc5555ca686344857156c18d
2014-03-02 20:17:58 +01:00
baed26b0c5
sal_uInt16 to size_t
...
Change-Id: If3cbea546716b7476e362e9b19f4656b27ff34a2
2014-03-02 20:17:58 +01:00
f46d23e242
sal_Bool to bool
...
Change-Id: Ie04d9314f66bcda8e1c7939248af79a15fbdaaeb
2014-03-02 20:17:57 +01:00
04deb742f6
Don't use tricks to get normal C++ features
...
* Use "mutable" to allow modification of a flag, maintaining logical constness
* No need to explicitly cast this to the base type inside a base class method
Change-Id: I50c015ba977d93e82331c97259d9f9fb774bb198
2014-03-02 20:17:57 +01:00
0d5652ab10
sal_Bool to bool
...
Change-Id: If63bfcfe4e16dd9232f3ef6fa29fadd0a6d01653
2014-03-02 20:17:57 +01:00
b514300565
pProgress is always NULL
...
Change-Id: I278103075582a0f0a5cde7b749db408c5912f82e
2014-03-02 20:17:56 +01:00
7f7e8673d3
bStopPrt is always false
...
Change-Id: I14559b1360ae9f845e0054c5125f1280d9786dff
2014-03-02 20:17:56 +01:00
2d7ece16a2
sal_Bool to bool
...
Change-Id: Iad75baebdf868cdd2ad13d23299385564277010e
2014-03-02 20:17:56 +01:00
a8155e3d77
sal_Bool to bool
...
Change-Id: Ib1db475feea0f8fdbb724273cc368f41d39e50c8
2014-03-02 20:17:56 +01:00
754dd9212a
sw: hey, don't forget about big-endian parts in wrtasc.cxx!
...
Change-Id: I8e71c35dfb4f8ce475357412cc9121c50830069e
Reviewed-on: https://gerrit.libreoffice.org/8401
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 14:21:42 -06:00
f9e365d138
Avoid a resource leak
...
It seems an aged mistake to pass pUnoCrsr to a std::auto_ptr too early
Change-Id: I99ab2d8c8719fb9f0fc3e90f36534007b4cde990
Reviewed-on: https://gerrit.libreoffice.org/8393
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 14:19:55 -06:00
a783421ef0
ooxml export: write w:compatSettings if present in GrabBag
...
Change-Id: Ie5f3ba8f12ca8d5b9729c5bfa13da3b34dbfda2d
2014-02-28 20:24:38 +01:00
4b4a1b8095
ooxml export: write mc:Ignorable for w14 and wp14 namespace
...
Change-Id: Ifc461da32fa732bafd3bab4d5bcb0760992c2679
2014-02-28 20:24:38 +01:00
8dd20b80ea
ooxml export: rename member settings to m_aSettings
...
Change-Id: Ic286df1c6d8bd611c7771482f91e5e375af3745c
2014-02-28 20:24:37 +01:00
3d66457b0b
-Werror,-Wunused-parameter
...
Change-Id: Ib468220253c494279cfd4f46235a91522fb0889c
2014-02-28 14:04:26 +01:00
2df809f4a3
WaE: unused parameter 'bCopyNext'
...
Change-Id: Ic455c6f7a40d8f96335ecda37084ff7c0ef601a5
2014-02-28 14:52:49 +02:00
dc23ea1522
WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'
...
Change-Id: Ide2bd5caf2d6920c99400fbad290349d7dcca464
2014-02-28 14:52:49 +02:00
c5ecd9d2a7
Correct indentation
...
Change-Id: I3ce85a17966c155c71cd3e3d1a142cc02ec34bd7
2014-02-28 13:05:19 +01:00
21d356f691
sw: export OLE objects outside run properties
...
Until now the export of OLE objects was being done adding them to the
m_postponedOLE member and reading that member when the run properties
are closed, but it can happen that we receive an OLE object while not
in the middle of the row properties.
We have extracted the code that actually does the export to a
separate method and call it if m_postponedOLE is not available.
Some lines are incorrectly indented to make the purpose of this patch
more evident, and will be corrected in the next patch.
Change-Id: I3e0d785c99c659ec35d0c02dfc52367dcb6880b7
2014-02-28 13:02:01 +01:00
94b46d202c
Correct wrong variable name.
...
Change-Id: Ic76e328e7600aab54dfb8318e1d9667fa6d309a5
2014-02-28 13:02:00 +01:00
de90456c71
sw: prevent crash
...
In case some error happens when exporting OLE to docx.
Change-Id: I5673f13e2fb4bc7887f1fc54771532c049129047
2014-02-28 13:01:59 +01:00
22aea93d50
Related: #i123480# assure correct Undo/Redo with not shown tracked changes
...
(cherry picked from commit e8613c7e3b76a83d804d28199fdeacc6369569c6)
Conflicts:
sw/source/core/doc/docedt.cxx
sw/source/core/undo/undobj.cxx
sw/source/core/undo/unredln.cxx
Change-Id: I45c25aa957995109b202e2130e5344b1bbb09669
2014-02-28 11:38:30 +00:00
af63727b9f
Resolves: #i15508# Added support for BMP file type
...
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)
Conflicts:
filter/source/msfilter/escherex.cxx
include/vcl/gfxlink.hxx
svx/source/xml/xmlgrhlp.cxx
sw/source/ui/docvw/romenu.cxx
vcl/source/filter/graphicfilter.cxx
Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00
8827b08dc3
fdo#39468 Translate German comments: sw/source/filter/ww1
...
There was still one untranslated paragraph left.
Change-Id: I9b951c5216560614bd3fc42f9118477ad66cbdf2
Reviewed-on: https://gerrit.libreoffice.org/8385
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 10:58:49 -06:00
1c0e1b9c64
ooxml export: w14:stylisticSets & w14:cntxtAlts element
...
Change-Id: I46e838fac213378f95389812b47ce5896f703505
2014-02-27 17:35:04 +01:00
675bdda729
ooxml export: w14:numSpacing element
...
Change-Id: I6592b9c5a02d96795411526eff69c3380668a10e
2014-02-27 17:35:02 +01:00
1ed9d3abf3
ooxml export: w14:numForm element
...
Change-Id: I7990d2ef77de855455f49e3f12f4ae117f753774
2014-02-27 17:35:01 +01:00
31cd5fc1fd
ooxml export: w14:ligatures element
...
Change-Id: Iad9a96d202487fa71e7110d7f89d94f161e0bb6f
2014-02-27 17:35:00 +01:00
f3307b0306
coverity#1187644 confused copy ctors, leaks, etc.
...
also
coverity#1187861 Uninitialized pointer field
coverity#1187862 Uninitialized pointer field
Change-Id: Ibc420b8ef2d6db58b1b23a85a4029182a05b5f44
2014-02-27 16:09:27 +00:00
a27462189d
Remove visual noise from sw
...
Conflicts:
sw/inc/unodraw.hxx
sw/inc/unoframe.hxx
sw/sdi/swriter.sdi
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unoparagraph.cxx
sw/source/filter/ww8/rtfexportfilter.cxx
sw/source/ui/inc/unotxvw.hxx
sw/source/ui/lingu/hyp.cxx
sw/source/ui/lingu/sdrhhcwrap.cxx
sw/source/ui/uno/swdetect.hxx
Change-Id: Ic0a3fb2392187c277c9b36915ffb10dcf0317908
Reviewed-on: https://gerrit.libreoffice.org/8322
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 09:41:00 -06:00
150420cbff
DOCX export: fix style's next element order
...
Change-Id: I03e91a448794efc2b91f3a6fb6c29dda3403ce9b
2014-02-27 16:22:25 +01:00
743d90ca38
DOCX export: fix order of table border elements
...
Change-Id: I17d8634017c5b0374d30501186b338ddedbcd7ea
2014-02-27 15:22:35 +01:00
0564c1c2dd
coverity#1187691 don't smoke crack and code
...
Change-Id: Id38ce22671ecf24fde1b828a5da94b7b19c27e60
2014-02-27 12:58:51 +00:00
c2a5369e6a
coverity#1187688 Resource leak
...
Change-Id: If7934080401af867282c1b54721134abcc157e53
2014-02-27 12:58:51 +00:00
ac44fc6bfd
coverity#1187860 Uninitialized pointer field
...
Change-Id: Ia68958ddb904cbb50969b3b184777ddd49ccb677
2014-02-27 12:58:47 +00:00
37a543e8d5
coverity#1187668 Dereference null return value
...
Change-Id: Ie0022c868484a9aed2d0efe2d95182d0094c6734
2014-02-27 12:58:43 +00:00
3bf6cd8a54
coverity#1187665 Missing break in switch
...
Change-Id: I672e38d37e385b458db97293dcc02f10513a7cfd
2014-02-27 12:58:43 +00:00
3c095024dc
coverity#1187662 Unchecked dynamic_cast
...
Change-Id: Iefe4021d6140614e73f2626f5da7a75a7beea979
2014-02-27 12:58:41 +00:00
002726d897
coverity#1187648 Logically dead code
...
Change-Id: I9d5425383600fa7c621f58ded52a211f4424575a
2014-02-27 12:57:26 +00:00
2f52414ec2
coverity#1187871 Unused pointer value
...
Change-Id: I0bb45512b0ad24444e7032f075d8fd6eb1529643
2014-02-27 12:57:25 +00:00
344c2dca6f
SwSrcEditWindow::Read/Write return value is never used anyway
...
Change-Id: I9b4064c1e08db9ac0bf48e1aa19e03b8bb495060
2014-02-27 12:42:18 +01:00
015b80e852
editeng: sal_Bool->bool
...
Change-Id: I9e27453f0b77a23ae3d811f0a50a85d3fdf80978
2014-02-27 12:30:30 +02:00
c521f07208
editeng: sal_Bool->bool
...
Change-Id: I7da10ad3ba8017d64c723b53795348edf0e7dd6d
2014-02-27 12:30:30 +02:00
2c4621c87e
editeng: sal_Bool->bool
...
Change-Id: I659497b79fe809865639429f2744d815f2a1f3e2
2014-02-27 12:30:29 +02:00
