Commit Graph

264 Commits

Author SHA1 Message Date
06b44f9961 coverity#738915 Uninitialized scalar field
Change-Id: I1ac675441b50ceab7df78fb9646e4e1bd8e6e36e
2014-02-18 15:18:11 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
665989cfc8 Fix integer ambiguity
Change-Id: I1247af709baf250b82a4156ea2cbf29c758f0c78
2013-12-06 14:32:26 +01:00
f992400f6f count notes - GetNotesInRange now include last tab
- refactor tests
- add unit test on counting notes on a sheet

Change-Id: I6762a0e791a745b828800645effdfc044ac33710
Reviewed-on: https://gerrit.libreoffice.org/6954
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-12-06 05:46:16 -06:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
ed8c4decb3 oups
Change-Id: I92eb65614b9c0afded3b9210208360a42747a34c
2013-11-09 17:51:28 +01:00
2062212d0a UnoApiTest does not dispose Desktop anymore
Change-Id: Ia6cd838426ff77af213f285a67a22223c7358585
2013-11-09 17:44:33 +01:00
edd4c694ab UnoApiTest don't dispose mxDesktop
It breaks CppunitTest_sc_outlineobj,
which runs several setUp/tearDown several times?

Change-Id: Ic81324d150aa64135cdbedc4cb99f78d415da1aa
2013-11-09 17:26:22 +01:00
fe2e43280f Don't dispose twice in CalcUnoApiTest::tearDown
...i.e., skip UnoApiTest::tearDown's dispose of mxDesktop and go directly to
BootstrapFixture::tearDown.

Change-Id: If4555c812cb42c4b76a36d4e59c1d96211915dba
2013-11-09 15:11:17 +01:00
6f40eec725 Calc UNO API test
Change-Id: I6dcd9ac05ff7c4a6fbae7947b0ceda8797feea2f
2013-11-09 06:36:49 +01:00
a071a29d4f UnoApiTest don't require Calc
There is no reason for the generic UnoApiTest to require Calc
specifically. Calc tests can/should instantiate a Calc instance.
We can create a CalcUnoApiTest for that that inherits from
UnoApiTest; however this does not seem necessary, "make sc.clean"
succeeds.

Anyway, the ScGlobals::ensure mentioned in the comment does not
seem to exist.

This allows us to eliminate some code duplication in tests
that were reimplementing UnoApiTest minus the Calc instantiation.

Change-Id: I37bea9df41e3960df0458fe689cf6c046a243617
2013-11-09 06:36:45 +01:00
5285beeaa4 remove redundant calls to OUString constructor in if expression
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
4954e2a2f6 simplify code and fix out of bounds read
Change-Id: I5be3a28d3d1ae43974f844d143a30bfd989cbe5b
2013-10-30 16:30:33 +01:00
18c702a8e1 gbuild: move unittest mock profile to WORKDIR
Change-Id: Idd6420a855fec8b44fce6c0694b491d5f1eec95e
2013-10-29 00:58:44 +01:00
febbf19265 langtag, test: remove Packages that deliver to OUTDIR/unittest/install
Change-Id: I13145c52bdf4a37e4a92ed653a2f131e09539285
2013-10-29 00:58:43 +01:00
8df17a3409 gbuild: set Package default target to INSTDIR
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28 20:17:26 +01:00
52a7238aed Improve test assertions
Change-Id: I5c5a76ca0e1db699dbb9f3fd381e050fc7256d27
2013-10-23 22:54:08 +02:00
2bcee80c62 WaE: unused variable
Change-Id: I55a0882def6f67719d8ba9d9b9bd41770486a812
2013-10-02 21:19:42 +03:00
d50bd55c5d Parsing master presentation objects from 'objectlist.xml'
Parsing the property values of master presentation objects.
Also new functions added to comphelper module for expanding
filepaths macro to appropriate system file paths(for
configuration files present at 'Impress.xcs')

Change-Id: If0381a12155673e85103ddb5d51c34ae53fe2ecb
2013-09-10 13:14:30 +02:00
26f34f89d9 Make sure unittest/user/config/soffice.cfg/ exits
...otherwise PresetHandler::getOrCreateRootStorageShare
(framework/source/accelerators/presethandler.cxx) will cause a
com.sun.star.io.IOException: "URL
"file:///.../solver/unxlngx6/unittest/user/config/soffice.cfg" passed to
css.embed.FileSystemStorageFactory.createInstanceWithArguments does not denote
an existing directory" in some CppunitTests.  (And
1eecb8df22b77a6982601bf877067a685d913a7d "Some cleanup and consolidation of the
Impress layout work" removed the last file that got definitely created in that
directory from test/Package_unittest.mk.)

Change-Id: Idbe42fdd6b06194781cceef62c50531ce0e1c706
2013-08-27 10:17:09 +02:00
1eecb8df22 Some cleanup and consolidation of the Impress layout work.
Also make unit test work again after Mac-app like path changes.

Change-Id: I13eae20141650e1d1d826a794d1f19baaef5f561
2013-08-26 14:47:28 +02:00
f78db7cb1c Making changes to unit-test as well.
Have made changes to unit-test file of 'layoutlist.xml' as well.

Change-Id: Ia4d85fd7935a935b77dfbb475a38a087520865b4
2013-08-26 14:47:28 +02:00
2c6e9b2da2 Deleting the required files.
The files were left to be deleted in the previous commit ,now deleting them.

Change-Id: I1243e6383d3cd96dccf1a786e9b9fc840e46f0a7
2013-08-26 14:47:27 +02:00
14c81676d1 Deleting useless unit-test files/directory.
Deleting the "empty_directory" entries of "unittest/user/*" in 'Package_unittest.mk' and corresponding
files from the "test/user-template/*" directory.

Change-Id: Ia53a18bf7d55bfaba91f9bb8c2a15d3578e35e11
2013-08-26 14:47:27 +02:00
8a1ccacb59 Few name conventions changes.
Changed the name of attributes from "title-shape-relative-height" to "relative-height" & all others.

Change-Id: I3010e8faf8a9bf347a7bec366449bbba77f0a69f
2013-08-26 14:47:26 +02:00
96087f52d9 Fixed a broken unit-test.
Added a new component of "unoxml/source/service/unoxml" in makefile of 'sd_uimpress'.
Also few changes in "drawdoc.cxx".Please ignore the changes of unit-test XML file,
it has to be deleted in subsequent commit.

Change-Id: I50eb516444820c8037aebc8859a322116989d3bf
2013-08-26 14:47:26 +02:00
95afd8e628 Made changes in the unit-test of other configuration files
Unit-test path is changed for the "effects.xml" and "transitions.xml" to avoid "unit-test" error.

Change-Id: Ia871b16b9b9c1bec96fa3d208dc9171c287b020a
2013-08-26 14:47:23 +02:00
8089be8358 Solved the unit-test problem
Changed the destination path of test-profile at "test/Package_unittest.mk".

Change-Id: I24ae595af22c38141add0ab8446281c3ccc84707
2013-08-26 14:47:23 +02:00
ac5b9651a4 Solved the identation problem related to "layoutlist.xml".
Have added a 'if' conditional statement to know whether layout's child is a empty 'text' node or 'presobj' node.And proceed with rest of the
things ,if it is a 'presobj' node.Also the xml files are indented.

Change-Id: I676e710b86b1f50dbd861f2cb180bf9be839b867
2013-08-26 14:47:22 +02:00
da5bca5b53 Adding new Slide Layouts Samples to "layoutlist.xml".
Have added new "Slide Layouts" samples.So commented out the code related to existing slide layouts in "sdpage.cxx" and also added some code
for XML parsing of the new layouts.

Change-Id: I8f5fdcab5f2eb41e37fa522a7801b388cbfefed5
2013-08-26 14:47:21 +02:00
2fd74b3b15 Working version of XML parser from configuration file path
Added some changes in the "getRootElement" and new "layoutlist.xml" is added for "unit-test" module.
XML parser works perfectly in the installation,only the failure of "unit-test" is left to be solved.
Some refactoring related to "layoutlist.xml" will be updated soon.

Change-Id: If7ed3af40e9b6df26e20881728181eb6c82936d8
2013-08-26 14:47:21 +02:00
4a281debd2 Changing the XML parser with configuration file path
Updating the "getRootElement" function.So "layoutlist.xml" can be read from actual configuration path.

Change-Id: Iee636d32e629e935e46a18572646659780ae20e3
2013-08-26 14:47:21 +02:00
03993b47c5 targetted clean of redundant header piece from 62badf3828
Change-Id: Ic1240114d667fb7797afae4847427cc889f3cb48
2013-07-26 14:18:52 +01:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
91ab2b6e9d Improve error messages for the xml-diff based unit tests.
Change-Id: Ided6749ebe4899a6d826d069c38d7b21b467d431
2013-05-14 16:50:46 +02:00
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
add638b725 test: clean up namespacing
Change-Id: I7df07176bdbd15fdfdf8f9a7cdb26d4bee12997d
2013-04-26 14:41:36 +02:00
e35f2f0631 don't pollute global namespace
Change-Id: Iffeeffb015c59ea787838c737c6a11f6fbef2794
2013-04-25 22:20:04 +02:00
c042cd05e9 gbuild: drop uses of removed packages
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac
Reviewed-on: https://gerrit.libreoffice.org/3502
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:18:03 +00:00
b9337e22ce execute move of global headers
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
ebeae438db move Python tests in-process
This is nice to make them more easily debuggable.
A series of crude hacks are employed to bootstrap enough services from
python so the current tests run.
This is only tested with system python3 on Fedora.

Change-Id: I5e06741e55ead7fddec41ff776ff8ca5d2399469
Reviewed-on: https://gerrit.libreoffice.org/3215
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-04-09 05:52:49 +00:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94 new module i18nlangtag
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
3aa3d170a0 Bypass cppunit stuff for non-DESKTOP in more places
We don't run any cppunit tests for cross-compiled platforms anyway, so no
point in compiling that. (Especially as compiling cppunit currently fails in a
--enable-werror build at least for Android thanks to -Wundef.)

Change-Id: I3139c62305ccfeddc0f67729f10e224618d2fc03
2013-04-02 18:17:51 +03:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00