2cf9fe7023
Remove visual noise from tools
...
Change-Id: I779bb5cf991e1fee1e2a2c0a4cd45af3c5f502bd
Reviewed-on: https://gerrit.libreoffice.org/8327
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 05:49:30 -06:00
29eac263c5
coverity#705324 Missing break in switch
...
Change-Id: I72c9a16c5236824424b33df353606e3e14aa4607
2014-02-11 12:11:43 +00:00
fb96dc3c8f
bool improvements
...
Change-Id: I5237197595b1b892e7720de13fc835b64470505e
2014-01-21 13:24:31 +01:00
6eeee04bad
WildCard::ImpMatch should return bool
...
Change-Id: Ib851cbe072bca0d594440cc28164e112d0fe37cb
2014-01-10 17:11:49 +01:00
2ac31b06ae
Unnecessary use of OUString constructor inside OUStringBuffer constructor
...
Convert code like:
OUStringBuffer sVal(OUString("0x"));
to:
OUStringBuffer sVal("0x");
Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17 11:49:05 +02:00
80612512fe
remove unnecessary casts
...
It is no longer necessary to cast to sal_Unicode when calling
OUStringBuffer::append
Change-Id: Iab3d1e12eef472cfe11f1d0d1969ca404091dd7d
2013-12-12 13:15:25 +02:00
a39d07e134
Unwind occurrences of deprecated sal_sChar, sal_uChar
...
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
2013-11-27 12:52:32 +01:00
d366c9b20e
remove unnecessary sal_Unicode casts in various places
...
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
0e6a2601b3
Convert code that calls OUString::getStr()[] to use the [] operator
...
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
89de6ba4c6
Introduce ASCII case conversion and use more/rtl/character.hxx.
...
Also remove all others implementations.
Change-Id: I1dc108a9103f087bd8ce591dff2ac5dd254746f8
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2013-09-30 11:49:22 +02:00
11d743af10
Some OSL_WARN -> SAL_WARN_IF
...
Change-Id: I076adcd2f94c38a74f2dce618bc16efec577ed91
2013-08-31 00:09:48 +02:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
44ddacb232
fdo#33605: Handle http etc. URLs with no path but fragment
...
Change-Id: I8c47cc55e7ad53e514c0bd46130cbbe6a1bb0357
2013-07-26 17:41:08 +02:00
9c0a390489
fdo#63133: Write tools/tempfile.hxx out
...
I deleted TempFile class and changed it to utl::TempFile class
-which in unotools/tempfile.hxx- in the followings: Storage,
StgTmpStrm, SwXMailMerge classes; and RenderAsEMF function.
I modified header in precompiled_sw.hxx.
Change-Id: I3dae5333dc42538e1b905f6a6bbc85534c591dc1
Reviewed-on: https://gerrit.libreoffice.org/4938
Reviewed-by: Andras Timar <atimar@suse.com >
Tested-by: Andras Timar <atimar@suse.com >
2013-07-16 18:40:45 +00:00
710f41b7ae
Clean String and sal_Bool in tools
...
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2013-06-30 04:58:49 +00:00
733d88433c
fdo#43460 tools: use isEmpty()
...
Change-Id: I832473cab555d8ac5c6b2a47d51124ac63e996e9
Reviewed-on: https://gerrit.libreoffice.org/4333
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-06-18 17:15:41 +00:00
2092f8810a
Show only filename in "Recent Files" list
...
As discussed here: http://nabble.documentfoundation.org/Libreoffice-ux-advise-Recent-files-dropdown-td4052945.html#a4052996
The changes are (inspired by Gedit):
* Display only the filename, not the (abbreviated) path
* Show the protocol name before the file, if not local (e.g. "ftp: myfile.odt")
* After the keyboard shortcut (a number from 1 to 10) display a '.' instead of a ':' (because the protocol has a ':')
* FIX: Display whitespace as whitespace, not "%20"
Change-Id: I47472c901aa866adb76c7c7ab36bc871f82ad8df
Reviewed-on: https://gerrit.libreoffice.org/3700
Reviewed-by: Jan Holesovsky <kendy@suse.cz >
Tested-by: Jan Holesovsky <kendy@suse.cz >
2013-05-02 09:04:18 +00:00
4976dd85fa
Introduce characters utilities in rtl/character.hxx
...
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >, with slight modifications
to sal/inc/rtl/character.hxx:
* Replaced "#pragma once" with explicit include guard for now.
* Missing includes.
* Cosmetic clean-up.
Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654
2013-04-10 10:43:38 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
75e014c307
fdo#61514 clean obsolete tools/ filesystem abstraction
...
Change-Id: I7d1d5eca43d0b0f9a013e31383abc574a7b15f93
2013-04-04 21:40:57 +02:00
c8f8f36027
fdo#44994 write out tools' FileCopier class
...
Change-Id: Ie3d04f0b2ed35099d5682d165e17c10a6d736f99
2013-04-04 19:31:20 +02:00
aa753f01ba
-Wunused-macros
...
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
d31bf8bf55
Clean obsolete tools/filesystem abstraction
...
Change-Id: I74f99c48b822644b26486a66d2f15386991154d6
Reviewed-on: https://gerrit.libreoffice.org/2968
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Reviewed-by: Andras Timar <atimar@suse.com >
Tested-by: Andras Timar <atimar@suse.com >
2013-03-24 19:25:06 +00:00
2098b720dd
tools: TempFile: create a file in ctor, not a directory
...
related: fdo#62617
(regression from a548924aece3dc99b2aa36b5c9b0fa52de9951ae)
Change-Id: Ie29a22e2bacc5fc31c9a5d1c33c01c3b6f22fe49
2013-03-23 23:02:56 +01:00
1a777d4387
tools: move some code around so there is less of it
...
Change-Id: Ib93ce32cbdceae959989f9575899be0519db8377
2013-03-23 23:02:56 +01:00
edf5701346
SEARCHDELIM_C() was unused
...
Change-Id: I64432470c3d53ec58d4bfe7ce5756f44bcfa5ac8
2013-03-22 09:37:46 +02:00
37d2588844
Remove RTL_CONSTASCII_(U)STRINGPARAM in tools
...
Change-Id: Id97070321ad6b20f349896d3b4e1ae51cc82ece7
Reviewed-on: https://gerrit.libreoffice.org/2769
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-03-16 17:12:27 +00:00
f965bc8098
fix merge conflict
...
Change-Id: I015a0065a88022ad4ff93711f1faae2874ccf506
2013-03-12 16:27:38 +01:00
a548924aec
tempfile: Creating tempfiles in a given folder is not used
...
It's always the case, that the default temp folder is used. aName and
aRet are always empty, pParent is no longer used. So the pParent
argument makes no sense anymore.
bDirectory makes no sense without pParent and is apparently unused
(always sal_False by default).
The include of tools/tempfile.hxx in unotools/tempfile.cxx in not
necessary.
Conflicts:
tools/source/fsys/tempfile.cxx
Change-Id: I9c53b263a640e53140a8ae8795181b1c5e43f26d
2013-03-12 16:20:15 +01:00
916d898209
fix regression reading OleStorages ( over THRESHOLD size )
...
Change-Id: I26daefd898873037325c02d96018890ebc7cb1b6
2013-03-08 12:43:10 +00:00
66f426b8fa
The macro FEAT_FSYS_DOUBLESPEED has been removed and the related #if / #endif have been removed too.
...
Bug: 61516
Change-Id: Id347e87a8789ddbe550dde7d7281d9c1cad0c199
2013-03-04 10:33:40 +00:00
2962aaa008
fdo#61513: Remove FSysFailOnErrorImpl macro
...
This patch removes all used of this useless macro.
Change-Id: Ib3842ef28ea676e75b18c192f8d9610dcb3c3d0c
2013-03-04 10:01:46 +00:00
3e1dea5948
tools: move FileCopier out of public headers, and remove unused bits.
...
Change-Id: Iccd052ae2587bb4448ecb5bc94aeba5dd2a2291e
2013-02-27 09:09:03 +00:00
a82f7b2053
port horrible tools temp directory abstraction to sal.
...
Change-Id: I3688c8babf7719091404317b13014283a8ce9492
2013-02-27 09:09:02 +00:00
d5caf6898b
loplugin: unused variables
...
Change-Id: I7fc203900256839e679bf73b717d121fedc42087
2013-02-24 17:44:31 +01:00
1443a9f7ab
[Uu]sefull -> [Uu]seful
...
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
2013-02-22 11:12:33 +01:00
f1bca26afc
Remove redundant braces around for loops
...
...that had once been workarounds for compilers that did not yet support the
C++98 scoping rules for declarations in for-init-statements.
Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-26 16:36:09 +01:00
87f9d7da00
Fix Variable 'nMode' is reassigned
...
See http://nabble.documentfoundation.org/Cppcheck-Variable-nMode-is-reassigned-in-fstat-cxx-td4030405.html
Thank you Stephan!
Change-Id: I780d422fe03c4c125cc89fee778d820a20553c1c
2013-01-21 21:19:02 +01:00
f98407403f
Revert "String Cleanup and news OUString methods/constructors"
...
Broke a unit test and made all tinderboxes red.
This reverts commit 3179055dc3e267c961a5618c810fbc0df1858d72.
2012-12-29 12:50:32 +02:00
3179055dc3
String Cleanup and news OUString methods/constructors
...
Change-Id: Ia6142020330d0e12650fdc519b66f00e607eac42
Reviewed-on: https://gerrit.libreoffice.org/1491
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2012-12-28 18:16:04 +00:00
c318f3b022
Check for _MSC_VER instead of MSC in sources
...
Change-Id: Ibaf2501e6b655913963a53c1cd63668f1c4cccb2
2012-12-27 13:18:24 +02:00
34a5932cd2
Fix comment
2012-12-05 11:31:50 +02:00
d9cf110dae
Bye bye ODMA
...
SUSE has no interest in it any longer, and I doubt anybody else has
either.
2012-12-05 08:56:52 +02:00
160cfb5e5e
Bin the HACK() sillyness
...
Change-Id: Ieeebc4098404fa006d66bb8b656172a4348b1dc1
2012-11-19 21:23:27 +02:00
4cc2571e49
CMIS urls: remove +atom in the internal URLS as the binding is guessed
...
Change-Id: I9ae0704f1e5203778e97de5843efe777ba717271
2012-10-31 12:03:28 +01:00
cda6b4e991
fdo#56366: INetURLObject::decode: do not clip utf-32 to 16-bit
...
Change-Id: Iaedc9f5b9f25f43b8b8deaf28129423abbb91672
2012-10-29 14:20:10 +04:00
a7efb9b8dd
loplugin: fix some indents and unused OUStrings
...
Change-Id: I1d7256eea7a79453d3cdb85d1edcf824d58d775e
2012-10-14 16:37:00 +01:00
17d4bb38fa
cleanup files in tools/source
...
This is a follow-up patch of 7710faa45640d25a83136a35044aafdb1b168d88.
Change-Id: I1f54cbe5c3170e9a79e11e9b9c1da3791419a4ba
2012-08-19 21:27:00 +02:00
9cadf9bdf3
fdo#39468: Translated German comments in core/tools/source
...
Change-Id: I28ec097a70a8d71312d9e8382c3cf71a1eabde88
2012-08-19 21:26:59 +02:00
920dcaec05
re-indent falsely formatted code in tools/source
...
Change-Id: Ibc26313e79dd5f992c4bfb9454a9798fb1a78f00
2012-08-18 18:33:54 +02:00
