Commit Graph

706 Commits

Author SHA1 Message Date
e218663251 fdo#63154 Remove unused solar.h
Removed from dbaccess. editeng, filter,
framwork, formula, lotuswordpro, reportdesing, rsc,
uui

Conflicts:
	framework/source/uielement/menubarwrapper.cxx
	reportdesign/inc/RptDef.hxx
	uui/source/iahndl.hxx

Change-Id: Ia6f1d8679736c3de99bd8060d8a7f76975268273
Reviewed-on: https://gerrit.libreoffice.org/8118
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-28 15:01:05 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
c4399bcd13 Remove visual noise from uui
Change-Id: I64fa42929aad00fc63f2937527dd3539f9d6f7f3
Reviewed-on: https://gerrit.libreoffice.org/8337
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 03:45:29 -06:00
d5c59404be Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I773524536c0ed7bc34eb08cd35cfc77e83f722ba
2014-02-26 17:21:20 +09:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
973b47a336 unotools: sal_Bool -> bool
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19 12:47:07 +01:00
b62b4e6558 typo
Change-Id: Ia3b810d7ff231674d63aaf82a8ff254290fa55ca
2014-02-10 13:57:25 +01:00
602a63785a bUpdateCheckEnabled had always been unused and marked TODO
...ever since its inception in c41efc6d0b2740be4243fd696385f8dbcec0aefe
"CWS-TOOLING: integrate CWS dba301a_DEV300"

Change-Id: I5da6a38f595146ef0d2894b33bf614e7663d53fa
2014-02-10 13:55:22 +01:00
ed9e1e7390 Use anonymous namespace for UUIInteractionHandler.
After it's no longer used in uui_component_getFactory,
since fe537786a42abea57551395f73328db48bebd086

Change-Id: I27f77b88c898f665d481931a55f1a0c1fce15818
2014-02-05 19:08:43 +01:00
fe537786a4 uui: Ctor feature for com.sun.star.comp.uui.UUIInteractionHandler.
Change-Id: I94858cef5402e88ddcc3e0e9e4383f7be8443e77
2014-02-05 19:07:20 +01:00
6f9976db93 bool improvements
Change-Id: I266d7ce86a30cedd1ae388a69b87f1b43d96e00c
2014-01-28 20:26:19 +01:00
5d99890f9d coverity#704132 Operands don't affect result
Change-Id: Ib2cf15d31231ff02645faae9d4a984112e5af795
2014-01-27 11:14:33 +00:00
fa290c7501 Resolves: #i123744# correct consideration of Subject Alternative Name...
field of the given certificate

(cherry picked from commit 117218483797c0aeedef9b68bdae96a727cb3426)

Change-Id: I81fbb49593b15edea2509aed81b252c8e5b0cd82
2014-01-22 09:45:49 +00:00
d5b01ac249 bool improvements
Change-Id: I6df7ec9669452a025fbac55199927347ef84c6b9
2014-01-22 08:22:34 +01:00
190e665348 convert login dialog to .ui
Change-Id: I775c87422f05552b7283f9c6f7103a72262f764e
2013-12-23 13:05:01 +00:00
d9922775bb convert unknown authority dialog to .ui
Change-Id: Iec8a8826188c81ff3a0e7e563d1f5f1a9921c180
2013-12-22 20:33:54 +00:00
254dcd96ea remove unused m_pParent members and trailings semicolons
Change-Id: I9c577b074ac3fc5382cea92394adeedbe0364de0
2013-12-21 21:14:29 +00:00
a5650e388d convert ssl warning dialog to .ui
Change-Id: I658cc3f1c63f8cfb18463befa3a0efbd92139659
2013-12-21 21:14:29 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
f74149bc21 Fix some typos for "height"
Change-Id: Ibe1fdd7a63ff09097cfe053279d779592d389539
2013-11-25 23:03:11 +01:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
54a17dd246 windows: warning 4355 is disabled globally in com_MSC_defs.mk
So there is no need to do this locally, too.

Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-28 01:02:13 +01:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
7235d23267 fdo#54938: Adapt supportsService implementations to cppu::supportsService
Change-Id: I683c0d30c3286ed5d725d4eefe8b3977b82ee316
Reviewed-on: https://gerrit.libreoffice.org/6035
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-07 17:01:33 +00:00
b879adc316 convert UUI module from String to OUString
Change-Id: I0dfcdb0b95112b5ee18b05d0c496059292be65c4
2013-10-01 10:08:40 +02:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
02740cbe0a Related: fdo#38838 drop String::EmptyString now as well
Change-Id: I849dbf3a40189e700036249b15dd8bde493083b6
2013-09-08 20:44:26 +01:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
19277d02fb osl_getThreadIdentifier(0) -> osl::Thread::getCurrentIdentifier()
Change-Id: Ida9785c4b9fda0459769957734952e69d7a9de44
2013-08-21 14:19:10 +02:00
c6a7300974 Use subfolder names from <config_folders.h>
Change all instances of hardcoded "program", "share" etc subfolder names to
use those from <config_folders.h> instead. In normal builds, the end result
will not change.

Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-18 21:11:16 +03:00
0d874ee2e4 Fix configuration access path for "URL" group member
...broken with 20430c74f391ceffd8a063c0b6b8a8fd615abac0 "fdo#46037: no more
comphelper/configurationhelper.hxx in uui" (but note that
NewerVersionWarningDialog is dead code anyway since
718c0fe73251be083d032f0905880058128d4054 "Ported
sfx2-remove-check-update-on-fileload.diff from ooo-build."

Change-Id: I7095044b73888aad12704d76a39551158e6c6b33
2013-07-25 17:15:24 +02:00
20430c74f3 fdo#46037: no more comphelper/configurationhelper.hxx in uui
Change-Id: Ie7f42eb02f38d5cac2eff7b434ca369ea28b4ed1
Reviewed-on: https://gerrit.libreoffice.org/5065
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-24 20:20:32 +00:00
009851223b module svl: all String and some bool and related clean-up
Change-Id: I36eb559fa58dbe75384b7119c788af0048813aed
Reviewed-on: https://gerrit.libreoffice.org/4733
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-07-07 20:00:16 +00:00
613036b5a1 Resolves: #i55152# the listbox in the filter selection dialog should be sorted
(cherry picked from commit 47fc3a3278a7aac0ba2d8f47eb10a83c0a5f40c7)

Change-Id: I07215bb62dbedcb2d9baa0fd6d66a3ebe30f540e
2013-07-05 08:52:51 +01:00
0306e253fe XubString->OUString
Change-Id: I40ff06facc304630ccedd82d2f20b3573bdc5cb4
2013-06-30 20:40:15 +01:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
26bda9f4a8 convert message box return types to an enum
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-05-01 14:42:04 +01:00
f8231a9765 some eco-activism
Change-Id: Ib447cd8633c3102ee78c919cfbeabcc88018b130
2013-04-27 23:04:15 +02:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
c32b6be06b fdo#60724 correct spelling
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
435f5e30c9 fdo#60724 correct spelling
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-15 05:10:29 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00