bbd51100fa
fdo#59329 Fix docked window border lines
...
This patch completes the missing border lines. This is intended
for versions 4.1 and 4.2 only.
Change-Id: Ib15cb3b01dca4631f643a0036475cf684793d256
2014-03-02 13:24:06 +03:00
1994ab92c8
[bug 75240] - removed unnecessary white spaces
...
Change-Id: I369ec4b2535b83673341ce389064d5a9c2050a48
Reviewed-on: https://gerrit.libreoffice.org/8388
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 14:46:41 -06:00
d12324d136
Rename GetGraphics to AcquireGraphics
...
Currently there are a number of classes that have a function called
GetGraphics(). It returns a SalGraphics instance if one is available
for the sole use of the caller. Some variants keep a pool of available
SalGraphics and return one not currently in use by anyone, creating
extra ones on demand, sometimes up to a set limit and returning NULL
on reaching that limit of simultaneously in use SalGraphics.
This is confusing. What is really happening from the perspective of the calling
is that is that we are attempting to *acquire* ownership of a SalGraphics
instance.
Therefore, rename GetGraphics to AcquireGraphics() which returns a handle to a
SalGraphics if we can acquire a free graphics instance, and NULL if we cannot,
which makes it cleared that ReleaseGraphics should be called on the result
of AcquireGraphics.
The classes that were changed to include the new acquire function are:
* SalFrame
* SalVirtualDevice
* SalInfoPrinter
* PspSalInfoPrinter
* X11SalFrame
* X11SalVirtualDevice
* GtkSalFrame
* KDESalFrame
* TDESalFrame
* WinSalFrame
* WinSalInfoPrinter
* WinSalVirtualDevice
* SvpSalFrame
* SvpSalVirtualDevice
* AquaSalFrame
* AquaSalInfoPrinter
* AquaSalVirtualDevice
Change-Id: Ic39c08a4bcaf665ae08ba2808cd03b0e80790c46
Reviewed-on: https://gerrit.libreoffice.org/8070
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 10:59:19 -06:00
1ec2880679
Resolves: rhbz#1007697 Update on a Window triggering delete on window
...
Change-Id: Ic6374ce45e3a3ba97217ae77e91f9143f46e277b
Reviewed-on: https://gerrit.libreoffice.org/8396
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 10:58:59 -06:00
29a4487a06
WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'
...
Change-Id: I70eb7c04d12fad8f46f549bf5d43e1d1ffb724a1
2014-02-28 12:10:46 +02:00
74c17d6187
WaE: implicit conversion (IntegralCast) from bool to 'long'
...
Change-Id: I065858bdacf88f87eabe6cec516f6357acc11152
2014-02-28 12:09:00 +02:00
c005d07dbc
WaE: implicit conversion (IntegralCast) from bool to 'sal_uInt16'
...
Change-Id: If6c41795a4015eb6bdd6bf785dd5ea6f7069e76b
2014-02-28 11:55:28 +02:00
bf470dcdf5
WaE: implicit conversion (IntegralCast) from bool to 'int'
...
Change-Id: I75d079a34355454a6e6b741f029c5ec37c149b17
2014-02-28 11:52:04 +02:00
02e355370d
More EndDialog() cleanup
...
Change-Id: I2e79190936d1eb7f55b521d2ce558fba45bf5f28
2014-02-28 11:50:26 +02:00
df94df2d7b
WaE: implicit conversion (IntegralCast) from bool to 'int'
...
The bIncludeUntil parameter is used as a bool, so make it a bool. It is passed
bool values anyway.
Change-Id: If477419e8d94af69ad2bd5b452819e83a5a8149f
2014-02-28 11:50:26 +02:00
17ec83705a
WaE: implicit conversion (IntegralCast) from bool to 'sal_uLong'
...
Change-Id: I5089279745c4247ec0006f2273f6ec3d40d7c2a2
2014-02-28 11:50:26 +02:00
f3f9e2d4fe
WaE: implicit conversion from bool to 'boolean' (aka 'int')
...
'boolean' is from the JPEG library, typedeffed as int, yay.
Change-Id: I6d35c3616e50127f1e00b47c25cf962fdc92c3db
2014-02-28 11:41:46 +02:00
8353589e7a
WaE: implicit conversion (IntegralCast) from bool to 'int'
...
These two functions should surely be of type bool.
2014-02-28 11:37:07 +02:00
b530a91f05
WaE: implicit conversion (IntegralCast) from bool to 'long'
...
Use the proper RET_OK amd RET_CANCEL parameters to EndDialog().
Change-Id: I2500e5e9793ee98c8cf38fc094d9f984576b67db
2014-02-28 11:32:08 +02:00
5ce23eb9f1
WaE: implicit conversion (IntegralCast) from bool to 'long'
...
Presumably RET_OK is what is meant here (that is how the code has worked,
anyway, as RET_OK == 1 == sal_True).
Change-Id: Ib6afffc606c6bc36b5ef4cf04991207c8c109973
2014-02-28 11:28:06 +02:00
381f8a5673
sal_Bool -> bool in mostly vcl module
...
Conflicts:
include/vcl/settings.hxx
svtools/source/table/tablecontrol_impl.cxx
sw/source/core/frmedt/fecopy.cxx
vcl/inc/canvasbitmap.hxx
vcl/inc/headless/svpframe.hxx
vcl/inc/unx/salframe.h
vcl/inc/win/salframe.h
vcl/inc/win/salprn.h
vcl/inc/win/salvd.h
vcl/osx/DragSource.cxx
vcl/osx/DragSource.hxx
vcl/osx/DropTarget.cxx
vcl/osx/DropTarget.hxx
vcl/osx/OSXTransferable.cxx
vcl/osx/OSXTransferable.hxx
vcl/osx/clipboard.cxx
vcl/osx/clipboard.hxx
vcl/osx/salprn.cxx
vcl/qa/cppunit/canvasbitmaptest.cxx
vcl/source/components/fontident.cxx
vcl/source/control/edit.cxx
vcl/source/control/spinfld.cxx
vcl/source/gdi/gdimtf.cxx
vcl/source/gdi/virdev.cxx
vcl/source/helper/canvasbitmap.cxx
vcl/source/window/dockwin.cxx
vcl/unx/generic/dtrans/X11_selection.hxx
vcl/unx/kde/UnxFilePicker.cxx
vcl/unx/kde/UnxFilePicker.hxx
vcl/unx/kde4/KDE4FilePicker.cxx
vcl/unx/kde4/KDE4FilePicker.hxx
vcl/unx/kde4/KDESalFrame.hxx
Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 03:19:47 -06:00
77ec79022f
constructor only used on WNT in FontSelectPatternAttributes
...
Change-Id: Iffbd9702f5a81e4bfe3baa3952824f4c6ba3bca3
2014-02-28 08:32:04 +02:00
98881b0a55
remove unused code in vcl/ImplRegionBand
...
ImplRegionBand::IsInside(long, long)
ImplRegionBand::IsOver(long, long)
Change-Id: I607c589d62a0c9178a32df5cf48fcbe279878030
2014-02-28 08:32:03 +02:00
3543d2d20b
fix name of method in vcl/Menu, SetHightlightItem to SetHighlightItem
...
Change-Id: I89a61aeffeebc69e06da6c1130436fb25528f1c7
2014-02-28 08:32:02 +02:00
b26047be9f
remove unused code Menu::GetHighlightItem()
...
Change-Id: I9b538bacbb98705b0345c3f6dc38fb554ce25bcf
2014-02-28 08:32:02 +02:00
01aa02a128
images: Skip comments in links.txt.
...
Change-Id: I446dec8447fb9b0b4fa37bf6343e130539211b50
2014-02-27 22:22:24 +01:00
af63727b9f
Resolves: #i15508# Added support for BMP file type
...
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)
Conflicts:
filter/source/msfilter/escherex.cxx
include/vcl/gfxlink.hxx
svx/source/xml/xmlgrhlp.cxx
sw/source/ui/docvw/romenu.cxx
vcl/source/filter/graphicfilter.cxx
Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00
90b33b3075
-Werror,-Wunused-variable
...
Change-Id: Ib207ea292a2ea389005510bad0ae931df91424f0
2014-02-27 15:06:55 +01:00
779b808df1
bad
...
Change-Id: Ife660e5738d862e28260abe412817fb06272f4e8
2014-02-27 13:14:20 +00:00
af3b804e19
coverity#1187685 Dereference null return value
...
Change-Id: I7f34eae7eedfa067f0f8a360aa6ae8dc5b0381bd
2014-02-27 12:58:47 +00:00
583c0ee3e1
coverity#1187660 Dereference after null check
...
Change-Id: I41a05e34c9b1dd312602f2c499793a4568473394
2014-02-27 12:57:49 +00:00
43d42775cb
coverity#1187659 Dereference after null check
...
Change-Id: I31b1a55a72be7fac80cd7bbac52b723d7e33a13a
2014-02-27 12:57:27 +00:00
3ed04054d3
coverity#1187658 Dereference after null check
...
Change-Id: I4924903f1763c6afc975efb45e43223ee3829951
2014-02-27 12:57:27 +00:00
e874ace32b
coverity#1187640 this code has no effect
...
Change-Id: I526e636fe80001f4cd5c94f0ba1df27134895d83
2014-02-27 12:57:26 +00:00
f61b6894ef
GetContextMenuDown is always true
...
Change-Id: Ib2ce1dd91cc7bfaf38feca7b056874a2508869e6
2014-02-27 12:57:24 +00:00
cb40b7d2f9
callcatcher: update unused code
...
Change-Id: I560471a3c2ac9d8ccf759fca1d8c30ae00d73484
2014-02-27 12:57:24 +00:00
f6e0d356b7
Removed unnecessary comment decorations and wspace from VCL sources
...
Change-Id: I190b57bb476a35ede1b6050f3c1edabd0ab00397
Reviewed-on: https://gerrit.libreoffice.org/8374
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:43:20 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
844d1a8959
sal_Bool -> bool fixup
...
Change-Id: I1104fc57f9f82944d258208f70993da1b00f1843
2014-02-26 15:00:51 +01:00
81afed113d
Removed unnecessary comment decorations from VCL sources
...
Conflicts:
vcl/headless/svpgdi.cxx
vcl/source/app/dbggui.cxx
vcl/source/app/help.cxx
vcl/source/app/idlemgr.cxx
vcl/source/app/settings.cxx
vcl/source/app/stdtext.cxx
vcl/source/app/svdata.cxx
vcl/source/app/svmain.cxx
vcl/source/control/fixed.cxx
vcl/source/control/ilstbox.cxx
vcl/source/control/spinbtn.cxx
vcl/source/filter/sgfbram.cxx
vcl/source/filter/sgvmain.cxx
vcl/source/filter/sgvtext.cxx
vcl/source/filter/wmf/emfwr.hxx
vcl/source/filter/wmf/winmtf.hxx
vcl/source/filter/wmf/wmfwr.hxx
vcl/source/fontsubset/cff.cxx
vcl/source/fontsubset/fontsubset.cxx
vcl/source/fontsubset/xlat.cxx
Change-Id: Ifc4fa21e552a8b031645eb883bdc23563eebb602
Reviewed-on: https://gerrit.libreoffice.org/8357
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 05:48:00 -06:00
d9f0af83b7
Remove visual noise from vcl
...
Conflicts:
vcl/source/app/settings.cxx
vcl/source/window/dockmgr.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/floatwin.cxx
vcl/source/window/toolbox2.cxx
Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 04:56:16 -06:00
45261b88c4
fdo#39468 Translate German Comments - vcl/source/window/toolbox2.cxx
...
Conflicts:
vcl/source/window/toolbox2.cxx
Change-Id: Ifcb3a31733d8122d228596e8ec1253990f979471
Reviewed-on: https://gerrit.libreoffice.org/8174
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 04:26:04 -06:00
4e5fb3ae8a
fdo#39468 Translate German Comments - vcl/source/window/floatwin.cxx
...
Conflicts:
vcl/source/window/floatwin.cxx
Change-Id: I5cf91515e088f7f7bb766089c0812b023ecb3bdd
Reviewed-on: https://gerrit.libreoffice.org/8172
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 04:11:27 -06:00
204642f307
fdo#39468 Translate German Comments - vcl/source/window/dockwin.cxx
...
(BTW: There seems to be some duplication between dockwin and dockmgr)
Conflicts:
vcl/source/window/dockwin.cxx
Change-Id: Icaf421620f87de7512a461b778958f6e141946db
Reviewed-on: https://gerrit.libreoffice.org/8171
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 04:02:27 -06:00
a980928ef8
Remove implementation details from vcl/settings.hxx
...
This reduces the number of files which need to be recompiled
after a change to the internal details.
Also: Remove explicit assignment operators since they are no longer
needed.
Change-Id: Ieb18a8437fbcd39c6003b50c656ce010f5002d9a
Reviewed-on: https://gerrit.libreoffice.org/8161
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-02-26 03:16:46 -06:00
d5c59404be
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I773524536c0ed7bc34eb08cd35cfc77e83f722ba
2014-02-26 17:21:20 +09:00
d5688e16e7
fdo#39468 Translate German Comments - vcl/source/window/dockmgr.cxx
...
Conflicts:
vcl/source/window/dockmgr.cxx
Change-Id: I0af8a95eab8b05752bb4497295d26b717021d3fd
Reviewed-on: https://gerrit.libreoffice.org/8169
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-25 21:18:32 +00:00
63de81621a
Update little-to-big endian GetSwapFloat functions
...
rSt >> pPtr[3] >> pPtr[2] >> pPtr[1] >> pPtr[0] results in error:
no match for 'operator>>' in 'rSt >> *(pPtr + 3u)'
Change-Id: I1820bac8c72f7633ab01a17bf5d073b988e1b58c
Reviewed-on: https://gerrit.libreoffice.org/8207
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-25 13:43:28 +00:00
1a48228535
remove unused code Menu::GetItemAccKeyStrFromPos(unsigned short)
...
Change-Id: Ia6967bd5ae412b473187d8bf5485e56fdc934efb
2014-02-25 15:17:01 +02:00
b510f69859
remove unused code Menu::IsTemporaryItemFromPos(unsigned short)
...
Change-Id: I90a9116aba75316992d2bddaf2f6466288b95bd0
2014-02-25 15:17:00 +02:00
58ba105a03
callcatcher: update unused code
...
Change-Id: Ia8e6abffb85b92ee4538fb0aeaee4e4aa18f2772
2014-02-25 10:45:27 +00:00
c47496fdf9
Add config_libraries.h definitions to get library names easily.
...
Works for libmerged too, so we can get rid of LIBO_MERGELIBS.
And remove few more #defines in vcl.
It's generated by gbuild, so probably abusing config_host directory.
Open to improvements.
Change-Id: I87ab109bf109e42751766011daf076e9cdf8f5ee
2014-02-25 09:05:09 +01:00
6e0bdf04ad
sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it
...
which means that icons suddenly reappeared in the menus when the gtk
theme had disabled them
ref e8f8f24c8415898c787bbfb629247ed62e73a2b9
Change-Id: Ia9aef5ca39bda2ddf6d7c4ebc2bddc01d470d09b
2014-02-24 12:53:14 +00:00
33740b7d5a
Replace exisiting TriState, AutoState with more generic TriState
...
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
