Commit Graph

1203 Commits

Author SHA1 Message Date
8353589e7a WaE: implicit conversion (IntegralCast) from bool to 'int'
These two functions should surely be of type bool.
2014-02-28 11:37:07 +02:00
b530a91f05 WaE: implicit conversion (IntegralCast) from bool to 'long'
Use the proper RET_OK amd RET_CANCEL parameters to EndDialog().

Change-Id: I2500e5e9793ee98c8cf38fc094d9f984576b67db
2014-02-28 11:32:08 +02:00
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
779b808df1 bad
Change-Id: Ife660e5738d862e28260abe412817fb06272f4e8
2014-02-27 13:14:20 +00:00
583c0ee3e1 coverity#1187660 Dereference after null check
Change-Id: I41a05e34c9b1dd312602f2c499793a4568473394
2014-02-27 12:57:49 +00:00
f6e0d356b7 Removed unnecessary comment decorations and wspace from VCL sources
Change-Id: I190b57bb476a35ede1b6050f3c1edabd0ab00397
Reviewed-on: https://gerrit.libreoffice.org/8374
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:43:20 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
81afed113d Removed unnecessary comment decorations from VCL sources
Conflicts:
	vcl/headless/svpgdi.cxx
	vcl/source/app/dbggui.cxx
	vcl/source/app/help.cxx
	vcl/source/app/idlemgr.cxx
	vcl/source/app/settings.cxx
	vcl/source/app/stdtext.cxx
	vcl/source/app/svdata.cxx
	vcl/source/app/svmain.cxx
	vcl/source/control/fixed.cxx
	vcl/source/control/ilstbox.cxx
	vcl/source/control/spinbtn.cxx
	vcl/source/filter/sgfbram.cxx
	vcl/source/filter/sgvmain.cxx
	vcl/source/filter/sgvtext.cxx
	vcl/source/filter/wmf/emfwr.hxx
	vcl/source/filter/wmf/winmtf.hxx
	vcl/source/filter/wmf/wmfwr.hxx
	vcl/source/fontsubset/cff.cxx
	vcl/source/fontsubset/fontsubset.cxx
	vcl/source/fontsubset/xlat.cxx

Change-Id: Ifc4fa21e552a8b031645eb883bdc23563eebb602
Reviewed-on: https://gerrit.libreoffice.org/8357
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:48:00 -06:00
d9f0af83b7 Remove visual noise from vcl
Conflicts:
	vcl/source/app/settings.cxx
	vcl/source/window/dockmgr.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/floatwin.cxx
	vcl/source/window/toolbox2.cxx

Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:56:16 -06:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
7e8ce6c666 coverity#441533 Dereference after null check
Change-Id: Iee024e2a16291aed98c10bfb6c33af6b17d44e4e
2014-02-23 03:28:22 +00:00
076a7eacca Bug #63962 Dynamically scan the config directory for icon themes
The hard-coded icon themes have been replaced by a dynamic list
which is filled by scanning the config directory

Conflicts:
	include/vcl/settings.hxx
	vcl/source/app/settings.cxx
	vcl/source/window/window.cxx

Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed
Reviewed-on: https://gerrit.libreoffice.org/7935
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21 17:23:50 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
49cecd8b41 Related: fdo#74242 hook up a selection and caret change for multiline edits
a) split the textengine selection changed broadcast into a text selection changed
and text caret change event
b) handle both in existing places that handled the text selection event
c) listen for them in VclMultiLineEdit and translate to
VCLEVENT_EDIT_SELECTIONCHANGED VCLEVENT_EDIT_CARETCHANGED events
d) profit from the VCLEVENT_EDIT_SELECTIONCHANGED and
VCLEVENT_EDIT_CARETCHANGED handling in
accessibility/source/standard/vclxaccessibleedit.cxx for VCLXAccessibleEdits

Change-Id: I09187e76ae4eb189ee9469e388374154087faf80
2014-02-19 15:32:00 +00:00
973b47a336 unotools: sal_Bool -> bool
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19 12:47:07 +01:00
3d024d29fa Related: fdo#74242 send selection change before caret change
because that's what I see gtk does

Change-Id: Ifa20f4d84fd31ea6fcc640589b72efd00c9665fd
2014-02-19 11:07:12 +00:00
1b2da3df54 enable spin-size for NumericField too
Change-Id: I77660572947f7a863982be7742cbcb1c784379ed
2014-02-13 14:19:47 +01:00
78ff9d90f2 fdo#74468 fix timing of slide transitions
Regression since commit 16428c9600964a4945cf6fd0d938dea047d1248b.

Change-Id: Id274c21e08d10d2e727f3b5a3fd852cd297e4637
2014-02-13 14:19:46 +01:00
76f5ce409f more similar handling of InputSequenceChecker as in other places
Change-Id: Ia6efc0eda03dac87c73e720d08f320ce3fc6ce4a
2014-02-11 22:34:36 +01:00
455d970206 Renamed VCL's OutputDevice mirroring functions
I have renamed the following functions:

* ImplReMirror            -> ReMirror
* ImplHasMirroredGraphics -> HasMirroredGraphics

This has been done because these functions are definitely public
and there is no need to prefix them with "Impl" as they are exposed
to other objects.

Change-Id: Ib52493c9824e29a038de2fc35736a5ca863c091a
Reviewed-on: https://gerrit.libreoffice.org/7911
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07 16:57:53 +00:00
d2d5864462 TabControl::DeactivatePage should return bool
Change-Id: I9fb774a235db2b9bc759976d2d3f84363ed944ec
2014-02-06 15:44:03 +01:00
fba46c6efd fdo#74424 Use Window::GetOutDev() to access ImplReMirrored()
Part of the decoupling of Window from OutputDevice. We now get
he Window's OutputDevice instance and manipulate this. Do not rely
on the inherited function.

Conflicts:
	include/vcl/window.hxx

Change-Id: Ie422df837e1596881b61d34a1627b0ecc668a54e
Reviewed-on: https://gerrit.libreoffice.org/7793
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-05 14:24:16 +00:00
c1d37365c4 bool improvements
Change-Id: Iede12ed1e35581cf48d64b898f22949d0c1aa6de
2014-01-28 20:26:19 +01:00
05534b5523 Resolves: #i124008# listbox entry's are selected automatically...
on mouse over instead of mouse click

(cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3)

Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28 11:37:23 +00:00
06cfc634cd coverity#735559 Logically dead code
Change-Id: I75205d46243c18bbd63532aea1965a0e058ef739
2014-01-27 17:03:07 +00:00
c3b888d5be coverity#441000 Logically dead code
Change-Id: I4fa2639b62ee08dc2367cfc975bf673cbed65fb6
2014-01-25 20:56:34 +00:00
c4b217c03e coverity#440998 Logically dead code
Change-Id: Ie7647ef6fb605f14febfb83804b23d8fd62bc717
2014-01-25 20:56:34 +00:00
5e6b8aebf1 coverity#440997 Logically dead code
Change-Id: Id8340d1c5c07026da7f737924d5caf3e6254c340
2014-01-25 20:56:33 +00:00
44348f093e coverity#440996 Logically dead code
Change-Id: I4ef10ab73aa506394f49e5501a4f6c35543cc573
2014-01-25 20:56:33 +00:00
081837dbf5 coverity#440995 Logically dead code
Change-Id: I8494cef9c63895c0d7b0a2377961da2df8f34606
2014-01-25 20:56:33 +00:00
cb10f3324e coverity#440994 Logically dead code
Change-Id: Ib01d71c43ab3761973a95e2faf9113ec46424e97
2014-01-25 20:56:33 +00:00
ae78fd8fda coverity#440993 Logically dead code
Change-Id: I03685c9a1db89ce4365945d88ce4251ccdf32246
2014-01-25 20:56:32 +00:00
5d7d4e78d7 coverity#1157769 Logically dead code
Change-Id: I48b83a8fba756ad44f9b823357f3fdd42a297430
2014-01-25 12:28:08 +00:00
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
f03ce265db drop translation of % now that we use icu to format it
Change-Id: Ia53815018cc5438ffbc2fecf2ec65ce69f1b90c5
2014-01-22 13:06:52 +00:00
b184636e1c bool improvements
Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705
2014-01-21 18:24:02 +01:00
3007e01531 Translated German comments vcl/source
Change-Id: I1143996ef86e35caa72cf2e60ae586940a10ce81
Reviewed-on: https://gerrit.libreoffice.org/7527
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-21 11:48:27 +00:00
062e6f76ba Related: #i56998# use locale rules to format percentage
Change-Id: I2cdeefc5a5a1ee970ee3da5191ceae28b58340a1
2014-01-20 13:32:15 +00:00
aab6645595 Related: #i56998# percent value should not takes space separator...
before the character

(cherry picked from commit acac627b8aed3353e542ce41fa9a7064e4d1790b)

Conflicts:
	vcl/source/control/field.cxx

Change-Id: Ia9c5496e1e2345f6249dc03efaf2c60f4231aecd
2014-01-20 12:45:55 +00:00
269af04481 Related: #i56998# no space for degree symbol
and now space between number and pages is explicitly added by code

Change-Id: Ic4e73d2f30b93bd4a34b98f480f1ba111c9a285d
2014-01-20 12:20:09 +00:00
ab50bc9d4a Resolves: #i56998# add a space separater between value and unit...
and remove separator between value and percent to match with ISO 31-0

(cherry picked from commit 0cea884e3f417e4b58d2fdcfc7b0111f3bfc6f30)

Conflicts:
	chart2/source/controller/dialogs/tp_SeriesToAxis.src
	cui/source/dialogs/colorpicker.cxx
	cui/source/dialogs/colorpicker.src
	cui/source/dialogs/grfflt.src
	cui/source/dialogs/zoom.src
	cui/source/tabpages/tabline.src
	editeng/source/items/frmitems.cxx
	editeng/source/items/textitem.cxx
	sd/source/ui/animations/CustomAnimationDialog.src
	sd/source/ui/animations/SlideTransitionPane.src
	svx/source/dialog/bmpmask.src
	svx/source/engine3d/float3d.src
	svx/source/items/algitem.cxx
	svx/source/sidebar/text/TextCharacterSpacingControl.cxx
	svx/source/xoutdev/xattr.cxx
	sw/source/ui/utlui/attrdesc.cxx
	sw/source/ui/utlui/uiitems.cxx

Change-Id: I554309cb72dd8956077c5ca6866a982cdd6529aa
2014-01-20 12:08:54 +00:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
5169abbac9 bool improvements
Change-Id: I7ec4f5b2e691ec03e9e2c5ca3a004f1e04efbc27
2014-01-17 18:45:14 +01:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
57ec4a841a longparas: drop xub_StrLen from fields
Change-Id: Icd6dbc9b374df3e528dc22afa07be72d7fc89ca7
2014-01-13 11:50:56 +00:00
9407f45186 longparas: STRING_LEN here means text len, so expand to just that
Change-Id: Iec55f8976ca180e380c9679c561aae61c0607520
2014-01-13 11:33:58 +00:00
c364fc1fc3 longparas: xub_StrLen to sal_Int32
Change-Id: Ib3eb5f9df112696b326bb30e4deed49d37f30c86
2014-01-13 09:50:11 +00:00
1b7a5c634a disentangle CalcSize
Change-Id: I42248ff611dbe7c109076da5d548717898341be3
2014-01-13 09:50:11 +00:00