f3f9e2d4fe
WaE: implicit conversion from bool to 'boolean' (aka 'int')
...
'boolean' is from the JPEG library, typedeffed as int, yay.
Change-Id: I6d35c3616e50127f1e00b47c25cf962fdc92c3db
2014-02-28 11:41:46 +02:00
381f8a5673
sal_Bool -> bool in mostly vcl module
...
Conflicts:
include/vcl/settings.hxx
svtools/source/table/tablecontrol_impl.cxx
sw/source/core/frmedt/fecopy.cxx
vcl/inc/canvasbitmap.hxx
vcl/inc/headless/svpframe.hxx
vcl/inc/unx/salframe.h
vcl/inc/win/salframe.h
vcl/inc/win/salprn.h
vcl/inc/win/salvd.h
vcl/osx/DragSource.cxx
vcl/osx/DragSource.hxx
vcl/osx/DropTarget.cxx
vcl/osx/DropTarget.hxx
vcl/osx/OSXTransferable.cxx
vcl/osx/OSXTransferable.hxx
vcl/osx/clipboard.cxx
vcl/osx/clipboard.hxx
vcl/osx/salprn.cxx
vcl/qa/cppunit/canvasbitmaptest.cxx
vcl/source/components/fontident.cxx
vcl/source/control/edit.cxx
vcl/source/control/spinfld.cxx
vcl/source/gdi/gdimtf.cxx
vcl/source/gdi/virdev.cxx
vcl/source/helper/canvasbitmap.cxx
vcl/source/window/dockwin.cxx
vcl/unx/generic/dtrans/X11_selection.hxx
vcl/unx/kde/UnxFilePicker.cxx
vcl/unx/kde/UnxFilePicker.hxx
vcl/unx/kde4/KDE4FilePicker.cxx
vcl/unx/kde4/KDE4FilePicker.hxx
vcl/unx/kde4/KDESalFrame.hxx
Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-28 03:19:47 -06:00
af63727b9f
Resolves: #i15508# Added support for BMP file type
...
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)
Conflicts:
filter/source/msfilter/escherex.cxx
include/vcl/gfxlink.hxx
svx/source/xml/xmlgrhlp.cxx
sw/source/ui/docvw/romenu.cxx
vcl/source/filter/graphicfilter.cxx
Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00
f6e0d356b7
Removed unnecessary comment decorations and wspace from VCL sources
...
Change-Id: I190b57bb476a35ede1b6050f3c1edabd0ab00397
Reviewed-on: https://gerrit.libreoffice.org/8374
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:43:20 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
81afed113d
Removed unnecessary comment decorations from VCL sources
...
Conflicts:
vcl/headless/svpgdi.cxx
vcl/source/app/dbggui.cxx
vcl/source/app/help.cxx
vcl/source/app/idlemgr.cxx
vcl/source/app/settings.cxx
vcl/source/app/stdtext.cxx
vcl/source/app/svdata.cxx
vcl/source/app/svmain.cxx
vcl/source/control/fixed.cxx
vcl/source/control/ilstbox.cxx
vcl/source/control/spinbtn.cxx
vcl/source/filter/sgfbram.cxx
vcl/source/filter/sgvmain.cxx
vcl/source/filter/sgvtext.cxx
vcl/source/filter/wmf/emfwr.hxx
vcl/source/filter/wmf/winmtf.hxx
vcl/source/filter/wmf/wmfwr.hxx
vcl/source/fontsubset/cff.cxx
vcl/source/fontsubset/fontsubset.cxx
vcl/source/fontsubset/xlat.cxx
Change-Id: Ifc4fa21e552a8b031645eb883bdc23563eebb602
Reviewed-on: https://gerrit.libreoffice.org/8357
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 05:48:00 -06:00
d9f0af83b7
Remove visual noise from vcl
...
Conflicts:
vcl/source/app/settings.cxx
vcl/source/window/dockmgr.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/floatwin.cxx
vcl/source/window/toolbox2.cxx
Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 04:56:16 -06:00
63de81621a
Update little-to-big endian GetSwapFloat functions
...
rSt >> pPtr[3] >> pPtr[2] >> pPtr[1] >> pPtr[0] results in error:
no match for 'operator>>' in 'rSt >> *(pPtr + 3u)'
Change-Id: I1820bac8c72f7633ab01a17bf5d073b988e1b58c
Reviewed-on: https://gerrit.libreoffice.org/8207
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-25 13:43:28 +00:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
e8f8f24c84
vcl: sal_Bool -> bool
...
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
55112988e6
Combine two subsequent SAL_INFO calls into one
...
Change-Id: Iec931ddb77ce09df72ee9ce321e443e6f5a785f1
2014-02-20 13:52:08 +02:00
e69ede57ff
loplugin:literaltoboolconversion
...
Change-Id: I0c444f2e81e2e0ac9d6969f674ec3da013427cee
2014-02-19 16:17:39 +01:00
2b2a3ed373
coverity#738862 Uninitialized scalar field
...
Change-Id: Ib970ef372e7754db890b5a4cd9c9b422a129ba02
2014-02-19 13:06:16 +00:00
cc74d3ce73
fix debug=2 build
...
Change-Id: Id7c6db5c6cbefef427d9c2cc4bd210811b5a7991
2014-02-17 09:51:39 +00:00
0c7f352775
remove SvStream::operator>> methods
...
in favour of ReadXXX methods.
Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 19:45:10 +00:00
15535e32dd
convert SvStream::operator>> methods to ReadXXX methods
...
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 15:31:40 +00:00
d69c4535a1
coverity#708311 Uninitialized scalar field
...
Change-Id: I19c19f4e1ae4e8718b44f4a70992113178a6658c
2014-02-11 14:33:35 +00:00
82d05f63fe
Translated German comments
...
Change-Id: Ia21618d8475f02cb0fe9c55ae70d2598435087c5
Reviewed-on: https://gerrit.libreoffice.org/7951
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-10 16:46:16 +00:00
654f0932b9
Translated German comments - polygon and matrix calculations
...
Change-Id: I3b01520cca854e6504787077a15fbe150eef86d4
Reviewed-on: https://gerrit.libreoffice.org/7950
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk >
2014-02-09 10:23:54 +00:00
65af1f3098
coverity#1169866 Uninitialized scalar variable
...
Change-Id: I0259c798bfff5034059fd3ef6a0463e5fbce409b
2014-02-08 14:15:54 +00:00
562fdfc9b4
coverity#1169868 Uninitialized scalar variable
...
Change-Id: I65c2c8fcbf83d8a93a838873c412d70f7d9196ef
2014-02-08 14:15:54 +00:00
6da0dc447c
coverity#1169872 Uninitialized scalar variable
...
Change-Id: I797e25c6cf23f3de6e812096574be8d4bce41338
2014-02-08 14:15:54 +00:00
518d641163
remove germanism: bEnde -> bEnd
2014-02-07 13:49:20 +01:00
2afb6528c1
Blind fix^3
...
Change-Id: I4124084a6ce47e96936b5cc8695af1981f9f33d4
2014-02-06 17:40:21 +01:00
c8e11b48a3
Blind fix^2
...
Change-Id: I8d44908fc849f93bbd076c7c62ad11a68f0dab6f
2014-02-06 16:04:13 +01:00
697e84f5de
Blind fix for spurious -Werror=clobbered
...
Change-Id: I724713927f181251e8f4a5be7887c49e6dc6edda
2014-02-06 15:37:54 +01:00
11dbbc792f
Make vcl/source/filter/jpeg/jpegc.c be C++ code
...
...simplify the corresponding jpeg.h now that it deals in C++, and fold
SetJpegPreviewSizeHint into ReadJPEG to avoid global static data.
Change-Id: Id3721bdb37be05e3e6bbbaef3b0aa0c0e1a9ff5a
2014-02-06 14:20:00 +01:00
51a68b4992
Doxygen warnings corrected
...
* Doxygen spits out a lot of warnings about not being able to find
match function signatures, etc. This is because in some headers we
have a using namespace statement, in others it gets confused between
::Window and Window (!).
* Wrong use of tags:
+ Lots of @seealso - should be @see
+ Wrong usage of @overload - corrected with the right function
signature
+ HTML tags that doxygen doesn't recognize removed
Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-05 09:14:53 +00:00
186b4ebc99
convert specialised SvStream::operator>> methods to ReadXXX methods
...
as preparation for converting the SvStream::operator>> methods on
primitive types
Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-04 22:50:39 +00:00
2b76184892
Revert "Doxygen warnings corrected"
...
This reverts commit ff8036df5c5575503dc30d255dfbe99cc637c510.
multiple build failures with namespace collisions etc
Change-Id: Ie8ac08feff518af3584a26957f07a60d95932c76
Reviewed-on: https://gerrit.libreoffice.org/7855
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-04 16:14:08 +00:00
ff8036df5c
Doxygen warnings corrected
...
* Doxygen spits out a lot of warnings about not being able to find
match function signatures, etc. This is because in some headers we
have a using namespace statement, in others it gets confused between
::Window and Window (!).
* Wrong use of tags:
+ Lots of @seealso - should be @see
+ Wrong usage of @overload - corrected with the right function
signature
+ HTML tags that doxygen doesn't recognize removed
Conflicts:
include/vcl/toolbox.hxx
Change-Id: I687f45e426280d411ef3cb6d8d5993a829f2f324
Reviewed-on: https://gerrit.libreoffice.org/7725
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-04 14:39:21 +00:00
4926444bbb
typo: howeve -> however
...
Change-Id: I12ca3f217eb1f3c77003014dc26ce4318d2b2857
2014-02-03 19:47:55 +01:00
17394c18c8
fdo#63154 Removed unused solar.h ref. in vcl
...
Change-Id: Ibbc80b09a288494baae4e5ebee4428a6a80a904a
Reviewed-on: https://gerrit.libreoffice.org/7738
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-30 11:25:42 +00:00
c1d37365c4
bool improvements
...
Change-Id: Iede12ed1e35581cf48d64b898f22949d0c1aa6de
2014-01-28 20:26:19 +01:00
92026cc844
coverity#440938 Logically dead code
...
Change-Id: I33f895ab913eee0dd6a5df05cd2f4cffb88cc1ef
2014-01-28 11:29:16 +00:00
c9b41602a0
coverity#708315 Uninitialized scalar field
...
Change-Id: I1a93fcb6107bdce10b1f967337e75c525ab24640
2014-01-27 17:03:06 +00:00
4a3c101276
coverity#708316 Uninitialized scalar field
...
Change-Id: I506ee57c59255494bbde91762da43c8b04b0f086
2014-01-27 17:03:06 +00:00
463dbd42d1
coverity#440937 Logically dead code
...
Change-Id: If388006a7f53aee5ffe42a152ab917ca5aca2072
2014-01-27 17:03:06 +00:00
53c8030045
Resolves: fdo#74051 support 8430x11700 jpegs
...
Change-Id: I1ca95a496bca80e5e2787af2ccbf0f6cd42455a5
2014-01-27 15:23:16 +00:00
0dda969660
coverity#440936 Logically dead code
...
Change-Id: I04299880a9e5ccc5d92aa194a9cd100a46906b79
2014-01-25 20:56:32 +00:00
e3133ae237
Let C++ inline functions return bool instead of sal_Bool
...
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23 18:43:53 +01:00
16a2e90335
remove SvStream::operator<< methods
...
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-22 22:00:47 +00:00
54a370753c
vcl: stylistic cleanup
...
Change-Id: Iaab13bd37b85128c9cf83b114a155f198b628587
2014-01-21 20:07:00 +01:00
3007e01531
Translated German comments vcl/source
...
Change-Id: I1143996ef86e35caa72cf2e60ae586940a10ce81
Reviewed-on: https://gerrit.libreoffice.org/7527
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2014-01-21 11:48:27 +00:00
e4f82812bb
Translated German comments (in 20 yr old code...)
...
Change-Id: Ie25a734bee8e2cfe3a8fb0a6471ab9988e9c915a
Reviewed-on: https://gerrit.libreoffice.org/7528
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk >
2014-01-20 07:58:26 +00:00
70068f428d
fdo#73764 partially revert 3998d1abb291
...
Change-Id: Ie9b6d6a318fad256f3f0999fe9c0810a4323f10d
2014-01-19 19:13:57 +01:00
09c722873b
EMF/WMF: fix rendering of pen styles (dash, dot, dashdot, dashdotdot)
...
Change-Id: I226bac370601b75f2589f7a7c5e8830746b31e2e
2014-01-19 18:00:26 +01:00
31507aaceb
WMF: parse line cap and line join
...
Change-Id: I5a19a724856938d5a0495ee1e454582238dbd3f0
2014-01-19 18:00:26 +01:00
8ca8896319
Translated German comments and corrected English spelling
...
Change-Id: I1ed1d06663cadc82a7ccf127897ccd85b77cacc0
2014-01-19 11:38:54 +01:00
