Commit Graph

2783 Commits

Author SHA1 Message Date
bbd51100fa fdo#59329 Fix docked window border lines
This patch completes the missing border lines. This is intended
for versions 4.1 and 4.2 only.

Change-Id: Ib15cb3b01dca4631f643a0036475cf684793d256
2014-03-02 13:24:06 +03:00
1ec2880679 Resolves: rhbz#1007697 Update on a Window triggering delete on window
Change-Id: Ic6374ce45e3a3ba97217ae77e91f9143f46e277b
Reviewed-on: https://gerrit.libreoffice.org/8396
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 10:58:59 -06:00
29a4487a06 WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'
Change-Id: I70eb7c04d12fad8f46f549bf5d43e1d1ffb724a1
2014-02-28 12:10:46 +02:00
74c17d6187 WaE: implicit conversion (IntegralCast) from bool to 'long'
Change-Id: I065858bdacf88f87eabe6cec516f6357acc11152
2014-02-28 12:09:00 +02:00
c005d07dbc WaE: implicit conversion (IntegralCast) from bool to 'sal_uInt16'
Change-Id: If6c41795a4015eb6bdd6bf785dd5ea6f7069e76b
2014-02-28 11:55:28 +02:00
bf470dcdf5 WaE: implicit conversion (IntegralCast) from bool to 'int'
Change-Id: I75d079a34355454a6e6b741f029c5ec37c149b17
2014-02-28 11:52:04 +02:00
02e355370d More EndDialog() cleanup
Change-Id: I2e79190936d1eb7f55b521d2ce558fba45bf5f28
2014-02-28 11:50:26 +02:00
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
3543d2d20b fix name of method in vcl/Menu, SetHightlightItem to SetHighlightItem
Change-Id: I89a61aeffeebc69e06da6c1130436fb25528f1c7
2014-02-28 08:32:02 +02:00
b26047be9f remove unused code Menu::GetHighlightItem()
Change-Id: I9b538bacbb98705b0345c3f6dc38fb554ce25bcf
2014-02-28 08:32:02 +02:00
90b33b3075 -Werror,-Wunused-variable
Change-Id: Ib207ea292a2ea389005510bad0ae931df91424f0
2014-02-27 15:06:55 +01:00
af3b804e19 coverity#1187685 Dereference null return value
Change-Id: I7f34eae7eedfa067f0f8a360aa6ae8dc5b0381bd
2014-02-27 12:58:47 +00:00
43d42775cb coverity#1187659 Dereference after null check
Change-Id: I31b1a55a72be7fac80cd7bbac52b723d7e33a13a
2014-02-27 12:57:27 +00:00
3ed04054d3 coverity#1187658 Dereference after null check
Change-Id: I4924903f1763c6afc975efb45e43223ee3829951
2014-02-27 12:57:27 +00:00
e874ace32b coverity#1187640 this code has no effect
Change-Id: I526e636fe80001f4cd5c94f0ba1df27134895d83
2014-02-27 12:57:26 +00:00
f61b6894ef GetContextMenuDown is always true
Change-Id: Ib2ce1dd91cc7bfaf38feca7b056874a2508869e6
2014-02-27 12:57:24 +00:00
cb40b7d2f9 callcatcher: update unused code
Change-Id: I560471a3c2ac9d8ccf759fca1d8c30ae00d73484
2014-02-27 12:57:24 +00:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
d9f0af83b7 Remove visual noise from vcl
Conflicts:
	vcl/source/app/settings.cxx
	vcl/source/window/dockmgr.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/floatwin.cxx
	vcl/source/window/toolbox2.cxx

Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:56:16 -06:00
45261b88c4 fdo#39468 Translate German Comments - vcl/source/window/toolbox2.cxx
Conflicts:
	vcl/source/window/toolbox2.cxx

Change-Id: Ifcb3a31733d8122d228596e8ec1253990f979471
Reviewed-on: https://gerrit.libreoffice.org/8174
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:26:04 -06:00
4e5fb3ae8a fdo#39468 Translate German Comments - vcl/source/window/floatwin.cxx
Conflicts:
	vcl/source/window/floatwin.cxx

Change-Id: I5cf91515e088f7f7bb766089c0812b023ecb3bdd
Reviewed-on: https://gerrit.libreoffice.org/8172
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:11:27 -06:00
204642f307 fdo#39468 Translate German Comments - vcl/source/window/dockwin.cxx
(BTW: There seems to be some duplication between dockwin and dockmgr)

Conflicts:
	vcl/source/window/dockwin.cxx

Change-Id: Icaf421620f87de7512a461b778958f6e141946db
Reviewed-on: https://gerrit.libreoffice.org/8171
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:02:27 -06:00
d5688e16e7 fdo#39468 Translate German Comments - vcl/source/window/dockmgr.cxx
Conflicts:
	vcl/source/window/dockmgr.cxx

Change-Id: I0af8a95eab8b05752bb4497295d26b717021d3fd
Reviewed-on: https://gerrit.libreoffice.org/8169
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:18:32 +00:00
1a48228535 remove unused code Menu::GetItemAccKeyStrFromPos(unsigned short)
Change-Id: Ia6967bd5ae412b473187d8bf5485e56fdc934efb
2014-02-25 15:17:01 +02:00
b510f69859 remove unused code Menu::IsTemporaryItemFromPos(unsigned short)
Change-Id: I90a9116aba75316992d2bddaf2f6466288b95bd0
2014-02-25 15:17:00 +02:00
c47496fdf9 Add config_libraries.h definitions to get library names easily.
Works for libmerged too, so we can get rid of LIBO_MERGELIBS.
And remove few more #defines in vcl.

It's generated by gbuild, so probably abusing config_host directory.
Open to improvements.

Change-Id: I87ab109bf109e42751766011daf076e9cdf8f5ee
2014-02-25 09:05:09 +01:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
338beca1f2 coverity#440750 Dereference after null check
Change-Id: I155e9fabaf26df71758c4b8da92664a35956accb
2014-02-23 03:28:21 +00:00
076a7eacca Bug #63962 Dynamically scan the config directory for icon themes
The hard-coded icon themes have been replaced by a dynamic list
which is filled by scanning the config directory

Conflicts:
	include/vcl/settings.hxx
	vcl/source/app/settings.cxx
	vcl/source/window/window.cxx

Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed
Reviewed-on: https://gerrit.libreoffice.org/7935
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21 17:23:50 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
34b3f01925 implement loading GtkSeparatorToolItems
Change-Id: I8111b154d8358fd4dd667000ccbdd16be38a6dc5
2014-02-20 13:50:00 +00:00
56bea42176 Fix minimal VCL menu item height with icons
Don't reset the calculated minimal menu item height to the icon
height, if the minimal height is already larger then the icon height.

Change-Id: Ifcd6c750352c4d3f754a693df7254a4654a8afe6
2014-02-19 08:50:54 +00:00
e527541702 Translated German comments - find-german-comments clean
Change-Id: I2521bb87dbd0d4f896b99865c741cc4900b4d31c
Reviewed-on: https://gerrit.libreoffice.org/8113
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-18 20:38:59 +00:00
685ec18994 Related: fdo#74284 try AccessibleRole::PANEL for VclBoxes under windows
Change-Id: Ic8c743c2646c8610b3d90425024413b40dfdab13
2014-02-17 17:04:25 +00:00
c4ecc15b25 fast scale doubling of biptmap mess up mac retina but is needed otherwise
Change-Id: I3d4a4bbbd85719fbf1422d9397727dd73bd09f37
2014-02-13 15:13:32 -06:00
02ef234b77 fix homogeneous grid spanning row/col handling
Change-Id: I26ca29f2b02a1587cfe94d5342809f51a207a194
2014-02-13 11:04:31 +00:00
67b1dad881 coverity#1130358 Deference after null check
Change-Id: I3ce41c86f57ed65fd87d403e50df47e3343a5a41
2014-02-12 21:58:15 -06:00
7e9ac59527 We don't need CreateDialogFactory() for non-DESKTOP, I think
Change-Id: Iced798f51fc2a46ede0c8e67d63941eca69ad208
2014-02-12 09:53:28 +02:00
064c628842 fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c
Reviewed-on: https://gerrit.libreoffice.org/8001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-12 07:23:09 +00:00
91d714c5dd silence unknown packing spew
Change-Id: Ic9fa7761ef03594a9609044a963c838f7dda555b
2014-02-11 12:11:43 +00:00
4357dd89ca fdo#59329 fix docked panels borders
Change-Id: Ia918d644fb57d6fbaeef90c8c1a6806a8d7e589c
2014-02-11 11:47:44 +03:00
3e2f160127 fast scale doubling of biptmap mess up mac retina
Change-Id: Ib39dd0048266483c385551a2f8f9f9629ea2ff66
2014-02-10 18:24:33 -06:00
19c5867f92 fdo#74424 HasMirroredGraphics changes
HasMirroredGraphics should be called upon by the object using the
OutputDevice. As I'm focussing on Window, which will be shortly decoupled
from OutputDevice, I have changed HasMirroredGraphics into a virtual
function, and introduced a wrapper function of the same name into Window
that calls upon Window's OutputDevice object.

Due to a bug that never appears to have been fully fixed, mirroring in
printing was broken and a workaround ("hotfix" in the code!) was
implemented but never fully fixed. Therefore, I have overridden
HasMirroredGraphics in Printer and just return false.

Change-Id: I9029e2c50cdb339c1e936bed6b92e8b2aac1dcf9
Reviewed-on: https://gerrit.libreoffice.org/7912
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10 20:38:22 +00:00
94bc29cb71 Typo: I/internaly -> I/internally
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-09 10:12:07 +01:00
661acb5e6f coverity#1169875 Uninitialized pointer field
Change-Id: I8c31ab748efedcfc88b80afc56bce1edf69084a2
2014-02-08 14:15:55 +00:00
4fcaa8ee1f coverity#441048 silence Dereference after null check
Change-Id: I3869657bbf20ac3152090a96428456c2a9eb9d14
2014-02-07 20:39:31 +00:00
fd5e86090b tidy up toolbox packing handling
we don't want to apply the children's attributes onto the parent widget

Change-Id: Iad31e7f89266633e621aaf597713564747f7cac7
2014-02-07 20:11:41 +00:00
85cdb06fd5 sal_Bool -> bool
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-07 18:43:32 +01:00