Commit Graph

769 Commits

Author SHA1 Message Date
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e23ea87cb3 Remove visual noise from xmloff
Change-Id: I205d4e555f5b88654a90007eb7ac05bc7b00a904
Reviewed-on: https://gerrit.libreoffice.org/8346
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:32:34 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
ee9729265c coverity#708700 Uninitialized scalar field
Change-Id: I294e455eb2b8853f2fbe43527a960e30d32c88c8
2014-02-21 12:40:35 +00:00
f44024d1a0 sal_Bool->bool
Change-Id: Iadc9f9ef444fe36d58304c2d6219021173385118
2014-02-14 14:15:15 +02:00
83055835b1 fdo#74112 Preserve Chart displayunits properties during ODF import/export.
Change-Id: I38508b71ee5b3b966e1d36b0d253304fe17c0ec0
Reviewed-on: https://gerrit.libreoffice.org/7721
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-11 23:23:40 +00:00
fa189d7447 bool improvements
Change-Id: I238ab0ebe54cc804c85356a3de9fbdcc396057d3
2014-01-28 20:26:18 +01:00
9f76437548 Removed unused solar.h reference
Change-Id: I1ff7d4bad068a8bc8cdc7f27dbfaee199d0f2e5f
Reviewed-on: https://gerrit.libreoffice.org/7513
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20 21:32:27 +00:00
2054af83fe fdo#72520 : Added property to store external data path in chart.
-  added new property entry to store xlsx external data for chart.

Change-Id: I3695865ad7e888359d1048e9bc380cba26108636
Reviewed-on: https://gerrit.libreoffice.org/7212
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-16 01:46:40 +00:00
6e12fb3be3 Consolidate XServiceInfo for classes derived from SvXMLImport
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
2014-01-09 10:12:19 +01:00
31911b3cdc Consolidate XServiceInfo for classes derived from SvXMLExport
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
2014-01-08 14:11:58 +01:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
ebc1b2fe50 added bool bForExport parameter to XMLPropertySetMapper ctor
Set to true for export, false for import. If export true, an
XMLPropertyMapEntry with mbImportOnly==true is not added to the
mappings. This to be able to have more than one mappings for import
(for example a current extension namespace and the future namespace
proposed to the ODF-TC, or corrected typos in element or attribute
names), but map only to one entry on export, of course.

Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3
2013-12-20 03:26:57 +01:00
9dd7ee88bd prepared XMLPropertyMapEntry with mbImportOnly flag
Change-Id: Id5a54a591a42c836884af1fd09dc055f2fce6db5
2013-12-20 03:26:56 +01:00
20bb1e6854 fdo#72304 Preserve Chart data table properties during ODF import/export.
Change-Id: I767bb32fdaddcaf742923055cc86bb19138b42be
2013-12-19 03:55:05 +01:00
a70dfc34a6 fdo#72306 Axis names were lost after saving file on LO.
While exporting chart "crosses" position values were
  not handled properly in chartexport.
  Fixed this issue by handling "autozero" value for c:crosses.
  Added unit test.

Change-Id: I3489908d4c3d4b41a04debfecf95e65f373649ce
2013-12-19 03:20:40 +01:00
909b27df48 remove unnecessary double calls to OUString constructor
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-12-17 11:49:04 +02:00
2b243ba51e Support regression curve name in ODF.
Change-Id: Ic065d63eee507906febfa15eb6d5ae1e7de58280
2013-11-24 19:43:17 +01:00
fc87d57f04 replace OUString::reverseCompareTo("xxx") with operator==
operator== with OUString and literal internally does a reverse-compare
(via OUString::equalsAsciiL) anyway, so no need to keep explicit calls
to OUString::reverseCompareTo with literal argument

Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
2013-11-22 11:23:05 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
ab5d1fbfb4 SAL_WARN_UNUSED com::sun::uno::Any
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
24cad6a649 Move MediaDescriptor from comphelper to unotools
...so it will be able to use SvtSecurityOptions internally.

Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14 11:13:24 +01:00
39c8da8c86 remove unnecessary sal_Unicode casts in XMLOFF module
Change-Id: I836c7a28d5ec9039c0b185e8db2aa6d01ac62566
Reviewed-on: https://gerrit.libreoffice.org/6665
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-11-14 06:16:12 +00:00
21123da759 xmloff: include <> for external includes
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
2013-11-11 22:37:28 -06:00
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
c87a8fc648 remove unnecessary use of OUString constructor in XMLOFF module
Change-Id: I3bb704d2b1063cd8c2c903cbfa237a7723c321d2
2013-11-07 13:22:56 +02:00
5285beeaa4 remove redundant calls to OUString constructor in if expression
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
68e39b840d Revert "transpose "data in rows" ranges for internal data provider, fdo#62057"
This reverts commit 14fa5488a829936275f79a7693b13da55114220e.

Conflicts:
	xmloff/source/chart/SchXMLTableContext.cxx
2013-11-02 20:44:38 +01:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
9239dc026a Fix for Chart Series Names
For Docx files, the chart series names (labels)
    were rendered incorrectly and hence exported incorrectly.
    In place of the correct label, the series name
    for next series was displayed.

Change-Id: I988571d76d9c706ac2f7693881198bb604ec3fa8
Change-Id: I52631bc62fce46a43298c284cb11c2e8916fabe3
Reviewed-on: https://gerrit.libreoffice.org/6350
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-30 11:21:00 +00:00
a45953ed7c fixincludeguards.sh: xmloff
Change-Id: I0e7d9daac1ad88fad8d240373e91ef323966bb47
2013-10-23 23:22:32 +02:00
d22ee5be41 sal_Bool to bool
Change-Id: I3db66690f9eaa809bcbf2257804d319aaec0f975
2013-10-13 02:35:48 +09:00
a9984d7744 CID#1079188 uninitialized member
Change-Id: I55c9f2d0d7a7c03dd9960a32a415398a194f8265
2013-10-08 14:41:40 +01:00
ad7b757a25 'ist' -> 'is' here and there.
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
2013-10-04 20:27:30 +02:00
ad53c5355d -Werror,-Wunused-variable
Change-Id: I5e70926bba93045528d6bea319ea31ed4d72ecf4
2013-10-02 17:38:24 +02:00
2ee4a04d61 Mark as const / static
Change-Id: Ib88b9e5533e56bb8b0b05c4e668299b033f17ffb
2013-09-29 22:34:40 +09:00
982f75e2c4 Mark as const / static
Change-Id: I4a70ed8b527096e35fa717b87efc4b6990f29121
2013-09-25 09:05:39 +09:00
d87cb77b42 Resolves: fdo#68431 style:font-name unknown in non autostyles in impress/draw
Change-Id: Ib904af4fac5659821ba3b5dbbf62370df8243001
Reviewed-on: https://gerrit.libreoffice.org/5810
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com>
Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-17 19:17:34 +00:00
2ef38f3739 sal_Bool to bool
Change-Id: I81767fda35b52e73bc78c07b660244a6808a0409
2013-09-17 23:37:22 +09:00
0825d0cb76 sal_Bool to bool
Change-Id: Id32780e5cb565e85f0366a91282ce085ed7d2f3c
2013-09-16 15:08:18 +02:00
396534403b Mark as const / static
Change-Id: I9bcf02b270200fd146d2bfee6f15ff1f9ad8888b
2013-09-10 02:50:04 +09:00
ccf7b15c0a -Werror=unused-but-set-variable second try
Change-Id: Ia8a9f60831d089ec04127213bb9ded31aa754bf7
2013-08-30 21:02:26 +02:00
47924a4656 Revert "-Werror=unused-but-set-variable bCategoriesApplied"
This reverts commit 72e019c4e301ef93bd1be985edd037d1e2b10e28.
2013-08-30 20:58:07 +02:00
72e019c4e3 -Werror=unused-but-set-variable bCategoriesApplied
Change-Id: I43c1f866847e2029bc1547dff3be3c1ed454d281
2013-08-30 20:47:27 +02:00
b090cbdf82 fdo#68663 don't blindly force categories when there are none
Change-Id: If52ea471ee3ca10e2f69d2fcd7b3ae0d5772bfc3
2013-08-30 18:36:55 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
7c02faf535 Properly hide implementation details.
If we are to hide, let's hide all.

Change-Id: Ic68926ee099ac80d2d477d68e3769a7203dfea6c
2013-08-16 21:31:44 -04:00
4f360266cd fdo#62475 removed pointless comments
Change-Id: I176886fbc9f3d9e2b8ad2308ac2b127d9c68d9a6
Reviewed-on: https://gerrit.libreoffice.org/5331
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-10 14:55:06 +00:00
30eb11ea79 cppcheck: Prefer prefix ++/-- operators for non-primitive types
Change-Id: If1bd91f28a96bd0eb53e4057e51db900f8b2c52b
2013-07-29 22:04:52 +02:00
15dc66c81a fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
Change-Id: I377902007445b0bce91491060f05fb8a9dbe3cd0
Reviewed-on: https://gerrit.libreoffice.org/5133
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 12:53:11 +00:00