Commit Graph

1356 Commits

Author SHA1 Message Date
7211162081 Clean up uses of rtl_ustr_ascii_shortenedCompareIgnoreAsciiCase_WithLength
Change-Id: Ie37614dac882bfe05f8ce595ae6b20326dce872e
2014-03-01 19:28:14 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e23ea87cb3 Remove visual noise from xmloff
Change-Id: I205d4e555f5b88654a90007eb7ac05bc7b00a904
Reviewed-on: https://gerrit.libreoffice.org/8346
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:32:34 -06:00
d5c59404be Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I773524536c0ed7bc34eb08cd35cfc77e83f722ba
2014-02-26 17:21:20 +09:00
4da81e4a0b xmloff: import style:rel-width/height for drawinglayer shapes
In case the underlying UNO object supports that, which is the case for
Writer. Export was already working before.

Change-Id: I4676c8349ebe1959da004d6e1a024a342da45049
2014-02-25 12:11:41 +01:00
b7259532d8 Remove unnecessary bool2any
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
f65b691d98 coverity#708702 Uninitialized scalar field
Change-Id: I89bab63349a5d89df0683eb36c3e69b6370e2ed1
2014-02-21 12:40:35 +00:00
94c87ec911 coverity#708704 Uninitialized scalar field
Change-Id: I135988584eb00e891bbc6410f3cf80f955f046ec
2014-02-21 12:40:35 +00:00
25f5b28f27 coverity#708705 Uninitialized scalar field
Change-Id: If48058d1f5cfb1c91c996f2921381b9c74aca04e
2014-02-21 12:40:35 +00:00
04a8c9eef4 coverity#708707 Uninitialized scalar field
Change-Id: I36432d090334440b596dfcc56339f10cb0b96426
2014-02-21 12:40:34 +00:00
b81e528803 coverity#708708 Uninitialized scalar field
Change-Id: I1b0f4ed24dd6c1281f2170e5b1199435ce1409f5
2014-02-21 12:40:34 +00:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
a519296007 Resolves: #i42894# added support for <presentation:animations>...
at import and creation

(cherry picked from commit 0f11a9d487744af6c50e9f1d547c22cd4bdeab48)

Conflicts:
	sd/source/core/EffectMigration.cxx
	sd/source/ui/dlg/animobjs.cxx
	sd/source/ui/unoidl/unoobj.cxx

Change-Id: Ib498bf718d40501cbab71a700342343df68a6ee9
2014-02-17 10:53:36 +00:00
8b34d05cb1 sal_Bool->bool
Change-Id: Iab0165ef642dfee5bd315fc1f42f4bad8e86aa47
2014-02-14 14:15:15 +02:00
f44024d1a0 sal_Bool->bool
Change-Id: Iadc9f9ef444fe36d58304c2d6219021173385118
2014-02-14 14:15:15 +02:00
17bb5abb6e Resolves: #i123879 dr3d rotation angle is degree in ODF1.2...
but radiant in AOO core

(cherry picked from commit 23b2b0b395537f4b5d0226f9ebb19dc38029ee55)

Conflicts:
	xmloff/source/draw/xexptran.cxx

Change-Id: I66cd482b2b237ca008c31b7738f9ea21502f3d45
2014-02-13 14:56:16 +00:00
746028f5c5 cid#705343 missing break in switch
Change-Id: I0fe11a71223c15937917a1a06a9078e856f0f67f
2014-02-12 08:59:08 +02:00
742d398731 cppcheck: Prefer prefix ++/-- operators for non-primitive types
Change-Id: I34446102091ef8be72d5aec603740db531fdd14b
2014-02-09 10:01:00 +01:00
45d3577bc5 fdo#74230: ODF export: write stroke and fill color in graphic defaults
The pool defaults for svg:stroke-color and draw:fill-color were changed
and while previously (effective, manually overridden) defaults were
written into ODF files, this was lost with the change; restore that.

(regression from c0eb5e7772c848806db8ab461f77f9549c1d8b2b)

Change-Id: Ibcd863260976aa42116175c7f19cb33760af986f
2014-02-07 18:56:39 +01:00
258e6f93e8 Resolves: #i124143# for draw:frame containing multiple draw:image...
and draw:glue-point it is necessary to move the GluePoints from the last
draw:image where they were automatically imported to the surviving one if these
are different

(cherry picked from commit c011af1087411a9bacd29cd479c807e698b2e92c)

Conflicts:
	xmloff/inc/xmloff/xmlictxt.hxx
	xmloff/source/core/xmlmultiimagehelper.cxx
	xmloff/source/draw/ximpshap.cxx
	xmloff/source/draw/ximpshap.hxx

Change-Id: I8f6c875767e9cbfee74838742401356df002b051
2014-02-05 11:36:35 +00:00
fa189d7447 bool improvements
Change-Id: I238ab0ebe54cc804c85356a3de9fbdcc396057d3
2014-01-28 20:26:18 +01:00
df2ad69d5d Resolves: fdo#73814 wrong name for drawing::PointSequenceSequence property
examining svx/source/unodraw/unoprov.cxx "Geometry" is a
indeed a drawing::PolyPolygonBezierCoords for the BezierShapes
and a drawing::PointSequenceSequence for the PolyShapes

regression since e44335abe006d05f0f915279605a03ef084116d6 because after
223f6b631c1b087754c0f9051fb55f029f2503ce we started getting
drawing::PointSequenceSequences in maPath which is the wrong type for the
argument to property "PolyPolygonBezier" for those shapes.  Which led me to
incorrectly assume that the all PolyPolygonBezier properties were named
"PolyPolygonBezier" which isn't the case.

so reverting the non maPath hunks of e44335abe006d05f0f915279605a03ef084116d6

Change-Id: I013a66778d11a472fc4567e53a9e17e73e2b91ce
2014-01-27 11:14:36 +00:00
b663316e83 Resolves: fdo#73355 reconcile legacy path bug detection
reconcile
 "223f6b631c1b087754c0f9051fb55f029f2503ce
    Resolves: #i123433# Detect pseudo-vertices at svg import..."
with
 "7a19798c73fd39d8d69ff6364f0696e68cdd1381"
    Compatibility option for incorrect relative moves after closePath (fdo#47406)
and
 "a2ee8055e9c136923f0244fe289cac6377933c31"
    Fix fdo#47406 incorrect relative moves after closePath

Change-Id: I1221099a40500aeb4165a3350d8ae2df1fd3111b
2014-01-24 12:56:09 +00:00
e7a99b3cde Flag bogus "true" with a FIXME
Change-Id: I0ff052ca980f33aa62333a26c70ba91e21ede56a
2014-01-17 18:45:14 +01:00
0c9d002ecd bool improvements
Change-Id: I42127c096aa4310e3c8b6c9b6487b4de63e7ac9a
2014-01-14 21:28:09 +01:00
6e12fb3be3 Consolidate XServiceInfo for classes derived from SvXMLImport
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
2014-01-09 10:12:19 +01:00
31911b3cdc Consolidate XServiceInfo for classes derived from SvXMLExport
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
2014-01-08 14:11:58 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
ebc1b2fe50 added bool bForExport parameter to XMLPropertySetMapper ctor
Set to true for export, false for import. If export true, an
XMLPropertyMapEntry with mbImportOnly==true is not added to the
mappings. This to be able to have more than one mappings for import
(for example a current extension namespace and the future namespace
proposed to the ODF-TC, or corrected typos in element or attribute
names), but map only to one entry on export, of course.

Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3
2013-12-20 03:26:57 +01:00
9dd7ee88bd prepared XMLPropertyMapEntry with mbImportOnly flag
Change-Id: Id5a54a591a42c836884af1fd09dc055f2fce6db5
2013-12-20 03:26:56 +01:00
909b27df48 remove unnecessary double calls to OUString constructor
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-12-17 11:49:04 +02:00
83e191e25d Do not use C++-UNO internal static_type functions in client code
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
c5b7a5fd19 fix equalsAscii conversion. Noticed in fdo#72391
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.

Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-09 12:53:18 +02:00
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
895e6e7bb7 Get rid of comphelper::UStringLess
...default std::less<OUString> is just fine.

Change-Id: Ib9d3c10f2817d757f3c19eb3d4607095883af91a
2013-12-05 18:36:22 +01:00
0c55303581 Get rid of DECLARE_STL_STDKEY_SET
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
2013-12-05 18:36:21 +01:00
f74149bc21 Fix some typos for "height"
Change-Id: Ibe1fdd7a63ff09097cfe053279d779592d389539
2013-11-25 23:03:11 +01:00
5668e73beb avmedia: Implement "block untrusted referer links" feature
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block
untrusted referer links' feature" for details.  This adds some further /*TODO?*/
comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not
blocked during a slideshow presentation.

Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-20 14:44:27 +01:00
363cc39717 convert equalsAsciiL calls to startWith calls where possible
Simplify code like:
    aStr.equalsAsciiL( "%", 1 )
to
    aStr.startsWith( "%" )

Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
306a39ec0d Resolves: fdo#62461 put preferred image first
with fallback after.

"Each child element of a frame is a different representation of the same
content. The order of content elements reflects the document author's
preference for rendering, with the first child element being preferred. That
means that consumers should render the first child element that they support. A
frame may contain multiple content elements, but shall contain at least one
content element."

Change-Id: If50062cad58f5b8561ad6bd8dc1a06956d2f444b
2013-11-15 16:04:34 +00:00
f0a9ca24fd rhbz#887420 Implement "block untrusted referer links" feature
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks
configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and
SvxBrushItem::GetGraphicObject.  Checking in additional places will probably be
necessary to block /all/ unwanted communication.  Also, some places marked
/*TODO?*/ currently pass in an empty referer (which is always considered
trusted) and will probably need to be adapted.

Ideally, Referer URIs would never be empty (and consistently use something like
<private:user> for cases where access is explicitly initiated by the user and
should never be blocked), but that's a very daunting task, so start small by
identifying the places that potentially need blocking and adding appropriate
Referer URIs there.  Also, Referer information should always be computed as
freshly as possible from the context in which an access attempt is made, but,
again, always carrying the information from the context all the way to the
relevant functions is a very daunting task, so for now store the information
upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...).

The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already
used to track macro execution, and there is one place in
SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked
by the user) is done that needs the current document's URI as Referer to check
execution of macro URIs but needs an empty (or <private:user>, see above)
Referer to not block non-macro URIs.  Special code has been added there to
handle that.

Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14 11:13:25 +01:00
39c8da8c86 remove unnecessary sal_Unicode casts in XMLOFF module
Change-Id: I836c7a28d5ec9039c0b185e8db2aa6d01ac62566
Reviewed-on: https://gerrit.libreoffice.org/6665
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-11-14 06:16:12 +00:00
21123da759 xmloff: include <> for external includes
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
2013-11-11 22:37:28 -06:00
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
c87a8fc648 remove unnecessary use of OUString constructor in XMLOFF module
Change-Id: I3bb704d2b1063cd8c2c903cbfa237a7723c321d2
2013-11-07 13:22:56 +02:00
f689578dc4 Resolves: #i123542# corrected ODF XML export of 3D cube and sphere
(cherry picked from commit a8cc15c001ac76c0d320837cc4cdf65ecb7fc923)

Conflicts:
	xmloff/source/draw/shapeexport2.cxx
	xmloff/source/draw/shapeexport3.cxx

Change-Id: I35f7817f3ea95177dd3aa633b9cbb1b5703f08a0
2013-11-05 15:13:20 +00:00
0794e9ec93 corrected export of polygons with text
(cherry picked from commit c0f65b29f8028ab750c8caac033645c3da3cf2f5)

Conflicts:
	xmloff/source/draw/shapeexport2.cxx

Change-Id: Ic8da384d094ce735ecba51b282de7a697558e51f
2013-11-05 15:00:18 +00:00