Commit Graph

3489 Commits

Author SHA1 Message Date
059f5a95b2 loplugin: cstylecast
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
2014-10-02 07:37:19 +02:00
fa537124ac loplugin: cstylecast
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
2014-10-01 13:08:41 +02:00
dc7ca91a04 avoid calling OUString::copy() with length being -1
Which asserts in dbgutil build.

Change-Id: I0f8205ae98c5a57c430b7d8a574e4c0019855841
2014-10-01 11:45:01 +02:00
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
4e26b91568 remove unnecessary casts in misc calls to SvStream.Write*
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26 15:27:18 +02:00
5cefde06ea remove unnecessary casts in calls to SvStream.WriteUInt32
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26 15:27:17 +02:00
04fd62096f remove unnecessary casts in calls to SvStream.WriteInt32
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26 15:27:17 +02:00
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26 15:26:48 +02:00
dedfa972bc remove unnecessary casts in calls to SvStream.WriteInt16
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26 15:26:48 +02:00
bec72dd34f remove unnecessary casts in calls to SvStream.WriteUChar
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26 15:26:19 +02:00
c476a84abd remove pointless comments
Change-Id: I8edfe830b8f6ca7f1809332870e06d1d286b90e8
2014-09-26 15:25:40 +02:00
8f684e21de remove unnecessary static_cast's
left over from our conversion of the SvStream output operators
to more specific methods
e Please enter the commit message for your changes. Lines starting

Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-26 15:25:40 +02:00
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
764e3016b6 fdo#84086 Fix assorted use-after-free bugs
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65
Reviewed-on: https://gerrit.libreoffice.org/11553
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-22 05:15:53 +00:00
234b5de79f vba: calm down bool -> long casting concerns.
Change-Id: Ib32a66d891242701d2f5c55519e5c52a6dd3df3c
2014-09-19 20:15:09 +01:00
857f72dfe3 vba - disable Currency test / invocation on master.
We're missing an effective SbxCURRENCY conversion here.

Change-Id: Id6530ed3a93623b31089304f3451d9693ab4f3af
2014-09-19 15:31:07 +01:00
01e14011e5 vba: add a different variant of the same compatibility function.
Change-Id: I92bc1dbceea2f10cbb055d97f68b33e575d9be11
2014-09-19 15:31:07 +01:00
19ee058a21 vba: initial impl. of compatibility methods.
Change-Id: Iebc25f1730766e96d2ad6921a8b4d2ea880c63f3
2014-09-19 15:31:06 +01:00
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
03043589c3 Clean up StorageMode parameter of SotStorage::OpenSotStorage
...which was only used to transport either STORAGE_TRANSACTED or sal_False
(i.e., 0, meaning "not STORAGE_TRANSACTED").

Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-15 18:22:37 +02:00
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06 15:47:44 -05:00
a7fbabdacd fdo#52076 remove Library dir when no library
when saving to same storage (in place)
we already did that when empty "Standard" was the only library,
but not when there was no library...
Cannot get through that state in through UI, but possible through scripting.

Change-Id: I0f1129e034ac31b3eaf6bd388a03aee5aae5b87e
2014-09-04 12:06:51 +02:00
513d95f318 detect if Standard is only library to *save*
as opposed to only library at all

Change-Id: I23bebfe7d156e1f4a60bc5f265a3cf9d295f3e4a
2014-09-04 12:06:50 +02:00
6846c1c88e add const qualifier
Change-Id: I88d61668b465e505cfa245dd17893828aaaecaa8
2014-09-04 12:06:50 +02:00
37b9ea92ba convert SBX flag bits to type-safe enum
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-26 04:30:03 -05:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
c319ccfc37 Revert "Simplify ImplRepository::impl_getLocationForModel return type"
This reverts commit 72305ed49d4c9ba968d7bf6d8d5ae564bb92147d, which was bogus,
cf. the comment in ImplRepository::getDocumentBasicManager about recursive
calls.
2014-08-22 09:10:40 +02:00
73b2ea1dfa Remove BasicManagerCleaner
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22 09:06:55 +02:00
72305ed49d Simplify ImplRepository::impl_getLocationForModel return type
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22 09:03:27 +02:00
8c5834d5cb Remove trivial typedef, to make code more obvious
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-22 08:59:01 +02:00
d718c1f65f coverity#1202729 - ensure we have exactly a one dimensional array.
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
2014-08-21 00:39:45 +01:00
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
d438c470d7 coverity#1231668 Unchecked return value
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
2014-08-17 16:39:21 +01:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
d9baa2b06e -Werror,-Wundefined-bool-conversion
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-11 16:00:46 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
e5b0aa9a7c basic: -Werror=sign-compare
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29 18:06:06 +02:00
ae7ca8b957 fdo#46037: remove unused comphelper/configurationhelper.hxx
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 15:40:41 +00:00
c694837aea convert linked list to std::vector in SbxDimArray
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23
Reviewed-on: https://gerrit.libreoffice.org/10298
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 15:38:56 +00:00
1392a88c25 fdo#52076 remove empty library instead of writing it out empty
Change-Id: Id4fd8c4f34e8ed07044eb428049731c4b9b694ca
Reviewed-on: https://gerrit.libreoffice.org/10507
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-07-24 15:34:09 +00:00
ea5ef0a72e Drop unused #includes
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
2014-07-24 01:06:15 +09:00
50725318e4 Drop an unused function
Change-Id: I59eb46f9d57e9fd72ed86c972685be93d154e3c7
2014-07-18 23:24:58 +09:00
fffc9b2f26 fdo#75757: remove inheritance to std::vector
... which was introduced at 2110397670695991b3a5cd28a15ba0ffd2a3a611.

Change-Id: If0f634b29e1891574267edf8cc07b24d07a9406c
Reviewed-on: https://gerrit.libreoffice.org/10363
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-17 21:29:50 +00:00
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
d97b5e420f Avoid possible memory leaks in case of exceptions
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
2014-07-16 18:01:39 +09:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
eb9b890bc9 DBG_ASSERT->assert when followed by dereference
Change-Id: I9390228721df1b713d8cf2e719854b74d6b639c8
2014-07-06 21:06:06 +01:00
c80be30203 coverity#706241 Uncaught exception
we've already checked to see if the element exists, so
we know that its not there.

Change-Id: I538c0d48a883d478e4c748d222b21958d083c049
2014-07-03 08:29:41 +01:00
b35f3dfb1a coverity#706240 Uncaught exception
Change-Id: Ie31f5e1ff74ff8b9f35d7ce08e1f02a780375890
2014-07-01 16:43:05 +01:00
42fcd888ae coverity#735397 dead code
Change-Id: If8d82a39af7a506f42b6c13d8408ffc479b564e7
2014-07-01 12:44:06 +02:00