wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
379,950 Commits 5 Branches 0 Tags
cf0c04a428754dfd5aa477cebc5441bc74e27005
Commit Graph

460 Commits

Author SHA1 Message Date
Julien Nabet
f0208db49d cppcheck: fix some redundantCondition warnings 
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2
Reviewed-on: https://gerrit.libreoffice.org/18353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-09-05 13:42:02 +00:00
Damjan Jovanovic
9e318c0977 Resolves: #i112383# CLng("&HFFFFFFFF") fails on 64-bits... 
rather than returning -1

Found-by: andrew
Patch-by: Damjan Jovanovic

(cherry picked from commit 175afdcb151d9ce1238dc9fec59f2dfc2eb07345)

Change-Id: I996bbfa82b10716318944f390ea53e0a5ae7c89c
 2015-08-28 10:32:01 +01:00
Stephan Bergmann
43c00bc489 Clean up aEmptyStr 
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
 2015-08-26 21:24:29 +02:00
Noel Grandin
4f87e9da41 loplugin: defaultparams 
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
 2015-08-11 09:48:17 +02:00
Noel Grandin
01075a7274 inline the "old" SbxErr constants 
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
 2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Adolfo Jayme Barrientos
3e926736c7 Miscellaneous typos 
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
 2015-07-21 04:53:48 -05:00
Noel Grandin
b4ee16da65 com::sun::star->css in basic 
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 09:39:36 +00:00
Matteo Casalin
f7a2795c88 sal_uIntPtr to sal_uInt32, for consistency 
Change-Id: Ib78dce61e8fb8c8e3bf8c7a2b02966100a4db0e8
 2015-07-19 17:12:32 +02:00
Matteo Casalin
c1edceb2f3 sal_uInt16 to sal_Int32 with some cleanup 
Change-Id: Ib6e42702dd1ce29645215114b26286f05ccc1332
 2015-07-19 17:12:32 +02:00
Michael Stahl
15f32b5a1e basic: replace boost::ptr_vector with std::vector<std::unique_ptr>> 
Change-Id: I96ea97c1df7903a28387d8e1171075be55a80ca7
 2015-07-17 20:26:59 +02:00
Noel Grandin
22b094f5d8 loplugin:unusedmethods basic 
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1
Reviewed-on: https://gerrit.libreoffice.org/17044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-15 09:07:05 +00:00
Noel Grandin
07d85c4499 remove SFX_NOTIFY macro 
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects

Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
 2015-06-24 12:06:34 +02:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]> 
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-06-17 15:50:45 +00:00
Stephan Bergmann
761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Caolán McNamara
8e22cd40ec cppcheck: noExplicitConstructor 
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
 2015-06-02 08:57:56 +01:00
Noel Grandin
afcf1ecee1 loplugin:loopvartoosmall 
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
 2015-05-29 08:48:41 +02:00
Andrea Gelmini
5b1337f7b2 tdf#62475: partial handmade fixes 
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2015-05-15 17:55:15 +00:00
Stephan Bergmann
ef6877c167 loplugin:cstylecast: nop between pointer types of exactly same spelling 
Change-Id: I1e4363f917a978434fb11368918435da12531dc6
 2015-05-11 12:49:03 +02:00
Stephan Bergmann
9f23260105 SvStream: WriteUChar -> WriteBool 
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
 2015-04-17 15:20:43 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
0511c86791 const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: If774a3b4e2e993d26dd9b5777a55665a330b2abe
 2015-03-26 15:33:28 +01:00
Noel Grandin
b2d2d72a7e loplugin:constantfunction: basic 
Change-Id: I1c9a33cefb68bec978b2a922c2c3ef00f2a7a1b4
 2015-03-24 10:31:17 +02:00
Caolán McNamara
34d6ec2c6e cppcheck: variableScope 
Change-Id: Ie77a988956927475ea384c36664ca7c3dd00b2a7
 2015-03-09 16:27:47 +00:00
Julien Nabet
5f6fcb4e7c Typos 
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
 2015-03-08 16:45:30 +01:00
LeMoyne Castle
3b585737ff convert error number to string 
BASIC error type was printing as "Error "+ odd char
 instead of "Error " + error number

Change-Id: I7407833626d6117f932cc29c6dab1a8a64c50b5a
Reviewed-on: https://gerrit.libreoffice.org/14776
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2015-03-07 05:57:20 +00:00
Noel Grandin
2f928b2d09 remove NUMBERFORMAT_ constants 
.. in favour of just using the underlying constants from
css::util::NumberFormat

Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
 2015-02-25 10:34:27 +02:00
Juan Picca
6e1d28efb3 fdo#39440: replace C-style cast's 
* Add get() method to tools::SvRef

Change-Id: I3825852176c9c37f3ee21f4fd57328b1c7451951
Reviewed-on: https://gerrit.libreoffice.org/14268
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-02-05 07:24:30 +00:00
Caolán McNamara
309574394b callcatcher: large newly detected unused methods post de-virtualization 
i.e lots now able to be detected after...

commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date:   Tue Jan 20 12:38:10 2015 +0200

    new loplugin: change virtual methods to non-virtual

    Where we can prove that the virtual method is never overriden.

    In the case of pure-virtual methods, we remove the method entirely.
    Sometimes this leads to entire methods and fields being
    eliminated.

Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
 2015-01-29 23:42:26 +00:00
Stephan Bergmann
4130c64355 Some more loplugin:cstylecast: basic 
Change-Id: Ib22bc7408d333a7080fa44c9c3ac9535ccf00752
 2015-01-20 09:06:45 +01:00
Noel Grandin
2f69f6efa0 remove unnecessary parentheses 
left over from "SVStream operator>> to Write method" conversion

Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
 2015-01-16 08:08:44 +02:00
Tsutomu Uchino
a272f5b7b3 Resolves: #i63614# fix strange type mismatch when Iif function is used 
Second or later compilation uses value type returned by previous execution of code.
Use the defined type as return value of the runtime function of Basic always.

(cherry picked from commit 7470c682e136a4a89c1e9474bbc79b2d61f31048)

Conflicts:
	basic/inc/basic/sbxmeth.hxx
	basic/inc/basic/sbxobj.hxx
	basic/source/runtime/stdobj.cxx
	basic/source/sbx/sbxobj.cxx

Change-Id: I3064e8403286a9c1401ef658bf139bedeae11f17
 2015-01-09 09:24:44 +00:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load 
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
 2015-01-09 00:00:47 +01:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants. 
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
 2015-01-08 10:39:36 +02:00
Nathan Yee
a509a8d995 Resolves: fdo#87003 Kill BOOST_FOREACH on master 
use C++11s range-based for() loops instead

Conflicts:
	sd/source/filter/eppt/pptx-epptooxml.cxx

Change-Id: I0868eb345932c05b7e40b087035da252b99bf0b9
Reviewed-on: https://gerrit.libreoffice.org/13714
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-01-05 09:34:08 +00:00
Stephan Bergmann
39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Stephan Bergmann
898c414700 basic: Use appropriate OUString functions on string constants 
Change-Id: Ied7e5eba39672363065083493bd5e60449fda371
 2014-12-12 10:21:45 +01:00
Caolán McNamara
19d0950451 Resolves: fdo#86843 avoid getting deleted before finishing Broadcast 
Change-Id: I19181f9e2fbd5f906e6e5d807b1b2483e7881cf0
 2014-12-09 14:13:26 +00:00
Michael Stahl
28adfcdcbc fdo#84935: basic: avoid silly SolarMutex asserts on exit on Mac 
Change-Id: If22b8ff962d2b68130176de3b7b9eccacfc850dc
 2014-10-23 21:30:45 +02:00
Michael Stahl
51906611ab basic: move SbxAppData to a BasicDLL member 
... so it is deleted by ~SfxApplication.

Change-Id: I161bd92eb9b5082d1fdeea603921d0372a4d97e6
 2014-10-23 21:30:45 +02:00
Tor Lillqvist
9ecac3874d Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTING 
Feature test macros that govern conditional compilation should be
defined in config_*.h include files, not on the compilation command
line.

Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
 2014-10-22 09:30:23 +03:00
Eike Rathke
04a810cee4 back out more wrong and confusing tools::Time comment changes 
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...

Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
 2014-10-08 14:24:21 +02:00
Noel Grandin
c625525ddc rename SvRef::AddRef to AddFirstRef 
to make it's intended purpose clearly distinguishable from AddNextRef

Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-03 05:25:41 +00:00
Noel Grandin
059f5a95b2 loplugin: cstylecast 
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
 2014-10-02 07:37:19 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Noel Grandin
5cefde06ea remove unnecessary casts in calls to SvStream.WriteUInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
 2014-09-26 15:27:17 +02:00
Noel Grandin
04fd62096f remove unnecessary casts in calls to SvStream.WriteInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
 2014-09-26 15:27:17 +02:00
Noel Grandin
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
 2014-09-26 15:26:48 +02:00
Noel Grandin
dedfa972bc remove unnecessary casts in calls to SvStream.WriteInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
 2014-09-26 15:26:48 +02:00
Noel Grandin
bec72dd34f remove unnecessary casts in calls to SvStream.WriteUChar 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
 2014-09-26 15:26:19 +02:00