wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
379,950 Commits 5 Branches 0 Tags
cf0c04a428754dfd5aa477cebc5441bc74e27005
Commit Graph

280 Commits

Author SHA1 Message Date
Andrea Gelmini
465489d97a Fix typos 
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:43:46 +00:00
Andrea Gelmini
5d5dc059cb Fix typos 
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:35:58 +00:00
Andrea Gelmini
69c88a32aa Fix typos 
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:28:31 +00:00
Andrea Gelmini
aade27554d Fix typos 
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-22 12:36:21 +00:00
Noel Grandin
754ade38dd speed up Java unit tests by removing sleeps 
and replacing them with a call to XToolkitExperimental::
processEventsToIdle

Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932
Reviewed-on: https://gerrit.libreoffice.org/16201
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-11 06:47:23 +00:00
Noel Grandin
275f0c7b25 Let JUnit take care of exceptions 
Inspired by commit
4dd0ac62855c5b9382cac004c7eebb9bed983a2b

Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960
Reviewed-on: https://gerrit.libreoffice.org/16094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-05 13:17:50 +00:00
Noel Grandin
04cadb3191 java: remove some unused code 
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
 2015-04-20 11:18:22 +02:00
Julien Nabet
25d3c618d8 Typo: formated->formatted 
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
 2015-03-25 21:12:16 +01:00
Julien Nabet
ca7f62c826 Typos 
Change-Id: Ic03fb2ee6470eac6034be13908dd9ec92cf175b6
 2015-02-26 23:03:14 +01:00
Noel Grandin
a7d1292194 java: remove some dead properties 
Change-Id: I96adb2941c483ec08c752f35e35cf9ceb941971d
 2015-01-13 08:42:56 +02:00
Noel Grandin
7e1dfc0928 java: inline the CheckAPI properties 
no need to make this configurable

Change-Id: I0ab149317f4660fc7ebc4c43342d20a386bdbc5f
 2015-01-13 08:42:56 +02:00
Noel Grandin
c55f945e4b java: move DEFAULT_SHORT_WAIT_MS to util.utils 
so I can turn PopertyNames into an enum

Change-Id: I939a83c0962813302a3653e75976147b2300cb18
 2015-01-13 08:42:55 +02:00
Noel Grandin
09330056a0 java: simplify sleeping and waiting in tests 
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere

Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
 2015-01-12 08:36:17 +02:00
Noel Grandin
4bf4e3d407 java: no need to instantiate the AccessibilityTools object 
since all of it's methods and fields are static.

Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
 2015-01-12 08:36:17 +02:00
Noel Grandin
3757c03fc8 java: simplify array creation 
and remove the need to worry about keeping indexes correct

Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
 2015-01-09 15:10:51 +02:00
Caolán McNamara
8ab4d2f29f drop crashrep unused since start of LibreOffice 
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-01-07 11:41:32 +00:00
Noel Grandin
566f16a2fd java: unnecessary imports 
found by CodePro

Change-Id: If1b75e43f81d70984422e437147048a491395b66
 2015-01-05 10:15:13 +02:00
Noel Grandin
10039462df java: remove more dead code 
found by looking for unused parameters (in Eclipse)

Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
 2015-01-05 09:59:03 +02:00
Noel Grandin
46540d08b1 java: these fields can become local variables 
found by PMD

Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
 2015-01-05 08:23:30 +02:00
Noel Grandin
43cc8ad33e java: remove dead code 
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
 2015-01-05 08:23:29 +02:00
Noel Grandin
2d82619a52 java: static fields that should not be static 
Found by FindBugs.

Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
 2014-12-19 10:41:58 +02:00
Noel Grandin
cba3956750 java: this does not need to be a Thread 
It is just being used as a Runnable

Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
 2014-12-19 10:41:54 +02:00
Noel Grandin
7557f23b31 java: reduce visibility of fields and methods 
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-11 06:09:03 +00:00
Noel Grandin
ffffc526e3 java: remove comment noise 
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6
Reviewed-on: https://gerrit.libreoffice.org/13408
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-10 08:06:38 +00:00
Noel Grandin
9adb820158 java: simplify the getMSF() methods 
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-10 08:04:58 +00:00
Noel Grandin
58eab57648 java: final fields that can be static 
found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-25 06:06:48 +00:00
Noel Grandin
1658c017a2 java,framework: remove unused vars and parameters 
Change-Id: I7df5ff730436b95cb93af9f813d7bc572da2b951
Reviewed-on: https://gerrit.libreoffice.org/13098
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-25 05:05:24 +00:00
Noel Grandin
fe095dada4 java,qadev: remove unused parameters and local vars 
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873
Reviewed-on: https://gerrit.libreoffice.org/13097
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-11-24 20:45:17 +00:00
Noel Grandin
0063cf2856 java: make fields final where possible 
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
 2014-11-18 12:44:28 +02:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible 
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:03:29 +00:00
Noel Grandin
03c7c26cbe java: final fields that can be static 
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
 2014-10-17 08:26:21 +02:00
Noel Grandin
9341bf3dc3 java: when rethrowing, store the original exception 
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
 2014-10-16 12:27:15 +02:00
Noel Grandin
f635ba0684 java: remove some unnecessary intermediary object creation 
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
 2014-10-07 13:20:01 +02:00
Noel Grandin
83636d2c09 java: when rethrowing exceptions, store the original cause 
so that we get a nice complete stacktrace when it hits the final
handler

Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
 2014-09-25 13:47:25 +02:00
Noel Grandin
c0415d5f1e java: remove unnecessary constructor declarations 
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
 2014-08-20 12:12:15 +02:00
Noel Grandin
8c9fdc4a96 java: remove modifiers implied by the context 
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
 2014-08-20 11:45:28 +02:00
Noel Grandin
2922a967a1 java: Avoid naming non-fields with the prefix m_ 
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
 2014-08-20 10:35:53 +02:00
Noel Grandin
4b4bff3402 java: no need to instantiate String objects directly 
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
 2014-08-19 14:57:18 +02:00
Noel Grandin
0764292c5d java: use 'Short.valueOf' instead of 'new Short' 
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
 2014-08-19 14:57:18 +02:00
Noel Grandin
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long' 
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
 2014-08-19 14:57:17 +02:00
Noel Grandin
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer' 
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
 2014-08-19 14:57:17 +02:00
Noel Grandin
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects 
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
 2014-08-19 14:57:16 +02:00
Noel Grandin
56ef5533fc java: classes in java.lang package do not need to be fully qualified 
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
 2014-08-19 14:57:16 +02:00
Noel Grandin
3a8d351988 java: remove unused methods 
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
 2014-08-19 14:57:13 +02:00
Noel Grandin
0d916bb240 java: remove unused imports 
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
 2014-08-14 10:59:49 +02:00
Noel Grandin
ac5954d7c5 java: remove commented out code 
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
 2014-08-14 10:59:48 +02:00
Noel Grandin
5ce80c9728 remove dead java constants 
found by UCDetector

Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
 2014-08-13 13:34:43 +02:00
Noel Grandin
34bcf9b498 java: remove dead methods 
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
 2014-08-13 10:24:10 +02:00
Noel Grandin
8583da1e93 java: remove unused fields 
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
 2014-08-13 08:49:24 +02:00