e9b7506415
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
2015-08-31 08:03:15 +02:00
bd8b93fdff
make PostUserEvent Link<> typed
...
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
edebac799d
cosmetic clean-up
...
Change-Id: I7e6689e07873dcb85c2bf1aac0db2ecddc01fe4b
2015-08-28 02:03:28 +02:00
431f2ce818
framework: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57
Reviewed-on: https://gerrit.libreoffice.org/17734
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-14 10:46:14 +00:00
f1639b2150
loplugin: defaultparams
...
Change-Id: I44772f7c26568353d02278486a8e960f40af6354
2015-08-11 09:48:17 +02:00
9e28cc8ca7
convert WindowAlign to scoped enum
...
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-24 09:52:08 +02:00
269bf161e6
loplugin:unusedmethods framework
...
Change-Id: Ibfeb0ef753a083f458c84f446f0729f05c73e2d6
Reviewed-on: https://gerrit.libreoffice.org/17060
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-15 11:33:21 +00:00
7aa9f04538
do not include boost/utility.hpp
...
It just includes a bunch of other boost headers; mostly we need
boost/noncopyable.hpp so include that directly.
This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp
completely, which is the 2nd biggest header after ustring.hxx.
Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10 23:25:22 +02:00
fa6db8cff1
coverity#1308527 Uncaught exception
...
Change-Id: I7ddc62f0ee005652dba62adc359959e1eb09a41e
2015-06-28 17:55:55 +01:00
8e1ad96626
Some missing SolarMutexGuard around VclPtr acquire/release
...
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called. Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)
Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-17 15:24:19 +02:00
01532b1ab8
Fix typos
...
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:05:58 +00:00
a1a5588b1b
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I4a72a60d621c65e63310ef70b991f9c86f00494d
2015-06-08 16:25:25 +02:00
b419da0f53
convert SHOW constants to scoped enum
...
Change-Id: I2712a0901049885502cade31f9757f712048bb33
2015-05-25 10:31:35 +02:00
24600dcf31
loplugin:constantfunction
...
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-22 09:59:46 +02:00
9bb254fc85
NOINSTANCE is implied now in IMPL_STATIC_LINK...
...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
5eb6bd4db7
lopluign:staticmethods: Handle DECL_LINK
...
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08 19:15:32 +02:00
8cafd08278
Use typed Timer::SetTimeoutHdl Link
...
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
3ead3ad52f
Gradually typed Link
...
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
e19cd844be
Rephrase comparisons between bool and sal_Bool
...
...to cater for forthcoming loplugin:implicitboolconversion improvements
Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-28 10:21:01 +02:00
ac1130130b
Use comphelper::SequenceAsHashMap::getUnpackedValueOrDefault<bool>
...
...instead of ...<sal_Bool>; plus ensuing loplugin:implicitboolconversion
Change-Id: I5400e9d3175b9fe9b6088d37fe6bf3275314d7d0
2015-04-23 17:03:58 +02:00
62532bf14e
framework: convert new to ::Create.
...
Change-Id: I436ae2e58b3f79e7a0418d25532f275f5c16154f
2015-04-17 21:55:53 +01:00
5ed0006b38
Don't enable toolbar layout manager using LibreOfficeKit
...
LibreOfficeKit doesn't need ToolbarLayoutManager.
Change-Id: I10ec8733448407b0a93ca63e444f914f05410eff
2015-04-17 12:11:00 +02:00
122577ba78
framework: fix for toolkit updates.
...
Change-Id: I1629cb6574361d6dd855140d61f38229ab593ed7
2015-04-10 11:04:36 +01:00
e4c1c0829a
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: I320895b73f101986e1aab95668c7b76e04315aab
2015-04-01 08:39:26 +02:00
3c22024f41
Resolves: tdf#90256 repair invalid docking positions
...
Change-Id: If144a867dc4be6975c08cd1eea9ebb540975aafc
2015-03-26 13:37:35 +00:00
5a308b1239
V801: Decreased performance
...
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
32f95a3551
V813: Decreased performance
...
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-04 13:07:40 +00:00
45ec1d9b56
brute-force find-and-remove of unused #define constants.
...
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
bae855e667
fdo#84938: replace BUTTONTYPE_ constants with 'enum class'
...
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-06 10:59:40 +02:00
38b8c1e880
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I57f336c6ab3c418eac82397edeadecb4c1b168a7
Reviewed-on: https://gerrit.libreoffice.org/13495
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-12-16 20:42:30 +00:00
1367e4b2af
changed timers to idle
...
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09 12:35:09 +00:00
439c8eba11
changed some timer to idle
...
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09 12:35:07 +00:00
f0a6ec25d0
changed timers to idle
...
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09 12:35:03 +00:00
d1684e16b5
changed some timer to idle
...
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09 12:35:03 +00:00
e5f67b2e94
changed timers to idle
...
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09 12:34:57 +00:00
18102201f4
changed some timer to idle
...
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09 12:34:51 +00:00
16e1fbb9aa
Avoid automatic toolbars in the non-desktop case
...
Change-Id: I9e5bff735b0035c147e10ae066da3a4873d66749
2014-12-04 23:04:24 +01:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
fc0d57b7af
Revert "use the new OUString::fromUtf8 method"
...
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
05050cdb23
use the new OUString::fromUtf8 method
...
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
cf33ce9667
coverity#736876 Negative array index read
...
Change-Id: I5e0f2e4633286b320abfb6735232b57aedd3a5b3
2014-10-23 14:54:52 +01:00
ddfb875ba2
coverity#1242768 Unused value
...
Change-Id: Ida66a4a4d00caa49e993938f86e357e4351a60c5
2014-10-02 14:49:00 +01:00
2b08019e2a
coverity#1242970 Result is not floating-point
...
Change-Id: Icd0b04a2b8d9250418dfec95668fa6c496e45e5e
2014-10-02 14:48:46 +01:00
1777c425fe
loplugin: cstylecast
...
Change-Id: I4a8786f335b5f9a14116c546d32f1ff6cff99930
2014-10-02 07:37:19 +02:00
787ca46d94
loplugin: cstylecast
...
Change-Id: Idac41288539ff171e1c9fb0e12b172a311878ed6
2014-10-01 13:08:42 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
8da21eca45
vcl: Allow creation of button content from action name (.uno: commands).
...
Change-Id: If4b2aef59d45a848fb77de9e1b7bf80d49548a75
2014-09-22 11:57:00 +02:00
5278a0e3a7
fdo#81237: OpenGL window is not resized by view change
...
Reproduce:
- Create a 2D OpenGL chart
- Step out from edit mode
- Zoom in / zoom out
Behavior
- Chart window is not resized, it has a constant size.
When we step out from chart edit mode the chart becomes
an inplace active object (instead of UI active) which means
the m_xDockingAreaAcceptor is removed. On the other hand
it seems we don't actually use this m_xDockingAreaAcceptor here,
so don't need to check whether it exists.
Change-Id: I056109b6e5cac28cdd2aeb8fabd9190413a16ed5
2014-09-21 15:49:54 +02:00
d22edd44b5
vcl: It's a close button, there is no such a thing as a 'closer'.
...
Clean up at least vcl + what depends on that, but unfortunately there are
still some "Closer"'s left elsewhere...
Change-Id: I019c863d07ee62d701ff01c8d871334012c105f1
2014-09-12 08:41:29 +02:00
