6c820a2816
basic: _FIND_STATIC likely not an error in SbiExprNode::GenElement()
...
All other _FIND_* are explicitly not errors, and probably CWS npower10
forgot to adapt this assertion.
Change-Id: If721c275eb1bc31d76140898602b41e11c23d82e
Reviewed-on: https://gerrit.libreoffice.org/7863
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2014-02-05 10:16:09 +00:00
a5090ccf75
Related: #i123862# use O*String's isEmpty() method...
...
to check for emptiness in modules starting with 'b'
Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 87204b0f4062ef8fc8f138ad15f4378da609d4e2)
Conflicts:
basctl/source/basicide/baside2.cxx
basctl/source/basicide/bastype2.cxx
basctl/source/basicide/localizationmgr.cxx
basctl/source/dlged/dlgedobj.cxx
basic/source/basmgr/basmgr.cxx
basic/source/basmgr/vbahelper.cxx
basic/source/classes/sbunoobj.cxx
basic/source/comp/sbcomp.cxx
basic/source/runtime/iosys.cxx
basic/source/runtime/methods.cxx
basic/source/runtime/methods1.cxx
basic/source/runtime/step2.cxx
basic/source/uno/namecont.cxx
basic/source/uno/scriptcont.cxx
binaryurp/source/bridge.cxx
binaryurp/source/bridgefactory.cxx
binaryurp/source/reader.cxx
binaryurp/source/unmarshal.cxx
bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
bridges/source/cpp_uno/shared/vtablefactory.cxx
bridges/source/jni_uno/jni_data.cxx
Change-Id: I37bd84e0a1d6426759dba81854faf32c88147fe1
2014-02-04 12:47:59 +00:00
326bec33e0
some more continuous corrections
2014-02-03 14:01:40 +01:00
25d089e09d
fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter.
...
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab
Reviewed-on: https://gerrit.libreoffice.org/7731
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-30 10:48:40 +00:00
f96f38f8f8
bool improvements
...
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
2014-01-28 20:26:30 +01:00
5c734f440a
coverity#738565 Uninitialized scalar field
...
Change-Id: Ie969773240bd7ecdcf56d7c533010d0aa32872c8
2014-01-28 11:29:15 +00:00
8cccfb8f8f
coverity#441077 Dereference after null check
...
Change-Id: Ia6a04846068e0bc500942e9a2dc6ee2e72d9d527
2014-01-27 14:38:39 +00:00
4e8692a3bf
coverity#984078 Uninitialized scalar field
...
Change-Id: I36b4a8c7d047f392fdbbe167a0e801b9a6d80b03
2014-01-27 14:38:38 +00:00
3848819cac
coverity#707652 Uninitialized scalar field
...
Change-Id: I6d561955454b0619255296704812b41a10ffe962
2014-01-27 14:38:38 +00:00
fd7dbe5a15
coverity#707651 Uninitialized scalar field
...
Change-Id: I6e497d60e72efd1df6c271ce6bf8d5e46ba09ea7
2014-01-27 14:38:38 +00:00
81926e66d1
coverity#707650 Uninitialized pointer field
...
Change-Id: I6843ce28f3e1395a2ab3c5515f393cce5096674b
2014-01-27 14:38:38 +00:00
7acea5ae4c
coverity#707649 Uninitialized scalar field
...
Change-Id: I1a95a051463860dc9c7b087bfaf17f3b70f297ee
2014-01-27 14:38:37 +00:00
a8d7c510b4
coverity#707629 Uninitialized scalar field
...
Change-Id: I0e3d9d4dad46e9b88be11cc9ac2c7d3c0c4b6f6e
2014-01-27 14:38:37 +00:00
7593b006df
coverity#736909 Allocation too small for type
...
Change-Id: I330ebdfd94d0c30b40e180e307d7543c09fd334b
2014-01-24 15:27:57 +00:00
28793abda5
coverity#736908 Allocation too small for type
...
Change-Id: Ic41c5071957f5e95322971f8ec3ef864edecdb20
2014-01-24 15:26:47 +00:00
fcf23e8a44
coverity#706117 Allocation too small for type
...
Change-Id: I1bb2bd26e533cf5b7de5225f0bcf323446e69f63
2014-01-24 15:22:55 +00:00
16a2e90335
remove SvStream::operator<< methods
...
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-22 22:00:47 +00:00
d803483f6a
convert more SvStream::operator<< calls
...
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.
Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-01-22 22:00:39 +00:00
4eda1a0293
Add some unit-tests for Mid vb function (includes fdo#73771)
...
Change-Id: Ib5ee18207897cbe16a818096769cdb055dc9dad7
Reviewed-on: https://gerrit.libreoffice.org/7583
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2014-01-22 13:56:51 +00:00
6cccf0f388
bool improvements
...
Change-Id: I64288207adb083e006b4acc5e7f26d647236a443
2014-01-21 18:24:03 +01:00
ff48f28f71
Resolves: fdo#73771 Non-standard behaviour for Function Mid
...
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2
Reviewed-on: https://gerrit.libreoffice.org/7539
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 15:50:51 +00:00
5f893db57d
how should I fix this memory leak??
2014-01-19 18:28:39 +01:00
d3b60aa648
CID#706118: possibly invalid cast
2014-01-19 18:15:49 +01:00
1b33a38e32
Whatever those "true" arguments to SotStorage ctor may once have meant
...
...is lost to history, but they are effectively equivalent to pssing default
SorageMode nStorageMode = 0 today, as the only thing that is done with that
nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx)
is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED
(0x44).
Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
2014-01-17 18:45:13 +01:00
99159a618f
fdo#73698 check for empty aOut
...
Change-Id: I0da26ef746553618bd8aee69f21ff0d1261efbf6
Reviewed-on: https://gerrit.libreoffice.org/7474
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-01-17 06:09:55 +00:00
da67f5b162
Environment variables can contain >127 characters
...
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a
2014-01-16 17:00:32 +01:00
c648d08720
convert SvStream::operator<< overloads to more explicit methods
...
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
0d29aab156
bool improvements
...
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
2014-01-14 18:11:10 +01:00
b69864f3f8
re-write SvStream operator<< to non-overloaded methods
...
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-10 13:26:24 +00:00
9e77ddcd19
Resolves: #i123817# prepare codebase for updating to boost 1.55
...
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)
Conflicts:
basic/source/comp/parser.cxx
basic/source/comp/token.cxx
dbaccess/source/ui/dlg/generalpage.cxx
sc/source/ui/unoobj/chart2uno.cxx
vcl/quartz/salbmp.cxx
Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
2014-01-06 16:32:20 +00:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
83e191e25d
Do not use C++-UNO internal static_type functions in client code
...
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
4b0f171b24
sbxbase.hxx is private to basic
...
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
2013-12-11 10:49:57 +02:00
d76178b52d
sbstdobj.hxx is private to basic
...
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
2013-12-11 10:48:12 +02:00
444aaceb15
sbprop.hxx is private to basic
...
Change-Id: I1d7a28652ee7743b6823d78e1565338a324f0a6a
2013-12-11 10:45:57 +02:00
0a33e24d11
sbobjmod.hxx is private to basic
...
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
2013-12-11 10:39:57 +02:00
dde119c8f2
basic/global.hxx is private to basic
...
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
2013-12-11 10:36:58 +02:00
526a60086c
Drop duplicate #include
...
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
2013-12-08 17:20:40 +09:00
3a437baee2
Resolves: #i74854# fix buttons in MsgBox with info icon
...
Patch by: hanya.runo@gmail.com
Found by: ooo@catcons.co.uk
Tested by: hdu@apache.org
(cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c)
Conflicts:
basic/source/runtime/methods.cxx
vcl/inc/vcl/msgbox.hxx
Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa
2013-12-02 16:45:50 +00:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
ab5d1fbfb4
SAL_WARN_UNUSED com::sun: ⭐ :uno::Any
...
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
04dead1c6b
make l10n buildable separately
...
- this renames the 'almost' module target to non-l10n
- and adds a l10n target which is intended to only build l10n parts of
the product
- packagers should then be able to build l10n and non-l10n parts of the
product independently, thus:
- enable quicker rebuilds
- distribution of load
- updates to l10n without a full rebuild
- security fixes to binaries without rebuilding all l10n
- the new targets are called build-l10n-only and build-non-l10n-only
- note this is not intended to move a concept of split packages
upstream -- while this exsists in distros, the number of test
scenarios for this would explode upstream
Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863
Conflicts:
filter/Module_filter.mk
2013-11-14 16:45:02 +01:00
2a6976dfa9
-Werror,-Wunused-member-function
...
Change-Id: I32e4a80e99885c561a30e8f059c9b9a24c4bd3c7
2013-11-14 10:15:16 +01:00
1b3e9bcdfa
-Werror,-Wunused-member-function
...
Change-Id: I4e47b5194992d3847a689284d7600be92a4ead26
2013-11-14 10:15:15 +01:00
d366c9b20e
remove unnecessary sal_Unicode casts in various places
...
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
8b308d510e
basic: include <> for external includes
...
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
2013-11-11 22:37:24 -06:00
a2505ae731
SAL_WARN_UNUSED INetURLObject
...
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11 16:50:05 +01:00
fcd1637d51
convert OUString compareToAscii == 0 to equalsAscii
...
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
e9c4ee996d
remove unnecessary use of OUString constructor in BASIC module
...
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
2013-11-11 11:21:25 +02:00