cb85f1c6ab
loplugin:defaultparams
...
Change-Id: I7e232e92cc9d058f93eff9f7249e37ed3a9cd9ac
2015-10-20 11:45:02 +02:00
25c047fec7
loplugin:defaultparams
...
Change-Id: I8e40cf9166aa65c81cb6b4ed17506ec5b9d725e3
2015-10-19 17:49:23 +02:00
0e13c94ad3
Get rid of connectivity's diagnose_ex.h
...
...that rather trivially wrapped some osl/diagnose.h functionality
Change-Id: I4105708488114a9c87aa415affb997a783241248
2015-09-09 07:54:05 +02:00
4712396b3b
loplugin: defaultparams
...
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-11 09:48:17 +02:00
6140ca9f1d
loplugin:loopvartoosmall
...
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29 08:48:41 +02:00
6d5ae48427
loplugin:staticmethods
...
Change-Id: I200fdb2e193127f0c9e8cec4859845d3ec19cea0
2015-04-23 13:08:47 +02:00
a1a25f4c6c
tdf#88710 Cleanup after removing dbtoolsclient
...
Removes "virtualdbtools" and its implementation under "simpledbt", which are
mostly wrappers around various dbtools functions and classes, previously aiding
the now removed dynamic loading logic.
Removes IDataAccessTools, IDataAccessTypeConversion and IDataAccessToolsFactory
interfaces and their accompanying implementations which are completely unused.
Removes IDataAccessCharSet (implemented by ODataAccessCharSet) and moves the
implementation into a function which replaces ODataAccessCharsetHelper.
Removes ISQLParseNode and ISQLParser and their implementation in
OSimpleParseNode and OSimpleSQLParser, which simply wrap around OSQLParseNode
and OSQLParser respectively. To avoid including "sqlbison.hxx" unnecessarily,
includes to "sqlbison.hxx" are now only used where needed.
Change-Id: Id882dfbf43514d84a1eaffc1f916d627830c8cd6
Reviewed-on: https://gerrit.libreoffice.org/15450
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-04-22 07:25:17 +00:00
6106d99a90
boost->std
...
Change-Id: Ifa87783f68b0fab98f8a0f7cd6ed867202b4532f
2015-02-18 20:43:16 +00:00
ecf24f3032
connectivity: Use appropriate OUString functions on string constants
...
Change-Id: I9ca72364cd57fd2da0c6f5f704a3fe494c0a1df5
2014-12-18 14:12:24 +01:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
705c48d32e
fdo#38835 strip out OUString globals
...
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
c70f1545e2
Removed duplicated includes
...
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-10-31 16:18:30 +00:00
25a092869c
connectivity: typo
...
Change-Id: Ic4c8637500c13d097f5b26222d7d4005f2251d1a
2014-09-26 16:58:04 +02:00
325ce86b56
fix build & better name for ERROR_INVALID_TABLE
...
Change-Id: Ic7253575859766f18869159e4a8dd6b3d715850d
2014-09-26 16:27:53 +02:00
ac10225762
implement --with-system-odbc on windows
...
Change-Id: I1757b9ce74277b1c11533f41caeafaf9b88658ef
2014-09-26 15:37:27 +02:00
a2db194ea0
connectivity: fix includes
...
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04 21:18:39 +02:00
7339ab25ee
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
this is a continuation of the above bug, removing SAL_INFO's
that only mark function entry.
Change-Id: Idb0f72481415594e3f8b7a11ad6e4b8835f6fca0
Reviewed-on: https://gerrit.libreoffice.org/9343
Tested-by: Thomas Arnhold <thomas@arnhold.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-13 18:04:58 +00:00
199d333f13
connectivity: sal_Bool->bool
...
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-04-16 11:51:51 +02:00
39d3f2bb3a
connectivity: sal_Bool->bool
...
Change-Id: Ice855d69c70d4f5fc119ddf1ddebf18ee6add270
2014-04-01 07:38:09 +02:00
8728c34662
connectivity: sal_Bool->bool
...
Change-Id: Iafa52d3643b9313c20c75cf98f6b1ec231bf9d6d
2014-04-01 07:38:09 +02:00
3194d22a24
connectivity: sal_Bool->bool and fix method name
...
Convert method name
getBoleanComparisonPredicate
to
getBooleanComparisonPredicate
Change-Id: I00c726b1fecd8352dc49f2af98c3ae3c799ef424
2014-04-01 07:38:08 +02:00
2c7bef7b8d
connectivity: sal_Bool->bool
...
Change-Id: Ic583deda8b0be3c89bcd644a1872ebd83276487a
2014-04-01 07:38:08 +02:00
358be80f65
comphelper,connectivity: prefer passing OUString by reference
...
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
ac9212feed
Remove visual noise from connectivity
...
Conflicts:
connectivity/source/inc/odbc/OConnection.hxx
Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:54:35 -06:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
3b06e5e646
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I1ebfb33063d39f64dc59623df0f942501870c4e7
2014-02-22 21:51:27 +09:00
ead1525417
bool improvements
...
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
2014-01-28 20:24:39 +01:00
09c749cc57
coverity#440711 Explicit null dereferenced
...
Change-Id: I794ac29dc81b1d42b959135277284de1f8c33ccf
2014-01-23 17:01:04 +00:00
c78f7d85ab
Get rid of DECLARE_STL_MAP
...
Change-Id: Ifbda934a89087fcc1c031978d3e5b5783722b328
2013-12-06 10:37:50 +01:00
1ba111343e
bugs.freedesktop.org -> bugs.libreoffice.org
...
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-17 08:33:01 +01:00
1bdb2b6f06
remove unnecessary use of OUString constructor in CONNECTIVITY module
...
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-11-11 11:21:25 +02:00
be3e037b38
setting a table name on an expression/function call makes no sense
...
Change-Id: Id30805f09bc359c6f66d87f050427c0e586ec93d
2013-09-13 12:08:05 +02:00
974d73d219
remove an arbitrary level of nested parentheses
...
not only one.
Change-Id: I1f611dda6a98fb6244409c0cd1fc87fc9dfaa8c3
2013-09-13 12:08:04 +02:00
7b4b3ad8c6
Don't clobber argument on failure
...
Change-Id: I709305d4ec3c37d3fc1c2c911551174f8cfbb883
2013-09-13 12:08:03 +02:00
fa1b2554d5
use replaceFirst
...
Change-Id: Ia20eec6e868579ed31e478514b7f2722a0972094
Reviewed-on: https://gerrit.libreoffice.org/5828
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-09-05 16:49:33 +00:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
21b2b1c049
unused variable 'sTableName' [loplugin]
...
Change-Id: I5fe746ed08a7b1124465231b6e85475da5490904
2013-07-11 20:48:20 +02:00
33fe41cf45
sort is ascending by default
...
Change-Id: I38354405acbbdb27b9e7ce1d19e862b7b352c850
2013-07-11 17:53:33 +02:00
417925840e
give right function name in debug messages
...
Change-Id: I7d82e34545a5aab657f3156b8c5b23c8a8531a11
2013-07-11 17:53:31 +02:00
40370f759c
ORDER BY columns are prioritarily *SELECT* columns
...
as opposed to *table* columns,
and notwithstanding HSQLDB 1.8 (our embedded database) bugs.
Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs
(but quite common)
Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6
2013-07-11 17:53:30 +02:00
ad1049716a
remove unreachable code, reorganise OSL_ENSUREs
...
Change-Id: I5a5df020dd6900e28a9db94bfa179baa3f59dc4a
2013-07-11 17:53:29 +02:00
48e5349a6e
lcl_getColumnRange: no table range -> match 1st name-matching select column
...
as opposed to no match
Change-Id: I811abd9df5b6cc617c28ab330cecb406cd11e709
2013-07-11 17:53:28 +02:00
83076c22e1
TODO note
...
Change-Id: I1b310119c08052949e975bfa3838e229d4e140b2
2013-07-10 03:15:13 +02:00
6eb9c378f4
fdo#58644 fix handling of subqueries
...
don't remove parentheses around subqueries
(without the parentheses, it is not valid SQL)
Change-Id: I4e9c55cea0276f10b0f97e31bc329949aba5b989
2013-07-10 03:15:11 +02:00
dd3f8fbaff
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*
Change-Id: If89af70767c3fdc4b1d0cb5e51033ca98583bc5d
Reviewed-on: https://gerrit.libreoffice.org/4286
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-06-17 15:55:21 +00:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
b0149eccbf
coverity#704590 Explicit null dereferenced
...
Change-Id: I787a39959a1558fe4f284bc1941194a841e2d600
Reviewed-on: https://gerrit.libreoffice.org/2860
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2013-03-19 23:43:11 +00:00
8f113d08ce
coverity: merge traverse{OR,AND}Criteria into traverseSearchCondition
...
Meaning, these two functions have the same behaviour,
they produce the same output (and side-effects)
when called on the same input.
traverseORCriteria handles only the actual "foo OR bar" case,
and hands off all other cases to traverseANDCriteria.
But, lo and behold, traverseANDCriteria also handles
the "foo OR bar" case, in the same manner!
Change-Id: I10410e88ce48852b60d1d688fe2865923de9d80b
2013-03-04 11:09:25 +01:00
405caad685
loplugin: unused variables
...
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
c9a40d21fa
When parsing does not give a table name, take it from the column
...
Change-Id: Ie8a2c7e473d717cc22c51205dd8cdc59934de8b1
2012-12-11 11:08:53 +01:00
