59b072e22b
yyyyy
...
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
021a5e7123
toolkit: pMouseEvt must not be captured
...
Its lifetime is bounded by the currently processed event.
(regression from 76e75d2dd6dafe55fd1740693529640652ed6455)
Change-Id: I4896b161295eeab3bbf08e59c5a82afac4338f08
2015-11-02 12:33:11 +01:00
bd63b48ab0
Avoid dangling references
...
Fixes JunitTest_sfx2_complex broken with
76e75d2dd6dafe55fd1740693529640652ed6455 "tdf#93243 replace boost::bind with
c++11 lambdas in toolkit/."
Change-Id: I3119482e4c2e978daf2c2ff34b6ee5007a29397d
2015-11-02 09:09:42 +01:00
76e75d2dd6
tdf#93243 replace boost::bind with c++11 lambdas in toolkit/
...
Change-Id: I33ba22fc5b3fa4d9b2b79f33b9abb7a2a0bbf9a2
Reviewed-on: https://gerrit.libreoffice.org/19716
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-01 11:21:08 +00:00
addb63fa8a
convert Sequence<XInterface> constructions to use initializer lists
...
Change-Id: I66475190cc0f18465c56b94af7bc0d5a1ca81242
2015-10-30 08:10:22 +02:00
7cdbde4867
Initialize Sequence<beans::NamedValue> from initializer_lists
...
Change-Id: I216dcbd983dcf3df79df9fda371b93114540a9d8
2015-10-29 08:57:08 +02:00
e25669fced
don't allocate uno::Reference on the heap
...
There is no point, since it's the size of a pointer anyway
(found by temporarily making the new operator in uno::Reference
deleted).
Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 12:48:50 +00:00
3d784c4af6
remove extra spaces around ::
...
just makes it harder to grep for methods
Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-26 09:12:05 +02:00
fc90cf2af5
ucb: replace boost::ptr_vector with std::vector<std::unique_ptr>
...
Change-Id: I05c64aaed4aaea813b369dccc721f9d10167f161
2015-10-23 11:21:33 +02:00
382eb1a23c
remove untyped Link<>
...
Change-Id: I809f9e10309ceadda0a82c3818277323b34ec61b
Reviewed-on: https://gerrit.libreoffice.org/19491
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-21 07:44:43 +00:00
092a390786
loplugin:defaultparams
...
Change-Id: I1d7e9bae07ff7bb13005d408522c6bb922ae00c6
2015-10-20 11:47:11 +02:00
ba00a4d2af
loplugin:defaultparams
...
Change-Id: If4234ce8e13781bcdba84d689e512a24fef007d0
2015-10-19 17:51:54 +02:00
c8479bdc5b
convert DBG_ASSERTWARNING to SAL_WARN_IF
...
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.
Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19 13:08:29 +02:00
59c38539bc
Allow injection of keyboard and mouse events through UNO
...
Change-Id: I3d139c6378f5274be1e7bfd88f72d1576c13243d
Reviewed-on: https://gerrit.libreoffice.org/19321
Reviewed-by: Matthew Francis <mjay.francis@gmail.com >
Tested-by: Matthew Francis <mjay.francis@gmail.com >
2015-10-16 12:03:30 +00:00
b4b7703e43
cppcheck:variableScope
...
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884
Reviewed-on: https://gerrit.libreoffice.org/19364
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-15 06:49:23 +00:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
527a9a1146
loplugin:mergeclasses
...
Change-Id: I555e3db911a97e798ce9f10c76d7fe187ea550a7
2015-10-12 09:13:32 +02:00
7ca450cbe5
Related tdf#94557: Combo box entries are case-sensitive (sometimes)
...
Revert partly http://cgit.freedesktop.org/libreoffice/core/commit/?id=76f33f10309b0ee384a75a7a854858b068d60495
author Julien Nabet <serval2412@yahoo.fr > 2015-03-16 21:31:23 (GMT)
committer Caolán McNamara <caolanm@redhat.com > 2015-03-26 14:14:44 (GMT)
commit 76f33f10309b0ee384a75a7a854858b068d60495 (patch)
tree e12e3b6f2ca46cb9998b93b5c1bb3406408ad3cb
parent 6c4100cf81e1678ff386549c0cdaa2f73a154ddc (diff)
tdf#67990: Management of case in combobox
See comments of tdf#94557 for more information
Change-Id: I0432db0c3f76c20e55d8fecb69734952dc0cf53b
Reviewed-on: https://gerrit.libreoffice.org/19260
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-10-09 06:02:29 +00:00
e209d115d4
remove old standalone Sun bug numbers
...
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 06:57:19 +00:00
a2a5187a8f
Fix typos
...
Change-Id: Ifddd2533b767924791338555031b848c59980c52
Reviewed-on: https://gerrit.libreoffice.org/18989
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org >
Tested-by: Joren De Cuyper <jorendc@libreoffice.org >
2015-09-29 22:19:19 +00:00
8f3d411f46
toolkit: convert alloca() to std::unique_ptr
...
Change-Id: Ie50b4a1a189fffdaa6a0b26040c2e7c4cc42cd69
2015-09-29 14:57:40 +02:00
1e67e94f1a
convert Link<> to typed
...
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
2015-09-21 08:03:52 +02:00
99bfc363a6
convert Link<> to typed
...
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-20 06:37:36 +00:00
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 07:59:14 +00:00
31ebd9f475
boost->std
...
Change-Id: Ic18be8b86727dd1179a7e39c70493d088ed00557
2015-09-16 15:34:23 +01:00
2a4ccc0c1e
convert Link<> to typed
...
Change-Id: I1c501671d72edd5b998e80c7fa1e91dbeb507af8
2015-09-14 10:00:44 +02:00
1ea153bb32
Use better/auto int types, remove a couple of OUStrings copies
...
Change-Id: I911742bddba1dac2641d7d2ac1dad0ed195474dd
2015-09-12 14:18:47 +02:00
9e3820ac21
convert Link<> to typed
...
Change-Id: I70d7c7ae4fc68d2f36a00d7c1b6eba71f63872d7
2015-09-11 08:48:55 +02:00
71a83295d8
convert Link<> to typed
...
and remove unused maChildEventListeners
Change-Id: I845a9af608c3429cf9ccb0e8041f24f423839513
2015-09-11 08:48:55 +02:00
2beeeea4ea
Get rid of OSL_UNUSED
...
In many cases it was originally used to silence warnings about variables used
only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is
based on SAL_WARN etc. In some other cases it was apparently used as a
speculative debugging aid, to have a value assigned to a variable to be easily
able to view the value in a debugger. And in some cases it was used with
(otherwise ignored) return values of (typically SQL-related) function calls, but
it is probably better to eventually find and fix all the problematic ones among
such calls via function declarations annotated SAL_WARN_UNUSED_RESULT.
Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf
2015-09-09 07:54:04 +02:00
bfa5b13b42
toolkit: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: If62a0c3da7f9732a60316dfd49323f6ab838fb6d
Reviewed-on: https://gerrit.libreoffice.org/18396
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-08 08:07:43 +00:00
4ea70f87f7
convert Link<> to typed
...
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4
Reviewed-on: https://gerrit.libreoffice.org/18306
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-04 06:31:30 +00:00
d829012eff
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: I03529fd3a769d0ebf1f17e3885cd6ecb691a8678
2015-08-31 08:01:08 +02:00
bd8b93fdff
make PostUserEvent Link<> typed
...
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
fe6c124da7
Remove demonstrated-useless comphelper::compare
...
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
ef46917ff3
Put Polygon from tools under tools:: namespace
...
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.
Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-17 02:07:43 +00:00
286dfc2a72
loplugin: defaultparams
...
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-08-11 09:48:18 +02:00
b8eeefebb7
toolkit: don't let ToolkitWorkerFunction join its own thread
...
Change-Id: I6694bf83e1e5ba6563d399e454442ce3574e8d26
2015-08-06 13:22:59 +02:00
300b4fa81a
vcl:: replace boost::function with std::function
...
Change-Id: Ibcc536558f26ed15c59263c25bfeb690950dd3d0
2015-08-03 14:47:43 +02:00
a4fd6c4f9e
inline some use-once typedefs
...
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d
Reviewed-on: https://gerrit.libreoffice.org/17495
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-03 12:16:33 +00:00
38ecca9b30
inline a bunch of use-once macros
...
no point in having a macro unless it's actually going to reduce the
number of lines of code
Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27 08:18:16 +02:00
442b788bc8
Resolves: tdf#90609 SolarMutex assert on threaded load
...
Change-Id: I81a784ab506d0d3ae266d7341b8ff7a163dcd8d2
2015-07-24 14:01:32 +01:00
9582380ebc
convert ImageAlign to enum class
...
Change-Id: I22e2e66a1f0b230403ad1d9c1f5b7f34a6ee6ea5
2015-07-24 09:52:08 +02:00
dc7fc2074d
convert WALLPAPER constants to scoped enum
...
Change-Id: I3b4b4e8a94904e22823a263bd5446a2e1aa47661
2015-07-24 09:52:08 +02:00
9f27e5b0e0
Fix typos
...
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2015-07-19 19:45:07 +00:00
93f0c1fdd8
loplugin:simplifybool
...
Change-Id: I9875ceec4276382d4bf96bc7e150d594df646602
2015-07-16 14:00:22 +02:00
cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
462e986e0d
Fix typos
...
Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec
Reviewed-on: https://gerrit.libreoffice.org/16712
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:18:19 +00:00
b55166d266
Revert "return and use std::vector from OInterfaceContainerHelper"
...
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29 10:11:53 +02:00
e57314f61f
return and use std::vector from OInterfaceContainerHelper
...
since most of the time we don’t need a heavyweight uno::Sequence.
Adds a new method getElementsAsVector().
Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a
Reviewed-on: https://gerrit.libreoffice.org/15747
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-29 07:25:22 +00:00
