83c1a3235d
Remove obsolete code
...
now that the ChartController doesnt own the VCL window anymore.
Change-Id: I2fefa73181a61b2a7828b36e70480b59aa7838f4
Reviewed-on: https://gerrit.libreoffice.org/35640
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-26 00:01:01 +00:00
5262883672
Fix typos
...
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e
Reviewed-on: https://gerrit.libreoffice.org/35617
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-25 08:43:01 +00:00
3784370615
fix for regression from 522e9c65: dont make all charts disappear
...
Change-Id: Ica8a8c8cfd1f0743c4ad9421f3cac9aa92645838
Reviewed-on: https://gerrit.libreoffice.org/35650
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-24 15:29:55 +00:00
9c2884ae4b
when getting the naked VCL Window from UNO: hold the solar mutex
...
Change-Id: Ia3513d67e09cdc9748a24aeffce0ec59cab30cc9
Also: fix some obvious violations of the above.
Reviewed-on: https://gerrit.libreoffice.org/35605
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-24 09:54:56 +00:00
522e9c65fa
UNO objects should never hold a VclPtr they dont own on heap ...
...
... so admit that the VclPtr that ChartController used to have is really
owned by m_xViewWindow, and get fetch that (stack-scoped only) from
there.
Change-Id: Ib9e2cd20201ebe5019c3607a8c65cb1a9856812f
Reviewed-on: https://gerrit.libreoffice.org/35603
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-24 00:09:56 +00:00
e8c723ac7f
Lets not call 1/2 of everyone we know friend...
...
...esp. when they dont even need it.
Change-Id: If9d00da3110328d88e832f12b8717a93f91393aa
Reviewed-on: https://gerrit.libreoffice.org/35602
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-23 21:34:36 +00:00
f0a6f3549e
Lets not call 1/2 of everyone we know friend...
...
...esp. when they tend try to own our private parts.
Lets be honest here. Also remove pointless repeated private:s.
Change-Id: Idaa7621fbe812ef25f13bba1882a16cca4de9d61
Reviewed-on: https://gerrit.libreoffice.org/35600
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-23 18:53:24 +00:00
eb0218315a
Lets not call 1/2 of everyone we know friend...
...
...esp. when they tend try to own our private parts.
Lets be honest here. Also remove pointless dynamic_casts.
Change-Id: Ie6ef8a0c07a72aaa15e374e5ec6841520c0fafb1
Reviewed-on: https://gerrit.libreoffice.org/35599
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2017-03-23 17:29:27 +00:00
b5bef1f7d5
Typos
...
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c
Reviewed-on: https://gerrit.libreoffice.org/35436
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-19 18:50:33 +00:00
d948d66509
Fix typos
...
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085
Reviewed-on: https://gerrit.libreoffice.org/35413
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-19 05:49:15 +00:00
9bb21ef311
cleanup itempool includes
...
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10
Reviewed-on: https://gerrit.libreoffice.org/35313
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-03-17 11:00:09 +00:00
e29dafb350
remove unused defines from HRC files in chart2
...
Change-Id: I8ce5b900353034c4ad1424375bed0ea0c9db36b1
Reviewed-on: https://gerrit.libreoffice.org/35255
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-16 10:14:33 +00:00
8ccbc16b5e
convert SvxFrameDirection to scoped enum
...
Based on the casts in chart2/source/view/main/ChartView.cxx
and the similarity of naming of values, I conclude that this
enum was intended to abstract over css::text::WritingMode2.
Added a comment to that effect.
Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57
Reviewed-on: https://gerrit.libreoffice.org/35164
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-15 08:35:10 +00:00
9cb57a50d7
convert SvxAdjust to scoped enum
...
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639
Reviewed-on: https://gerrit.libreoffice.org/34941
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 06:30:49 +00:00
60708af4a7
Revert "tdf#99352: ensure ChartController is disposing its VclPtrs on DeInitVCL"
...
The original patch crashes charts on disposing, e.g. during the UI testing.
This reverts commit 926c0d73e82bb1d5644c49fb95c56e241b6c8f34.
Change-Id: I93cb5c41e3705a487d2547b55eac761c6952049c
Reviewed-on: https://gerrit.libreoffice.org/34900
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-03-05 08:48:21 +00:00
926c0d73e8
tdf#99352: ensure ChartController is disposing its VclPtrs on DeInitVCL
...
Change-Id: I46851debe8a0bdc1ff871ee9ba34ca41f89b844b
Reviewed-on: https://gerrit.libreoffice.org/34841
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2017-03-03 10:22:01 +00:00
198c41c4fe
new loplugin unoany
...
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-28 10:17:47 +00:00
b8e85c6a64
loplugin:subtlezeroinit: chart2
...
Change-Id: I9012f97b188195140504dacb262c212d46df675a
2017-02-21 07:35:11 +01:00
ce315ac121
SvNumberFormatter::GetType() does not include NumberFormat::DEFINED
...
... so masking it out is unnecessary.
Change-Id: I4b25ced640f9287c4db52a6257020fce4e4c1303
2017-02-20 20:58:17 +01:00
be021ba04d
convert StackMode to scoped enum
...
and drop unused AMBIGUOUS enumerator
Change-Id: I71954d75a64928061c0e520beb47f979c53ee5a8
2017-02-17 09:56:19 +02:00
80dd757500
convert GraphicObjectType to scoped enum
...
and drop unused FILL_PROPERTIES enumerator
Change-Id: I302d9d1d997c4fc491f7950b220060740f831539
2017-02-17 07:57:52 +02:00
3ed6cb5748
convert AccessibleBase::EventType to scoped enum
...
and drop unused enumerators
Change-Id: I1ce08b16d587edcaee214b40798fe53fa3fc7923
2017-02-17 07:57:52 +02:00
6de3688cc6
Drop :: prefix from std in c*/
...
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tor Lillqvist <tml@collabora.com >
2017-02-15 23:01:23 +00:00
8faff1ee9c
chart2: remove unneeded includes
...
Change-Id: I49e15f57e8eddb53dbf4d1b7ddbf6d33fed116f2
Reviewed-on: https://gerrit.libreoffice.org/34172
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
2017-02-13 21:09:50 +00:00
608811c2cb
chart2: simplify and/or clean-up and c++11 features
...
Change-Id: I4550d04ae4bf6e45f24e34dfb2babc0fdef8ba5a
Reviewed-on: https://gerrit.libreoffice.org/34006
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
Tested-by: Tomaž Vajngerl <quikee@gmail.com >
2017-02-12 23:00:59 +00:00
4df2bc90cc
A newline is not that special or hard to remember
...
Change-Id: I2960a59283a5a04c5c804a57e43bdb633c0e45cf
2017-02-08 13:35:19 +02:00
a3190d7201
remove unused SCHATTR_DIAGRAM_STYLE
...
and associated SvxChartStyleItem and SvxChartStyle
Change-Id: I1564a4583125dd32af71e4eff338dfcefc6517c4
Reviewed-on: https://gerrit.libreoffice.org/33988
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-08 08:12:56 +00:00
5601c77e99
fix oss-fuzz build
...
Change-Id: I0e292bcca27035b316bcf0c93dbd6c87e3f93e3b
2017-02-07 12:35:21 +00:00
6dce9c6757
Add missing #includes
...
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception
specifications".
Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
83721f4365
makeAny->Any in basctl..chart2
...
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61
Reviewed-on: https://gerrit.libreoffice.org/33867
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-03 08:50:50 +00:00
1c3e84d819
teach lolugin:stringconstant about calling constructors
...
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
Foo(OUString("xxx"), 1)
Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-01-31 08:56:20 +00:00
f1d83ac45f
loplugin:stringconstant check for unnecessary OUString constructor..
...
..calls when creating exceptions
Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-01-28 09:22:55 +00:00
e57ca02849
Remove dynamic exception specifications
...
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html >
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-01-26 12:54:43 +00:00
80cec5faa5
AccStatisticsObject is apparently dead code
...
Change-Id: I4e04b13538d1242ea38d1400df0ced813171bc5e
2017-01-24 13:37:59 +01:00
bd281dc6e1
use rtl::Reference in AccessibleBase
...
instead of storing both a raw pointer and an uno::Reference
Change-Id: I583de7a25893baa65363aa6d3199564f63f4fa60
2017-01-24 07:03:11 +02:00
33319078e9
use rtl::Reference in ControllerCommandDispatch
...
rather than storing both a raw pointer and an uno::Reference
Change-Id: I46496da508689d82211940da765d53378f72fd7a
2017-01-24 07:03:11 +02:00
5145f60cc9
loplugin: unnecessary destructor: basctl..codemaker
...
Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c
Reviewed-on: https://gerrit.libreoffice.org/33452
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-01-24 04:59:44 +00:00
bf110d40ef
Change all Idle* LINKs to be Timer*
...
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:
1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
2. split the inheritance of Idle from Timer again to maintain
different Link<>s and move all common code into a TimerBase.
While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.
And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.
It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).
Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23 20:49:05 +01:00
abc8057ab1
pass ownership by pointer
...
to show the intend of the code.
assert on invalid objects.
remove useless OSL_ENSURE.
make sure list of owning pointers can't be copied.
Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c
Reviewed-on: https://gerrit.libreoffice.org/33393
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-01-23 13:50:45 +00:00
df98a363f3
chart2: replace custom Deg2Rad/Rad2Deg for basegfx functions
...
Change-Id: Idbc843b54b3037bd55199a8918b06d21eb7b2f2c
Reviewed-on: https://gerrit.libreoffice.org/33343
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
Tested-by: Tomaž Vajngerl <quikee@gmail.com >
2017-01-20 14:27:13 +00:00
46a0ce8032
use rtl::Reference in TheModelRef
...
instead of manual acquire/release
Change-Id: I7a5ae0337fc8fa1465ac716050e7187aa1accb87
2017-01-20 08:51:08 +02:00
ea88107a65
New loplugin:dynexcspec: Add @throws documentation, chart2
...
Change-Id: I9b558b713186c64054914ebfc4c122ff769b71a1
2017-01-19 18:03:24 +01:00
8211548e7d
svx: load BitmapEx resources instead of Image ones
...
Change-Id: Id23523170f757361f3fc3d8a18b6db827f45d109
2017-01-19 15:13:30 +00:00
afaa10da25
make SfxItemSet with SAL_WARN_UNUSED
...
Change-Id: Ia74ca329d8438f614169031acfbe0406faf7c281
Reviewed-on: https://gerrit.libreoffice.org/33268
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-01-19 05:41:29 +00:00
e87071ac57
replace boost::checked_deleter with std::default_delete
...
and remove all traces of boost/checked_delete.hpp
Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2
Reviewed-on: https://gerrit.libreoffice.org/33182
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-01-17 20:24:17 +00:00
74b92741b8
b*, c*: load BitmapEx resources instead of Image ones
...
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
2017-01-16 11:45:35 +00:00
570d8dab6d
new loplugin: useuniqueptr: chart2
...
Change-Id: Ic029ed28fd6de8cf4ee204585c1c6e0c8a4b67ff
Reviewed-on: https://gerrit.libreoffice.org/32960
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-01-16 06:10:10 +00:00
5af78ee8df
This lock seems useless
...
m_pCurrentMainType->commitToModel creates the same lock.
Change-Id: Iaecf6b3392ce7b1371623f962b0fdc58f8ddaa07
2017-01-05 04:22:05 +01:00
a3cf075880
I miss empty lines from between these function definitions
...
Change-Id: Icec3a948a92bf54bfc442b34cf806e053a9096f3
2017-01-05 02:17:51 +01:00
e885c4429a
m_bDoLiveUpdate is always true
...
Change-Id: I169027a02bd4e0e5c2e0011e6aca4d6063547ca0
2017-01-05 02:02:04 +01:00
