wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
386,353 Commits 5 Branches 0 Tags
dd615af367a11749e6490a40b4d9bcfaeebe7046
Commit Graph

505 Commits

Author SHA1 Message Date
Noel Grandin
bc80f951c1 loplugin:unusedmethods unused return value in basic 
Change-Id: I0ccbf994d2c9be35f43fc3c62e60da90634bacdf
 2016-01-11 10:49:24 +02:00
Arnaud Versini
5e0d36adc3 BASIC : use std::vector instead of SbArray for Modules. 
Change-Id: I9594efb13b3dccc637ccd61eea4b42255c2a775c
Reviewed-on: https://gerrit.libreoffice.org/20817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-01-07 12:18:40 +00:00
Andrea Gelmini
92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Julien Nabet
ec3e174569 Remove some includes (stdio/stdlib) 
Change-Id: I4aa649961efac521e72c363efb5d0a3192125da5
Reviewed-on: https://gerrit.libreoffice.org/20966
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-12-27 17:24:11 +00:00
Arnaud Versini
4251e676bb BASIC : Refactor FoldConstants for extracting it from SwExprNode. 
Change-Id: Ia47597b26d63db216dd3ab71acbb18449ece7b1a
Reviewed-on: https://gerrit.libreoffice.org/16963
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-12-22 11:13:03 +00:00
Julien Nabet
36984c75cc cppcheck: false positive deallocuse 
Help cppcheck by returning early and remove a now useless bool var

Change-Id: If4dcb6f64bcfd6c3cb22136163caf3679d6fd5a8
 2015-12-20 22:17:36 +01:00
Damjan Jovanovic
a22702ab0d Resolves: #i126272# compile error : if statement followed by End If... 
- in next Line ???

Allow the Else in a single-line If statement to be terminated by a comment instead of only EOL.

Patch by: me

(cherry picked from commit cbd43d0cb1165add5b9b559c3608a93ea631da13)

Change-Id: I3dcf014c9fe501bc9770ae3cfd69e7730c0b86cb
 2015-12-16 09:18:23 +00:00
Arnaud Versini
4df183e2c9 BASIC: use c++ foreach loops when possible. 
Change-Id: Ia1c734e26da88010eef40a4375c423b0765f43ae
Reviewed-on: https://gerrit.libreoffice.org/20423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-12-13 15:57:42 +00:00
Stephan Bergmann
c4c059beb3 DBG_TRACE_BASIC/PROFILING had been rotting for quite some time now 
...e.g., it still used the long-gone tools String class

Change-Id: I9d1930c72fbae3208a0f3da14c6991f30d89a9bc
 2015-12-10 08:18:15 +01:00
Damjan Jovanovic
d5443023ef #i117960# Basic: Line Input doesn't work in single-line If 
i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = "hi"),
but also caused a regression where "Line Input" is broken in single-line If statements.
This patch fixes that by allowing Then and Else to also be the start-of-line tokens expected to
immediately preceed the "Line" token in order for that "Line" token to be recognized a keyword instead
of a variable name. Also added FVT spreadsheet tests for "Line" as both a variable name and as "Line Input".

Patch by: me

(cherry picked from commit f8a51d0f5a645704bc2bdc939474ac931d55559c)
 2015-11-25 20:46:26 +00:00
Stephan Bergmann
08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann
a80bab7058 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
 2015-11-06 09:34:39 +01:00
Benjamin Ni
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b" 
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2015-11-02 23:40:57 +01:00
Michael Stahl
51eb04a158 basic: replace boost::ptr_vector with std::vector<std::unique_ptr> 
Change-Id: I98c4ac860fbdb55a61f9be0e9d2d5f29fb849e05
 2015-10-26 16:09:20 +01:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
4d00131b67 Reduce variable scope 
Change-Id: I87850db982f413b328976e043d8386b7577ba17c
 2015-10-07 11:32:42 +02:00
Caolán McNamara
31ee230b6e Related: tdf#94814 some cleanup of static_cast following dynamic_cast 
to the same type

Change-Id: I197e88acbc30f8e8bb9e7f2d54803971df6062af
 2015-10-06 15:10:51 +01:00
Stephan Bergmann
5e02785ff1 clang-analyzer-deadcode.DeadStores 
Change-Id: Ib26cbbc839040c49288606f588cb7400d7e40b83
 2015-10-06 15:31:15 +02:00
Oliver Specht
89d39bc100 tdf#94559: 4th step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
    idl, editeng, sc, sd, sw, sfx2, sot, starmath

Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-10-06 07:29:37 +00:00
Andrea Gelmini
2957be02c5 Fix typos 
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-10-02 08:54:51 +00:00
Noel Grandin
58aea3f36c loplugin:unusedmethods 
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 10:43:24 +00:00
Andrea Gelmini
9e4c87be31 Fix typos 
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 05:53:57 +00:00
Oliver Specht
d3c7c9ea81 tdf#94559: first step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff

Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-29 12:26:20 +00:00
Caolán McNamara
365b13e152 pVar != null, so static_cast(pVar) != null 
Change-Id: Id22808858b5884b2f87064b389eb411e0712bab4
Reviewed-on: https://gerrit.libreoffice.org/18881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-26 11:49:06 +00:00
Caolán McNamara
3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Stephan Bergmann
1f6b082388 Fix previous commit 
...4b4a7c0d87eb580272aba0777c9021789025bdc0 "Revert a fix that can never have
worked in the first place?"---which presumably did work after all, as Noel
thankfully pointed out to me,
<http://lists.freedesktop.org/archives/libreoffice/2015-September/070193.html>
"Re: [Libreoffice-commits] core.git: basic/source 'Revert a fix that can never
have worked in the first place?'"

Change-Id: I411bfaacbfebf50589290c6a3040d0300c256439
 2015-09-09 10:54:03 +02:00
Stephan Bergmann
4b4a7c0d87 Revert a fix that can never have worked in the first place? 
clang-analyzer-deadcode.DeadStores finds that conditionally assigning

  eTok = SYMBOL

inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the directly
following

  if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )

will unconditionally assign into eTok again, without intermediate use of the old
eTok value.

Now, the conditional "eTok = SYMBOL" assignment was added as
5d98ed5c6a4afc0a7943318c510e56aef8c45193 "INTEGRATION: CWS ab12fixes: #118234#
SbiExpression::Term(): Allow Input as symbol for action option compatible,"
while the unconditional "eTok = eNextTok" assignment had followed that block
ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import."

The referenced "#118234#" was a Sun-internal bug and is no longer available, but
it does very much look as if this alleged bugfix never worked in the first
place.  So revert the code back to what it looked before
5d98ed5c6a4afc0a7943318c510e56aef8c45193, for now.

Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae
 2015-09-08 10:57:54 +02:00
Arnaud Versini
d417059dae BASIC : SbiParser::DefXXX Only convert the first letter to uppercase 
Change-Id: Iccee4712459653b35b11d8dbe99c45df753307be
Reviewed-on: https://gerrit.libreoffice.org/17859
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-09-05 09:22:41 +00:00
Arnaud Versini
7985e5245a BASIC : SbiParser::pBasic is useless 
Change-Id: I5aa041f78ea5685b996a6baf1d7bc22d5bd957ab
Reviewed-on: https://gerrit.libreoffice.org/17782
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-17 07:20:31 +00:00
Noel Grandin
4f87e9da41 loplugin: defaultparams 
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
 2015-08-11 09:48:17 +02:00
Noel Grandin
c2ac8569de convert SBSTRM constants to scoped enum 
Change-Id: I478a9c7eca6509baf3e9a3dd3ce3dd8f3060f842
 2015-07-29 12:10:18 +02:00
Noel Grandin
b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Noel Grandin
01075a7274 inline the "old" SbxErr constants 
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
 2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Noel Grandin
b4ee16da65 com::sun::star->css in basic 
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 09:39:36 +00:00
Miklos Vajna
2e7fe50874 error: 'pGen' was not declared in this scope 
Change-Id: I6ebf100be3a90b315491e2735da9c82e5901fc59
 2015-07-02 10:24:59 +02:00
Arnaud Versini
fabe329412 BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr. 
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a
Reviewed-on: https://gerrit.libreoffice.org/16551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2015-07-02 07:43:03 +00:00
Andrea Gelmini
5d5dc059cb Fix typos 
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:35:58 +00:00
Andrea Gelmini
69c88a32aa Fix typos 
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:28:31 +00:00
Stephan Bergmann
687ab37853 loplugin:stringconstant: Flag more inefficiencies 
Change-Id: Ie6ca3065ee60fb2ad75f3bab53059046a981da8d
 2015-06-25 12:38:33 +02:00
Andrea Gelmini
ca9de688c2 Fix typos 
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:10:51 +00:00
Arnaud Versini
0766db041e BASIC: Don't use SbiStringPool to pass SbiParser. 
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9
Reviewed-on: https://gerrit.libreoffice.org/16137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-06-13 11:53:03 +00:00
Stephan Bergmann
761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Noel Grandin
623445aa0e convert PropertyMode to scoped enum 
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
 2015-06-04 08:30:24 +02:00
Noel Grandin
afcf1ecee1 loplugin:loopvartoosmall 
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
 2015-05-29 08:48:41 +02:00
Arnaud Versini
563a3935b8 BASIC: Remove BasicCharClass::IsLetterTab 
Change-Id: Ib6a13cb7a5725d451c0f8d64c2c543a8a9ec2ad0
Reviewed-on: https://gerrit.libreoffice.org/15876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2015-05-26 08:46:32 +00:00
Noel Grandin
539ba642d7 remove unnecessary header file 
Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
 2015-05-17 10:08:59 +02:00
Arnaud Versini
7ff58e1a89 Basic: Doesn't allow non ASCII characters in numeric literals 
Change-Id: I8b7755dbea56953a04cd7687181ec246fc680c43
Reviewed-on: https://gerrit.libreoffice.org/14691
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-05-12 09:25:18 +00:00
Julien Nabet
0f79a5ff07 tdf#84435: Mod operator does not deal with decimals as described in help 
Change-Id: I8dbfdf4bb2eceac0b5afbddd3f35e1dcde2db68b
Reviewed-on: https://gerrit.libreoffice.org/14611
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2015-04-30 14:27:06 +00:00
Stephan Bergmann
ed83ba34a5 loplugin:simplifybool 
Change-Id: I6e181bc4b144c2559ede99d3bae0496cf546415c
 2015-04-24 12:36:18 +02:00