Commit Graph

2941 Commits

Author SHA1 Message Date
6f1bdda2d2 loplugin: more unused OUStrings and so forth
Change-Id: I4f3a51e1fd3ddca9442022a7134306fbf32e13ae
2012-10-11 15:01:47 +01:00
7d044841e8 loplugin: misleading indent
Change-Id: Ia3c27c2b2e869af09557ad50e51a65894943947a
2012-10-11 11:15:41 +01:00
19d37e5c4b loplugin: unused O[U]Strings
Change-Id: I020149a3073d8479887d108465cf5d3b727588d7
2012-10-10 09:29:00 +01:00
8113588c35 cppcheck: unreadVariable.
aLangMap is a std::map that is written but never used, so drop it.

Change-Id: I8f5184c58fbe812beab8580349535920645e062e
Reviewed-on: https://gerrit.libreoffice.org/781
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-06 22:14:21 +00:00
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-04 16:29:53 +02:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
c2ca6fabd1 Use comphelper::getComponentContext
...and some further clean up.

Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
2f002e3a49 having two SetPosSizePixel is a blasted nuisance
Lets rename the multiargument SetPosSizePixel to
setPosSizePixel drop the various using Window::SetPosSizePixel
and work towards de-virtualizing SetPosSizePixel/SetPosPixel and
SetSizePixel and doing the work in a virtual setPosSizePixel

Change-Id: I7057654168001b67becee1791e97f9e9dc01f7b8
2012-09-28 08:48:39 +01:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
1b034ebe04 fdo#41440, fdo#50296: start center: force black text color
Change-Id: I13834d3c0385e1a75d2d66d1622a966c66b9aab2
2012-09-22 14:32:05 +04:00
b40f95f915 fdo#34392: request button size after vcl has updated its settings
Change-Id: I1810562a2c0c09404271be5b910f5811fce3e465
2012-09-22 14:32:05 +04:00
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-19 13:16:38 +02:00
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00
3357115adf Unused #includes
Change-Id: If5c8ee05ef84c03a9cec6ef428256e17b33f073e
2012-09-12 17:51:27 +02:00
8a0d4ff715 Disable the experimental orcus-based csv filter for now.
Change-Id: Iba8b36aaa19bbf2a9cb632fb6fe586b27ae27a7a
2012-09-07 09:10:40 -04:00
a663931200 First cut on integrating liborcus into libreoffice tree....
It introduces the 'FilterProvider' property in the media descriptor
to optionally bypass the normal loading process and let the external
filter provider to handle the loading.

For now I'm overwriting the csv import filter just to see how this
could work just as an experiment.

Orcus still needs a lot of work, and it crashes very often at the
moment.

Change-Id: I11b34572c71073144804a7d0dd5176c8067d8deb
2012-09-07 09:10:34 -04:00
6a1c29d7ef offapi: move css.ui.UICommandDescription to css.frame.UICommandDescription:
The service implementation used "com.sun.star.frame.UICommandDescription"
since forever, so the IDL file was essentially wrong documentation.
But since 7a464263cc5c2ca2b7128734ff4860e02d662818 converted the service
to new-style, it cannot be instantated any more and e.g. clicking on
Tools->Customize crashes.
(Adapting the implementation instead would be an incompatible change.)

Change-Id: I564bddaf3836827f5b72360a2bde19d6158b7ba5
2012-09-06 11:13:42 +02:00
1c7a54e3a1 fdo#46808, Adapt frame::ModuleManager UNO service to new style
Create a merged XModuleManager2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Explicitly document the XNameReplace interface in the IDL, which
is already implemented by the service, since there is code currently using it.

Change-Id: Ib46349174b1ce495c240031e93c9427fc33d9853
2012-09-05 14:56:19 +02:00
55aa40bcd6 Quick and dirty adaption of ModuleManager to WeakImplHelper
...to better be able to change its set of implemented interfaces later on.

Some potential for further clean up:
* a generic helper for supportsService;
* remove need for impl_createFactory;
* base impl_createInstance on XComponentContext instead of XMultiServiceFactory;
* replace ThreadHelpBase with a plain osl::Mutex.

Change-Id: Ia2cbd14872a609c2ed57d9ce58b546f087c2fdfb
2012-09-05 14:56:18 +02:00
b8a671ac07 Missing 1 include and 2 using
Change-Id: I5100e40f9e2bb2f27f7cac490e7c9fa8c3814166
2012-09-03 21:16:16 +02:00
756352698d More places that require a prefixed "system"
Change-Id: I49cf1f02faf70a5a92ab45e7678253ba4e5f68d0
2012-09-03 18:34:24 +02:00
bc00717bb7 fdo#46808, Adapt system::SystemShellExecute UNO service to new style
Change-Id: Ib298b3219c3e89dd35bce0974846ed4888ed941e
2012-09-03 15:55:05 +02:00
7a464263cc fdo#46808, Adapt UICommandDescription UNO service to new style
Change-Id: Ibca112904f137ff981ae9be3e5bd56aa11aec352
2012-09-03 15:55:03 +02:00
10362695c2 fdo#46808, Adapt ModuleUIConfigurationManagerSupplier UNO service to new style
Change-Id: I58b17349474b974edd24aa17ec08ffa848a92ae9
2012-09-03 15:55:03 +02:00
9cfc64c66f fdo#36149: Do not display error dialogs while showing a menu
...it apparently leads to crashes, but is probably not good from a usability
perspective anyway (as the menu closes again when the dialog appears/is operated
on by the user).

For now, just disable the Java specific interaction handler here; might make
sense to address this more generally though (there's framework::QuietInteraction
btw).

Change-Id: I6ae303c0084549b5339d219e158cdb89e5a6b331
2012-08-28 17:07:56 +02:00
043d6b6442 Missing using com::sun::frame::DispatchHelper
Change-Id: Ia4a830c342077bdc5b61daba1edccca2edb544c6
2012-08-28 10:46:42 +02:00
8638f1e72a fdo#46808, Adapt script::Converter service code to new style
Change-Id: I19b3ba7c978e02ce865360f0411007525012149c
2012-08-27 15:40:07 +02:00
f789715a41 fdo#46808, Use factory methods for frame::DispatchHelper instances
Change-Id: I7bdf16fc6d042e5ecd404c604a8b7c31c1ac7bc1
2012-08-27 15:40:06 +02:00
9ec8d331dc kill more unneeded stuff; rename uiconfig Packages
Change-Id: Ib2f73d679ac4a6164142a370ce6d55c6de41117c
2012-08-24 23:24:11 +02:00
35c9ffb275 Fix off-by-one drawing problems of the bottom docking area.
Change-Id: Ic463f6829f7faa6d9667656f42f844a12d85518e
2012-08-23 17:54:00 +02:00
18a39e216f remove menubar post processing of SID_PASTESPECIAL state to always enabled
at least calc deals with paste-special correct, if other applications don't
let's fix 'em up one by one

Change-Id: I1beb04e227f2971ee8ef2ce9b7ebdabf566be086
2012-08-16 17:50:14 +01:00
8a11858921 -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: I57abfb3b3d659edcd130788d173c2df3b79101f0
2012-08-16 09:47:00 +02:00
529951aae5 -Werror,-Wunused-value (Clang towards 3.2)
Change-Id: Idf2ec39ba286d359903edb6be60f2692c6a9837b
2012-08-16 09:46:59 +02:00
7bfb229230 sync cell context menu & edit menu 'PasteSpecial' entries for calc fdo#46250
calc application specifically handles PasteSpecial so no need to set the state of the menu entry to enabled always ( for calc at least )

Change-Id: Iaf13dd825f0cbdcf9f455db07d727753fae90868
2012-08-14 09:55:11 +01:00
88840a796e Remove unused local vars
Change-Id: I80bd0329e15cb365091ea6f5c7e1ef3559d681fc
2012-08-11 10:25:54 +02:00
6dcb3d4ef4 Related fdo#51252: No more prereg, no more unopkg sync
Now that 5c47e5f63a79a9e72ec4a100786b1bbf65137ed4 "fdo#51252 Disable copying
share/prereg/bundled to avoid startup crashes" removed the use of share/prereg,
there is no longer need to generate it in the first place (by calling "unopkg
sync" at build or installation time), and so no need for the "unopkg sync" sub-
command, either.  This also allows to simplify some of the jvmfwk code that was
only there so that "unopkg sync" (which can require a JVM) can work in "hostile"
environments (during build and installation).

Change-Id: I52657384f4561bf27948ba4f0f88f4498e90987f
2012-08-10 16:03:28 +02:00
2beba8f93e reduce ascii noise and useless comments
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08 13:53:54 +02:00
49ad17e2b1 remove include comments and boxes
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-08-08 13:53:53 +02:00
548a2ffe3a remove bogus date information
Change-Id: I2789153ee35f4ec10e760f9412eb7d379de031bf
2012-08-07 18:08:30 +02:00
2854d8b17c fdo#46193 MessBox was made copyable
Part of MultiLineEdit was moved down from stvools to vcl
with name VCLMultiLineEdit. MessBox uses it to display the
message in read-only mode. Some of svtools' classes - which
are necessary to implement VCLMultiLineEdit - were moved to
vcl as a whole, and their includes are rewrite.
Note: ExtTextView and ExtTextEngine classes would be leaved in svtools
if VCLMultiLineEdit is a template class, but two macros: IMPL_LINK
end IMPL_LINK_NOARG make it impossible to use template syntax.

Change-Id: I26543868d8081c225c7125404d23369de3c3afcd
2012-08-07 10:50:23 +02:00
889de665ec Typo ressource -> resource
Change-Id: Id13e7acfbe34eca5e124c9032d36d6f158bfb831
2012-07-30 09:26:00 +02:00
a86bef45ec Fix excessive indentation.
Change-Id: Id96c7693a53981d69820aa45e97fb34c64cb787a
2012-07-27 19:23:48 -04:00
6410afaa44 Remove unnecessary fluffy comment partitions.
Change-Id: I8fad1d7e4bb9827266b6b1f1d90fe1dd2b401b44
2012-07-27 19:23:48 -04:00
c549e1e836 Unused methods.
Change-Id: Iafd1895d96df32c312f937db479e04abd7cb7038
2012-07-24 21:03:07 -04:00
f15b1d084e It makes no sense to make these methods virtual.
LoadEnv doesn't have any child classes, and is not a UNO service.

Change-Id: I773324e10b755c6e5f1a29c07495b21f6a236a3e
2012-07-24 21:03:06 -04:00
4dd7c0369d Various Clang 3.1 -Wunsued-variable, -Wconstant-conversion
Change-Id: I0799f22685609201dfb524c373d065b6184ed53c
2012-07-18 08:23:28 +02:00
e0f7e213af the unknwon typo is surprisingly popular
Change-Id: Iffe25051c8357019521196f9a27065d6108ede47
2012-07-16 19:40:58 +02:00
df645a2bd8 There is not need to allocate memory just for getting the 'indexOf'
a literal within a OUString.

Change-Id: I01ca30c68228f81b3d313dfca5b975448f3c4fc7
2012-07-16 11:33:05 +01:00
6c4838c13c These methods can be const
Change-Id: Ia4aa8df3768923f7b5a31fb5158e4a744f4b9788
2012-07-15 15:41:15 +02:00
d3bfd98213 fix breaker introduced by 0fcd1a73f0e1ec564f3c6da1ccd890183d3c18db
Change-Id: I5e60c2d157e53831fb8239ca6d833aaca6735994
2012-07-14 16:07:40 +02:00