abe958a713
tdf#89130 Draw: Better UI for handling layer attributes
...
This is a RFC to implement comment#2 in tdf#89130: Add
shortcuts to change layer attributes and make the current
attribute values visible in the tab layer name.
Already implemented is that pressing LeftMouse+Shift
toggles layer visibility. When a layer is not visible
its name is displayed in blue.
This patch adds that pressing LeftMouse+Ctrl toggles
layer locked/unlocked and LeftMouse+Ctrl+Shift toggles
layer printable/not printable.
The name of a locked layer is displayed italic. The name
of a nonprintable layer is underlined.
This also adds an Undo action for all changes to mirror
the behavior of the layer attribute change dialog box.
Change-Id: I5d8fa0585d4f088768716956583e324e66e29602
Reviewed-on: https://gerrit.libreoffice.org/41366
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2017-09-04 02:10:20 +02:00
1abd3b0e00
set parent for insert media file dialog
...
Change-Id: I71eace1995b229caa75e61df363fd8bad981bed1
Reviewed-on: https://gerrit.libreoffice.org/41851
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-03 16:14:42 +02:00
b625d790bf
SfxItemPool::AddRef always adds 1
...
Change-Id: I710ff662ed5b8a77d228e49804d3de418899c76b
Reviewed-on: https://gerrit.libreoffice.org/41859
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-09-03 15:32:42 +02:00
09ae0a74bb
Fix leak BacktraceState (enable-dbgutil)
...
buffer is created from sal/osl/unx/backtraceapi.cxx with:
70 auto b1 = new void *[maxDepth];
71 int n = backtrace(b1, static_cast<int>(maxDepth));
72 return std::unique_ptr<BacktraceState>(new BacktraceState{ b1, n });
and from sal/osl/w32/backtrace.cxx with:
79 auto pStack = new void *[maxDepth];
80 // https://msdn.microsoft.com/en-us/library/windows/desktop/bb204633.aspx
81 // "CaptureStackBackTrace function" claims that you "can capture up to
82 // MAXUSHORT frames", and on Windows Server 2003 and Windows XP it even
83 // "must be less than 63", but assume that a too large input value is
84 // clamped internally, instead of resulting in an error:
85 int nFrames = CaptureStackBackTrace( 0, static_cast<ULONG>(maxDepth), pStack, nullptr );
86
87 return std::unique_ptr<BacktraceState>(new BacktraceState{ pStack, nFrames });
Introduced with:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc9a2ba677ce3fcd46c2bbef6e8faeacb14292c1
Change-Id: Iea0528f5d2b38ff1f3dc4bd50ff035bb100ab981
Reviewed-on: https://gerrit.libreoffice.org/41854
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-09-03 10:11:58 +02:00
1d9b0dfb5c
set parent for open file dialog
...
Change-Id: Ic823085567afde211b3991ebb60199dd336f562d
Reviewed-on: https://gerrit.libreoffice.org/41819
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-02 14:34:23 +02:00
31ee13b5a4
convert SHAPEFLAG defines to scoped enum ShapeFlag
...
they were defined in escherex.hxx as SHAPEFLAG_*
and in msdffimp.hxx as SP_*.
Added include for escherex.hxx to msdffimp.hxx.
Filled the missing flag bits.
ShapeFlag::Deleted is not used at the moment.
Convert ADD_SHAPE macro to lambda.
Fix horizontal/vertical mixup in RtfSdrExport::AddLineDimensions.
Comments for flag Connector were wrong. The flag applies to shapes
which ARE connectors.
MSO definition: "connector: A line that is used to connect two
or more shapes and that remains connected to those shapes."
So Rectangles and such with Connector flag don't make sense.
Change-Id: I735de00110411b280a302840dc0fcdfac5156399
Reviewed-on: https://gerrit.libreoffice.org/41754
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-09-02 14:10:40 +02:00
fae405c522
use more ErrCode.IsWarning()
...
Change-Id: I92a84cbe3d9a9e794d3e875c60d8db7cb40ae5bd
Reviewed-on: https://gerrit.libreoffice.org/41827
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-09-02 13:04:49 +02:00
44f023d599
always use a systemwindow for file dialog parent
...
cause the native dialogs can only be a parent of a "real" system
window
Change-Id: I6d06bda25c74b9a25f71e405027d3fb31711e136
Reviewed-on: https://gerrit.libreoffice.org/41812
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-02 12:34:33 +02:00
cba232f918
svx: Simplify code with std::unique_ptr
...
as SdrPathObj owns mpDAC.
Change-Id: I3e4411046fa55ae8ffae2da5e406ad7d20a7ca6e
Reviewed-on: https://gerrit.libreoffice.org/41818
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-09-02 08:07:52 +02:00
d9527fd01f
remove some casting
...
Change-Id: Idf6c82b0c609d8680e2017602bfe9a93acb093b9
Reviewed-on: https://gerrit.libreoffice.org/41807
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-02 00:35:28 +02:00
3814952f0b
support XSystemDependentWindowPeer for all toplevel windows
...
Change-Id: Id79fba6956e2a97a10dcec1cab883d3665ef1628
Reviewed-on: https://gerrit.libreoffice.org/41806
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-02 00:35:07 +02:00
52ec6ab3e3
weird SetModalInputMode variant only called by itself
...
Change-Id: I5846eaee38109238f49736583fb4e326ab21f698
Reviewed-on: https://gerrit.libreoffice.org/41794
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-01 22:11:26 +02:00
5aafb3db7e
Fix typos
...
Change-Id: I4496faa9ce7cad393bf06ca789099b045aea2741
Reviewed-on: https://gerrit.libreoffice.org/41785
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-09-01 17:15:14 +02:00
ef8341f05e
bump FileDialogHelper to XFilePicker3
...
Change-Id: I726676aaa8944bc3b6418abe305ad03f8ec96c59
Reviewed-on: https://gerrit.libreoffice.org/41783
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-09-01 16:58:41 +02:00
e06ef6f42e
tdf#111884: Implement export of group shapes in pptx.
...
Change-Id: If12984c0670db6396cbfd0dcb8ae1f5a9b591705
Reviewed-on: https://gerrit.libreoffice.org/41766
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
2017-09-01 14:30:19 +02:00
2e1cafaf66
Bin fairly pointless default for parameter that was defaulted just once anyway
...
Change-Id: If6d7c8f3223a45803a05d4950abe27bd90ac6dc6
2017-08-31 14:07:54 +03:00
b02998a7cb
inline some use-once typedefs
...
and remove some dead ones
Change-Id: I6946d717d3c15dc5207489ed3d56d985dd953d59
Reviewed-on: https://gerrit.libreoffice.org/41746
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-31 12:06:50 +02:00
c54850b23a
gpg4libre/comphelper: add storage helper for GPG encryption data
...
Change-Id: Idba9ad7a821cb33070cf5e5a0f79ae55db99b276
Reviewed-on: https://gerrit.libreoffice.org/41504
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de >
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de >
2017-08-31 12:02:32 +02:00
2fdbf463f9
nothing is reading the futilely set WB_AUTOSIZE bit
...
Change-Id: Ifbc2dffcb8db1511d5c08e51c972e822355f41c6
Reviewed-on: https://gerrit.libreoffice.org/41737
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-08-30 20:14:02 +02:00
14afb688d3
Resolves: tdf#95960 improve custom properties page
...
wrt widget heights and positions and other flakiness
take the natural combobox height as the line height, use a vclgrid
element for each row to get everything set to the same height
move the positioning code into Resize, etc.
Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb
Reviewed-on: https://gerrit.libreoffice.org/41734
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-08-30 20:12:33 +02:00
dce78f9caa
gpg4libre: Add flag for filters that support GPG encryption
...
Change-Id: I48518f26a3ccbe430d36fb6657bdeff0943492d3
Reviewed-on: https://gerrit.libreoffice.org/41263
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2017-08-30 17:56:41 +02:00
4e70d0b6bf
rename SBX errorcodes to BASIC
...
Change-Id: Ia6c2d2379a2f6e9b1109e2c04edd5cdd9dcf242f
Reviewed-on: https://gerrit.libreoffice.org/41706
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-29 19:50:11 +02:00
a486a379ba
osl: partial cleanup of socket_decl.hxx doxygen comments
...
Change-Id: Ie7de4fb82a6e5162bb1732baaa742f1943559ce6
2017-08-30 02:09:11 +10:00
856ff88131
move ListControl to vcl
...
Change-Id: I022bba9a9a4d3d0bdb25ca8fa43aef2544decddb
Reviewed-on: https://gerrit.libreoffice.org/41682
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-29 15:34:54 +02:00
b2e229ea40
ListControl: append new entries by default
...
Change-Id: Ibd11b59526f95be054c4c1599bf45bc9e757dada
Reviewed-on: https://gerrit.libreoffice.org/41681
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-29 15:33:50 +02:00
492462a3e7
handle scroll wheel scrolling in new ListControl
...
Change-Id: I8dc68b674aabf446c4b949770ae066d41204efc3
Reviewed-on: https://gerrit.libreoffice.org/41680
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-29 15:32:58 +02:00
45acf26775
remove some unused macro definitions
...
Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0
Reviewed-on: https://gerrit.libreoffice.org/41672
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-29 15:19:17 +02:00
e6abf10fa2
Add cautionary comment
...
Change-Id: I6003e8193bf58ba21cd8d5abe42959b489b2f39d
2017-08-29 13:44:38 +03:00
218ca21147
add a listbox that can contain any controls as children
...
This is adapted from the code that I originally wrote for the
conditional format dialogs.
Change-Id: I3349b7c720d99ede595cc6ebea2046e0f9dadc57
Reviewed-on: https://gerrit.libreoffice.org/41653
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-29 12:12:17 +02:00
c8ff3059a7
move all the basic errcodes to one file
...
Change-Id: Ic3353c80ac9fdbd17f17503b1c973c9a7cef0c7f
Reviewed-on: https://gerrit.libreoffice.org/41617
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-29 11:50:43 +02:00
6d8598acb2
svl: populate subject and date-time when verifying signature
...
Change-Id: I50eeabf3e18176cac383f48797daa771ee9dc7e4
Reviewed-on: https://gerrit.libreoffice.org/41591
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2017-08-28 03:49:01 +02:00
e002de40ca
osl: rearrange socket.h sections
...
Change-Id: I4a288699f2b313d7519554d7a66dc5f591c8767b
Reviewed-on: https://gerrit.libreoffice.org/41613
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com >
2017-08-28 00:00:04 +02:00
ae8e1ad2e3
convert code-class in ErrCode to scoped enum
...
Change-Id: I9aa8703921308d6fee8bae9ee2d7b29e19181cc7
Reviewed-on: https://gerrit.libreoffice.org/41601
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-27 21:24:16 +02:00
c4bc382229
Fix typos
...
Change-Id: I3097ef16912f72b59f0759d8826068cbb9b00ec2
Reviewed-on: https://gerrit.libreoffice.org/41606
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
2017-08-27 19:48:10 +02:00
0876a6f05d
osl: fix socket.h doxygen param
...
Change-Id: I4299433ec30ee5d102750b41e8cc6e82e4530a59
2017-08-28 03:39:59 +10:00
243c371b77
remove some unused svx error codes
...
which seem to be unused ever since initial import
Change-Id: I19460961876c73a0754c54b1a5c0ff8cc6311e4e
Reviewed-on: https://gerrit.libreoffice.org/41490
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-27 14:45:43 +02:00
829b73b1e9
tdf#45904 Move _DataPilotItem Java tests to C++
...
Change-Id: Ia20630f4cc187bd6f1a47bb6d747fda3c8b39e86
Reviewed-on: https://gerrit.libreoffice.org/41551
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-27 09:52:14 +02:00
c298f79083
tdf#45904: Move _DatabaseRange Java tests to C++
...
Change-Id: Iefe319c379ac8fffbb167b4bd4bcb235defabfa9
Reviewed-on: https://gerrit.libreoffice.org/41541
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-27 09:50:02 +02:00
90b5555e3a
tdf#45904 Move _CellAreaLink Java tests to C++
...
Change-Id: I82dac69dfed136eaf96771bf1ef2b8dfbf4e05aa
Reviewed-on: https://gerrit.libreoffice.org/41488
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2017-08-27 09:49:44 +02:00
b2d7a11835
replace magic numbers for ppt view types
...
Change-Id: I0cd234cd039a2117fe49e6de3461becdbfa07e30
Reviewed-on: https://gerrit.libreoffice.org/40475
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2017-08-27 09:32:13 +02:00
8f60fe1af6
osl: document socket enums
...
Change-Id: I6f4904d415a44ba20ec0a9bfea9876c50eedb968
2017-08-27 16:05:10 +10:00
1fab08fbea
osl: cleanup socket.h
...
Change-Id: I0f7889db570717e9606425b51a418c499bd3a40a
2017-08-27 13:17:56 +10:00
e463c96092
tdf#111980: DOCX: Handle ActiveX radio button group
...
Change-Id: I3372b3b69623bda5c6e8587215e8fb7056fdf0a7
Reviewed-on: https://gerrit.libreoffice.org/41586
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2017-08-26 18:31:45 +02:00
1ab6d39146
osl: clarify osl_scheduleThread() documentation
...
Change-Id: If9990acd06f5395c07d44fc462292ccae795abe1
2017-08-27 01:36:41 +10:00
4aee9d3283
osl: thread doxygen update
...
Change-Id: I345fdc1facd3eb38e2304f313c1eb67dc32b3608
2017-08-27 01:31:47 +10:00
aa7dc5fa1d
Get rid of need to use initial :: for ::opencl to avoid clash with sc::opencl
...
Rename the global opencl namespace to openclwrapper. Its public API is
after all declared in a file called openclwrapper.hxx. The confusion
started when part of the OpenCL code was moved out from sc some years
ago.
Change-Id: I98ebd8498b2244804411e5de9169eb619f86070b
2017-08-25 15:49:34 +03:00
001e0e530f
Add check and comment for i18npool locale data using reserved formatIndex
...
Change-Id: I9401e353241973129bff764d6d7b7f94d7c9b7b0
2017-08-25 14:23:56 +02:00
4d41b2e42f
loplugin:unusedfields
...
Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298
Reviewed-on: https://gerrit.libreoffice.org/41556
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-25 13:10:03 +02:00
db6b703d39
Allow non-modal Dialogs during FileImport/Load
...
When opening a file that triggers Dialogs (e.g. cannot
read/repair/FileType) the Frame from which it was
initialized gets blocked. This irritates quite some
people. Changed this to a non-modal Dialog so that
the user can continue to work with all opened docs,
open new ones, close and print/PDF/export these.
Change-Id: I048d3de3369527cec20d26396b87439254764b8a
Reviewed-on: https://gerrit.libreoffice.org/41534
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de >
2017-08-25 11:31:42 +02:00
1b694dad64
loplugin:unusedmethods
...
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f
Reviewed-on: https://gerrit.libreoffice.org/41539
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-25 09:04:26 +02:00
