wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
384,169 Commits 5 Branches 0 Tags
e5c55a6f99052d71505ca97d7a1ef3822960cbba
Commit Graph

233 Commits

Author SHA1 Message Date
Noel Grandin
25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Stephan Bergmann
f19dda5a55 loplugin:nullptr (automatic rewrite) 
Change-Id: I5bbef6c88255f3e8c740a5239a5010cf1251b7fa
 2015-11-10 10:31:25 +01:00
Stephan Bergmann
8cff2e85e9 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: Ia91f035c188fa99cdf0b9e80cb256e1b86f00551
 2015-11-06 09:35:47 +01:00
Noel Grandin
dd1729f854 use uno::Reference::set method instead of assignment 
Change-Id: Ib297f2ab1c0c82703030f28d034d24f8a84a85ea
Reviewed-on: https://gerrit.libreoffice.org/19732
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-02 06:46:53 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Noel Grandin
f1de3e14df com::sun::star->css in extensions/ 
Change-Id: I64af9f5ae444e1f7bc6c0e8c29df383a9531dba9
 2015-10-01 12:18:24 +02:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed 
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
 2015-08-28 09:49:56 +02:00
Stephan Bergmann
5da0dce19c Consolidate isFileUrl checks 
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
 2015-08-19 12:24:37 +02:00
Andrea Gelmini
465489d97a Fix typos 
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:43:46 +00:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]> 
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-06-17 15:50:45 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete 
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
 2015-06-15 14:46:41 +02:00
Stephan Bergmann
c278518819 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I4c3c6bfce836ddc35ba6b277e240f5ed7e652e57
 2015-06-08 16:25:04 +02:00
Stephan Bergmann
5e2fe8f2a0 loplugin:cstylecast: deal with those that are (technically) const_cast 
Change-Id: I636c05a34afc857c75a35e4c6fefedbce3e99c06
 2015-06-02 11:26:25 +02:00
Noel Grandin
49ea2258d4 loplugin:loopvartoosmall 
Change-Id: I5518e40a30bdad53470cc52b59eff04ab6d873d4
 2015-05-29 08:48:41 +02:00
Noel Grandin
ac3802da9a convert WINDOW_POSSIZE constants to scoped enum 
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
 2015-05-22 10:37:59 +02:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Michael Meeks
3f32e149d9 extensions: convert new to ::Create. 
Change-Id: I8c438d62ae0fc2c1954c965966a39d4f98e6b871
 2015-04-22 17:20:25 +01:00
Stephan Bergmann
6ff2d84ade Various #include <sal/log.hxx> fixups 
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it.  Cleaned up some, but something like

  grep -FwL sal/log.hxx $(git grep -Elw \
    'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)

shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.

Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
 2015-04-22 09:57:47 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
54e87df11f Change INetProtocol enumerators to CamelCase 
...to avoid clashes with macros and poor warnings about hiding global FILE

Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
 2015-04-02 18:33:37 +02:00
Stephan Bergmann
44b3e56bb4 Change INetProtocol to scoped enumeration 
...and fix o3tl::enumarray::operator [] const overload

Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
 2015-04-02 16:30:34 +02:00
Stephan Bergmann
78a7f969b4 Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I0e12e63846f7d06b4c2a4c00614c65b46aa64238
 2015-03-31 13:14:06 +02:00
Stephan Bergmann
5bd4b3fc59 Clean up C-style casts from pointers to void 
Change-Id: Ifd2e057ec440a072a342b307175d34cc6885b2e3
 2015-03-28 19:09:19 +01:00
Stephan Bergmann
ac3ebf3bde const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: Id0a3194e20128ad6defb95b51757dd01fcab9eb1
 2015-03-26 15:33:30 +01:00
Michael Stahl
040cf119d1 extensions: PVS-Studio V595 The 'm_pPlugin' pointer could be null 
The plugin streams are a bit of a disaster area: there are 2 of them
with a common base class and the PluginInputStream is a UNO service.

The m_pPlugin gets reset in PluginStream::setMode(-1), which is called
by the plugin itself.  So those PluginStream/PluginInputStream methods
that are called via UNO (including dtors) need to check that m_pPlugin
isn't null, but they also lock member access with m_pPlugin's mutex.

Try to ensure that that works by ensuring that the plugin is still alive
with a WeakReference, *and* checking that m_pPlugin isn't null.

Change-Id: I925b30dd7cad3d3587fcc6b10f888e30d45fc38a
 2015-03-13 16:23:27 +01:00
Stephan Bergmann
7889f9e5a3 Some more loplugin:cstylecast: extensions 
Change-Id: I3b1a00f12b75e3b115e08289b7f486a6a9c3c863
 2015-01-20 09:06:47 +01:00
Noel Grandin
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class' 
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
 2015-01-07 11:20:44 +02:00
Stephan Bergmann
f8922b67a4 Remove unnecessary comphelper::string::getToken 
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
 2015-01-02 14:22:21 +01:00
Stephan Bergmann
3639824532 extensions: Use appropriate OUString functions on string constants 
Change-Id: Ief21a59fc58cdd6fb3398bbe5080ed5a53cb374e
 2014-12-19 10:03:51 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Noel Grandin
e5bf214ebb loplugin: cstylecast 
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
 2014-10-01 13:08:43 +02:00
Stephan Bergmann
d66b757083 Leftover XLIB_Window -> Window 
Change-Id: I51aa3e3fbf440bbd16d43ab8113cd69937060bf3
 2014-09-23 14:19:31 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Thomas Arnhold
c9d7b9fdc4 warning C4628: digraphs not supported with -Ze... 
...Character sequence '<:' not interpreted as alternate token for '['

Change-Id: If5024a7e3ede9b416f391583a2d3959620f2437c
 2014-08-13 10:10:36 +02:00
Caolán McNamara
6d28e240f0 coverity#982457 Explicit null dereferenced 
Change-Id: Ia5229858cdb2c6d8088ed6684186e5cfc1fe4213
 2014-07-19 21:26:01 +01:00
Caolán McNamara
9fb4cf25cf coverity#983663 Uncaught exception 
Change-Id: Iecfbb9b7cd1cb8507028cbaf7e39a1e401f74dbe
 2014-07-02 10:46:47 +01:00
Caolán McNamara
5f5768e022 coverity#983661 Uncaught exception 
Change-Id: Id0cecd2a6431e21c896210e255f37ba220a0941f
 2014-07-02 10:46:46 +01:00
Caolán McNamara
1851e1e29c coverity#983659 Uncaught exception 
and

coverity#983660 Uncaught exception

Change-Id: I509805fd6517196d505e78bcbf632d83dff01f03
 2014-07-02 10:46:46 +01:00
Caolán McNamara
bae5099882 coverity#983658 Uncaught exception 
Change-Id: I99cb4f64b093765d0667ddcddf1f696891450a9a
 2014-07-02 10:46:45 +01:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Julien Nabet
8d471d4b37 Fix previous commit (extensions part) 
Change-Id: I942cca3639e4d823415da557262e35432a798d04
 2014-05-11 10:24:46 +02:00
Julien Nabet
bd59628620 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10 
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
 2014-05-11 10:16:42 +02:00
Thomas Arnhold
f106f41956 postwin.h handles OPTIONAL already 
Change-Id: Ia04bc545f90a093f70bbd7036b7b9403af15daa1
 2014-05-09 22:32:53 +02:00
Stephan Bergmann
93f5d5a919 The opaque PostUserEvent IDs are actually pointers 
...so declare them as such.  This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.

While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent.  And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.

Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
 2014-05-07 11:49:46 +02:00
Noel Grandin
7ae4102f17 extensions: sal_Bool->bool 
Change-Id: I1730f99c08690138e9aa7aba54304fd7bc51491d
 2014-05-02 08:49:22 +02:00
Michael Stahl
e98e738a82 replace some SvStream seeking with calls to remainingSize() 
Change-Id: I2905e98425b9991d6138ab0adc15083d313ca445
 2014-04-11 23:08:11 +02:00
Takeshi Abe
4da62012fe Fix a memory leak by freeing last pBytes 
Change-Id: I7d170d704fa8950057698856d12df63992e38381
Reviewed-on: https://gerrit.libreoffice.org/8822
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-04-04 07:20:50 -05:00
Takeshi Abe
8f7c677dbb Avoid possible resource leaks by boost::scoped_array 
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
 2014-04-02 16:09:11 +09:00