2554efabb6
use comphelper::containerToSequence
...
in chart2, we remove a local equivalent of the method
Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-19 09:33:29 +02:00
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:20:39 +00:00
11d3652418
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ic67c3138ca66c6b6d6fcf76b09d4581e23f51f8d
2015-11-10 10:31:26 +01:00
abf49c259b
coverity#1338244 Uncaught exception
...
Change-Id: If46689d2b9cf8f6cb76d61296332444d4c3fb5fd
2015-11-06 12:15:49 +00:00
b2d54b09c6
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: I5b543edcae47c9ae4c90dba8082127fcb2b9b938
2015-11-06 09:36:00 +01:00
1b41208608
use uno::Reference::set method instead of assignment
...
Change-Id: I3d94c94a9829161663a7ed18421ace38ce95a659
Reviewed-on: https://gerrit.libreoffice.org/19733
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-02 06:17:21 +00:00
b5db48ada1
no need to use OUString constructor in call to createInstance
...
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-01 15:25:43 +00:00
e25669fced
don't allocate uno::Reference on the heap
...
There is no point, since it's the size of a pointer anyway
(found by temporarily making the new operator in uno::Reference
deleted).
Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 12:48:50 +00:00
3d784c4af6
remove extra spaces around ::
...
just makes it harder to grep for methods
Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-26 09:12:05 +02:00
2f3ea8dfbc
refactor out some com::sun::star typedefs
...
which mostly serve to make the code harder to read
Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-21 14:17:56 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
7ba7a974f6
cppcheck: noExplicitConstructor
...
Change-Id: I32c6728ce7423fd997cdbec66feb8a6ba39948d2
2015-10-07 15:11:03 +01:00
56a5734b06
cppcheck: noExplicitConstructor
...
Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
2015-10-05 20:30:59 +01:00
19b85e90ab
Fix typos
...
Change-Id: Ib30f4e5f16518cbbe71cf03998513ebd8c2a4d1a
Reviewed-on: https://gerrit.libreoffice.org/18949
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-10-02 07:55:15 +00:00
de020fc9c3
com::sun::star->css in forms/
...
Change-Id: I1c09e88f839bdf11c6ff809ec95769e8f729c7cd
2015-10-02 08:20:11 +02:00
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 07:59:14 +00:00
0535f42e5f
convert Link<> to typed
...
Change-Id: Ic3ce7783614d90a34f9c4414bbc7df9774091805
2015-09-17 12:22:47 +02:00
82285ab5c9
Merge INetMessageIStream into INetMIMEMessageStream
...
Change-Id: Ic3d9cd117b3f911a7cb1317fc9d1d2e9d8f1ff42
2015-09-10 23:04:35 +02:00
8cb1f9ac1c
A charset is not a content transfer encoding
...
...the code was in this odd shape ever since
bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d "initial import"
Change-Id: Ic931b99267bb6501f15119636f13391f1d065ed4
2015-09-10 23:04:34 +02:00
e871b6a31a
Reduce INetMIMEMessage::EnableAttachChild to its only use case
...
Change-Id: I67221408d6b9d2aee942ca8bd39ca51da0209551
2015-09-10 23:04:33 +02:00
7b096a6da1
make Link<> typed
...
Change-Id: I8949a92792df892b7f360e6b9979c8f61c702ce3
2015-08-31 09:50:10 +02:00
7144ce742a
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: If06eb179be6dd00a14d8920e303af37b53e22bdc
2015-08-31 08:03:28 +02:00
bd8b93fdff
make PostUserEvent Link<> typed
...
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
fe6c124da7
Remove demonstrated-useless comphelper::compare
...
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
d0f18382c5
comphelper::isA(Any... -> Any::has
...
Change-Id: I4fdc77c6fde93d9d1ee814f7614a1c4c81e18247
2015-08-19 14:48:27 +02:00
d21260cdb6
Remove two silly typedefs
...
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
fceee9237c
loplugin: defaultparams
...
Change-Id: I4080aece6fec2778a2a8646ddedd280337303591
2015-08-14 11:09:40 +02:00
14bead7f42
forms: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: Ia4f56692c9beddda13ee948ab8bbc1ee95098fbf
Reviewed-on: https://gerrit.libreoffice.org/17648
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-08-11 13:30:17 +00:00
2886f830a9
idl,framework,forms: inline some use-once typedefs
...
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
2015-08-04 08:55:56 +02:00
38ecca9b30
inline a bunch of use-once macros
...
no point in having a macro unless it's actually going to reduce the
number of lines of code
Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27 08:18:16 +02:00
771d9ef3f6
loplugin:unusedmethods forms
...
Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f
2015-07-17 11:07:13 +02:00
891c80e172
loplugin:simplifybool
...
Change-Id: I8b704401233fa865c8ec4d4663d720a3d7d8de69
2015-07-16 14:00:17 +02:00
4c5498ec5e
fix windows build
...
Change-Id: I505b7b0e6bf86093fbed1aa7e28b710e12116e6e
2015-07-14 12:37:32 +02:00
70f152983f
tdf#47832: Pictures on buttons, created in forms, gone after reopening form
...
When image is set to a Button control the correspoding graphic object
lives only temporarily, after the graphic is copied from the graphic
object it's destroyed so save can't find it by graphic ID.
Use the same solution which works for ImageControls: use a graphic object
member for the control, so save can find it.
Change-Id: If99a3efc4727a07df9d2daaefbdacc9565920005
2015-07-14 10:36:17 +02:00
cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
465489d97a
Fix typos
...
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-03 09:43:46 +00:00
5d39063581
coverity#1308583 Uncaught exception
...
Change-Id: Ibc6a8e437d81769b9a77d0a52e98f71b1c7e7d51
2015-06-29 09:43:35 +01:00
0a4e65219e
coverity#1308582 Uncaught exception
...
Change-Id: Ibe15ebdbdd5c0eb719821043696ce22f76c5b232
2015-06-29 09:43:35 +01:00
265ad0605c
coverity#1308542 Uncaught exception
...
Change-Id: I083d3152c0bb51f72e9f61203a7b3d9c4421a072
2015-06-28 17:56:00 +01:00
bd20422248
Disambiguate needlessly overloaded OGridControlModel::createColumn
...
Change-Id: Ie12370fbd0b1d5aaacd56d6e21de29b6134d9741
2015-06-19 11:04:15 +02:00
ae150c6a54
Fix typos
...
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-06-18 11:44:56 +00:00
3fa7b0b70f
Fix typos
...
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:25:13 +00:00
ca9de688c2
Fix typos
...
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:10:51 +00:00
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
885bf7c68c
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I1d24939c085ee0751de00124d2a90de1270dbd22
2015-06-08 16:25:15 +02:00
d33c6cd785
fix Windows build
...
after my commit 55bc128636596032c23ee855904822ad813986fc
"loplugin:loopvartoosmall"
Change-Id: I1d43447df24d7bf5c8737801389447980bb69d26
2015-06-01 10:19:15 +02:00
55bc128636
loplugin:loopvartoosmall
...
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-06-01 09:58:56 +02:00
3a05a08ba7
loplugin:redundantcast: const_cast to same type
...
Change-Id: I5fe081bc2edfe14c81372ae0fd407e493d80d689
2015-05-29 12:04:32 +02:00
