Commit Graph

1448 Commits

Author SHA1 Message Date
82285ab5c9 Merge INetMessageIStream into INetMIMEMessageStream
Change-Id: Ic3d9cd117b3f911a7cb1317fc9d1d2e9d8f1ff42
2015-09-10 23:04:35 +02:00
8cb1f9ac1c A charset is not a content transfer encoding
...the code was in this odd shape ever since
bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d "initial import"

Change-Id: Ic931b99267bb6501f15119636f13391f1d065ed4
2015-09-10 23:04:34 +02:00
e871b6a31a Reduce INetMIMEMessage::EnableAttachChild to its only use case
Change-Id: I67221408d6b9d2aee942ca8bd39ca51da0209551
2015-09-10 23:04:33 +02:00
7b096a6da1 make Link<> typed
Change-Id: I8949a92792df892b7f360e6b9979c8f61c702ce3
2015-08-31 09:50:10 +02:00
7144ce742a loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: If06eb179be6dd00a14d8920e303af37b53e22bdc
2015-08-31 08:03:28 +02:00
bd8b93fdff make PostUserEvent Link<> typed
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
fe6c124da7 Remove demonstrated-useless comphelper::compare
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
d0f18382c5 comphelper::isA(Any... -> Any::has
Change-Id: I4fdc77c6fde93d9d1ee814f7614a1c4c81e18247
2015-08-19 14:48:27 +02:00
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
fceee9237c loplugin: defaultparams
Change-Id: I4080aece6fec2778a2a8646ddedd280337303591
2015-08-14 11:09:40 +02:00
14bead7f42 forms: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: Ia4f56692c9beddda13ee948ab8bbc1ee95098fbf
Reviewed-on: https://gerrit.libreoffice.org/17648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11 13:30:17 +00:00
2886f830a9 idl,framework,forms: inline some use-once typedefs
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
2015-08-04 08:55:56 +02:00
38ecca9b30 inline a bunch of use-once macros
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27 08:18:16 +02:00
771d9ef3f6 loplugin:unusedmethods forms
Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f
2015-07-17 11:07:13 +02:00
891c80e172 loplugin:simplifybool
Change-Id: I8b704401233fa865c8ec4d4663d720a3d7d8de69
2015-07-16 14:00:17 +02:00
4c5498ec5e fix windows build
Change-Id: I505b7b0e6bf86093fbed1aa7e28b710e12116e6e
2015-07-14 12:37:32 +02:00
70f152983f tdf#47832: Pictures on buttons, created in forms, gone after reopening form
When image is set to a Button control the correspoding graphic object
lives only temporarily, after the graphic is copied from the graphic
object it's destroyed so save can't find it by graphic ID.
Use the same solution which works for ImageControls: use a graphic object
member for the control, so save can find it.

Change-Id: If99a3efc4727a07df9d2daaefbdacc9565920005
2015-07-14 10:36:17 +02:00
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
465489d97a Fix typos
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:43:46 +00:00
5d39063581 coverity#1308583 Uncaught exception
Change-Id: Ibc6a8e437d81769b9a77d0a52e98f71b1c7e7d51
2015-06-29 09:43:35 +01:00
0a4e65219e coverity#1308582 Uncaught exception
Change-Id: Ibe15ebdbdd5c0eb719821043696ce22f76c5b232
2015-06-29 09:43:35 +01:00
265ad0605c coverity#1308542 Uncaught exception
Change-Id: I083d3152c0bb51f72e9f61203a7b3d9c4421a072
2015-06-28 17:56:00 +01:00
bd20422248 Disambiguate needlessly overloaded OGridControlModel::createColumn
Change-Id: Ie12370fbd0b1d5aaacd56d6e21de29b6134d9741
2015-06-19 11:04:15 +02:00
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
3fa7b0b70f Fix typos
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:25:13 +00:00
ca9de688c2 Fix typos
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:10:51 +00:00
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
885bf7c68c loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I1d24939c085ee0751de00124d2a90de1270dbd22
2015-06-08 16:25:15 +02:00
d33c6cd785 fix Windows build
after my commit 55bc128636596032c23ee855904822ad813986fc
"loplugin:loopvartoosmall"

Change-Id: I1d43447df24d7bf5c8737801389447980bb69d26
2015-06-01 10:19:15 +02:00
55bc128636 loplugin:loopvartoosmall
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-06-01 09:58:56 +02:00
3a05a08ba7 loplugin:redundantcast: const_cast to same type
Change-Id: I5fe081bc2edfe14c81372ae0fd407e493d80d689
2015-05-29 12:04:32 +02:00
4f00dce2b3 Use IMPL_[STATIC_]LINK_NOARG where applicable
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10 11:25:48 +02:00
e3ff2da892 Replace IMPL_STATIC_LINK[_TYPED] with more useful variants
Change-Id: I347eb4655babca809f4141e2f0dfe86077b77c75
2015-05-10 11:25:43 +02:00
c9b4c56811 Use typed Idle::SetIdleHdl Link
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05 12:05:38 +02:00
8cafd08278 Use typed Timer::SetTimeoutHdl Link
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
e95b073790 loplugin:staticmethods
Change-Id: I60678dfd1bd0d2e4754dbbe6ba053e90d5870780
2015-05-05 09:30:40 +02:00
3ead3ad52f Gradually typed Link
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
e6c08b6b30 Remove unnecessary STATIC_LINK macro
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29 18:29:59 +02:00
e19cd844be Rephrase comparisons between bool and sal_Bool
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-28 10:21:01 +02:00
bfef606e61 loplugin:simplifybool
Change-Id: I6b7203e55b38ce0503963f8b7f27167081fb2bf2
2015-04-24 12:36:22 +02:00
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs.
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
08a943fc37 Get rid of trivial comphelper::query_interface wrapper
Change-Id: I2b9dafd2a34d055dcd8b8c4d894be30dc821d3be
2015-04-21 08:56:51 +02:00
4592d27dca Get rid of trivial comphelper::in-/decrement wrappers
Change-Id: Id3a12ef9d56c30719f483e610c8a8b08caf05def
2015-04-21 08:56:51 +02:00
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
373a9b9bb6 loplugin:redundantcast: redundant const_cast followed by implicit upcast
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-13 12:36:36 +02:00
5ba54aacd5 Remove dead INetProtocol::Vim
...which removes the need to abstract over the standard URI '%' escape prefix
vs. the silly vim '=' special case invention.

Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
2015-04-07 20:21:21 +02:00
045211b399 unused ODatabaseForm::Create
Change-Id: If8da2da02942fb1fc38ca04c4a9e8923e373df6f
2015-04-06 16:47:45 +01:00
54e87df11f Change INetProtocol enumerators to CamelCase
...to avoid clashes with macros and poor warnings about hiding global FILE

Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
44b3e56bb4 Change INetProtocol to scoped enumeration
...and fix o3tl::enumarray::operator [] const overload

Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
e9cb5577f4 loplugin:staticmethods
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02 09:38:29 +02:00