47897fdd93
weld SwCondCollPage
...
and put back original SvTreeListBox a11y factory use
Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79
Reviewed-on: https://gerrit.libreoffice.org/63501
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-11-21 22:08:04 +01:00
97bbffc917
weld TreeView
...
a) use GtkTreeStores for GtkTreeViews
b) ironically can't store GtkTreeStore contents in .ui apparently
c) set show_expanders for all non-trees and unconverted cases
d) on-demand subtrees
Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31
Reviewed-on: https://gerrit.libreoffice.org/63336
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-11-19 12:09:25 +01:00
492ea7e085
tdf#42949 Fix IWYU warnings in include/vcl/[ab]*
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625
Reviewed-on: https://gerrit.libreoffice.org/63453
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
2018-11-19 09:38:53 +01:00
11300c48d4
Resolves: tdf#121246 crash in chart dialogs
...
Change-Id: I3bc720e44f5ea15749e6bc0f0fada3a17a783e23
Reviewed-on: https://gerrit.libreoffice.org/63463
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-11-16 14:51:52 +01:00
39aa91cfb4
Resolves: tdf#121341 weld TrendlineTabPage
...
Change-Id: I8ecc1901388986bd6a3822e8d0055e48d873586c
Reviewed-on: https://gerrit.libreoffice.org/63387
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-11-15 18:45:22 +01:00
6eff96fa68
move fmtfield
...
Change-Id: Ic3f4388ea2ca92d9e97d4a9e066eea07c7de79e5
Reviewed-on: https://gerrit.libreoffice.org/63363
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-11-14 13:48:40 +01:00
e329049900
loplugin singlevalfields improvement
...
checking for casting to void* turns out to mask useful stuff, so
remove that and just deal with a few extra false+
Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668
Reviewed-on: https://gerrit.libreoffice.org/63145
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-11-13 12:27:08 +01:00
afbfe42e63
clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2
...
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d
Reviewed-on: https://gerrit.libreoffice.org/63241
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2018-11-10 23:11:28 +01:00
8cac3565f9
tdf#42949 Fix IWYU warnings in chart2/source/controller/dialogs/*hxx
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ie6fb9f03f36d71e7b07ef70238d969db65121c8f
Reviewed-on: https://gerrit.libreoffice.org/61506
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
2018-11-09 08:49:24 +01:00
9e0770ea7e
Convert FieldUnit to scoped enum
...
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af
Reviewed-on: https://gerrit.libreoffice.org/62958
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2018-11-08 12:15:51 +01:00
906f8e8937
loplugin:constantparam
...
Change-Id: I593ccc2fb43321caf3ff64d0c348b1bac742ad18
Reviewed-on: https://gerrit.libreoffice.org/63025
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-11-08 07:37:53 +01:00
6311f7ffce
move SvTreeListBox to vcl
...
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44
Reviewed-on: https://gerrit.libreoffice.org/62787
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-11-07 22:01:02 +01:00
819149fb1f
loplugin:collapseif in accessibility..cui
...
Change-Id: I1437b493f3289b4ac97d061bd71973580571e792
Reviewed-on: https://gerrit.libreoffice.org/62933
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-11-06 10:28:47 +01:00
a2058e7516
replace double-checked locking patterns with thread safe local statics
...
Change-Id: Ie1aae7ecbd065a88b371d8c0deb586f54f7eff65
Reviewed-on: https://gerrit.libreoffice.org/62835
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2018-11-04 11:49:42 +01:00
163dd5df9f
tdf#120703 PVS: V1023
...
V1023 A pointer without owner is added to the 'm_aChartTypeDialogControllerList'
container by the 'emplace_back' method. A memory leak will occur in case
of an exception.
Change-Id: I35bf344fd083c6a1717a150f78370ec59f206240
Reviewed-on: https://gerrit.libreoffice.org/62821
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2018-11-03 22:02:42 +01:00
13869d040f
merge SchTitleResources/TitleResources back together
...
Change-Id: I4c7ff790b2b6d76a96a5d54f1537fa051beac7d1
Reviewed-on: https://gerrit.libreoffice.org/62439
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-27 22:16:32 +02:00
ecb7a18aef
merge SchLegendPositionResources/LegendPositionResources back together
...
Change-Id: I53b5bc65313a6f5e661c3f6804db256d18037c74
Reviewed-on: https://gerrit.libreoffice.org/62437
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-27 21:43:32 +02:00
646a6307b9
loplugin:unusedmethods
...
Change-Id: I66ef078794ed1eb44dbfa854c589545e5f9ba78e
Reviewed-on: https://gerrit.libreoffice.org/62407
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-27 20:10:03 +02:00
4c5ad24111
tdf#120703 (PVS): redundant nullptr check
...
V668 There is no sense in testing the 'm_spNumberFormatterWrapper' pointer
against null, as the memory was allocated using the 'new' operator.
The exception will be generated in the case of memory allocation error.
Change-Id: Id9e89bfcb412c6034ac3c06f67236a77d335c9fc
Reviewed-on: https://gerrit.libreoffice.org/62127
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2018-10-21 15:24:43 +02:00
8947c9b1d8
weld SchAttribTabDlg
...
Change-Id: Ia53547b7b42a3ff8848085ab8f8d214259d5cc7b
Reviewed-on: https://gerrit.libreoffice.org/61959
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-20 13:52:34 +02:00
59a55475af
weld SchOptionTabPage
...
Change-Id: Iadcdd4b5343992517718da4adc7945e9a9f53710
Reviewed-on: https://gerrit.libreoffice.org/61958
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-19 10:06:16 +02:00
ccb2a1f650
clang-tidy readability-redundant-smartptr-get
...
redundant get() call on smart pointer
Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd
Reviewed-on: https://gerrit.libreoffice.org/61837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-10-17 08:25:47 +02:00
16690220ed
loplugin:singlevalfields
...
tighten up the handling of binary operators
Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee
Reviewed-on: https://gerrit.libreoffice.org/61777
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-10-17 08:25:06 +02:00
aa75bf8b11
weld RangeChooserTabPage
...
Change-Id: I3006d215cc734d28b208c0c4e8b9c719b70d4954
Reviewed-on: https://gerrit.libreoffice.org/61799
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-15 21:03:34 +02:00
27a5f7d368
weld TitlesAndObjectsTabPage
...
Change-Id: I071ddf117e44fab3b5f712198973c86a0fd8d206
Reviewed-on: https://gerrit.libreoffice.org/61798
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-15 21:03:16 +02:00
ec548bce30
weld ChartTypeDialog and SchLayoutTabPage
...
Change-Id: I101c56b855d0bdc43559ca4561d298fa4ad92572
Reviewed-on: https://gerrit.libreoffice.org/61797
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-15 21:02:23 +02:00
1c4a996489
weld InsertErrorBarsDialog and ErrorBarsTabPage
...
Change-Id: I3fb2fb4d8010e43e59b4de5c488f137960bc6417
Reviewed-on: https://gerrit.libreoffice.org/61760
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-15 17:07:29 +02:00
0ed250a9ac
drop some unnecessary headers
...
Change-Id: I203824738f3e3eb5ff21b9099c731e7026e644f6
Reviewed-on: https://gerrit.libreoffice.org/61785
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-15 13:28:26 +02:00
afed3d177b
loplugin:unusedfields
...
Change-Id: I4ebd1e89daf7ba5e6ab709f56c0fec5b49f50dd0
Reviewed-on: https://gerrit.libreoffice.org/61774
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-10-15 12:53:27 +02:00
2b9f23b9b8
weld SwFrameAddPage
...
Change-Id: Ia63e22d01c6bcc08f50d3e1b12943094660c7fd0
Reviewed-on: https://gerrit.libreoffice.org/61758
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 20:18:41 +02:00
7e85ee1e5f
rename SchTextDirectionListBox back to TextDirectionListBox
...
Change-Id: Ic2369630e66fa26e189fbbc374c5a60ce7fb8173
Reviewed-on: https://gerrit.libreoffice.org/61754
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 15:03:51 +02:00
c8ecf827f4
TextDirectionListBox is gone now
...
Change-Id: If71c156164b51362754b6996f46917e30aee5b87
Reviewed-on: https://gerrit.libreoffice.org/61753
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 15:03:37 +02:00
60c5c3576a
weld SchLegendPosTabPage
...
Change-Id: Iee0b2a028119d3d65eb613ce65f05c9ab3f778fc
Reviewed-on: https://gerrit.libreoffice.org/61752
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 15:03:25 +02:00
21a6a6832b
drop now unused orienthelper
...
Change-Id: I6a33104002ecb304a65e930320595a082049faa9
Reviewed-on: https://gerrit.libreoffice.org/61750
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 15:03:14 +02:00
41e5d31b19
weld PolarOptionsTabPage
...
Change-Id: I7e0c9bcd940a5f1816e3e18077be4373644ce760
Reviewed-on: https://gerrit.libreoffice.org/61748
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 15:02:52 +02:00
c3c02d0120
weld SchAxisLabelTabPage
...
Change-Id: I499162c6c2327a6c0d635382defea7e0bae068cd
Reviewed-on: https://gerrit.libreoffice.org/61747
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-14 15:02:41 +02:00
9886625d02
weld SchAlignmentTabPage
...
Change-Id: I9b67720b087d2d89dd1a64933b0e073132e601b7
Reviewed-on: https://gerrit.libreoffice.org/61745
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-13 22:42:27 +02:00
f7a2e12cb5
weld DataLabelsDialog and DataLabelsTabPage
...
Change-Id: I509d58b2677b5e8f0db476e2650661cb128a5279
Reviewed-on: https://gerrit.libreoffice.org/61723
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-13 00:51:26 +02:00
664db0d945
loplugin:unusedmethods
...
Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb
Reviewed-on: https://gerrit.libreoffice.org/61576
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-10-09 14:16:36 +02:00
8a63cdd32c
make OGenericUnoDialog take an awt::XWindow
...
Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876
Reviewed-on: https://gerrit.libreoffice.org/61469
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-06 20:54:24 +02:00
a57f67f177
weld SchLegendDlg
...
Change-Id: Ie57d195782d9fbfdf555205e53e733529b4c1ae8
Reviewed-on: https://gerrit.libreoffice.org/61360
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-04 15:42:20 +02:00
3d4012a84c
weld SteppedPropertiesDialog
...
Change-Id: I6e5a5a76f4e7d0d8b71e7d2e3dee9f7c2815f5d5
Reviewed-on: https://gerrit.libreoffice.org/61357
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-04 14:22:56 +02:00
d4e61b53fb
weld SchTitleDlg
...
Change-Id: Ie4537b9b6d856178ae378473fda4a1b27a1ed0b5
Reviewed-on: https://gerrit.libreoffice.org/61356
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-10-04 14:22:38 +02:00
990ced77a5
weld NumberFormatDialog
...
Change-Id: I82f3574142bbcdfba5277a7ad5db82e3a33fdbd8
Reviewed-on: https://gerrit.libreoffice.org/61092
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-09-28 19:05:09 +02:00
80761fd7cd
weld ShapeParagraphDialog
...
Change-Id: I8c3b3c0f6c0cfe133e1ec8eda8c10bbbaee5f010
Reviewed-on: https://gerrit.libreoffice.org/60584
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-09-19 11:41:18 +02:00
230f67d958
weld ShapeFontDialog
...
Change-Id: I9df9dd3f2bfaedccb4a02681964544daf39f261e
Reviewed-on: https://gerrit.libreoffice.org/60580
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-09-18 10:06:08 +02:00
76c7cabc42
rename to weld::ComboBox are they are not text only now
...
Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d
Reviewed-on: https://gerrit.libreoffice.org/60500
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-09-17 15:11:47 +02:00
206b5b2661
New loplugin:external
...
...warning about (for now only) functions and variables with external linkage
that likely don't need it.
The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
returns 1, both moving just the struct S2 into an nunnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
as well as moving just the function f overload into an unnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }
would each change the program to return 0 instead.
Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2018-09-17 09:05:38 +02:00
c289c25523
loplugin:simplifyconstruct in canvas..cui
...
Change-Id: I02eba1df117a9d0df42bcac13c3251cb4fa6da14
Reviewed-on: https://gerrit.libreoffice.org/60074
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-09-06 14:38:52 +02:00
085269d25a
Replace find_if with proper quantifier algorithms
...
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11
Reviewed-on: https://gerrit.libreoffice.org/59744
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-08-29 11:40:29 +02:00
