Commit Graph

7364 Commits

Author SHA1 Message Date
2092a45888 vcl: move private impl. detail of Scheduler out of global header.
Change-Id: Iee56131a15f9554c263406356456f65694515719
2015-11-25 13:17:51 +00:00
94e98c674a -Werror=type-limits
comparison is always true due to limited range of data type

Change-Id: If4bcf1f3123cbbd9261e48d2c786a610fc7c0cbc
2015-11-25 14:03:28 +02:00
3e6ba91e2d loplugin:unusedfields in include/xmloff
Change-Id: I979743671e9a2e868d815f917427588b7b0320ba
2015-11-25 13:57:29 +02:00
1522d4b36a loplugin:unusedfields in include/vcl
and fixed bug in sepia filter, where it was using the
wrong member of the union to get the percentage

Change-Id: I56b76496a3ac711adec12dd8c08b28d69644d66f
2015-11-25 13:57:29 +02:00
4d9a757a38 store custom icon set info into ODF
Change-Id: I1581b28237d2b9f9c22d3f3b0436dc281508aafa
Reviewed-on: https://gerrit.libreoffice.org/20118
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-25 08:50:42 +00:00
631b679529 loplugin:unusedfields in include/toolkit,include/tools
Change-Id: I22966b66b1b8e4dff2e565de456f21a668f33f28
2015-11-25 08:25:10 +02:00
a4af308d90 loplugin:unusedfields in include/svx
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-11-25 08:25:10 +02:00
234884c09d loplugin:unusedfields in include/sot,include/svl,include/svtools
Change-Id: Ia2dd13c2c48b127ab85311a668fa1f37608d360a
2015-11-25 08:25:09 +02:00
85c758a461 loplugin:unusedfields in include/sfx2/
Change-Id: I3eb27ed10e82ee56b33866ac576c1b1f8c9756b9
2015-11-25 08:25:09 +02:00
a78182a993 loplugin:unusedfields in include/package,include/registry
Change-Id: Iadba30885ba3bab7aaee58e298a9dc6b22c8b977
2015-11-25 08:25:09 +02:00
87199d3829 vcl: re-introduce idle handling.
The idea here is that we should process 'idle' events - like re-paint
after we have processed any OS messages - such as key/mouse input,
window re-size events etc.

The previous approach wasn't achieving this - it was processing a single
idle event each time around the main-loop iteration; urk.

Lubos implemented something -like- this, the vestiges of it need cleaning
up and removing in: 06d731428ef6cf93c7333e8228bfb6088853b52f but it was
disabled (most likely because it broke gtk in tdf#91727, which was itself
broken by using silly values for timeouts in the scheduler (now fixed))

Tested on Windows, gtk, kde4, unx-generic.

Change-Id: I7756bca874779c00f72b372cacb7745d0f189f66
Reviewed-on: https://gerrit.libreoffice.org/20158
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-24 19:46:02 +00:00
9b52b8999b Resolves: tdf#95962 incorrect scanline stride
we were reusing the stride of the surface we were cloning,
but the new surface has a different underlying size.

remove the custom stride argument and just change our stride
calculation to use the same scheme that cairo and GDI uses, which
remove another platform/drawing-system variable

Change-Id: I257dac9757b121642e9ccfde7db0911edc9f3fb1
Reviewed-on: https://gerrit.libreoffice.org/20149
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-24 18:49:04 +00:00
1bd5e8b73d vcl: reduce maximum timeout to some sensible range.
This fixes a bug with glib, where prepare of a source with such a
large (max uint64) causes precision & wrap-around problems.
Add assert to avoid recurrence.
Also add a helpful user-visible source name in debug mode.

Change-Id: I9e1eb41af9cc49f8bff88e07f04d4bc4d1877376
Reviewed-on: https://gerrit.libreoffice.org/20152
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-24 17:07:28 +00:00
5a08d3fa47 vcl: remove UpdateStack concept.
Change-Id: I6d9b7de7c57349bfb9c75a35e63bcf1eac172fd2
Reviewed-on: https://gerrit.libreoffice.org/20143
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-24 12:40:29 +00:00
745751e32d Vcl Toolbox: Move Impl and local defines out of header files
This reverts part of 1e82a3e6e3ea8b5cda520551faed81bc74c848c1

Change-Id: I683a855727c4a52d3ac6a7c5a1f104a6cf5b9ee2
2015-11-24 13:36:08 +01:00
60795a7fd1 loplugin:unusedfields in include/oox/
Change-Id: Ie7a53f3ecc05d1d4f6f71aa8165315f9155c60dc
2015-11-24 14:20:26 +02:00
73b7c5034f loplugin:unusedfields in include/framework/
Change-Id: I04603a3b78b0611fcca4974b00e2da06045308d1
2015-11-24 14:20:25 +02:00
6cd5d5f0a1 loplugin:unusedfields in include/filter/
Change-Id: Id79bc51ba273746873a1381243b2c1d32711bbb4
2015-11-24 14:20:25 +02:00
e78bb6d545 loplugin:unusedfields in include/comphelper,include/editeng
Change-Id: I619c2cf1765df97159fc52ee84e0e9e8d16a22fe
2015-11-24 14:20:25 +02:00
c18c50cda3 add SAL_WARN_UNUSED to css::uno::WeakReference and SvCompatWeakRef
Change-Id: Idb784d398ed22f2291f1beaffb82f68642d68bcd
2015-11-24 11:04:33 +02:00
4bd8ffd27f Replace return boolean from DoYield with pleasant enumeration.
Change-Id: I1b1f885b4d7916a18dfb2457a8e9af9a5b4ae6e4
Reviewed-on: https://gerrit.libreoffice.org/20138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-24 09:02:31 +00:00
1e82a3e6e3 Vcl: Cleanup Toolbox
* Move defines to header file
* Limit line length to 120 chars
* Some other smaller cleanups (unused defines etc)

Change-Id: I14b52579f9b5bae4ea0bc1df434cc3d29c223d4e
Reviewed-on: https://gerrit.libreoffice.org/20133
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-24 07:22:01 +00:00
67a6bfb1f1 crashtesting: fdo30583-1 hits the Clone ugly tree all the way down
Change-Id: I091c3a61a28275e090975016908e3b25c7506fba
2015-11-23 21:21:38 +00:00
eb0da37545 crashtesting: ooo55544-2.sxi, etc. missing Clones
Change-Id: I3e1b8f78289500bad8013e858f9abf03ab14914a
2015-11-23 20:39:04 +00:00
d058765ff3 updae getTileMode
Change-Id: Ic8d67f08d40f475020c0534570fe3bea07aa431b
2015-11-23 14:26:00 +00:00
b639fe60ea VirtualDevices either match another device depth, or are 1 bit
cairo can therefore always render to a svp virtual device with
need for a fallback

Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
2015-11-23 14:25:59 +00:00
c43a3a5867 establish that Virtual Devices either match Physical Device depth or ...
are 1 or (rarely) 8 bit and lock that down.

Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-23 14:25:59 +00:00
a4fc2b364f vcl: simplify Image internals
Image could be of 2 types - BITMAP or IMAGE, where BITMAP used to
store the content in a Bitmap and IMAGE in a ImplImageData, which
contained a BitmapEx. This was refactored with this commit to
always store the content in a BitmapEx and there are no distinct
image types anymore. This greatly simplfies the code.

Drawing of the image in case of type IMAGE was done in the class
ImplImageBmp which also modified the image according to
DrawImageFlags (for example to create a "disabled" image). This
was moved to ImplImage and the bitmap manipulation code was moved
to BitmapProcessor (done in previous commits).

Change-Id: Iec9f63a7c05618c457d8465f1ec60ed4f16bd579
2015-11-23 13:59:25 +01:00
49b0711dad vcl: add colorizeImage to BitmapProcessor
Change-Id: Ic90368e83d7f9a187eb8404d8aaec4380ff5bcb1
2015-11-23 13:59:25 +01:00
15f66df860 vcl: Bitmap processor to create a disabled image
Change-Id: Iba5d86988736fa28329e1ba2783dfb15e37815a8
2015-11-23 13:59:24 +01:00
d95a715dd8 remove unused constructor parameter
Change-Id: Ia2d1a8d7d43ceac36b6bce87f5a733d6bce3bd6f
2015-11-23 13:59:24 +01:00
56a9594649 Update-check, expand to allow reporting of H/W and OS versions.
Off by default.
Expand config options to show the user agent used.
Re-use this to show more useful info in Help->About too.

Change-Id: I1044116ef9beeb341a537c0f4451dca54e198f67
Reviewed-on: https://gerrit.libreoffice.org/20098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-23 11:18:08 +00:00
91cbbb7797 loplugin:sallogareas
Change-Id: Ibffaa2e3924877b22abbcd17aaa8fac01607f639
2015-11-23 09:56:10 +01:00
fc06f801ee LOK: add Document::getTileMode()
So that clients can know if they get old-style RGBA or new-style ARGB
output in paintTile().

Change-Id: Icfde4b3259444b3524e64478ccd976664a3fe0ed
2015-11-23 09:52:32 +01:00
229583f298 Fix build
Change-Id: I310d10793613bae05d7b89f6cb4773a1c2d5556b
2015-11-23 00:09:38 +02:00
1335f3bd80 SvxSmartTagsControl: Do not leak sub menus
And while on it, move other things to smart pointers as well.

Change-Id: I8b234b8a9fe60e0ca82bb08e48f6b7db94cbcd4d
2015-11-23 00:04:06 +02:00
fae2fa5570 crashtesting: fdo72067-2.odp missing SdrEdgeLineDeltaAnzItem::Clone
Change-Id: I6dea8c690d07b670358f8488c6be83ec49c8ee43
2015-11-22 21:02:27 +00:00
ec5250dcc6 loplugin:staticmethods
Change-Id: Ia306219fdcce4633e85c34db343a99b21e88157e
2015-11-20 16:03:37 +01:00
536c259cb9 tdf#67770 store sidebar elements states
deck & panel states at user registry level
when disposing a sidebar

if a shared deck (with "any" context application) is modified,
it apply to all applications (eg. Gallery between calc and writer); TODO ?

clean ResourceManager Get/Set const/non-const

add panels when deck is created & refactoring

* macro example

Sub Main

controller = thisComponent.currentcontroller
sidebar = thisComponent.currentcontroller.getSidebar()

sidebar.setVisible(true)

decks = sidebar.getdecks()
deck = decks.getByName("PropertyDeck")

deck.activate(true)
deck.setTitle("new deck title")
deck.moveLast()

panels = deck.getPanels()
panel = panels.getByName("TextPropertyPanel")

panel.setTitle("new panel title")
panel.expand(true) ' expand and collapse other
panel.moveLast()

End Sub

Change-Id: I2552000af92a366ebb51a479962a094b72e400b6
Reviewed-on: https://gerrit.libreoffice.org/17992
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-20 13:33:29 +00:00
b8793748b0 Seems more natural to pass a homogenous list by initializer_list
...than by template parameter pack (even if that requires using ServiceDecl*, as
initializer_list cannot take reference types)

Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
2015-11-20 13:39:52 +01:00
009face61b Revert "vcl: Initial NotebookBar implementation."
Will use a different approach for NotebookBar.
Also this should not be in 5.1.

This reverts commit 8c1014021dbe9da2e18233d215b970f5359db67b.

Change-Id: Ic699723818a890bf4c3be3a2c045527148bd118b
Reviewed-on: https://gerrit.libreoffice.org/20075
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-20 11:14:24 +00:00
6f5c6cf490 mark WeakReference with SAL_WARN_UNUSED
Change-Id: I9d56cdecba8066058a0c6f128720534fcf6f6e34
2015-11-20 11:48:48 +02:00
ab9add5c96 loplugin:sallogareas
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
2015-11-20 10:14:49 +01:00
e58120920f tdf#95938 Toolbar context menu has no commands
because of an integer overflow

Change-Id: I75103450d0af59fd6f3196f451984e0dce45c693
Reviewed-on: https://gerrit.libreoffice.org/20072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-20 09:03:55 +00:00
fe3fd05966 add mapKeysToSequence/mapValuesToSequence methods to comphelper
and use them

Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec
Reviewed-on: https://gerrit.libreoffice.org/20055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-20 08:14:13 +00:00
b0339005b8 loplugin:sallogareas
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-19 16:05:35 +01:00
a3eec8a043 Toolbar: Add 'Save As' to 'Save' dropdown
Change-Id: I6597ae5569b29d09a8c44fc9a55b71166aa37b05
2015-11-19 13:39:17 +01:00
0e6e0cea8f Add OpenGLContext::UseNoProgram()
Will be useful in cases where there is some external library code that uses
shaders outside of our OpenGLContext.

Change-Id: I59c57e3225f55d13e69b6a9b7c0db1a7487c586d
2015-11-19 14:05:29 +02:00
6480b4d11a move translating a command name to image name out of framework
This is the first step to decouple resolving of command names to
image (icon) names. This is necessary to make allow additional
processing of images before the image is passed on and better
decision which image source to take.

Change-Id: I129dc6a1ae812aaaca32696ef2a2749d5fa86a54
2015-11-19 13:02:53 +01:00
f1132fd50a SystemMenuData::nSize is never read
...and of little use if all users of SystemMenuData agree on the definition in
vcl/sysdata.hxx

Change-Id: Id102a30074b611e3ad37ce69ce27c929f4505495
Reviewed-on: https://gerrit.libreoffice.org/20044
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-18 21:10:41 +00:00