Commit Graph

1415 Commits

Author SHA1 Message Date
c9b4c56811 Use typed Idle::SetIdleHdl Link
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05 12:05:38 +02:00
8cafd08278 Use typed Timer::SetTimeoutHdl Link
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
e95b073790 loplugin:staticmethods
Change-Id: I60678dfd1bd0d2e4754dbbe6ba053e90d5870780
2015-05-05 09:30:40 +02:00
3ead3ad52f Gradually typed Link
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
e6c08b6b30 Remove unnecessary STATIC_LINK macro
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29 18:29:59 +02:00
e19cd844be Rephrase comparisons between bool and sal_Bool
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-28 10:21:01 +02:00
bfef606e61 loplugin:simplifybool
Change-Id: I6b7203e55b38ce0503963f8b7f27167081fb2bf2
2015-04-24 12:36:22 +02:00
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs.
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
08a943fc37 Get rid of trivial comphelper::query_interface wrapper
Change-Id: I2b9dafd2a34d055dcd8b8c4d894be30dc821d3be
2015-04-21 08:56:51 +02:00
4592d27dca Get rid of trivial comphelper::in-/decrement wrappers
Change-Id: Id3a12ef9d56c30719f483e610c8a8b08caf05def
2015-04-21 08:56:51 +02:00
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
373a9b9bb6 loplugin:redundantcast: redundant const_cast followed by implicit upcast
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-13 12:36:36 +02:00
5ba54aacd5 Remove dead INetProtocol::Vim
...which removes the need to abstract over the standard URI '%' escape prefix
vs. the silly vim '=' special case invention.

Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
2015-04-07 20:21:21 +02:00
045211b399 unused ODatabaseForm::Create
Change-Id: If8da2da02942fb1fc38ca04c4a9e8923e373df6f
2015-04-06 16:47:45 +01:00
54e87df11f Change INetProtocol enumerators to CamelCase
...to avoid clashes with macros and poor warnings about hiding global FILE

Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
44b3e56bb4 Change INetProtocol to scoped enumeration
...and fix o3tl::enumarray::operator [] const overload

Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
e9cb5577f4 loplugin:staticmethods
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02 09:38:29 +02:00
cf42ba089f Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Ifd082fb63b791441a9af595e02f6ce1732d36ab0
2015-04-01 08:39:17 +02:00
0bd502af47 Clean up remaining C-style casts among void pointers
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
2015-03-29 09:17:47 +02:00
73e2c6ae27 Clean up C-style casts from pointers to void
Change-Id: I9564d76c9b6fb808ca92b53f1bca07ec0850c6f8
2015-03-28 19:09:20 +01:00
39c4b2787e forms: Replace these macros
Change-Id: I656905cf6f0e3647824ff3836fcea93920251264
2015-03-28 11:52:41 +01:00
a9535fe984 forms: More unused services related stuff
Change-Id: I3be9b1a57971286441d78e03130d0467ea2cc838
2015-03-28 11:52:40 +01:00
0b1d8eff97 const_cast: convert some C-style casts and remove some redundant ones
Change-Id: I4293d3e9244bb2ae3c6b8999c0d682e7f23138fb
2015-03-26 15:33:30 +01:00
d772b9bdc4 loplugin:constantfunction: forms
Change-Id: Icb1b4bb3fd73b54378b77fbaa6c41c3a0f03706a
2015-03-24 10:31:18 +02:00
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
8f9b0c8692 Idle: Changed to new enum name
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
2015-03-06 12:27:10 +00:00
2d95bc0510 Idle: Removed VCL_IDLE_PRIORITY_ prefix of enum
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
2015-03-06 12:27:09 +00:00
826143684d Timer: Adapted all idle includes and enum uses
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
2015-03-06 12:27:05 +00:00
fa6c09877e Fix OFormattedFieldWrapper[_ForcedFormatted] instance creation
broken with 5d05f7ed8582193c39e29b7dc16767fb850e9f28 "forms: use constructor
feature for form modules" and follow-up misguided clean up

Change-Id: If9447740e6408472722b81d112cd85349020eabe
2015-02-27 13:25:42 +01:00
186dbb6890 callcatcher: update unused code
Change-Id: If6e0cbf8544ca7a4668cdc67fcf390d8835b7017
2015-02-19 09:55:18 +00:00
e46549e955 forms: Fix copy'n'paste mistakes.
com_sun_star_form_ORadioButtonModel_get_implementation ->
  com_sun_star_form_ORadioButtonControl_get_implementation

com_sun_star_form_OGroupBoxModel_get_implementation ->
  com_sun_star_form_OGroupBoxControl_get_implementation

and a bit of further cleanup.

Change-Id: I2d03d69ac83c482257baed5a6b84a6bacae68889
2015-02-17 12:05:47 +01:00
5c3d918062 forms: Convert also com.sun.star.form.XForms.
Plus some associated cleanup.

Change-Id: I0a923198c23e2e4ecbc91e5b56cfac31b7f71256
2015-02-17 11:34:20 +01:00
5d05f7ed85 forms: use constructor feature for form modules
Change-Id: I8f1588cbd338e2f8b5bc6047d84b17c697a7d2d3
2015-02-17 11:34:20 +01:00
c27ab70f26 GenerateHeader(false) -> SetHeaderGenerated()
Change-Id: I41f06c92589e6b1839e39d840a479f1a184b47dd
2015-02-11 17:09:09 +01:00
a11c71f7f1 forms: use constructor feature for ODatabaseForm
Change-Id: I1f36b28c3d71b90e439c6ba86bba09cf55bc43ae
2015-02-09 08:09:25 +01:00
73076f5e9a forms: use constructor feature for OFormsCollection
Change-Id: Ifdc031480617ec4d0a50ae5b6cd6a2c838ae076a
2015-02-09 08:09:25 +01:00
73e117d19a loplugin:deletedspecial
Change-Id: Ic3b744fe3eb3a07d7f5a7feeaf43cde2ec2b3241
2015-02-07 12:35:59 +01:00
05abd8b205 chisel off some more unused code
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
2015-01-30 12:44:36 +00:00
f61dbc3029 followup code removal after changing virtual methods to non-virtual
This cleanups up indentation and removes dead classes.

This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"

Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26 08:42:29 +02:00
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
3ad6e328a7 Some more loplugin:cstylecast: forms
Change-Id: I39325fccdadcc57df32fe5821eef0d8477018b59
2015-01-20 09:06:47 +01:00
4efa9604cf Revert "ListBox: refuse to give values before we are loaded"
This reverts commit 1cc29a04adb721205655091854f5ea828bb8eb11, as it caused
JunitTest_forms_unoapi trigger the

  assert( m_nConvertedBoundValuesType == getValueType())

at forms/source/component/ListBox.cxx:1189.
2015-01-14 08:35:33 +01:00
7ca657e5ee css.form.component.{CheckBox,RadioButton} DefaultState property values
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.

Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
2015-01-13 15:17:18 +01:00
0331fa6a90 ListBox with value list: consider first empty value as NULL
Change-Id: I15c040b481b7f03720d0227ba5d2fcd2ccc78386
2015-01-13 14:59:04 +01:00
1cc29a04ad ListBox: refuse to give values before we are loaded
If we are not loaded,
we don't know our field type,
so cannot give values with the right type

Change-Id: I372b77647ec8ff7428b67cca72fdd89e5e147a32
2015-01-13 14:59:03 +01:00
5cd4ab7f5c janitorial
Change-Id: If0fcad97538556ef7be5fe5f8405ca171696502d
2015-01-13 14:59:03 +01:00
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class'
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
54942f0d09 spelling: attachement -> attachment
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
2015-01-05 12:57:18 +02:00