Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
...which removes the need to abstract over the standard URI '%' escape prefix
vs. the silly vim '=' special case invention.
Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
broken with 5d05f7ed8582193c39e29b7dc16767fb850e9f28 "forms: use constructor
feature for form modules" and follow-up misguided clean up
Change-Id: If9447740e6408472722b81d112cd85349020eabe
com_sun_star_form_ORadioButtonModel_get_implementation ->
com_sun_star_form_ORadioButtonControl_get_implementation
com_sun_star_form_OGroupBoxModel_get_implementation ->
com_sun_star_form_OGroupBoxControl_get_implementation
and a bit of further cleanup.
Change-Id: I2d03d69ac83c482257baed5a6b84a6bacae68889
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
This reverts commit 1cc29a04adb721205655091854f5ea828bb8eb11, as it caused
JunitTest_forms_unoapi trigger the
assert( m_nConvertedBoundValuesType == getValueType())
at forms/source/component/ListBox.cxx:1189.
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.
Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7