fa4071bb52
tdf#63054: pdf_string_parser incorrectly handles escapes
...
This patch fixes the escapes handling by avoiding boost built-in
functions that skip whitespaces behind the scenes.
Change-Id: I9607ecd9e2e052aadcba69cf30ec25c981743c49
Reviewed-on: https://gerrit.libreoffice.org/15562
Tested-by: Jenkins <ci@libreoffice.org >
Tested-by: David Tardon <dtardon@redhat.com >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-04-29 07:43:19 +00:00
c82515eb6b
More loplugin:simplifybool
...
Change-Id: I4ea5c7e9f807dfd5242c8e87a87d9ad604ebd035
2015-04-27 15:31:00 +02:00
f88a1b8d55
loplugin:simplifybool
...
Change-Id: If5f4042642364424f8d7e1e13b6285503df1d381
2015-04-24 12:36:27 +02:00
79ed057b95
loplugin:staticmethods
...
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-23 13:08:48 +02:00
da36fc8c95
No more need for PartialWeakComponentImplHelper here
...
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing
and add/removeListener rename."
Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21 22:48:02 +02:00
697804f48f
Make cpp/poppler-version.h header optional
...
Older popler (SLE11) does not have this header yet.
With the code simply if the header not found define version to oldest
possible working candidate and also raise the .pc check to the same.
Change-Id: I039c879879188fe2eb90cd119b80a1d6354a6a9c
Reviewed-on: https://gerrit.libreoffice.org/15339
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-04-21 13:07:16 +00:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
d1b27a1d9a
loplugin:staticmethods
...
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-07 10:24:54 +02:00
e4688a3d41
loplugin:staticmethods
...
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-04-07 10:24:54 +02:00
e9cb5577f4
loplugin:staticmethods
...
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02 09:38:29 +02:00
1a18cafecb
loplugin:staticmethods
...
Change-Id: I3ae555fd9f0dc3c11ea301ee1cb2c799fbec820d
2015-04-02 09:38:29 +02:00
3a2baade81
loplugin:staticfunction
...
Change-Id: I4b7b04031fa74956379c5a1b21abe10b0717f3e9
2015-03-30 10:44:59 +02:00
8d6c8d7fa0
Clean up C-style casts from pointers to void
...
Change-Id: I525293c6baaa2ab13db8f3205782a0d206d9d7ca
2015-03-28 19:09:25 +01:00
f474984cd7
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: I207f23b084013f9ce2fcf087a7f335bd8a194f50
2015-03-26 15:33:35 +01:00
ef2d6401ad
fix higher debug levels
...
Change-Id: I10556946c4bd6c60adcd9f662462b0f4b73781a2
2015-03-18 09:21:59 +00:00
3099c70b11
Fix various XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
d1c9e5ee53
tdf#43157: Fix format string violations in OSL_TRACE etc.
...
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build
Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13 18:21:36 +01:00
c11b6b64f6
add accel. to switch monitors to pres. console
...
Change-Id: I86c458f2c0a1c6a6baa6461a44b68c5f48ea55b0
2015-03-12 15:51:41 +01:00
d22519f62b
V801: Decreased performance
...
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09 22:04:31 +00:00
5a308b1239
V801: Decreased performance
...
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
a3646d5572
cppcheck: duplicate inherited member
...
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
2015-03-02 10:25:49 +02:00
e3e95f9763
Typo: embeded->embedded
...
Change-Id: I27d0cdac158a674274647fe0081a8d8c046fe0ea
2015-03-01 00:50:51 +01:00
98b27ea907
SkipImages option for PDF import
...
This option allows images and drawings to be skipped while importing
a PDF, the main reason was performance improvement where images were
not needed.
Change-Id: Ibca342ff6e7005bedf7b16869473832ce2576fb2
Reviewed-on: https://gerrit.libreoffice.org/14470
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-02-17 13:31:29 +00:00
b48874cd54
loplugin:deletedspecial
...
Change-Id: I4b7583a69ddd8de0e428a0ce848c95f805433952
2015-02-07 12:36:01 +01:00
b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
7c3386f279
fdo#79045 PDF Import: fix text displacement
...
Change-Id: I22e3b90671f1dc4f9720758a7a5b79f56fa2ff49
Reviewed-on: https://gerrit.libreoffice.org/14098
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2015-01-22 09:13:27 +00:00
f2be1cf932
pdf import: Kill cut'n'paste, and fix a memory leak.
...
Change-Id: I9460e458e9ac5274d68bd11b0ed77b06d664ce0e
2015-01-22 10:09:50 +01:00
df54862ec6
fdo#85174 PDF Import: fix character positions without modifying poppler
...
Change-Id: I4ec6409e8fa13161c5cd37fcae2055b4bc5ecfd4
Reviewed-on: https://gerrit.libreoffice.org/14066
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-01-21 15:32:25 +00:00
37e4920a31
continue to implement drawChar for unpatched popplers without drawChar2 hack
...
Change-Id: Id4ad86f3f563d88777352722e397cd77cfad45e4
2015-01-20 15:48:05 +00:00
7818c73445
fdo#85174 PDF Import: fix character positions
...
Change-Id: I0aa75b6cb834341e47bbeeaa15d39387a8cb5240
Reviewed-on: https://gerrit.libreoffice.org/14029
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-01-20 13:55:04 +00:00
6812daf271
Some more loplugin:cstylecast: sdext
...
Change-Id: Id98eab748280cd9c9c6e34cc3f6938ff6911361a
2015-01-20 09:06:51 +01:00
ee21771db0
fdo#88465 PDF Import: fix scale and rotate image transformations
...
Change-Id: I64bb088320099303b0da6d272c3cd6a9ba954f87
Reviewed-on: https://gerrit.libreoffice.org/13957
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-01-19 12:53:50 +00:00
2f69e16c72
override the overloading of "overload" to decrease cognitive (over-)load
...
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
0be5d2b2f6
boost::unordered_map->std::unordered_map
...
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2015-01-04 11:07:58 +00:00
ea644f0e90
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5
Reviewed-on: https://gerrit.libreoffice.org/13608
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-23 05:53:41 +00:00
0ad5204d32
sdext: Use appropriate OUString functions on string constants
...
Change-Id: I6815b791b935bffe6409af2bcfdd6d6adceb2252
2014-12-18 14:12:31 +01:00
afb28021e9
sdext: Use appropriate OUString functions on string constants
...
Change-Id: I0e9800f1c828294e5b97e513dae30a4f2d1161fe
2014-12-15 10:16:27 +01:00
0375504f7b
fdo#38835 strip out OString globals
...
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
2014-12-05 11:34:20 +02:00
897513899d
fix higher debug level build
...
Change-Id: Ibc2b9e56882fac4ebd181ef9fd66d91981951d32
2014-11-26 20:49:34 +00:00
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
99bada2f4c
coverity#1019392 Uncaught exception
...
Change-Id: Iab953700c9aa95fc3acd5f25233a942a31b7f5ad
2014-11-14 12:02:46 +00:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
fc0d57b7af
Revert "use the new OUString::fromUtf8 method"
...
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
05050cdb23
use the new OUString::fromUtf8 method
...
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
9b3410961e
Resolves: fdo#76581 copy-and-paste -> slideshow crash in presenter console
...
crash started after...
commit 0218b0e2fa510d7acd7413dbedefd9ad50257f76
Date: Mon Jul 15 19:45:44 2013 +0300
fdo#65457 - Provide visual clues in presenter view.
Change-Id: I19d84800bd5924f2dcc9e5debcf18ef95577105c
2014-11-06 09:58:16 +00:00
7ddfa141d3
coverity#1019393 Uncaught exception
...
Change-Id: I818a91a3090392efed46700b5e2d77d7f1e3bdb9
2014-11-05 14:57:59 +00:00
705c48d32e
fdo#38835 strip out OUString globals
...
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
0371a63365
remove unnecessary 'using namespace rtl' declarations
...
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-29 11:28:54 +00:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
58ff30d1a1
convert to floating point before divide
...
Change-Id: I0328ca6594b3809210ea124dcb744bad3b5eb92e
2014-10-06 14:08:58 +01:00