a20f9388f1
-Werror=misleading-indentation (GCC 6)
...
Change-Id: Ia633b859df94ede325469ec8a20e7383d2a178d4
2016-01-13 17:20:28 +01:00
c93486bbb8
loplugin:loopvartoosmall
...
Change-Id: Ifa813b91b153004aa0fba42cdc209f4c4fd9578f
2016-01-12 08:59:48 +02:00
bbfeab3b13
loplugin:unusedmethods unused return value in include/basic
...
Change-Id: Ib1a006adaa92e257d40a20ff0d8beeb37e7c2fe0
Reviewed-on: https://gerrit.libreoffice.org/21360
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-01-12 06:40:03 +00:00
a5c2328313
BASIC: Store directly SbxVarEntry in SbxArray
...
Change-Id: I64ae6c2a45e0ed880f5b76ca2ad420d684fdfeb4
Reviewed-on: https://gerrit.libreoffice.org/21308
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2016-01-12 06:06:49 +00:00
9a64d7f8dd
fix windows build
...
Change-Id: Ie00d2dd3fbf6ff498c652249797f8d01acef8a97
2016-01-11 11:59:18 +02:00
bc80f951c1
loplugin:unusedmethods unused return value in basic
...
Change-Id: I0ccbf994d2c9be35f43fc3c62e60da90634bacdf
2016-01-11 10:49:24 +02:00
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
cb98c423bb
sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32
...
also avoid some explicit temporaries and group some checks.
Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
2015-12-27 16:51:27 +01:00
4df183e2c9
BASIC: use c++ foreach loops when possible.
...
Change-Id: Ia1c734e26da88010eef40a4375c423b0765f43ae
Reviewed-on: https://gerrit.libreoffice.org/20423
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-12-13 15:57:42 +00:00
caa080ea80
Adapt to true wchar_t in clang-cl
...
Change-Id: I215b8215108a268f969106db6f01f876bd0dc0a0
2015-11-28 08:44:39 +01:00
d9e6270392
loplugin:unnecessaryvirtual
...
update the plugin with lessons learned from the mergeclasses plugin and
re-run it
Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-17 12:26:32 +00:00
fa91dd31f3
5th step to remove tools/rtti.hxx
...
tools/rtti.hxx removed
completed the interface of some Sdr.* Items
and removed pseudo items
Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-11-11 10:49:30 +00:00
db17d3c17c
new loplugin: memoryvar
...
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr
Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc
Reviewed-on: https://gerrit.libreoffice.org/19884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-11 07:16:20 +00:00
08e49fa337
loplugin:nullptr (automatic rewrite)
...
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
2015-11-10 10:31:17 +01:00
192ca71f07
basic: replace boost::ptr_vector with std::vector<std::unqiue_ptr>
...
Change-Id: Ieba2fb34e0279871d36b4fe80d9de76e614b5cde
2015-10-26 16:09:19 +01:00
31ee230b6e
Related: tdf#94814 some cleanup of static_cast following dynamic_cast
...
to the same type
Change-Id: I197e88acbc30f8e8bb9e7f2d54803971df6062af
2015-10-06 15:10:51 +01:00
89d39bc100
tdf#94559: 4th step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
idl, editeng, sc, sd, sw, sfx2, sot, starmath
Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-10-06 07:29:37 +00:00
2957be02c5
Fix typos
...
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-10-02 08:54:51 +00:00
58aea3f36c
loplugin:unusedmethods
...
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 10:43:24 +00:00
d70302ef5c
basic: more plausible build fix than e5a8eb9e
...
Change-Id: I26fd8a76a17386de73fa12058509ccee7e768512
2015-09-29 14:57:39 +02:00
e5a8eb9e29
fix dbgutil build
...
Change-Id: If2a9d330bd7fde8db5e998e97c278fb19c90f24a
2015-09-29 13:48:00 +01:00
d3c7c9ea81
tdf#94559: first step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff
Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-29 12:26:20 +00:00
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 07:59:14 +00:00
f0208db49d
cppcheck: fix some redundantCondition warnings
...
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2
Reviewed-on: https://gerrit.libreoffice.org/18353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-09-05 13:42:02 +00:00
9e318c0977
Resolves: #i112383# CLng("&HFFFFFFFF") fails on 64-bits...
...
rather than returning -1
Found-by: andrew
Patch-by: Damjan Jovanovic
(cherry picked from commit 175afdcb151d9ce1238dc9fec59f2dfc2eb07345)
Change-Id: I996bbfa82b10716318944f390ea53e0a5ae7c89c
2015-08-28 10:32:01 +01:00
43c00bc489
Clean up aEmptyStr
...
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
2015-08-26 21:24:29 +02:00
4f87e9da41
loplugin: defaultparams
...
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-08-11 09:48:17 +02:00
01075a7274
inline the "old" SbxErr constants
...
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28 08:35:34 +02:00
9072c5c855
convert SbxFlagsBits to scoped enum
...
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-28 08:35:34 +02:00
3e926736c7
Miscellaneous typos
...
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
2015-07-21 04:53:48 -05:00
b4ee16da65
com::sun::star->css in basic
...
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 09:39:36 +00:00
f7a2795c88
sal_uIntPtr to sal_uInt32, for consistency
...
Change-Id: Ib78dce61e8fb8c8e3bf8c7a2b02966100a4db0e8
2015-07-19 17:12:32 +02:00
c1edceb2f3
sal_uInt16 to sal_Int32 with some cleanup
...
Change-Id: Ib6e42702dd1ce29645215114b26286f05ccc1332
2015-07-19 17:12:32 +02:00
15f32b5a1e
basic: replace boost::ptr_vector with std::vector<std::unique_ptr>>
...
Change-Id: I96ea97c1df7903a28387d8e1171075be55a80ca7
2015-07-17 20:26:59 +02:00
22b094f5d8
loplugin:unusedmethods basic
...
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1
Reviewed-on: https://gerrit.libreoffice.org/17044
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-15 09:07:05 +00:00
07d85c4499
remove SFX_NOTIFY macro
...
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects
Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-24 12:06:34 +02:00
0980095619
Replace boost::scoped_array<T> with std::unique_ptr<T[]>
...
This may reduce some degree of dependency on boost.
Done by running a script like:
git grep -l '#include *.boost/scoped_array.hpp.' \
| xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
| xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'
... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.
Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-06-17 15:50:45 +00:00
761e0ae0a7
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-06-08 16:23:17 +02:00
8e22cd40ec
cppcheck: noExplicitConstructor
...
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-06-02 08:57:56 +01:00
afcf1ecee1
loplugin:loopvartoosmall
...
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
5b1337f7b2
tdf#62475: partial handmade fixes
...
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
2015-05-15 17:55:15 +00:00
ef6877c167
loplugin:cstylecast: nop between pointer types of exactly same spelling
...
Change-Id: I1e4363f917a978434fb11368918435da12531dc6
2015-05-11 12:49:03 +02:00
9f23260105
SvStream: WriteUChar -> WriteBool
...
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
2015-04-17 15:20:43 +02:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
0511c86791
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: If774a3b4e2e993d26dd9b5777a55665a330b2abe
2015-03-26 15:33:28 +01:00
b2d2d72a7e
loplugin:constantfunction: basic
...
Change-Id: I1c9a33cefb68bec978b2a922c2c3ef00f2a7a1b4
2015-03-24 10:31:17 +02:00
34d6ec2c6e
cppcheck: variableScope
...
Change-Id: Ie77a988956927475ea384c36664ca7c3dd00b2a7
2015-03-09 16:27:47 +00:00
5f6fcb4e7c
Typos
...
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-08 16:45:30 +01:00
3b585737ff
convert error number to string
...
BASIC error type was printing as "Error "+ odd char
instead of "Error " + error number
Change-Id: I7407833626d6117f932cc29c6dab1a8a64c50b5a
Reviewed-on: https://gerrit.libreoffice.org/14776
Reviewed-by: Tor Lillqvist <tml@collabora.com >
Tested-by: Tor Lillqvist <tml@collabora.com >
2015-03-07 05:57:20 +00:00
2f928b2d09
remove NUMBERFORMAT_ constants
...
.. in favour of just using the underlying constants from
css::util::NumberFormat
Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-25 10:34:27 +02:00