wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
386,758 Commits 5 Branches 0 Tags
f8779bbcef2a2eeab8d74bce445a0eaceda8bdde
Commit Graph

336 Commits

Author SHA1 Message Date
Caolán McNamara
c9be2744d8 cppcheck: noExplicitConstructor 
Change-Id: Ifdcb1cc12645d6cdba81d16f94f0268696187cde
Reviewed-on: https://gerrit.libreoffice.org/21201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-01-07 19:27:28 +00:00
Mike Kaganski
3149c04bb7 Resolve Linker Warning LNK4104 
See https://msdn.microsoft.com/en-us/library/e821azx1.aspx
Some export symbols should be PRIVATE

Also, don't export DLLMain. It is internal function
used by CRT, and not intended to be exported.

Change-Id: I48139b985aa2ee499c2005d8b0d966a2cc6dcd0c
Reviewed-on: https://gerrit.libreoffice.org/20419
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matúš Kukan <matus@libreoffice.org>
 2015-12-08 19:34:59 +00:00
Stephan Bergmann
803bff584c -Werror,-Wint-to-pointer-cast 
Appart from the by-design type-punned use in CreateWindowEx, m_uID is (only)
used in a call to MAKEWPARAM (to create a WPARAM to pass into a SendMessage
call), so the most realistic type to use seems to be WORD.  And
CHatchWindow::Init is only called with a value of 2000 (from docholder.cxx),
anyway.

Change-Id: I4b6554d1ca9bb3926378c9e25a5473609f5951c5
 2015-12-02 08:02:21 +01:00
Stephan Bergmann
c59646dce5 Silence clang-cl warnings in ATL headers 
Change-Id: Id94279d0086bc29569783f4e0b5d975be162e823
 2015-12-02 08:02:18 +01:00
Stephan Bergmann
31927f9703 -Werror,-Wunused-variable 
Change-Id: I6800b97cfbf2e986c341d8893658f511951bc8f0
 2015-11-28 13:59:59 +01:00
Stephan Bergmann
0ea6755161 -Werror,-Wunused-variable 
Change-Id: If674f0a3199a43cec84eb8cfb3b3c1d334a288ca
 2015-11-24 08:46:57 +01:00
Stephan Bergmann
fa257a38b0 Use Get/SetWindowLongPtr, for 64-bit build 
Change-Id: I02e5ca8dad87c24f8bf6e192a6b37ffc82a5a04a
 2015-11-24 08:46:56 +01:00
Stephan Bergmann
04277e7bcf -Werror,-Wbitwise-op-parentheses 
Change-Id: I36bd91dc2bb77a09f59e865527db1e9c6724a652
 2015-11-24 08:46:56 +01:00
Stephan Bergmann
0968238517 Expand single use of SendCommand macro 
Change-Id: I8af259f55e8fc318ccdbc69bba00ae0d7d3aacdb
 2015-11-24 08:46:55 +01:00
Stephan Bergmann
63915326cb -Werror,-Wreorder 
Change-Id: I8350b7e60e54eb0f0be5fa33a4ca4de40551618c
 2015-11-24 08:46:55 +01:00
Stephan Bergmann
e3eebcc45c -Werror,-Wlogical-op-parentheses 
Change-Id: I39f59a88c34c37bad520dd44f3e8fcaf4a016eee
 2015-11-24 08:46:55 +01:00
Stephan Bergmann
5508383014 -Werror,-Wreorder 
Change-Id: I71e3d8878a8c7190ef239e4529d23eccaadc80d6
 2015-11-24 08:46:54 +01:00
Stephan Bergmann
cf2f0f9c20 -Werror,-Wint-to-pointer-cast 
Change-Id: I6db7d7595fda972e7c5d5c24d235678671478975
 2015-11-24 08:46:54 +01:00
Stephan Bergmann
f08d0142af Fix css.awt.XSystemDependentMenuPeer.getMenuHandle 
...to return an ANY containing a 64-bit HYPER instead of a 32-bit LONG for
SYSTEM_WIN32 (which covers both 32-bit and 64-bit versions of Windows), so that
the HMENU value (which is effectively a void*) is not truncated for the 64-bit
build.

This should effectively be URE ABI compatible for the 32-bit build, as there the
HYPER value will fit into 32 bits, so extracting a LONG from the ANY should
still work.

Change-Id: Ief3de5924f672e8f6bbe6df08c15439456ca036f
Reviewed-on: https://gerrit.libreoffice.org/20045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2015-11-18 21:11:02 +00:00
Stephan Bergmann
753057b0d8 The #else branch is unused now 
...after a3ce60eb3c8bb5c69ab41556398efa8316286477 "We only support MSVC 2008
(_MSC_VER 1500) or later" removed the

  && (_MSC_VER > 1310)

part from the #if

Change-Id: I472461b29a37fcf996262c0a83cb10f4cb8443a9
Reviewed-on: https://gerrit.libreoffice.org/20042
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2015-11-18 17:42:37 +00:00
Stephan Bergmann
8c0d5d494f -Werror,-Wlogical-op-parentheses 
Change-Id: I8e22b6399bbdb07c376299d5a23c8061af18578d
 2015-11-18 17:19:18 +01:00
Stephan Bergmann
94f790a4e6 -Werror,-Wduplicate-decl-specifier (extern "C" already in STDAPI) 
Change-Id: I634debc05a24e0d519200fc91a77d50f36b9af38
 2015-11-18 17:19:15 +01:00
Stephan Bergmann
4668528dda -Wmissing-braces is globally disabled in com_GCC_defs.mk anyway 
Change-Id: Ie2a1e6785ac925f268e63775f2282df3f3c6bcd4
 2015-11-18 16:53:14 +01:00
Noel Grandin
25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Noel Grandin
b5db48ada1 no need to use OUString constructor in call to createInstance 
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:25:43 +00:00
Noel Grandin
3c971162b5 use uno::Reference::set method instead of assignment 
Change-Id: I150f213ab033f5fc1b50abe4e1529292206c9feb
Reviewed-on: https://gerrit.libreoffice.org/19689
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-31 12:56:38 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Noel Grandin
6a93b970c5 com::sun::star->css in embedserv/ 
Change-Id: Iaf1e30ae7dc9710a16a031ea623d531e9e65a6a5
Reviewed-on: https://gerrit.libreoffice.org/19025
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 08:01:49 +00:00
Caolán McNamara
35fd0cf311 cppcheck: noExplicitConstructor 
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
 2015-09-13 22:42:35 +01:00
Julien Nabet
f0208db49d cppcheck: fix some redundantCondition warnings 
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2
Reviewed-on: https://gerrit.libreoffice.org/18353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-09-05 13:42:02 +00:00
Takeshi Abe
aecdaa7186 tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants in embedserv and eventattacher.

Change-Id: I556ad208a7ffcf85c484e298cdbb1324b8a6a659
Reviewed-on: https://gerrit.libreoffice.org/17499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-05 07:00:14 +00:00
Noel Grandin
b55166d266 Revert "return and use std::vector from OInterfaceContainerHelper" 
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
 2015-06-29 10:11:53 +02:00
Noel Grandin
e57314f61f return and use std::vector from OInterfaceContainerHelper 
since most of the time we don’t need a heavyweight uno::Sequence.
Adds a new method getElementsAsVector().

Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a
Reviewed-on: https://gerrit.libreoffice.org/15747
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-29 07:25:22 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete 
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
 2015-06-15 14:46:41 +02:00
Stephan Bergmann
fccf76ee8c css::uno::Reference can automatically up-cast now 
follow-up to 8568c7226cfb732e17fa42b365b9fce3a8264691 "tdf#66232: Cannot open
files by COM2"

Change-Id: I5a0858dd6f48136f9f07b0d04c5634a6173dd154
 2015-05-04 13:11:13 +02:00
Mike Kaganski
8568c7226c tdf#66232: Cannot open files by COM2 
As suggested by comment 13 of the bug, the problem is caused
by commit b248624126c271c88381d3dad6e04fc954f65779 by Noel Grandin.

1. DocumentHolder::DocumentFrame(): XDesktop2 cannot be directly
queried for XFrame2. And in this case, simple XFrame is enough.

2. DocumentHolder::CloseFrame(): m_xFrame->dispose() violates an
assert because of NULL reference. Reverted to previous code.

3. Following commit debde4fdc443f522562ee29def4c27512d64609a by
Andras Timar (supposed to fix the bug), found two places where
previously used to be UNO_QUERY, but now UNO_QUERY_THROW is used.
These places are reverted to use UNO_QUERY.

Change-Id: Ifb9e74367d5dd99ba12166abdd443b29a8018aeb
Reviewed-on: https://gerrit.libreoffice.org/15607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2015-05-03 16:14:03 +00:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
c6dcd7b7f3 Fix various Windows-only XServiceInfo implementations 
...to match what is recorded in the .component files

Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc
 2015-03-24 18:08:39 +01:00
Julien Nabet
b98ac70724 Typo: trough->through 
Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
 2015-02-21 14:45:36 +01:00
Caolán McNamara
ca8787a981 boost::unordered_map->std::unordered_map 
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
 2015-01-04 12:51:09 +00:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Jens Carl
3ddb928061 fdo#68849: Add header guards to all include files 
Added header guards to files in directories desktop/*, and embedserv/*

Change-Id: Idaffcc0539b84962ed7c132cb20078512799d433
Reviewed-on: https://gerrit.libreoffice.org/9556
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-30 01:44:03 -05:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left 
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-15 12:50:46 +00:00
Thomas Arnhold
c327acab9e remove globally disabled warnings from source files 
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
 2014-05-10 13:03:20 +02:00
Stephan Bergmann
fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused 
...since f059134fab0f91b7a15594ad06536a13fbfae034 "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
 2014-04-15 07:46:43 +02:00
Stephan Bergmann
c63ba20f2a embedserv: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: I383eea6c556005e1547df364b4cf34042b5e3a18
 2014-03-10 17:39:54 +01:00
Alexander Wilms
eb8b76211e Remove visual noise from embedserv 
Change-Id: I4914fd2f3e067fcc10fc110f172d3e33daa0977b
Reviewed-on: https://gerrit.libreoffice.org/8257
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 15:00:58 -06:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
612dac063a bool improvements 
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
 2014-01-29 11:08:32 +01:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
0fa31bed9a Default OMultiTypeInferfaceContainerHelperVar equalImpl parameter 
...and assorted OUStringHash clean up

Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
 2013-12-06 12:03:59 +01:00
Michael Stahl
b24957e812 clean up some COM initialization 
CoInitialize{Ex] always exist in all supported Win32 versions, so just
call them.

Change-Id: I45f227319aae811b6c94a3ac475467a06146b8e9
 2013-11-28 00:59:48 +01:00