Commit Graph

2793 Commits

Author SHA1 Message Date
4158ae52fb WaE: Werror=shadow
Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880
2013-03-15 20:49:11 +00:00
c90373f98e detect follow-on default member of default member object bnc#809017
Change-Id: I366c049fc342240081957b81d2f28bfcf8d4e331
2013-03-15 17:24:12 +00:00
a63cc778d1 i119933 - make Basic FORMAT function work with non-ASCII text
Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: I5b77231d1b09cbf32fa914f3d7b60d6e631e5870
2013-03-14 18:07:30 +01:00
9dcfc56c7c Fix Set/Let mixup ( from String -> OUString rework ) fdo#60752
Change-Id: I56f3e8b54d80f4575937f8515e8a8d9318353b8d
2013-03-13 14:39:18 +00:00
59b5ff7574 basic: translation of all debug messages
runtime.cxx: Added some output instead of nothing.

Change-Id: Ia25ae4b5fe8661a8a3ac317bc0562e1339640cd8
2013-03-11 21:36:43 +01:00
d06f4577b5 bnc#805071 fix object assigment problems when default members present
Change-Id: I6f7dfd369a36aff06f15b9a3affadb9d19787a9c
2013-03-11 17:32:52 +00:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
a2454a42ad fdo#43460: use isEmpty()
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-09 20:32:39 +01:00
ead0a6038b coverity#705627: fix memory leak
Change-Id: I4f73f77b27d2ed28a9f97757105c8a6cc5521b33
2013-03-09 17:59:12 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
8035a3af26 some further OUString cleanup
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-08 04:51:28 +01:00
a9813b9ab3 doh! sReturnStrg is OUStringBuffer, no need to assign
Change-Id: I490d20e8b494b4f59277b1cc92c73beb65a05813
2013-03-07 17:26:21 +00:00
f202b21770 fix String->OUString foobar
Change-Id: Ia924e6e8f3cfa25b131185713699d64e9d339357
2013-03-07 16:27:35 +00:00
a3bb733ec6 fdo#46808, Convert singleton theMasterScriptProviderFactory
Change-Id: I647a02e552acdd354463fc46c13c5a73b1c90d09
2013-03-07 08:23:39 +02:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
33d6a7b2d7 doubled namespaces
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-04 13:58:40 +01:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
23e572f475 don't do something different in dbgutil mode than product
Change-Id: Ibe0f41206ffaa3ff73018e49b4e710123c7fb14d
2013-03-04 11:23:58 +00:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
d021bb4dae coverity: fix memory leak
Change-Id: I17a09015d98a98349571a35492d516724ae2daa9
2013-03-02 06:51:58 +01:00
ece1af8c7f coverity#736108: nesting level mismatch
Change-Id: I6e6a3baa5aba5591a40fd236e7a2056fb59d6977
2013-03-01 07:00:09 +01:00
1544c17ffd coverity#705626 and coverity#705627: fix memory leak
Change-Id: I68f43d07798ccb3fc3a5ab438992ac74f4cd262a
2013-02-28 06:29:35 +01:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
94477cb5fb Fix typo accessable/accessible
Change-Id: I2f6d00a6361243a52a593acaaf2bf624d8a2730e
2013-02-23 17:29:22 +01:00
3a014901fd Fix typo seperated/separated
Change-Id: I133423de994b1befe246b6c921802428a3528202
2013-02-23 17:20:45 +01:00
fe86d0ca5d Fix typo "paramater" -> "parameter" + remove some commented lines
Change-Id: I1e6343fdcee91d23aacd776520e8bfdf81d411e4
2013-02-23 15:37:28 +01:00
7ca8407b40 coverity#707499 coverity#735400 coverity#738541
Change-Id: Idc00fe9ad5158043cf2eee652567581111c89177
Reviewed-on: https://gerrit.libreoffice.org/2277
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:53:55 +00:00
558e956403 coverity#704204 Logically dead code
Change-Id: I0a8dbbb3dbe7408e6f4d92c0bbebdaaa7d882f01
Reviewed-on: https://gerrit.libreoffice.org/2271
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:53:22 +00:00
8abb2f4d57 coverity#982288 Logically dead code
Change-Id: I4fb90cb00829bc4be7d050521215528de4748d76
Reviewed-on: https://gerrit.libreoffice.org/2245
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:51:47 +00:00
7f561b9d66 coverity#735398 Logically dead code
Change-Id: Iadb7fbd8a1fb1c535a3ed78d4b2f7120b29aeb75
Reviewed-on: https://gerrit.libreoffice.org/2270
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-02-19 21:00:00 +00:00
bc56c5f881 coverity#707502 Uninitialized scalar variable
Change-Id: I38db032b2e9331170da9e8d84eaa85c894f9d8fb
2013-02-17 09:10:53 +00:00
9a55875ef4 coverity#707496 Uninitialized scalar variable
also...
 coverity#707497 Uninitialized scalar variable

Change-Id: Ie3ac361685a52b23e088b78404ea4e013407fe2a
2013-02-17 09:10:52 +00:00
c16e9f4ed9 Move SyntaxHighlighter class from svtools to comphelper
We use this class in helpcompiler, and it is not desirable to
compile svtools (thus half of LibreOffice) for a build tool
in cross-compiling environment.

Change-Id: I5e6bc3e576af41eb03c1420dd347c542306f69fa
2013-02-16 12:55:03 +01:00
2ce2fafa1b Some cppcheck cleaning
Change-Id: Idb380dbb7470dbdb371778ba0c486392cc55380e
2013-02-12 14:48:04 +01:00
fc27fec054 Fix Variable 'TimeBuffer' is not assigned a value
See http://nabble.documentfoundation.org/Cppcheck-TimeBuffer-is-not-assigned-a-value-in-basic-module-td4036591.html

Change-Id: I2d67cecf3530301d49c43bbe397c5e975b2816b0
2013-02-12 11:54:08 +01:00
6865445a5e fix basic access to nested uno structures fdo#60117
Although basic might appear to correctly change nested struct elements
fdo#60117 shows that basic can be fooled ( and even the watch(ed) variable
in the debugger shows the expected values ). The problem stems from the
fact that the uno object held by basic isn't infact modified when changed
via the introspection uno service.

Additionally pimp the existing tests to check the actual uno struct to see
if the changes made are *really* reflected in the object

Change-Id: Iff007e17df87148ea81e69d3567c8cf9857fdcaa
2013-02-11 12:23:38 +00:00
591ef78440 fdo#46808, Use singleton util::theMacroExpander new-style constructor
And deprecate the old-style service util::MacroExpander

Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-11 08:02:13 +02:00
bed621572c fdo#46808, Use service constructor for awt::DialogProvider
Change-Id: I5d0a3e66afeadafa6d53ff0a255d036b7e3d528d
2013-02-11 08:02:12 +02:00
6d0f1f6639 fix for fdo#60065
squash errors trying to gain object for rhs ( where no object yet exists (

Change-Id: I81548d1c6a32f0445dc18e31c84c3df85163ed45
2013-02-05 10:36:05 +00:00
015a93d6b6 make basic XubString free
Change-Id: Iea5c01fe902b052a55c86ca3b879bcca12c80690
2013-01-30 10:49:35 +00:00
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28 08:25:24 +02:00
49cf14a3ca fdo#46808, Adapt document::GraphicObjectResolver UNO service to new style
The services already existed, it just did not have an IDL file

Change-Id: I245f78c165dbfde11a981efd7033c5c282f4e8ad
2013-01-28 08:22:53 +02:00
e3f11c10d8 Changed SetText() / GetText() to take/return OUString
replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21 20:48:35 +00:00
63bcb139b9 Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21 15:04:17 +00:00
d4bca924dd fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
- Clean up OSL_
- Clean up DBG_
- Clean up OUString

Change-Id: I002d17ffbbd8371b0518ede34931b2eea30865a3
Reviewed-on: https://gerrit.libreoffice.org/1602
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-14 08:47:52 +00:00
dbfc8777bf fdo#53521 Crash when running BASIC's "shell()" with a non-existent program
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed.

Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3
Reviewed-on: https://gerrit.libreoffice.org/1530
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:58:24 +00:00
9c06700874 fix build
Change-Id: I2588b69280abbc510ee2fdc9845df56616db8b95
2013-01-03 19:06:15 +01:00