Commit Graph

678 Commits

Author SHA1 Message Date
4158ae52fb WaE: Werror=shadow
Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880
2013-03-15 20:49:11 +00:00
c90373f98e detect follow-on default member of default member object bnc#809017
Change-Id: I366c049fc342240081957b81d2f28bfcf8d4e331
2013-03-15 17:24:12 +00:00
59b5ff7574 basic: translation of all debug messages
runtime.cxx: Added some output instead of nothing.

Change-Id: Ia25ae4b5fe8661a8a3ac317bc0562e1339640cd8
2013-03-11 21:36:43 +01:00
d06f4577b5 bnc#805071 fix object assigment problems when default members present
Change-Id: I6f7dfd369a36aff06f15b9a3affadb9d19787a9c
2013-03-11 17:32:52 +00:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
8035a3af26 some further OUString cleanup
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-08 04:51:28 +01:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
d021bb4dae coverity: fix memory leak
Change-Id: I17a09015d98a98349571a35492d516724ae2daa9
2013-03-02 06:51:58 +01:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
3a014901fd Fix typo seperated/separated
Change-Id: I133423de994b1befe246b6c921802428a3528202
2013-02-23 17:20:45 +01:00
7ca8407b40 coverity#707499 coverity#735400 coverity#738541
Change-Id: Idc00fe9ad5158043cf2eee652567581111c89177
Reviewed-on: https://gerrit.libreoffice.org/2277
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:53:55 +00:00
558e956403 coverity#704204 Logically dead code
Change-Id: I0a8dbbb3dbe7408e6f4d92c0bbebdaaa7d882f01
Reviewed-on: https://gerrit.libreoffice.org/2271
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:53:22 +00:00
9a55875ef4 coverity#707496 Uninitialized scalar variable
also...
 coverity#707497 Uninitialized scalar variable

Change-Id: Ie3ac361685a52b23e088b78404ea4e013407fe2a
2013-02-17 09:10:52 +00:00
6d0f1f6639 fix for fdo#60065
squash errors trying to gain object for rhs ( where no object yet exists (

Change-Id: I81548d1c6a32f0445dc18e31c84c3df85163ed45
2013-02-05 10:36:05 +00:00
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28 08:25:24 +02:00
e3f11c10d8 Changed SetText() / GetText() to take/return OUString
replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21 20:48:35 +00:00
d4bca924dd fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
- Clean up OSL_
- Clean up DBG_
- Clean up OUString

Change-Id: I002d17ffbbd8371b0518ede34931b2eea30865a3
Reviewed-on: https://gerrit.libreoffice.org/1602
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-14 08:47:52 +00:00
dbfc8777bf fdo#53521 Crash when running BASIC's "shell()" with a non-existent program
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed.

Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3
Reviewed-on: https://gerrit.libreoffice.org/1530
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:58:24 +00:00
c40cd8a4f2 Remove all occurences of RTL_* and ::rtl prefix from basic
This is a big commit, so thanks for your time reviewing this :)

Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-03 10:07:39 +01:00
a8fdb0ba4d fdo#58222 The BASIC HEX Command now returns uppercase hexadecimal characters
Instead of returning lowercase characters with BASIC's HEX command, uppercase characters are now returned. Digits from 0-9 are not affected. This change utilizes on OUString's toAsciiUpperCase() method.

Change-Id: Id6ea93a7635c1913c8592bf5519bdd7391f4e3bc
Reviewed-on: https://gerrit.libreoffice.org/1428
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-12-27 20:33:43 +00:00
6943c7b11c Sigh, my git grep regexps missed some cases
Change-Id: I085f14f40fb83cba171b35b14cf7c0d99091fc00
2012-12-27 14:03:18 +02:00
551cd20762 fix crash for fdo#58306 by avoiding literal assign
OUStringBuffer doesn't handler append ( if it had been previously assigned to "" literal )

Change-Id: Ief4379490a4873fbee4117db5833111943b86334
2012-12-19 17:40:02 +00:00
77d3777c89 Remove --with-stlport from LO 4.0
The STLport was only built for the benefit of old extensions on platforms that
once used it themselves (Linux x86, Solaris x86 and SPARC, Windows).  We
deliberately break such old extensions for LO 4.0 by no longer shipping that
backwards-compatiblity cludge.

Keeps STLport listed in readlicense_oo/ because of
o3tl/inc/o3tl/compat_functionality.hxx.

Also removes GXX_INCLUDE_PATH, as that was only used by STLport (if at all?).

Removes a spurious #define MOVEFILE_REPLACE_EXISTING 0x01 from
l10ntools/inc/helpmerge.hxx that was once added with
854812584862d0609b695682d2bfea2667d75c00 "INTEGRATION: CWS extensionl10nfix01
(1.11.6); FILE MERGED: 2008/06/26 13:56:03 ihi 1.11.6.1: #i90987# windows rename
-> MoveFileEx" but now starts to cause trouble on Windows.  Also disables
warning C4005 about redefinition of WB_LEFT/RIGHT macros (defined in both
tools/wintypes.hxx and the Windows API) in a number of places that include
windows.h -- however the old STLport caused those warnings to not show.

Change-Id: Ie138a219fbbc86fb5aaa7ea0b88cf349935d9829
2012-12-17 16:34:23 +01:00
b05dc2e391 German comment translations
Change-Id: I0d169b7cd0f47b6986063d0cc0b6697b1d575e6a
2012-11-25 16:48:01 +00:00
af60316514 some i18n wrappers with LanguageTag
Change-Id: I2ceaa3159e8669c2c569fa8559c1e061dcad399d
2012-11-23 23:09:16 +01:00
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
cc63555fd0 PutEntry familly of functions use consistent pairing OUString/sal_Int32
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
2012-11-18 19:57:23 -06:00
e3e7dfa011 basic: fix OUString copy overrun in Mid()
Change-Id: I91cdd3a52917b89ab2a452e0eeb7a9e00dc35e8b
Reported-by: vmiklos@suse.cz
2012-11-18 02:50:14 -06:00
5837402fb1 fdo#46808, use service constructor for ucb::SimpleFileAccess
I upgraded the service to return XSimpleFileAccess3, since it
already implemented that interface, and it's backwards
compatible.

Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-15 08:28:44 +01:00
fc5bb7d477 Clean up
Also, avoid global static data in sb lib, so that gengal.bin now also works well
on Mac OS X, cf. 12fa9ece663f24eff44197befe546a92e6c90724 "Avoid global static
data."

Change-Id: I23f2a7abc0c06a752ded1c1c64619b3aab009190
2012-11-14 13:32:28 +01:00
c3edb00e13 Report errors for invalid DateAdd/Diff/Part Add parameter values
...so that e.g.,

  DateAdd("x", 1, "1/31/2004")

(where "x" is not in the list of valid values for the Add parameter, "yyyy",
"q", "m", etc.) leads to a Basic runtime error rather than going into a
seemingly endless while(nNewMonth>nTargetMonth) loop at the end of
RTLFUNC(DateAdd) (basic/source/runtime/methods.cxx).

Change-Id: I15c3bdb62723ffddf36ff2396ffb294369d93ff8
2012-11-14 13:32:27 +01:00
f0e797a351 basic: adapt dllmgr-x64.cxx to OUString changes
Change-Id: I9e5ff5be1f001a9f55953fd516fb5ef7fe94bf44
2012-11-07 12:18:39 +01:00
7aa973919d Fix String -> OUString fallout
Change-Id: I038848aed0c64c39ca93da89b4a78bd3a1f6d7d0
2012-11-07 11:43:02 +02:00
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
d2c45d0460 fdo#46808, Adapt i18n::Transliteration UNO service to new style
Simply make the service implement XExtendedTransliteration, since all
of the implementatins already do that.

Change-Id: If03bf56a8d33931ad0230743a4603e2ae9b104ac
2012-11-05 16:43:15 +01:00
d92814f462 basic: preliminary cosmetic clean-up
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03 20:24:28 -05:00
a884fe58a1 basic: OUStringification of ddectrl
Change-Id: I2af40d7c8117aff8ce62a8ea0eec579664f8bdeb
2012-11-03 20:24:27 -05:00
c5b7d8f9d9 basic migration to OUString
Change-Id: I1f9403174b3779801d91ba20d846191ed9a09eed
2012-11-03 20:24:27 -05:00
6702bc37d4 basic: convert StepPAD to OUString
Change-Id: I19d05f455767c973a47d0233b3af20af1ac3a20a
2012-11-03 20:24:27 -05:00
8ce4050497 simplify and use OUString for StepLOADNC
Change-Id: I92c86f672cc79506c2c7c56bb3402b4436f71c98
2012-11-03 20:24:27 -05:00
c1435d9ea6 basic: use OUString in DimAsNewRecoverItem
Change-Id: Icfecff549161c3c429524549b65752671792a94f
2012-11-03 20:24:27 -05:00
973d061839 basic: unnecessary round-trip via String
Change-Id: I691a59b8ab9e6352a9257dac35b8e378e6ef9666
2012-11-03 20:24:26 -05:00
5120d8c59d basic: avoid String<>OUString issue by by-passing them completely
Change-Id: If741661f1151950a2180fa5c6504957b44a7e998
2012-11-03 20:24:26 -05:00
c5e5699c80 svformatter already accept OUString input
Change-Id: Icca8c40db4a4449876e115a0746319f3f893e846
2012-11-03 20:24:26 -05:00
6f978fa977 basic: use OUString internaly for error messages
Change-Id: I9ea243f93b7477814037deca2f332c3359ce527d
2012-11-03 20:24:25 -05:00
363d2c6f8b use OUString for intermediary result in PrepareNumberFormatter
Change-Id: I9435d926beb2fd7ebe350f61634673eed7228fbe
2012-11-03 20:24:25 -05:00