fa91dd31f3
5th step to remove tools/rtti.hxx
...
tools/rtti.hxx removed
completed the interface of some Sdr.* Items
and removed pseudo items
Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-11-11 10:49:30 +00:00
db17d3c17c
new loplugin: memoryvar
...
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr
Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc
Reviewed-on: https://gerrit.libreoffice.org/19884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-11 07:16:20 +00:00
f7715e6821
Resolves: #i61854# Basic: Default title of Msgboxes should be changed
...
Found by: berend dot cornelius at germany dot sun dot com
Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: Damjan Jovanovic
(cherry picked from commit 519770a2b47d4bb95a7616cedcc1582ae83ab205)
Change-Id: I61c9eacd285c8335925f1569b64bb2d600caf545
2015-11-10 09:45:21 +00:00
08e49fa337
loplugin:nullptr (automatic rewrite)
...
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
2015-11-10 10:31:17 +01:00
6c80a8fe89
new loplugin: oncevar
...
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-09 08:34:40 +00:00
a80bab7058
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
2015-11-06 09:34:39 +01:00
42a63dd0e8
Resolves: #i61277# Basic open file with random access erases all data.
...
StarBasic tries to emulate truncation of files opened for writing
by deleting them before opening them (if they exist). However there
are exclusion to the truncation behaviour when the file is opened
in append mode or is a binary file. Another exclusion - that was
missing with disasterous consequences - is that the file should
not be truncated when opened in random access mode.
(cherry picked from commit 72b2f07ccac7578ef36fc2b92dcba49abe397ebc)
Change-Id: Ic0053039ce5fd67ad42bf5332ae301d83f1a158d
2015-11-04 14:04:36 +00:00
59b072e22b
yyyyy
...
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
be729e7721
tdf#94269: Replace "n" prefix for bool variables with "b"
...
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2015-11-02 23:40:57 +01:00
3bc5df7f32
UNO: no need to use OUString constructor when calling createInstance
...
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-30 08:59:59 +00:00
065c8b48a6
use uno::Reference::set method instead of assignment
...
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
51eb04a158
basic: replace boost::ptr_vector with std::vector<std::unique_ptr>
...
Change-Id: I98c4ac860fbdb55a61f9be0e9d2d5f29fb849e05
2015-10-26 16:09:20 +01:00
71f6aab077
basic: replace boot::ptr_vector with std::vector
...
Change-Id: I4967ad8345cd74c39edbea1df513978b62996b90
2015-10-26 16:09:20 +01:00
79a7cf5424
basic: replace boost::ptr_vector with std::vector<std::unique_ptr>
...
Change-Id: I0bd3a5182d62432a8f0caf4bbae11bbce56a363c
2015-10-26 16:09:19 +01:00
192ca71f07
basic: replace boost::ptr_vector with std::vector<std::unqiue_ptr>
...
Change-Id: Ieba2fb34e0279871d36b4fe80d9de76e614b5cde
2015-10-26 16:09:19 +01:00
fc0b9a3493
loplugin:defaultparams
...
Change-Id: I5a3852f85f20543165e174da9cd9a36da9a3df8d
2015-10-20 11:44:49 +02:00
af9684f604
loplugin:defaultparams
...
Change-Id: Ib0f01af2c7a7186d138369c177a563b322a87214
2015-10-19 17:49:12 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
ccc5ea08d6
cppcheck:variableScope
...
Change-Id: I037feb335499629300309851dcda3bb661f03d4f
Reviewed-on: https://gerrit.libreoffice.org/19316
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-12 06:52:56 +00:00
4d00131b67
Reduce variable scope
...
Change-Id: I87850db982f413b328976e043d8386b7577ba17c
2015-10-07 11:32:42 +02:00
31ee230b6e
Related: tdf#94814 some cleanup of static_cast following dynamic_cast
...
to the same type
Change-Id: I197e88acbc30f8e8bb9e7f2d54803971df6062af
2015-10-06 15:10:51 +01:00
e8233e1510
clang-analyzer-deadcode.DeadStores
...
Change-Id: I03769bd4105e4e1d140b2885978ea9da9ef866de
2015-10-06 15:31:16 +02:00
5e02785ff1
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ib26cbbc839040c49288606f588cb7400d7e40b83
2015-10-06 15:31:15 +02:00
66ef464799
clang-analyzer-deadcode.DeadStores
...
Change-Id: I2ef946572a61eb766454d2df0cb2ff523050ed7e
2015-10-06 15:31:15 +02:00
89d39bc100
tdf#94559: 4th step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
idl, editeng, sc, sd, sw, sfx2, sot, starmath
Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-10-06 07:29:37 +00:00
e9ae1b64af
checkUnoObjectType etc always deref their ptr arg, convert to ref
...
Change-Id: Iabdb057fb2dc05cfb8c98864dc5109360b50633a
2015-10-02 11:38:58 +01:00
2957be02c5
Fix typos
...
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-10-02 08:54:51 +00:00
ddb4526159
tdf#94617 allow to store nStart information greater than sal_Int16 limit
...
- preserve backward compatibility
- nDebugFlag is stored but not used when loaded
- Flag nDebugFlag set the top bit to 1
- stores the multiplier of sal_Int16 limit to reach nStart
- in load, test this flag bit
- rebuild correct nStart
- new B_CURVERSION file format for binary storage macro
- unit test for big modules
Reviewed-on: https://gerrit.libreoffice.org/18926
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
(cherry picked from commit db17079fcff6f9a068c499b17f2501cc4c82d10b)
Change-Id: Iaa037982d828fef7195615e6eda546b7199a4fe8
2015-10-01 16:36:05 +01:00
e31cd8f3ae
coverity#1325250 Unchecked dynamic_cast
...
Change-Id: Id52cad11d2ca4ef42a31c0905ee123ccd53e0677
2015-10-01 14:41:29 +01:00
62b39a7c48
coverity#1325255 Unchecked dynamic_cast
...
Change-Id: Ie1a6b231e0313d1c00ffb9ab0137af2beeb05e02
2015-10-01 14:05:27 +01:00
58aea3f36c
loplugin:unusedmethods
...
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 10:43:24 +00:00
9e4c87be31
Fix typos
...
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 05:53:57 +00:00
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-09-29 18:33:40 +00:00
34180700b2
loplugin:removeunusedmethods, remove unused stuff
...
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
9555d03c98
remove unused #include <sal/alloca.h>
...
Change-Id: I490841fd2c526e4ca6d6c94cc7b9dba318c932a1
2015-09-29 14:57:43 +02:00
d70302ef5c
basic: more plausible build fix than e5a8eb9e
...
Change-Id: I26fd8a76a17386de73fa12058509ccee7e768512
2015-09-29 14:57:39 +02:00
e5a8eb9e29
fix dbgutil build
...
Change-Id: If2a9d330bd7fde8db5e998e97c278fb19c90f24a
2015-09-29 13:48:00 +01:00
d3c7c9ea81
tdf#94559: first step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff
Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-29 12:26:20 +00:00
365b13e152
pVar != null, so static_cast(pVar) != null
...
Change-Id: Id22808858b5884b2f87064b389eb411e0712bab4
Reviewed-on: https://gerrit.libreoffice.org/18881
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-26 11:49:06 +00:00
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 07:59:14 +00:00
22b80ac8e2
boost->std
...
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-14 12:54:25 +00:00
b3ee922299
basic: one more WeakImplHelper<XPropertySetInfo> duplicate
...
This one may be quite busted even since it compares
sal_Int32(-1) with USHRT_MAX.
Change-Id: I894b382ad499ee49f4616c7704afbb90f0556744
2015-09-11 23:44:59 +02:00
1f6b082388
Fix previous commit
...
...4b4a7c0d87eb580272aba0777c9021789025bdc0 "Revert a fix that can never have
worked in the first place?"---which presumably did work after all, as Noel
thankfully pointed out to me,
<http://lists.freedesktop.org/archives/libreoffice/2015-September/070193.html >
"Re: [Libreoffice-commits] core.git: basic/source 'Revert a fix that can never
have worked in the first place?'"
Change-Id: I411bfaacbfebf50589290c6a3040d0300c256439
2015-09-09 10:54:03 +02:00
4b4a7c0d87
Revert a fix that can never have worked in the first place?
...
clang-analyzer-deadcode.DeadStores finds that conditionally assigning
eTok = SYMBOL
inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the directly
following
if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )
will unconditionally assign into eTok again, without intermediate use of the old
eTok value.
Now, the conditional "eTok = SYMBOL" assignment was added as
5d98ed5c6a4afc0a7943318c510e56aef8c45193 "INTEGRATION: CWS ab12fixes: #118234#
SbiExpression::Term(): Allow Input as symbol for action option compatible,"
while the unconditional "eTok = eNextTok" assignment had followed that block
ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import."
The referenced "#118234#" was a Sun-internal bug and is no longer available, but
it does very much look as if this alleged bugfix never worked in the first
place. So revert the code back to what it looked before
5d98ed5c6a4afc0a7943318c510e56aef8c45193, for now.
Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae
2015-09-08 10:57:54 +02:00
751c771adc
loplugin:mergeclass, merge BiNode with NameNode, Obj0Type with ObjkType
...
Change-Id: Icbc0dfc6096a6e2c651dad4fe9f78d176f389390
2015-09-08 09:20:31 +02:00
f0208db49d
cppcheck: fix some redundantCondition warnings
...
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2
Reviewed-on: https://gerrit.libreoffice.org/18353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-09-05 13:42:02 +00:00
d417059dae
BASIC : SbiParser::DefXXX Only convert the first letter to uppercase
...
Change-Id: Iccee4712459653b35b11d8dbe99c45df753307be
Reviewed-on: https://gerrit.libreoffice.org/17859
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-09-05 09:22:41 +00:00
3fb50fbe2b
basic: remove over-engineered XEnumeration service
...
... that was causing duplicate WeakImplHelper symbols now.
Change-Id: Ibbf84a2059f30bfeb5c265adcafb4b56d2534dc8
2015-09-03 16:31:59 +02:00
