Commit Graph

347 Commits

Author SHA1 Message Date
9b60eeac51 janitorial: c++-style cast
Change-Id: I746eff36778e30e36b975e24c70712301c3c71cb
2013-09-10 15:05:07 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
91f3d77b98 tweak comment translations
ede5f05c fb3a1bb9 5e04331f fd6089b9 66a1d406

Change-Id: I5077ce5f6182f9193cebaaf63190450d375679dd
2013-08-08 23:25:25 +02:00
392c5b2a70 Mark as const
Change-Id: Idd1d0641d5b7d8594f354c7d2e2a9093ecc6b2f7
2013-08-01 04:33:23 +09:00
bddd4d4598 Mark as const
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
abba78f644 -Werror,-Wdeprecated-register (Clang trunk towards 3.4)
Change-Id: I64e4933f7a0a8026ccc7ce98804bfc497d3f0eed
2013-07-08 17:32:25 +02:00
3835dee3c7 SvStream: remove the error prone operator<</>>(sal_Int64)
As the recent regression after merging AOO patch adding code serializing
"long" variables has shown, this overload (which was added in
7b2a0e541567be9750dfc7d98374555967da3470) is a bad idea.

In a unxlngx build, nm finds uses of the symbols _ZN8SvStreamrsERl
and _ZN8SvStreamlsEl in these files:

- sbxvalue.cxx: this appears to be a legitimate use with sal_Int64

- dateitem.cxx: this was accidentally changed by commit
  9830fd36dbdb72c79703b0c61efc027fba793c5a

- atrfrm.cxx: this was added for Table Autoformat enhancement in
  7e8c0bd73ee59ff3041e55268c77203373962e51, which is after the
  sal_Int64 operators were added, so the file format is now
  platform dependent

Change-Id: I78352b5429b53612c4831cdb81b587b5de5180a9
2013-07-02 16:30:01 +02:00
318f2b64cc remove some createFromAscii usage
there are a lot more of them:

git grep 'createFromAscii[^)]*"'

Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-29 16:23:23 +02:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
29bfb507b3 get rid of some Germanism (and some Windowsism)
Change-Id: I2ca1b34ff688a7d4fcf6c84c02035eda3ab0dee8
2013-04-18 23:43:18 +02:00
4976dd85fa Introduce characters utilities in rtl/character.hxx
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, with slight modifications
to sal/inc/rtl/character.hxx:
* Replaced "#pragma once" with explicit include guard for now.
* Missing includes.
* Cosmetic clean-up.

Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654
2013-04-10 10:43:38 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94 new module i18nlangtag
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
bb52f5b2bf Use local utility functions instead of SbxSimpleCharClass
Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef
Reviewed-on: https://gerrit.libreoffice.org/3132
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-04-01 01:14:00 +00:00
4f811c0474 fix loplugin warnings
Change-Id: I17593ac6e495213a1ef99d4d5525a6e38aee0bc7
2013-03-30 13:01:09 -04:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
e96c7a60c8 replace decimal separator at correct position, rhbz#919020
Change-Id: I97a652e6a1286726fe21ae580f6dbf5536f9d52d
2013-03-20 00:06:40 +01:00
9e9f39d171 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number
Code wrongly replaced decimal separator with '.' and used atof() to scan
the number string which itself may be localized on *iX systems but not
on Windows. Hence on *iX the numbers may had been truncated where on
Windows they were not.

Additionally made this work with Unicode separators if defined for the
locale, removed the awkward conversion to ASCII byte string and
eliminated use of toupper() and isdigit() calls. Also eliminated a
possible buffer overflow.

Change-Id: Ic3f791601c321ef1386fe51a5244d3dacac3d908
2013-03-19 23:36:02 +01:00
9be25f14bd avoid Wundef for various FIXME, FEATURE_NOT_DONE_YET and what not
Change-Id: I8e409ba63d32dca9a1c7f09d143165d1d702d642
2013-03-18 17:15:56 +01:00
a63cc778d1 i119933 - make Basic FORMAT function work with non-ASCII text
Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: I5b77231d1b09cbf32fa914f3d7b60d6e631e5870
2013-03-14 18:07:30 +01:00
59b5ff7574 basic: translation of all debug messages
runtime.cxx: Added some output instead of nothing.

Change-Id: Ia25ae4b5fe8661a8a3ac317bc0562e1339640cd8
2013-03-11 21:36:43 +01:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
a9813b9ab3 doh! sReturnStrg is OUStringBuffer, no need to assign
Change-Id: I490d20e8b494b4f59277b1cc92c73beb65a05813
2013-03-07 17:26:21 +00:00
f202b21770 fix String->OUString foobar
Change-Id: Ia924e6e8f3cfa25b131185713699d64e9d339357
2013-03-07 16:27:35 +00:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
ece1af8c7f coverity#736108: nesting level mismatch
Change-Id: I6e6a3baa5aba5591a40fd236e7a2056fb59d6977
2013-03-01 07:00:09 +01:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
bc56c5f881 coverity#707502 Uninitialized scalar variable
Change-Id: I38db032b2e9331170da9e8d84eaa85c894f9d8fb
2013-02-17 09:10:53 +00:00
015a93d6b6 make basic XubString free
Change-Id: Iea5c01fe902b052a55c86ca3b879bcca12c80690
2013-01-30 10:49:35 +00:00
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28 08:25:24 +02:00
63bcb139b9 Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21 15:04:17 +00:00
c40cd8a4f2 Remove all occurences of RTL_* and ::rtl prefix from basic
This is a big commit, so thanks for your time reviewing this :)

Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-03 10:07:39 +01:00
59074c09b8 remove use of #pragma optimize
All these are years old, guessing from some comments as old
as Windows 9x support. These workarounds do not seem to be needed now.

Change-Id: If67baa5cdefcec33b28696c764b1ed96143b7ccd
2013-01-01 22:39:15 +01:00
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
160cfb5e5e Bin the HACK() sillyness
Change-Id: Ieeebc4098404fa006d66bb8b656172a4348b1dc1
2012-11-19 21:23:27 +02:00
cc63555fd0 PutEntry familly of functions use consistent pairing OUString/sal_Int32
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
2012-11-18 19:57:23 -06:00
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
d92814f462 basic: preliminary cosmetic clean-up
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03 20:24:28 -05:00
8eb5db8997 replace sxub_Unicode by sal_Unicode
Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
Reviewed-on: https://gerrit.libreoffice.org/887
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-19 10:55:56 +00:00
af4df7ac08 fdo#48257 collect function prototypes from basic/ into single header file
Change-Id: I1666e64b2b611054e1a713a76575e2f06781f80a
2012-10-04 10:35:48 +01:00
b854de954f deprecate oustringostreaminserter.hxx
the intent of this header has canged over time. now it is already
systematically included with ustring.hxx and the operator overload it
provide fit nicely there...

Just to be safe, since that include as been added to the api during the
3.5 timeframe and therefore is already in 'production'
the header remain and simply attempt to include ustring.hxx
but a warning is issued indicating that this header should not be used
anymore... in a couple of major release we will thenr emove it completely

All internal users of that header are converted.

Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad
Reviewed-on: https://gerrit.libreoffice.org/634
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-18 10:10:06 +00:00
cfa6f85242 sal_Bool to bool
Change-Id: Iebed1c159606ab695b049032da5a3509e468fb91
2012-09-05 10:40:17 +09:00
911e412b87 sal_Bool to bool
Change-Id: I96fe31c80f952b1ac6d25c65431597d81e0fdda3
2012-08-24 12:58:56 +09:00
407509c058 sal_Bool to bool
Change-Id: I75dd089b34c94831bfdfd0e02585af7609013a08
2012-08-22 19:25:08 +09:00
0c89907c83 Remove dead code
Change-Id: Ib5e794495b542ed96b5424d1aec38c4dd60ae182
2012-08-22 19:25:08 +09:00
1817cf60d1 sal_Bool to bool
Change-Id: I61a6675df622232923a827fc20bf121dd03cd7da
2012-08-12 09:16:58 +09:00