Commit Graph

38 Commits

Author SHA1 Message Date
02740cbe0a Related: fdo#38838 drop String::EmptyString now as well
Change-Id: I849dbf3a40189e700036249b15dd8bde493083b6
2013-09-08 20:44:26 +01:00
7fd6d43c1d Related: fdo#38838 String::GetBufferAccess is now no more
Change-Id: I9fdd600fd0a530c0763875109eee6600e4a77879
2013-09-08 20:44:25 +01:00
ce9c390e1a Related: fdo#38838 String::ReleaseBufferAccess is now no more
Change-Id: Ib5390183e3d98a23f9243debfe3624561ca92535
2013-09-08 14:52:59 +01:00
1d3483ed27 Remove some unused code from unusedcode.easy
Change-Id: Ic3e96eebbb914c5b905a8c58532ead9cb01dd41d
Reviewed-on: https://gerrit.libreoffice.org/5721
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-01 09:15:44 +00:00
74929bba73 Related: fdo#38838 remove UniString::ToUpperAscii
things got a little out of hand and I ended up
converting quite a bit of calc to OUString

Change-Id: I056326d37ffefa8c120cb2e564d166dd9f20f216
2013-08-30 11:39:01 +01:00
a720ff09d8 Related: fdo#38838 AllocBuffer is now unused
Change-Id: Ib2cf99f3dd9ce5e3acc7364d07d6b6e5d03de423
2013-08-27 10:01:19 +01:00
f00cd93a66 callcatcher: update unused code, esp unused Resource based ctor
e.g. no ImageRadioButton is now loaded from any res/rsc file, so
that ctor and associated code paths can be stripped out

Change-Id: Ic4cf19d45adb7c734f150e0b89eef193157a74a7
2013-08-27 09:58:35 +01:00
cc0b40f6a9 add some a11y relations and enable translation of ms
Change-Id: Ib509a7ae62aefc919bdaed269c1605ac6bae9564
2013-08-18 13:47:31 +01:00
d69d6f4dc8 Related: fdo#38838 ToInt64 and a EqualsIgnoreCaseAscii variant are now unused
Change-Id: I2a2cc56cf005f564c798b8d43ef7e8c4b7f9eeff
2013-08-16 13:59:30 +01:00
2235f495e3 add a seconds unit
Change-Id: I3507caab5cd61c282102ab21bf034ec54e497af3
2013-08-13 14:51:15 +01:00
9891cb881b Related: fdo#38838 remove String::Equals(const sal_Unicode* ...)
Change-Id: I6eeede3261e7b6f5ad81a4d2fa9ecc6c07002dbb
2013-08-10 21:51:42 +01:00
8ee69b0ba1 fdo#67235 adapt form control code to time nanosecond API change, step 3
Change-Id: I4899c89ee5b2a54c9c05b531ab284365f1558e3d
Reviewed-on: https://gerrit.libreoffice.org/5270
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-08-04 06:51:31 +00:00
a95d1eff07 Remove effectively unused INetURLObject OString overloads
Change-Id: Icbbe27b229d5454d27be646e00e8b362a77359b3
2013-07-29 08:26:29 +02:00
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
9c0a390489 fdo#63133: Write tools/tempfile.hxx out
I deleted TempFile class and changed it to utl::TempFile class
-which in unotools/tempfile.hxx- in the followings: Storage,
StgTmpStrm, SwXMailMerge classes; and RenderAsEMF function.
I modified header in precompiled_sw.hxx.

Change-Id: I3dae5333dc42538e1b905f6a6bbc85534c591dc1
Reviewed-on: https://gerrit.libreoffice.org/4938
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-07-16 18:40:45 +00:00
c66e9cd24c Delete SvCacheStream class
I changed SvCacheStream class to SvMemoryStream class in
the following:  MSE40HTMLClipFormatObj, SfxLockBytesItem,
SwEditShell, INetMIMEMessageStream classes,
MakeLockBytes_Impl function and SwUnoCursorHelper namespace.
I modified header the precompiled_sw.hxx, wrtsh1.cxx, unoobj2.cxx.
I added two functions in SvMemoryStream class: GetBuffer and
GetSize, and I renamed the old GetSize function to GetBufSize.
I deleted SvCacheStream class.

Change-Id: I929236538dfbe23cccfd1eb85f10c1d5411baa8d
Reviewed-on: https://gerrit.libreoffice.org/4847
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-07-16 13:31:53 +00:00
c162a4c8e4 remove String::ReplaceAscii
last remaining users used it as a complicated way to do a simple thing

Change-Id: I810b1542b03bd6faa54f6f076b58cb7d3e680ab0
2013-07-14 20:05:19 +01:00
82937ce3d7 String::SearchAndReplaceAllAscii -> OUString::replaceAll
Change-Id: I5091835c9f71c712f15996e5c6263fc5f21f6f96
2013-07-14 14:04:03 +01:00
d0e6571634 add degrees and pixels as known spin field units
Change-Id: I5937843a5c5485f469ef1fb6b5844aa15c33a14d
2013-07-08 18:40:11 +01:00
6e82772db5 TODO note for future *internal* API change
Signed year so that ~all our date types have about the same capacities.

Change-Id: Iab8a66bee0eb22ffd04608c345302218094e53a7
2013-07-05 12:22:03 +02:00
33ff399d72 warning C4389 != signed/unsigned mismatch
Change-Id: I1cc4be1e7068ce3c40340e88fcde75fc7862a18a
2013-07-04 20:08:56 +02:00
3835dee3c7 SvStream: remove the error prone operator<</>>(sal_Int64)
As the recent regression after merging AOO patch adding code serializing
"long" variables has shown, this overload (which was added in
7b2a0e541567be9750dfc7d98374555967da3470) is a bad idea.

In a unxlngx build, nm finds uses of the symbols _ZN8SvStreamrsERl
and _ZN8SvStreamlsEl in these files:

- sbxvalue.cxx: this appears to be a legitimate use with sal_Int64

- dateitem.cxx: this was accidentally changed by commit
  9830fd36dbdb72c79703b0c61efc027fba793c5a

- atrfrm.cxx: this was added for Table Autoformat enhancement in
  7e8c0bd73ee59ff3041e55268c77203373962e51, which is after the
  sal_Int64 operators were added, so the file format is now
  platform dependent

Change-Id: I78352b5429b53612c4831cdb81b587b5de5180a9
2013-07-02 16:30:01 +02:00
710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
820901f915 WaE: comparison between signed and unsigned integer expressions
Change-Id: I3b5e3a8bf4bbecf6bf697b91c9a16ec19045bfdf
2013-06-10 14:27:58 +02:00
4e41227dd6 mingw64: change Link class to use sal_IntPtr instead of long
Change-Id: I2b78c7b714ff064f2f1b8a8eb161e5e2ae121eee
2013-06-10 14:03:40 +02:00
ce959ab7ce mingw64: use the right integer sizes on win64
Change-Id: Idb263ad369d2dad4fe4de924f2b2404a0fcf62d3
2013-06-10 14:03:34 +02:00
2cb247a12d fix file and lineno info for DBG_UNHANDLED_EXCEPTION
which I broke in commit 863d38fbfa4fb4861e476828c46410602100919e
"move DBG_UNHANDLED_EXCEPTION out of line"

Change-Id: Ic30e985cc356d81013ced1ce74ec6c78469d9882
2013-06-10 10:20:45 +02:00
6bf00f0f94 fix for linking
caused by my commit
863d38fbfa4fb4861e476828c46410602100919e "move DBG_UNHANDLED_EXCEPTION out of line"

Change-Id: Idfd84d987ba9151ba476ce0516a9e5fbdb2003ec
2013-05-21 13:53:21 +02:00
863d38fbfa move DBG_UNHANDLED_EXCEPTION out of line
makes it easier to set a breakpoint on it.
Plus it's getting a little big to be a macro.

Change-Id: I2827aa3618ba966fbc85a4a56e0e794a55630730
Reviewed-on: https://gerrit.libreoffice.org/3988
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-21 10:02:39 +00:00
abb6f47bd3 Secured some places where PolyPolygons were created
using a all-points count and a all-points array

(cherry picked from commit 8ee49906f04106317997e9ca3bb890870816e274)

Conflicts:
	svtools/source/filter/wmf/enhwmf.cxx
	svtools/source/filter/wmf/winwmf.cxx
	tools/inc/tools/poly.hxx
	tools/source/generic/poly2.cxx

Change-Id: I57f7f08d8dd87c83c30ab2d16ca22b772b2bd834
2013-05-19 14:47:38 +01:00
3126793480 added documentation about non-normalized invalid dates
Change-Id: I88a95d8fac8af9085d41cf1b13c8ff3ee7abb141
2013-05-17 18:26:15 +02:00
cd9d1bdf5e resolved fdo#63805 max day of month of the intended month
Since 6619955e72c1c2f29a32e82478d19147c0d7610a Date::GetDaysInMonth()
operates on the normalized value that corresponds to the actual values
set at the Date instance, obtain and set number of days for the intended
month instead of using the rolled-over date.

Change-Id: Ia6b007675104f8e134b278f216c3bb48b72f061c
2013-05-17 14:13:36 +02:00
11fd73acce SolarMutex does not belong into the URE interface
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx.  It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.

I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.

(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)

Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
86b73eeef4 fdo#63154: Remove _CL and _LF from solar.h
And use RTL_CHAR_{CR,LF} from rtl/string.h

Conflicts:

	vcl/source/app/dbggui.cxx

Change-Id: I05b0325006845e48eb5483485a9042aa7b0cd22a
Reviewed-on: https://gerrit.libreoffice.org/3740
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-05-09 09:49:15 +00:00
2092f8810a Show only filename in "Recent Files" list
As discussed here: http://nabble.documentfoundation.org/Libreoffice-ux-advise-Recent-files-dropdown-td4052945.html#a4052996

The changes are (inspired by Gedit):
* Display only the filename, not the (abbreviated) path
* Show the protocol name before the file, if not local (e.g. "ftp: myfile.odt")
* After the keyboard shortcut (a number from 1 to 10) display a '.' instead of a ':' (because the protocol has a ':')
* FIX: Display whitespace as whitespace, not "%20"

Change-Id: I47472c901aa866adb76c7c7ab36bc871f82ad8df
Reviewed-on: https://gerrit.libreoffice.org/3700
Reviewed-by: Jan Holesovsky <kendy@suse.cz>
Tested-by: Jan Holesovsky <kendy@suse.cz>
2013-05-02 09:04:18 +00:00
ec8617568f Bin ugly (ab)use of preprocessor in headers
The time when it made sense to use "clever" #ifdefs to, for performance or
compiler reasons, conditionally bypass private parts of a class declaration
passed a decade or longer ago.

Still more of this in sw and sc. People working on those modules might want to
do it too, or not.

Change-Id: I1053139ca5e5e2631f7b22d99d3bada54fc337be
Reviewed-on: https://gerrit.libreoffice.org/3627
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-27 09:28:37 +00:00
c914d7d5cc fdo#63154: Remove all usages of the macro EXTERN_C
Change-Id: I25b7f509ba5d1007a16c84ad05870a8174c094ec
Reviewed-on: https://gerrit.libreoffice.org/3621
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-26 11:52:36 +00:00
b9337e22ce execute move of global headers
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00